On Fri, Apr 30, 2021 at 11:30:33PM +0100, Sergei Trofimovich wrote:
> From: Sergei Trofimovich <sly...@gentoo.org>
>
> Modern binutils unconditionally tracks x86_64 ISA levels in intermediate
> files in .note.gnu.property. Custom liker script does not handle the
> section and complains about it:
>
> ld --gc-sections -T out/vgasrc/vgalayout.lds out/vgaccode16.o \
> out/vgaentry.o out/vgaversion.o -o out/vgarom.o
> ld: section .note.gnu.property LMA [0000000000000000,0000000000000027] \
> overlaps section .text LMA [0000000000000000,00000000000098af]
>
> The change ignores .note.gnu.property section.
>
> Signed-off-by: Sergei Trofimovich <sly...@gentoo.org>
> ---
> vgasrc/vgalayout.lds.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/vgasrc/vgalayout.lds.S b/vgasrc/vgalayout.lds.S
> index 533734d..e17d89e 100644
> --- a/vgasrc/vgalayout.lds.S
> +++ b/vgasrc/vgalayout.lds.S
> @@ -19,5 +19,5 @@ SECTIONS
>
> // Discard regular data sections to force a link error if
> // 16bit code attempts to access data not marked with VAR16.
> - /DISCARD/ : { *(.text*) *(.rodata*) *(.data*) *(.bss*) *(COMMON) }
> + /DISCARD/ : { *(.text*) *(.rodata*) *(.data*) *(.bss*) *(COMMON)
> *(.note.gnu.property) }
> }
Thanks. It looks like scripts/layoutrom.py uses "*(.note*)". Could
we also use that here for consistency? Also, as a minor thing, I
think it would be preferable to keep the lines to 80 columns.
-Kevin
_______________________________________________
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-le...@seabios.org
