Agreed, this patch makes no sense at all. If someone is building from my coreboot tree, then they can simply revert the patch there which was made to accommodate edk2 payload, and no change is needed to SeaBIOS.
On Tue, Feb 14, 2023 at 5:14 AM Peter Stuge <pe...@stuge.se> wrote: > Hi Christopher, > > christopherericlento...@gmail.com wrote: > > tom Firmware > > > > while using the SeaBios payload with MrChromebox's SMM variable > > in coreboot. This is required even if we are booting off of a > > USB, since it will give MMC errors in Linux and Windows 10 > > and 11 won't see it, though I didn't test 11, It would most > > likely do it since all Linux versions I tried did the same. > > I'm merely a community member here but neither your commit message > nor the comments you add to source files explain to me what is being > done and why - only what the outcome is and that actually this > problem is much larger than your patch addresses and that your patch > is only applicable in certain circumstances (and harmful in others?). > > That will likely not be accepted into the codebase. > > It's completely okay to post the patch on this list anyway. > > But if you want the problem you experience to actually be fixed > correctly/thoroughly then I think this issue needs much more work. > > Is that your ambition? > > > Thanks and kind regards > > //Peter > _______________________________________________ > SeaBIOS mailing list -- seabios@seabios.org > To unsubscribe send an email to seabios-le...@seabios.org >
_______________________________________________ SeaBIOS mailing list -- seabios@seabios.org To unsubscribe send an email to seabios-le...@seabios.org
