On Mon, Jun 02, 2025 at 10:31:48AM +0200, Philippe Mathieu-Daudé wrote: > Hi Jiaxun, > > On 30/5/25 18:12, Jiaxun Yang wrote: > > Although we are not going to have a clang build any time > > soon, those warnings generally make sense. > > > > ./src/hw/usb-ohci.c:192:13: warning: logical not is only applied to the > > left hand side of this bitwise operator [-Wlogical-not-parentheses] > > 192 | if (! status & OHCI_HCR) > > > > ./src/util.h:217:53: warning: attribute declaration must precede definition > > [-Wignored-attributes] > > 217 | extern struct bios_config_table_s BIOS_CONFIG_TABLE __aligned(1); > > | ^ > > In file included from out/ccode32flat.o.tmp.c:83: > > ./src/hw/virtio-blk.c:56:9: warning: misleading indentation; statement is > > not part of the previous 'while' [-Wmisleading-indentation] > > 56 | vring_get_buf(vq, NULL); > > > > Signed-off-by: Jiaxun Yang <jiaxun.y...@flygoat.com> > > --- > > src/hw/serialio.c | 1 + > > src/hw/usb-ohci.c | 2 +- > > src/hw/virtio-blk.c | 2 +- > > src/std/LegacyBios.h | 4 +++- > > 4 files changed, 6 insertions(+), 3 deletions(-) > > Fixing distinct issues in distinct files doesn't seem wise > to me, I'd rather see that split, but up to the maintainers; > my 2 cents.
One patch per warning would be better indeed. take care, Gerd _______________________________________________ SeaBIOS mailing list -- seabios@seabios.org To unsubscribe send an email to seabios-le...@seabios.org
