On Fri, Jun 27, 2025 at 11:03:06PM +0000, Kevin O'Connor wrote:
> On Fri, Jun 27, 2025 at 07:34:40PM +0000, Andrei Purdea wrote:
> > Hello,
> > 
> > This fixes what happens when F11/F12 is sent via serial port.
> > The existing code already correctly detected the byte sequence that was sent
> > on the serial connection, however it translated it to incorrect keycode.
> > The termseq table must map to "DOS scan codes".
> > The incorrect value matched "PS2 set1 scan codes" for F11 and F12, so I 
> > think
> > this was simply an implementation mistake.
> > 
> > I have tested the attached patch on real hardware.
> > 
> > I am not the author of the patch, the original change can be found here:
> > https://github.com/Dasharo/SeaBIOS/commit/0f4530859f11b3235b7d6163388f19577bdc6e1e
> 
> Thanks.  Looks correct to me (in that sercom.c:termseq would then
> match kbd.c:scan_to_keycode).
> 
> Gerd, do you have any thoughts on this change?

Looks good to me.

take care,
  Gerd

_______________________________________________
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-le...@seabios.org

Reply via email to