Thanks, Stephen! Change has been pushed to https://android-review.googlesource.com/49340. ________________________________________ From: Stephen Smalley [[email protected]] Sent: Tuesday, January 08, 2013 7:17 AM To: Alice Chu Cc: [email protected]; William Roberts Subject: Re: Fixing libselinux issue found by Klocwork
On 01/07/2013 09:01 PM, Alice Chu wrote: > Hi Stephen, > > Thank you for pointing out the error. I think it would be better checking > mkdir return value instead of waiting for mount to catch the error, although > the end result will be the same. Here is the change. > > >>From 1b64d988c2722acebcab2b6866e4b46526d64a46 Mon Sep 17 00:00:00 2001 > From: Alice Chu <[email protected]> > Date: Fri, 4 Jan 2013 16:02:46 -0800 > Subject: [PATCH] Fix issues found by Klocwork. > > Change-Id: Ieab3494c04b835ae48f43ee14834f57f1ca3f2a8 > --- > src/android.c | 7 ++++++- > 1 files changed, 6 insertions(+), 1 deletions(-) > > diff --git a/src/android.c b/src/android.c > index a74428f..d299ade 100644 > --- a/src/android.c > +++ b/src/android.c > @@ -731,7 +731,12 @@ int selinux_android_load_policy(void) > if (errno == ENOENT) { > /* Fall back to legacy mountpoint. */ > mnt = OLDSELINUXMNT; > - mkdir(mnt, 0755); > + rc = mkdir(mnt, 0755); > + if (rc == -1 && errno != EEXIST) { > + selinux_log(SELINUX_ERROR,"SELinux: Could not > mkdir: %s\n", > + strerror(errno)); > + return -1; > + } > rc = mount(SELINUXFS, mnt, SELINUXFS, 0, NULL); > } > } > Ok, feel free to upload to AOSP, but with a better description in the subject and patch description. -- This message was distributed to subscribers of the seandroid-list mailing list. If you no longer wish to subscribe, send mail to [email protected] with the words "unsubscribe seandroid-list" without quotes as the message.
