I have no real objections to this type of functionality. LGTM.


On 08/08/2013 11:24 AM, William Roberts wrote:

Wait all paths should be relative to ANDROID_TOP already.

However, other variables may wish to be included. I'm fine with this.

On Aug 8, 2013 11:13 AM, "Richard Haines" <[email protected] <mailto:[email protected]>> wrote:

    If no problems with this I'll upload
    Richard

    ----------------------------------------


    Currently a path to a key in keys.conf must be fully qualified or have
    the -d option appended. This fix will allow paths to have environment
    variables that will be expanded. This will give portability to the
    entries. For example the following entry will now be resolved
    correctly:
    [@NET_APPS]
    ALL :
    $ANDROID_BUILD_TOP/device/demo_vendor/demo_dev/security/net_apps.x509.pem

    Change-Id: If4f169d9ed4f37b6ebd062508de058f3baeafead
    Signed-off-by: Richard Haines <[email protected]
    <mailto:[email protected]>>
    ---
     tools/insertkeys.py | 3 ++-
     1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/tools/insertkeys.py b/tools/insertkeys.py
    index cccb92f..dec6d87 100755
    --- a/tools/insertkeys.py
    +++ b/tools/insertkeys.py
    @@ -87,7 +87,8 @@ class ParseConfig(ConfigParser.ConfigParser):
                     if tag in keyMap:
                         sys.exit("Duplicate tag detected " + tag)

    -                path = os.path.join(key_directory, self.get(tag,
    option))
    +                tag_path = os.path.expandvars(self.get(tag, option))
    +                path = os.path.join(key_directory, tag_path)

                     keyMap[tag] = GenerateKeys(path)

    --
    1.8.3.1



    --
    This message was distributed to subscribers of the seandroid-list
    mailing list.
    If you no longer wish to subscribe, send mail to
    [email protected] <mailto:[email protected]> with
    the words "unsubscribe seandroid-list" without quotes as the message.


Reply via email to