In AOSP master, make_ext4fs.c ensures that the path always has a trailing slash in the canonicalize_slashes() helper function. make_ext4fs_internal() calls canonicalize_abs_slashes() on the provided mountpoint path and then uses the result.
On Wed, Apr 30, 2014 at 1:14 PM, Tai Nguyen (tainguye) <[email protected]> wrote: > I see the change use > asprintf(&path, "%slost+found", dir_path); > > Do you expect the dir_path to include the delimiter? > It works with command > make_ext4fs -S file_context -a /dev/isys/ /dev/isys > > It doesn¹t work if I use -a /dev/isys. Is that the expected usage of -a > option? > > On 4/25/14, 3:06 PM, "Stephen Smalley" <[email protected]> wrote: > >>On 02/05/2014 01:31 PM, Stephen Smalley wrote: >>> On 02/05/2014 10:50 AM, Tai Nguyen (tainguye) wrote: >>>> make_ext4fs creates a default lost+found directory without label. The >>>>option S and a sets the label for the root directory only. >>>> And option L doesn¹t seem to work for me. I looked at the code and >>>>didn¹t see it is used anywhere except the print statement. >>>> >>>> So, what is the recommended/common way to set the label for lost+found >>>>dir in ext4 fs? >>> >>> It seems like a bug if make_ext4fs creates lost+found and is not >>> labeling it. I haven't looked into it as originally make_ext4fs did not >>> create lost+found directories at all and we don't mind them being >>> unlabeled as nothing should be accessing them except unconfined domains >>> such as init. >> >>I finally tracked this down, see: >>https://android-review.googlesource.com/#/c/92290/ >> > > > _______________________________________________ > Seandroid-list mailing list > [email protected] > To unsubscribe, send email to [email protected]. > To get help, send an email containing "help" to > [email protected]. _______________________________________________ Seandroid-list mailing list [email protected] To unsubscribe, send email to [email protected]. To get help, send an email containing "help" to [email protected].
