Good to hear it might work for ya. Yeah, we have something similar like
this in our build tree - not sure it's the best solution but it gets the
job done.
ifeq ($(word 2, $(subst _, ,$(TARGET_PRODUCT))), hammerhead)
On 03/11/2015 01:46 PM, Owain Davies wrote:
Thanks Robert, that is a good idea. I would still need to do
myprod_hammerhead myprod_shamu myprod_flounder though If I use a
consistent name convention myprod_<target_device> then I could use the
following:
ifneq($(filter myprod_%, $(PRODUCT_NAME) ),)
On 11 March 2015 at 17:23, Robert Craig <[email protected]
<mailto:[email protected]>> wrote:
If you're worried about including those changes in all the builds
then maybe put a conditional at the top of the
vendor/foo/hammerhead/device-partial.mk <http://device-partial.mk>
file. What if you put the following at the top of the file.
ifeq ($(TARGET_PRODUCT), myhammerhead)
On 03/11/2015 01:12 PM, Owain Davies wrote:
I have some clarification on this now.
The TARGET_DEVICE is specified in a Product makefile using
PRODUCT_DEVICE.
The build system will then look for a BoardConfig.mk file in
"build/target/board/$(TARGET_DEVICE)/" and search up to 4
directories deep in "vendor" and "device" for a directory named
$(TARGET_DEVICE) containing a BoardConfig.mk file. If it finds
none that is an error if it find more than one that is also an error.
So my proposed directory structure does not work, and I still can
find no way to conditionally include the BOARD_SEPOLICY_UNION
just for when my product is being built.
I can crate a newly named target device (eg. "myhammerhead")
which would inherrit the original device config (eg.
"hammerhead"), but that breaks all the hardware and devices
specific modules which only build for the original TARGET_DEVICE
name.
Stephen's idea would obviously work, but it would still
unconditionally include those changes even if I was not building
myprod but building the base aosp build.
I guess there is not an easy answer to this.
_______________________________________________
Seandroid-list mailing list
[email protected] <mailto:[email protected]>
To unsubscribe, send email [email protected]
<mailto:[email protected]>.
To get help, send an email containing "help"
[email protected] <mailto:[email protected]>.
_______________________________________________
Seandroid-list mailing list
[email protected]
To unsubscribe, send email to [email protected].
To get help, send an email containing "help" to
[email protected].
