[Bug 217394] IRQ override skipping breaks the Aya Neo Air Plus 6800U keyboard buttons
https://bugzilla.kernel.org/show_bug.cgi?id=217394 Mario Limonciello (AMD) (mario.limoncie...@amd.com) changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|acpi_config-tables@kernel-b |mario.limoncie...@amd.com |ugs.osdl.org| --- Comment #17 from Mario Limonciello (AMD) (mario.limoncie...@amd.com) --- I've submitted https://lore.kernel.org/linux-acpi/20230515213822.1277-1-mario.limoncie...@amd.com/T/#u for discussion on this issue. -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug. ___ acpi-bugzilla mailing list acpi-bugzilla@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
[Bug 217394] IRQ override skipping breaks the Aya Neo Air Plus 6800U keyboard buttons
https://bugzilla.kernel.org/show_bug.cgi?id=217394 Mario Limonciello (AMD) (mario.limoncie...@amd.com) changed: What|Removed |Added Attachment #304233|0 |1 is obsolete|| Attachment #304242|0 |1 is obsolete|| --- Comment #16 from Mario Limonciello (AMD) (mario.limoncie...@amd.com) --- Created attachment 304243 --> https://bugzilla.kernel.org/attachment.cgi?id=304243=edit potential patch (v2) -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug. ___ acpi-bugzilla mailing list acpi-bugzilla@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
[Bug 217394] IRQ override skipping breaks the Aya Neo Air Plus 6800U keyboard buttons
https://bugzilla.kernel.org/show_bug.cgi?id=217394 --- Comment #15 from Mario Limonciello (AMD) (mario.limoncie...@amd.com) --- Created attachment 304242 --> https://bugzilla.kernel.org/attachment.cgi?id=304242=edit potential patch (v2) -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug. ___ acpi-bugzilla mailing list acpi-bugzilla@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
[Bug 217394] IRQ override skipping breaks the Aya Neo Air Plus 6800U keyboard buttons
https://bugzilla.kernel.org/show_bug.cgi?id=217394 --- Comment #14 from Mario Limonciello (AMD) (mario.limoncie...@amd.com) --- The following have been tested: Lenovo Z13 HP Pro x360 435 Lenovo L14 Gen2a Lenovo P14s Gen1 HP ProBook 635 Aero G7 HP Elitebook 445 Various pre-production laptops Everything worked, but I found a mistake in the AMDI0007 override. It shouldn't be going to level sensitive, but should be going to edge sensitive instead. I'll bump the patch and drop a new version. -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug. ___ acpi-bugzilla mailing list acpi-bugzilla@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
[Bug 217394] IRQ override skipping breaks the Aya Neo Air Plus 6800U keyboard buttons
https://bugzilla.kernel.org/show_bug.cgi?id=217394 --- Comment #13 from Mario Limonciello (AMD) (mario.limoncie...@amd.com) --- The BIOS version (and logs) is more relevant if there is a problem. Thanks for testing what you have so far. I have an internal team at AMD testing more systems as well. -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug. ___ acpi-bugzilla mailing list acpi-bugzilla@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
[Bug 217394] IRQ override skipping breaks the Aya Neo Air Plus 6800U keyboard buttons
https://bugzilla.kernel.org/show_bug.cgi?id=217394 --- Comment #12 from Matthew (ruinairas1...@gmail.com) --- (In reply to Mario Limonciello (AMD) from comment #11) > Great! > > Yes, please document everything you can test with this including the BIOS > version if possible. Sure, it may take me a bit to collect all the information, especially if we are wanting BIOS versions as well. As of right now the tested systems have been. OneXplayer Mini 5800U: No regressions (Uses the same i8042). GPD Win 4 6800U: Fixes the volume buttons. Aya Neo Air Plus 6800U: Fixes the non-gamepad "keyboard" buttons. OneXPlayer 2 6800U: This device has issues with and without the patch (Not tested by me so I can't verify if the user followed instructions correctly) Will be testing: Aya Neo 2 Aya Neo Geek OneXPlayer 1S Intel 1195G7 Potential devices that can be tested: AOKZOE A1 GPD Win Max 2 GPD Win 2 -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug. ___ acpi-bugzilla mailing list acpi-bugzilla@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
[Bug 217394] IRQ override skipping breaks the Aya Neo Air Plus 6800U keyboard buttons
https://bugzilla.kernel.org/show_bug.cgi?id=217394 --- Comment #11 from Mario Limonciello (AMD) (mario.limoncie...@amd.com) --- Great! Yes, please document everything you can test with this including the BIOS version if possible. -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug. ___ acpi-bugzilla mailing list acpi-bugzilla@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
[Bug 217394] IRQ override skipping breaks the Aya Neo Air Plus 6800U keyboard buttons
https://bugzilla.kernel.org/show_bug.cgi?id=217394 --- Comment #10 from Matthew (ruinairas1...@gmail.com) --- (In reply to Mario Limonciello (AMD) from comment #9) > Created attachment 304233 [details] > potential patch v1 > > Can you please have a try with this patch? I expect it should help your > case, but it will need a lot more testing to ensure that it's not causing > regressions for other systems. I can confirm that this fixes the issue on the Air Plus. I have other devices I can test later as well. -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug. ___ acpi-bugzilla mailing list acpi-bugzilla@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
[Bug 217394] IRQ override skipping breaks the Aya Neo Air Plus 6800U keyboard buttons
https://bugzilla.kernel.org/show_bug.cgi?id=217394 --- Comment #9 from Mario Limonciello (AMD) (mario.limoncie...@amd.com) --- Created attachment 304233 --> https://bugzilla.kernel.org/attachment.cgi?id=304233=edit potential patch v1 Can you please have a try with this patch? I expect it should help your case, but it will need a lot more testing to ensure that it's not causing regressions for other systems. -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug. ___ acpi-bugzilla mailing list acpi-bugzilla@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
[Bug 217394] IRQ override skipping breaks the Aya Neo Air Plus 6800U keyboard buttons
https://bugzilla.kernel.org/show_bug.cgi?id=217394 --- Comment #8 from Matthew (ruinairas1...@gmail.com) --- (In reply to Mario Limonciello (AMD) from comment #7) > At least in your situation you can see that very clearly the interrupt > source override in the MADT is correct: > > [0.00] ACPI: INT_SRC_OVR (bus 0 bus_irq 1 global_irq 1 low edge) > > But your ACPI tables are incorrect (and hence the patch to the DSDT helps > the issue). > > To me it seems this issue really boils down to the logic in the kernel of > what to trust when, and there doesn't seem to be a great answer. > > Today it's something like this: > > 1) If it's extended IRQ syntax, trust the DSDT. > 2) If it's legacy syntax (IRQ/IRQNoflags) mabe double check what the > MADT and the DSDT have agree. This is needed for a number of older buggy > machines. > > "2" ended up causing problems for a number of Ryzen 6000 machines because > they didn't have an interrupt source override in place and without this the > value found in the MADT was wrong (Active high) but the value in the DSDT > was right (Active Low). > > This is why we put in place a case to ignore all that and trust the DSDT on > Ryzen systems. > > You're the exact opposite of this and so that's why this logic fell apart. > > I think what we're missing is an indication of whether an interrupt source > override is actually being used or not. So it could work like this: > > 1) Extended IRQ syntax >-> Trust DSDT > 2) Legacy Syntax >Does polarity and trigger match the IOAPIC configuration? >A) Yes > -> Done >B) No: > a) Interrupt Source Override > -> Trust ISR > b) DMI override? > -> Trust DMI override > c) Zen system? > -> Trust DSDT > d) Not Zen system > -> Trust IOAPIC configuration The GPD Win 4 also has an issue when skipping the override. A user on ChimeraOS reported that when using a patched kernel I created fixed the volume buttons for them. The usable DMI for this product is the "product_name" which is "G1618-04". GPD isn't that great at being consistent with their DMI configuration outside of product names. -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug. ___ acpi-bugzilla mailing list acpi-bugzilla@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
[Bug 217394] IRQ override skipping breaks the Aya Neo Air Plus 6800U keyboard buttons
https://bugzilla.kernel.org/show_bug.cgi?id=217394 --- Comment #7 from Mario Limonciello (AMD) (mario.limoncie...@amd.com) --- At least in your situation you can see that very clearly the interrupt source override in the MADT is correct: [0.00] ACPI: INT_SRC_OVR (bus 0 bus_irq 1 global_irq 1 low edge) But your ACPI tables are incorrect (and hence the patch to the DSDT helps the issue). To me it seems this issue really boils down to the logic in the kernel of what to trust when, and there doesn't seem to be a great answer. Today it's something like this: 1) If it's extended IRQ syntax, trust the DSDT. 2) If it's legacy syntax (IRQ/IRQNoflags) mabe double check what the MADT and the DSDT have agree. This is needed for a number of older buggy machines. "2" ended up causing problems for a number of Ryzen 6000 machines because they didn't have an interrupt source override in place and without this the value found in the MADT was wrong (Active high) but the value in the DSDT was right (Active Low). This is why we put in place a case to ignore all that and trust the DSDT on Ryzen systems. You're the exact opposite of this and so that's why this logic fell apart. I think what we're missing is an indication of whether an interrupt source override is actually being used or not. So it could work like this: 1) Extended IRQ syntax -> Trust DSDT 2) Legacy Syntax Does polarity and trigger match the IOAPIC configuration? A) Yes -> Done B) No: a) Interrupt Source Override -> Trust ISR b) DMI override? -> Trust DMI override c) Zen system? -> Trust DSDT d) Not Zen system -> Trust IOAPIC configuration -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug. ___ acpi-bugzilla mailing list acpi-bugzilla@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
[Bug 217394] IRQ override skipping breaks the Aya Neo Air Plus 6800U keyboard buttons
https://bugzilla.kernel.org/show_bug.cgi?id=217394 --- Comment #6 from The Linux kernel's regression tracker (Thorsten Leemhuis) (regressi...@leemhuis.info) --- FWIW, this issue is currently discussed in this thread: https://lore.kernel.org/all/01ea5c8e-ed2f-7568-f6ed-896329e7b...@leemhuis.info/ -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug. ___ acpi-bugzilla mailing list acpi-bugzilla@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
[Bug 217394] IRQ override skipping breaks the Aya Neo Air Plus 6800U keyboard buttons
https://bugzilla.kernel.org/show_bug.cgi?id=217394 --- Comment #5 from Matthew (ruinairas1...@gmail.com) --- Using a modified DSDT I was able to get this working on any kernel. The bios do not have proper values so a kernel workaround will most certainly be needed for this device and likely many others as well. -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug. ___ acpi-bugzilla mailing list acpi-bugzilla@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
[Bug 217394] IRQ override skipping breaks the Aya Neo Air Plus 6800U keyboard buttons
https://bugzilla.kernel.org/show_bug.cgi?id=217394 --- Comment #4 from Matthew (ruinairas1...@gmail.com) --- Created attachment 304205 --> https://bugzilla.kernel.org/attachment.cgi?id=304205=edit Patched kernel dmesg -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug. ___ acpi-bugzilla mailing list acpi-bugzilla@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
[Bug 217394] IRQ override skipping breaks the Aya Neo Air Plus 6800U keyboard buttons
https://bugzilla.kernel.org/show_bug.cgi?id=217394 --- Comment #3 from Matthew (ruinairas1...@gmail.com) --- Created attachment 304204 --> https://bugzilla.kernel.org/attachment.cgi?id=304204=edit stock kernel dmesg -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug. ___ acpi-bugzilla mailing list acpi-bugzilla@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
[Bug 217394] IRQ override skipping breaks the Aya Neo Air Plus 6800U keyboard buttons
https://bugzilla.kernel.org/show_bug.cgi?id=217394 --- Comment #2 from Matthew (ruinairas1...@gmail.com) --- Created attachment 304203 --> https://bugzilla.kernel.org/attachment.cgi?id=304203=edit dmidecode output -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug. ___ acpi-bugzilla mailing list acpi-bugzilla@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
[Bug 217394] IRQ override skipping breaks the Aya Neo Air Plus 6800U keyboard buttons
https://bugzilla.kernel.org/show_bug.cgi?id=217394 The Linux kernel's regression tracker (Thorsten Leemhuis) (regressi...@leemhuis.info) changed: What|Removed |Added CC||regressi...@leemhuis.info --- Comment #1 from The Linux kernel's regression tracker (Thorsten Leemhuis) (regressi...@leemhuis.info) --- Could you please attach the output of "sudo dmidecode"; and having a dmesg at hand might be good as well. -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug. ___ acpi-bugzilla mailing list acpi-bugzilla@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
[Bug 217394] IRQ override skipping breaks the Aya Neo Air Plus 6800U keyboard buttons
https://bugzilla.kernel.org/show_bug.cgi?id=217394 Matthew (ruinairas1...@gmail.com) changed: What|Removed |Added CC||mario.limoncie...@amd.com, ||ruinairas1...@gmail.com -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug. ___ acpi-bugzilla mailing list acpi-bugzilla@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
