Re: [asterisk-dev] [Code Review] 3133: manager: Clarify eventfilter documentation
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3133/ --- (Updated Jan. 23, 2014, 4:22 p.m.) Status -- This change has been marked as submitted. Review request for Asterisk Developers. Repository: Asterisk Description --- Hi, I wasn't too happy with the eventfilter documentation, so I tried to clarify it a bit. Suggestions are welcome. I'm still not fond of the DAHDI.* example, since it implies that there is anchoring going on, which there isn't. Diffs - /branches/1.8/main/manager.c 405159 /branches/1.8/configs/manager.conf.sample 405159 Diff: https://reviewboard.asterisk.org/r/3133/diff/ Testing --- No testing needed. Changes are textual only. Thanks, wdoekes -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 3133: manager: Clarify eventfilter documentation
On Jan. 21, 2014, 3:08 a.m., Matt Jordan wrote: /branches/1.8/configs/manager.conf.sample, line 92 https://reviewboard.asterisk.org/r/3133/diff/1/?file=52957#file52957line92 I agree that it's odd to use basic instead of extended. Maybe document it in 1.8+, and change in trunk? I'm fine with that. Just say ship-it and I'll make a second patch after this one is committed. - wdoekes --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3133/#review10645 --- On Jan. 17, 2014, 9:46 a.m., wdoekes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3133/ --- (Updated Jan. 17, 2014, 9:46 a.m.) Review request for Asterisk Developers. Repository: Asterisk Description --- Hi, I wasn't too happy with the eventfilter documentation, so I tried to clarify it a bit. Suggestions are welcome. I'm still not fond of the DAHDI.* example, since it implies that there is anchoring going on, which there isn't. Diffs - /branches/1.8/main/manager.c 405159 /branches/1.8/configs/manager.conf.sample 405159 Diff: https://reviewboard.asterisk.org/r/3133/diff/ Testing --- No testing needed. Changes are textual only. Thanks, wdoekes -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 3133: manager: Clarify eventfilter documentation
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3133/#review10652 --- Ship it! Ship It! - Matt Jordan On Jan. 17, 2014, 3:46 a.m., wdoekes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3133/ --- (Updated Jan. 17, 2014, 3:46 a.m.) Review request for Asterisk Developers. Repository: Asterisk Description --- Hi, I wasn't too happy with the eventfilter documentation, so I tried to clarify it a bit. Suggestions are welcome. I'm still not fond of the DAHDI.* example, since it implies that there is anchoring going on, which there isn't. Diffs - /branches/1.8/main/manager.c 405159 /branches/1.8/configs/manager.conf.sample 405159 Diff: https://reviewboard.asterisk.org/r/3133/diff/ Testing --- No testing needed. Changes are textual only. Thanks, wdoekes -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 3133: manager: Clarify eventfilter documentation
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3133/#review10645 --- /branches/1.8/configs/manager.conf.sample https://reviewboard.asterisk.org/r/3133/#comment20136 I agree that it's odd to use basic instead of extended. Maybe document it in 1.8+, and change in trunk? - Matt Jordan On Jan. 17, 2014, 3:46 a.m., wdoekes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3133/ --- (Updated Jan. 17, 2014, 3:46 a.m.) Review request for Asterisk Developers. Repository: Asterisk Description --- Hi, I wasn't too happy with the eventfilter documentation, so I tried to clarify it a bit. Suggestions are welcome. I'm still not fond of the DAHDI.* example, since it implies that there is anchoring going on, which there isn't. Diffs - /branches/1.8/main/manager.c 405159 /branches/1.8/configs/manager.conf.sample 405159 Diff: https://reviewboard.asterisk.org/r/3133/diff/ Testing --- No testing needed. Changes are textual only. Thanks, wdoekes -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 3133: manager: Clarify eventfilter documentation
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3133/ --- (Updated Jan. 17, 2014, 9:46 a.m.) Review request for Asterisk Developers. Changes --- going +on Repository: Asterisk Description (updated) --- Hi, I wasn't too happy with the eventfilter documentation, so I tried to clarify it a bit. Suggestions are welcome. I'm still not fond of the DAHDI.* example, since it implies that there is anchoring going on, which there isn't. Diffs - /branches/1.8/main/manager.c 405159 /branches/1.8/configs/manager.conf.sample 405159 Diff: https://reviewboard.asterisk.org/r/3133/diff/ Testing --- No testing needed. Changes are textual only. Thanks, wdoekes -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
