Re: [PATCH 1/7] mmc: sdio: store owner from modules with sdio_register_driver()

2024-03-31 Thread Francesco Dolcini 
Hello Krzysztof,

On Fri, Mar 29, 2024 at 06:24:31PM +0100, Krzysztof Kozlowski wrote:
> Modules registering driver with sdio_register_driver() might
> forget to set .owner field.  The field is used by some of other kernel
 ^^ double space here

> parts for reference counting (try_module_get()), so it is expected that
> drivers will set it.
> 
> Solve the problem by moving this task away from the drivers to the core
> code, just like we did for platform_driver in
> commit 9447057eaff8 ("platform_device: use a macro instead of
> platform_driver_register").
> 
> Since many drivers forget to set the .owner, this effectively will fix
> them.  Examples of fixed drivers are: ath6kl, b43, btsdio.c, ks7010,
   ^^ and here

> libertas, MediaTek WiFi drivers, Realtek WiFi drivers, rsi, siano,
> wilc1000, wl1251 and more.
> 
> Signed-off-by: Krzysztof Kozlowski 

My nit comments are irrelevant, but given you did the same twice I felt
like letting you know.

Reviewed-by: Francesco Dolcini

Re: [PATCH 6/7] wifi: marvell: mwifiex: drop driver owner initialization

2024-03-31 Thread Francesco Dolcini 
On Fri, Mar 29, 2024 at 06:24:36PM +0100, Krzysztof Kozlowski wrote:
> Core in sdio_register_driver() already sets the .owner, so driver does
> not need to.
> 
> Signed-off-by: Krzysztof Kozlowski 

Reviewed-by: Francesco Dolcini

Re: [PATCH 6/6] wifi: marvell: mwifiex: replace open-coded module_sdio_driver()

2024-03-31 Thread Francesco Dolcini 
On Fri, Mar 29, 2024 at 06:10:19PM +0100, Krzysztof Kozlowski wrote:
> Use module_sdio_driver() instead of open-coding it.  No functional
> difference.
> 
> Signed-off-by: Krzysztof Kozlowski 

Reviewed-by: Francesco Dolcini