[aur-dev] Data left behind from a deleted package

2013-03-02 Thread Connor Behan 
When I recently looked through the AUR source, it seemed to me that when
a package is deleted, a record is only removed from the `Packages` table
and that there is data for the corresponding package still in
`CommentNotify`, `PackageComments`, `PackageContents`, `PackageSources`
and `PackageVotes`.

Does this orphan data get deleted by another mechanism I haven't seen?
If not, could I send patches that do a better job of cleaning it up?



signature.asc
Description: OpenPGP digital signature

Re: [aur-dev] Data left behind from a deleted package

2013-03-02 Thread canyonknight 
On Sat, Mar 2, 2013 at 4:33 AM, Connor Behan connor.be...@gmail.com wrote:
 When I recently looked through the AUR source, it seemed to me that when
 a package is deleted, a record is only removed from the `Packages` table
 and that there is data for the corresponding package still in
 `CommentNotify`, `PackageComments`, `PackageContents`, `PackageSources`
 and `PackageVotes`.

 Does this orphan data get deleted by another mechanism I haven't seen?
 If not, could I send patches that do a better job of cleaning it up?


Foreign key constraints in the database schema should take care of
removing the relevant data from the other tables when a record is
removed from the `Packages` table.

Regards,

Jason