Re: [9] Review request for 8171909: [PIT] on Windows, failure of java/awt/Dialog/DialogAboveFrame/DialogAboveFrameTest.java

2017-01-12 Thread Yuri Nesterenko 

Fine with me: runs as expected even on Win10.

-yan

On 01/11/2017 04:53 PM, Sergey Bylokhov wrote:

Looks fine.
Yuri can you please take a look also? Thanks.




Hello,

Could you review a fix for jdk9, please?

bug: https://bugs.openjdk.java.net/browse/JDK-8171909
webrev: http://cr.openjdk.java.net/~dmarkov/8171909/webrev.00/

Problem description:
The test displays a frame and a dialog; then it checks the pixel's
color to test whether the dialog is above the frame or not. It looks
like drawing operation on Windows works a bit slowly than on OSX and
the pixel doesn't have desired color when we examine it.

Fix:
The test should use Util.testPixelColor() from regtesthelpers package
which is specially designed for asynchronous window manager.

Thanks,
Dmitry

Re: [9] Review request for 8171909: [PIT] on Windows, failure of java/awt/Dialog/DialogAboveFrame/DialogAboveFrameTest.java

2017-01-11 Thread Sergey Bylokhov 
Looks fine.
Yuri can you please take a look also? Thanks.


> 
> Hello,
> 
> Could you review a fix for jdk9, please?
> 
>   bug: https://bugs.openjdk.java.net/browse/JDK-8171909 
> 
>   webrev: http://cr.openjdk.java.net/~dmarkov/8171909/webrev.00/ 
> 
> 
> Problem description:
> The test displays a frame and a dialog; then it checks the pixel's color to 
> test whether the dialog is above the frame or not. It looks like drawing 
> operation on Windows works a bit slowly than on OSX and the pixel doesn't 
> have desired color when we examine it. 
> 
> Fix: 
> The test should use Util.testPixelColor() from regtesthelpers package which 
> is specially designed for asynchronous window manager.
> 
> Thanks,
> Dmitry

[9] Review request for 8171909: [PIT] on Windows, failure of java/awt/Dialog/DialogAboveFrame/DialogAboveFrameTest.java

2017-01-10 Thread Dmitry Markov 
Hello,

Could you review a fix for jdk9, please?

bug: https://bugs.openjdk.java.net/browse/JDK-8171909
webrev: http://cr.openjdk.java.net/~dmarkov/8171909/webrev.00/

Problem description:
The test displays a frame and a dialog; then it checks the pixel's color to 
test whether the dialog is above the frame or not. It looks like drawing 
operation on Windows works a bit slowly than on OSX and the pixel doesn't have 
desired color when we examine it. 

Fix: 
The test should use Util.testPixelColor() from regtesthelpers package which is 
specially designed for asynchronous window manager.

Thanks,
Dmitry