Re: RFR: 8266949: Check possibility to disable OperationTimedOut on Unix [v2]
On Sun, 16 May 2021 01:29:59 GMT, Sergey Bylokhov wrote: >> Our implementation of realSync on Unix is not straightforward, we try to >> move the awt root window and catch the ConfigureNotify. The problem is that >> the request to move the awt root window can be ignored, and it is possible >> that the notification will not come. In this case, we throw non-specified >> OperationTimedOut and it crashes the random tests here and there. >> >> I have applied the same logic as on Windows and Linux we will wait till >> timeout(10 seconds) and then exit from the realsync. > > Sergey Bylokhov has updated the pull request incrementally with one > additional commit since the last revision: > > Update SunToolkit.java Marked as reviewed by kizune (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/4038
Re: RFR: 8266949: Check possibility to disable OperationTimedOut on Unix [v2]
On Sun, 16 May 2021 01:29:59 GMT, Sergey Bylokhov wrote: >> Our implementation of realSync on Unix is not straightforward, we try to >> move the awt root window and catch the ConfigureNotify. The problem is that >> the request to move the awt root window can be ignored, and it is possible >> that the notification will not come. In this case, we throw non-specified >> OperationTimedOut and it crashes the random tests here and there. >> >> I have applied the same logic as on Windows and Linux we will wait till >> timeout(10 seconds) and then exit from the realsync. > > Sergey Bylokhov has updated the pull request incrementally with one > additional commit since the last revision: > > Update SunToolkit.java Marked as reviewed by azvegint (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/4038
Re: RFR: 8266949: Check possibility to disable OperationTimedOut on Unix [v2]
On Sun, 16 May 2021 01:29:59 GMT, Sergey Bylokhov wrote:
>> Our implementation of realSync on Unix is not straightforward, we try to
>> move the awt root window and catch the ConfigureNotify. The problem is that
>> the request to move the awt root window can be ignored, and it is possible
>> that the notification will not come. In this case, we throw non-specified
>> OperationTimedOut and it crashes the random tests here and there.
>>
>> I have applied the same logic as on Windows and Linux we will wait till
>> timeout(10 seconds) and then exit from the realsync.
>
> Sergey Bylokhov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Update SunToolkit.java
src/java.desktop/share/classes/sun/awt/SunToolkit.java line 1562:
> 1560: if (timeout(end) <= 0) {
> 1561: return false;
> 1562: }
If the timeout is ended we will exit at the end of this method immediately, but
let's post one less event to the EDT.
-
PR: https://git.openjdk.java.net/jdk/pull/4038
Re: RFR: 8266949: Check possibility to disable OperationTimedOut on Unix [v2]
> Our implementation of realSync on Unix is not straightforward, we try to move > the awt root window and catch the ConfigureNotify. The problem is that the > request to move the awt root window can be ignored, and it is possible that > the notification will not come. In this case, we throw non-specified > OperationTimedOut and it crashes the random tests here and there. > > I have applied the same logic as on Windows and Linux we will wait till > timeout(10 seconds) and then exit from the realsync. Sergey Bylokhov has updated the pull request incrementally with one additional commit since the last revision: Update SunToolkit.java - Changes: - all: https://git.openjdk.java.net/jdk/pull/4038/files - new: https://git.openjdk.java.net/jdk/pull/4038/files/338b8e20..07127d06 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=4038=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk=4038=00-01 Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk/pull/4038.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4038/head:pull/4038 PR: https://git.openjdk.java.net/jdk/pull/4038
