Re: [PATCH] watchdog: stm32_iwdg: explicitly set .running to UNSUPPORTED
On Fri, Nov 22, 2019 at 02:39:29PM +0100, Ahmad Fatoum wrote: > I've spent some time trying to get the ONF (Watchdog enable status) > bit in the IWDG_SR register to read as something other than zero. > > It has since been confirmed to be non-functional[1]. To avoid someone > else spending time on this, document that running status is unsupported > on this hardware explicitly. > No functional change as UNSUPPORTED is already the default. > > [1]: https://www.spinics.net/lists/arm-kernel/msg770527.html > > Signed-off-by: Ahmad Fatoum > --- > drivers/watchdog/stm32_iwdg.c | 1 + > 1 file changed, 1 insertion(+) Applied, thanks Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0| Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
[PATCH] watchdog: stm32_iwdg: explicitly set .running to UNSUPPORTED
I've spent some time trying to get the ONF (Watchdog enable status) bit in the IWDG_SR register to read as something other than zero. It has since been confirmed to be non-functional[1]. To avoid someone else spending time on this, document that running status is unsupported on this hardware explicitly. No functional change as UNSUPPORTED is already the default. [1]: https://www.spinics.net/lists/arm-kernel/msg770527.html Signed-off-by: Ahmad Fatoum --- drivers/watchdog/stm32_iwdg.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/watchdog/stm32_iwdg.c b/drivers/watchdog/stm32_iwdg.c index 808d7c83720e..c7a5cb9caaf4 100644 --- a/drivers/watchdog/stm32_iwdg.c +++ b/drivers/watchdog/stm32_iwdg.c @@ -256,6 +256,7 @@ static int stm32_iwdg_probe(struct device_d *dev) wdd->set_timeout = stm32_iwdg_set_timeout; wdd->timeout_max = (RLR_MAX + 1) * data->max_prescaler * 1000; wdd->timeout_max /= wd->rate * 1000; + wdd->running = WDOG_HW_RUNNING_UNSUPPORTED; /* ONF bit not present in IP */ ret = watchdog_register(wdd); if (ret) { -- 2.24.0 ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox