Re: [Bro-Dev] Move 3rdparty into a separate submodule
bro-3rdparty exists now. You have admin privs, I suggest you prepare that one directly in its master branch, and then do a topic branch in bro that pulls that in. Robin On Fri, Aug 16, 2013 at 17:44 -0700, you wrote: > If someone can create a new git-repo for it, I can move it there… > > or I can file a bug-report :) > > Bernhard > > On Aug 15, 2013, at 11:37 AM, Seth Hall wrote: > > > On Aug 15, 2013, at 2:33 PM, Robin Sommer wrote: > > > >> I think it's a good idea. > > > > > > Me too. > > > > -- > > Seth Hall > > International Computer Science Institute > > (Bro) because everyone has a network > > http://www.bro.org/ > > > > > > ___ > > bro-dev mailing list > > bro-dev@bro.org > > http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev > > -- Robin Sommer * Phone +1 (510) 722-6541 * ro...@icir.org ICSI/LBNL* Fax +1 (510) 666-2956 * www.icir.org/robin ___ bro-dev mailing list bro-dev@bro.org http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
Re: [Bro-Dev] Move 3rdparty into a separate submodule
If someone can create a new git-repo for it, I can move it there… or I can file a bug-report :) Bernhard On Aug 15, 2013, at 11:37 AM, Seth Hall wrote: > On Aug 15, 2013, at 2:33 PM, Robin Sommer wrote: > >> I think it's a good idea. > > > Me too. > > -- > Seth Hall > International Computer Science Institute > (Bro) because everyone has a network > http://www.bro.org/ > > > ___ > bro-dev mailing list > bro-dev@bro.org > http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev ___ bro-dev mailing list bro-dev@bro.org http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
Re: [Bro-Dev] Move 3rdparty into a separate submodule
On Aug 15, 2013, at 2:33 PM, Robin Sommer wrote: > I think it's a good idea. Me too. -- Seth Hall International Computer Science Institute (Bro) because everyone has a network http://www.bro.org/ signature.asc Description: Message signed with OpenPGP using GPGMail ___ bro-dev mailing list bro-dev@bro.org http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
Re: [Bro-Dev] Move 3rdparty into a separate submodule
I think it's a good idea. Robin On Thu, Aug 15, 2013 at 11:26 -0700, you wrote: > Just wanted to check if really none has an opinion on this besides me :) > > Bernhard > > On Jul 31, 2013, at 4:25 PM, Bernhard Amann > wrote: > > > Hi, > > > > I just wanted to ask what you think about moving the 3rdparty stuff under > > src (which at > > the moment only contains sqlite) into a separate git submodule? > > > > That way we keep the 3rdparty sources and their change history out of Bro > > history. SQLite > > alone already has more than 140k lines - and I kind of suspect that we > > might other 3rdparty > > sources in the future. > > > > The disadvantage of this approach is, that the bro git repository does no > > longer contain > > all source-files necessary to compile bro. On the other hand - stuff like > > cmake already is > > in submodules - so even though the bro git contains all source files at the > > moment, you > > still cannot compile it without checking out the submodules. > > > > Bernhard > > > ___ > bro-dev mailing list > bro-dev@bro.org > http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev > -- Robin Sommer * Phone +1 (510) 722-6541 * ro...@icir.org ICSI/LBNL* Fax +1 (510) 666-2956 * www.icir.org/robin ___ bro-dev mailing list bro-dev@bro.org http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
Re: [Bro-Dev] Move 3rdparty into a separate submodule
Just wanted to check if really none has an opinion on this besides me :) Bernhard On Jul 31, 2013, at 4:25 PM, Bernhard Amann wrote: > Hi, > > I just wanted to ask what you think about moving the 3rdparty stuff under src > (which at > the moment only contains sqlite) into a separate git submodule? > > That way we keep the 3rdparty sources and their change history out of Bro > history. SQLite > alone already has more than 140k lines - and I kind of suspect that we might > other 3rdparty > sources in the future. > > The disadvantage of this approach is, that the bro git repository does no > longer contain > all source-files necessary to compile bro. On the other hand - stuff like > cmake already is > in submodules - so even though the bro git contains all source files at the > moment, you > still cannot compile it without checking out the submodules. > > Bernhard ___ bro-dev mailing list bro-dev@bro.org http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
[Bro-Dev] Move 3rdparty into a separate submodule
Hi, I just wanted to ask what you think about moving the 3rdparty stuff under src (which at the moment only contains sqlite) into a separate git submodule? That way we keep the 3rdparty sources and their change history out of Bro history. SQLite alone already has more than 140k lines - and I kind of suspect that we might other 3rdparty sources in the future. The disadvantage of this approach is, that the bro git repository does no longer contain all source-files necessary to compile bro. On the other hand - stuff like cmake already is in submodules - so even though the bro git contains all source files at the moment, you still cannot compile it without checking out the submodules. Bernhard ___ bro-dev mailing list bro-dev@bro.org http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
