Re: Upstreaming the glibc Hurd port

[Samuel Thibault]

Samuel Thibault, on lun. 19 mars 2018 02:51:22 +0100, wrote:
> - Two patches pending comments on libc-alpha:
>   [PATCH] hurd: Initialize TLS and libpthread before signal thread start
>   [PATCH] hurd: Fix early rtld access to errno

That is done.

> - plugging the htl tests to the glibc test infrastructure.

That can be done last.

> - Fixing the date in sysdeps/mach/hurd/bits/posix_opt.h.

That is done too.

> - Fixing GNU Coding Style, notably first line of files.

As I mentioned in another mail, "first line of files" can probably be
copied from the nptl files.

I'm currently trying to use indent to fix the indentation in files, some
manual fixes are needed, but it's quite quick to do, so I'll do it over
all files.

Samuel

Re: Upstreaming the glibc Hurd port

[Samuel Thibault]

Tulio Magno Quites Machado Filho, on mar. 27 mars 2018 11:46:32 -0300, wrote:
> Are these all the patches pending an update there?
> https://patchwork.sourceware.org/project/glibc/list/?submitter=384

No, it's not all of them, so it's really me who should work it out :)

Carlos O'Donell, on mar. 27 mars 2018 09:52:54 -0500, wrote:
> On 03/27/2018 09:46 AM, Tulio Magno Quites Machado Filho wrote:
> > Samuel Thibault  writes:
> > 
> >> Rafal Luzynski, on mar. 27 mars 2018 01:13:23 +0200, wrote:
> >>> 19.03.2018 02:51 Samuel Thibault  wrote:
>  Thanks a lot for the feedback on what needs to be done. It was a busy
>  week-end :)
> >>>
> >>> I appreciate your work. :-) Sorry for a kinda off-topic but could you
> >>> please visit the Patchwork site [1] and mark your committed patches
> >>> as committed, or ask someone to do it for you?
> >>
> >> It seems I can't mark patches submitted by other people, perhaps I just
> >> need to be added to the "Maintainers" list?
> > 
> > Indeed.
> > 
> > Carlos and Siddhesh, could you help Samuel?
> 
> Fixed. I added Samuel to the maintainers list.

Thanks!  It works indeed.

Samuel

Re: Upstreaming the glibc Hurd port

[Tulio Magno Quites Machado Filho]

Samuel Thibault  writes:

> Rafal Luzynski, on mar. 27 mars 2018 01:13:23 +0200, wrote:
>> 19.03.2018 02:51 Samuel Thibault  wrote:
>> > Thanks a lot for the feedback on what needs to be done. It was a busy
>> > week-end :)
>> 
>> I appreciate your work. :-) Sorry for a kinda off-topic but could you
>> please visit the Patchwork site [1] and mark your committed patches
>> as committed, or ask someone to do it for you?
>
> It seems I can't mark patches submitted by other people, perhaps I just
> need to be added to the "Maintainers" list?

Indeed.

Carlos and Siddhesh, could you help Samuel?

For the record: Carlos and Siddhesh are the maintainers of our Patchwork
instance.
https://sourceware.org/glibc/wiki/MAINTAINERS#Maintainers_for_the_patchwork_instance

I can't put your account in the maintainers list, but I can change the status
of the patches.
Are these all the patches pending an update there?
https://patchwork.sourceware.org/project/glibc/list/?submitter=384

-- 
Tulio Magno

Re: Upstreaming the glibc Hurd port

[Carlos O'Donell]

On 03/27/2018 09:46 AM, Tulio Magno Quites Machado Filho wrote:
> Samuel Thibault  writes:
> 
>> Rafal Luzynski, on mar. 27 mars 2018 01:13:23 +0200, wrote:
>>> 19.03.2018 02:51 Samuel Thibault  wrote:
 Thanks a lot for the feedback on what needs to be done. It was a busy
 week-end :)
>>>
>>> I appreciate your work. :-) Sorry for a kinda off-topic but could you
>>> please visit the Patchwork site [1] and mark your committed patches
>>> as committed, or ask someone to do it for you?
>>
>> It seems I can't mark patches submitted by other people, perhaps I just
>> need to be added to the "Maintainers" list?
> 
> Indeed.
> 
> Carlos and Siddhesh, could you help Samuel?

Fixed. I added Samuel to the maintainers list.

> For the record: Carlos and Siddhesh are the maintainers of our Patchwork
> instance.
> https://sourceware.org/glibc/wiki/MAINTAINERS#Maintainers_for_the_patchwork_instance
> 
> I can't put your account in the maintainers list, but I can change the status
> of the patches.
> Are these all the patches pending an update there?
> https://patchwork.sourceware.org/project/glibc/list/?submitter=384


-- 
Cheers,
Carlos.

Re: Upstreaming the glibc Hurd port

[Samuel Thibault]

Rafal Luzynski, on mar. 27 mars 2018 12:40:27 +0200, wrote:
> 27.03.2018 11:00 Samuel Thibault  wrote:
> > [...]
> > It seems I can't mark patches submitted by other people, perhaps I just
> > need to be added to the "Maintainers" list?
> 
> No, I wouldn't ask you to mark patches by other people, if you mark
> your own patches that would be a great cleaning work already.

Just to be sure: I meant patches submitted by others which I have
commited myself to glibc.

Samuel

Re: Upstreaming the glibc Hurd port

[Rafal Luzynski]

27.03.2018 09:45 Samuel Thibault  wrote:
> [...]
> Oh, I didn't know about it. Is there a way to make them marked as
> commited right from the mail subject, for future commits?

I don't know. Any hints, anybody?


27.03.2018 11:00 Samuel Thibault  wrote:
> [...]
> It seems I can't mark patches submitted by other people, perhaps I just
> need to be added to the "Maintainers" list?

No, I wouldn't ask you to mark patches by other people, if you mark
your own patches that would be a great cleaning work already.
When I mentioned other people I meant that other people should
do the same with their own patches, so that's a general message,
not just for you.

Regards,

Rafal

Re: Upstreaming the glibc Hurd port

[Samuel Thibault]

Rafal Luzynski, on mar. 27 mars 2018 01:13:23 +0200, wrote:
> 19.03.2018 02:51 Samuel Thibault  wrote:
> > Thanks a lot for the feedback on what needs to be done. It was a busy
> > week-end :)
> 
> I appreciate your work. :-) Sorry for a kinda off-topic but could you
> please visit the Patchwork site [1] and mark your committed patches
> as committed, or ask someone to do it for you?

It seems I can't mark patches submitted by other people, perhaps I just
need to be added to the "Maintainers" list?

Samuel

Re: Upstreaming the glibc Hurd port

[Samuel Thibault]

Hello,

Rafal Luzynski, on mar. 27 mars 2018 01:13:23 +0200, wrote:
> I appreciate your work. :-) Sorry for a kinda off-topic but could you
> please visit the Patchwork site [1] and mark your committed patches
> as committed, or ask someone to do it for you?

Oh, I didn't know about it. Is there a way to make them marked as
commited right from the mail subject, for future commits?

Samuel

Re: Upstreaming the glibc Hurd port

[Samuel Thibault]

Svante Signell, on mar. 27 mars 2018 02:54:06 +0200, wrote:
> On Tue, 2018-03-27 at 00:50 +0200, Samuel Thibault wrote:
> > Svante Signell, on lun. 26 mars 2018 23:53:31 +0200, wrote:
> > > On Mon, 2018-03-19 at 02:52 +0100, Samuel Thibault wrote:
> > > > Samuel Thibault, on lun. 19 mars 2018 02:51:22 +0100, wrote:
> > > > > - Fixing GNU Coding Style, notably first line of files.
> > > > 
> > > > Could people have a look in the libpthread repository?
> > > > Most probably, for a lot of these files, one can just take the first
> > > > line of the corresponding nptl file and put "Hurd version".
> > > 
> > > Which branch, or master??
> > > http://git.savannah.gnu.org/cgit/hurd/libpthread.git/
> > 
> > Master, simply.
> 
> It would be nice if you could be more explicit next time when writing such
> mails. I cannot divine into your thoughts :D

Well, "master" is the default branch and all other branches are really
old, I don't see why I couldn't assume that it is obvious that master
would be the one to work on.

Samuel

Re: Samuel: Do you have permission to _enable_ the gccgo patches again?

[Samuel Thibault]

Svante Signell, on mar. 27 mars 2018 02:52:36 +0200, wrote:
> On Tue, 2018-03-27 at 00:49 +0200, Samuel Thibault wrote:
> > Svante Signell, on lun. 26 mars 2018 19:50:58 +0200, wrote
> > 
> > Well, a month is a long time indeed. I guess he needed to move forward,
> > so he dropped; no big deal.
> 
> Yes it is a big deal. If somebody spends numerous (spare time, unpaid) hours
> porting gccgo to Hurd and that work is thrown away then this _is_ a big deal.

What else could he do?  Really, please think about it.

No, he does not have (spare, unpaid) time to spend on fixing patches
himself.  What option did he have at the time except dropping the
patches? (waiting for fixes is not an option)

> > My point is: no, it's not obvious to just commit and forget.  While it
> > *is* obvious to just fix what's currently there.  If you don't see why
> > that commit was a move forward concerning Debian, please do check its
> > consequences and think about it.
> 
> ??

Please do take a think at what actual benefit my commit had, instead of
assuming that it is necessarily a step back.

> > > As I wrote in that bug report, all needed patches are there. And as the 
> > > bug
> > > report says: gcc-8 (8-8-20180321-1 and earlier) was successfully built.
> > 
> > But that's not the latest version, as you said it, even.
> 
> ??
> Latest released Debian version of gcc-8 is 8-8-20180321-1, see
> https://buildd.debian.org/status/package.php?p=gcc-8=sid

Ok, sorry, above I thought you were referring to thread "Hurd port of
go" which was talking about 8-8-20180312-1,2 only.

Anyway, nobody just applies patch blindly, so no it's not a piece of
cake to apply thousands of lines of patches.

Samuel