Re: Three Cheers for Samuel!

2020-06-08 Thread Samuel Thibault
Hello,

I don't know what initially triggered the round of cheers, anyway thank
you all :)

One thing I'm not good at is showing news of what is happening, the
"quarter of the hurd" news were quite useful I think to show people what
happens. It's a matter of taking the time to collect news items, and
publish it periodically on the news part of the wiki (and on the list so
people know about it). Any volunteer? :)

Samuel



Re: Three Cheers for Samuel!

2020-06-08 Thread Richard Braun
On Sun, Jun 07, 2020 at 08:29:14AM -0400, Joshua Branson wrote:
> I just want to thank you for being so diligent at maintaining and
> continuing to develop the GNU/Hurd.  You are one of my heroes, and I
> love how dedicated you are to the project!
> 
> Wishing you a good day,

Likewise.

-- 
Richard Braun



Re: Three Cheers for Samuel!

2020-06-08 Thread Miguel Figueiredo

+1

(actually it's much more than 1)

Às 13:29 de 07/06/20, Joshua Branson escreveu:

Hey Samuel!

I just want to thank you for being so diligent at maintaining and
continuing to develop the GNU/Hurd.  You are one of my heroes, and I
love how dedicated you are to the project!

Wishing you a good day,

Joshua



--
Best regards / Melhores cumprimentos,

Miguel Figueiredo



Re: [hurd,commited] htl: Enable more tests

2020-06-08 Thread Samuel Thibault
Samuel Thibault, le lun. 08 juin 2020 13:34:42 +0200, a ecrit:
> Andreas Schwab, le lun. 08 juin 2020 12:43:16 +0200, a ecrit:
> > On Jun 07 2020, Samuel Thibault wrote:
> > 
> > > * htl/Makefile: Remove rules adding libpthread.so and libpthread.a to link
> > > lines.
> > > * nptl/Makefile: Move rules adding libpthread.so and libpthread.a to
> > > link lines to...
> > > * sysdeps/pthread/Makefile: ... here.
> > 
> > That breaks powerpc:
> [...]
> > make[2]: *** [../Rules:223: 
> > /home/abuild/rpmbuild/BUILD/glibc-2.31.9000.532.g314a431d37/cc-base/nptl/test-get_hwcap]
> >  Error 1
> 
> Oh...
> So it's a test added by sysdeps/powerpc/Makefile, and it seems
> sysdeps/powerpc gets included *after* sysdeps/pthread, thus the missing
> rules for this test. I'll copy back the rules to htl/ and nptl/ for now.

Done so.

Samuel



Re: [PATCH] hurd: libgcc unwinding support over signal trampolines

2020-06-08 Thread Samuel Thibault
Samuel Thibault, le lun. 08 juin 2020 13:36:55 +0200, a ecrit:
> Thomas Schwinge, le lun. 08 juin 2020 12:15:12 +0200, a ecrit:
> > Which GCC branches would you like this on?
> 
> Ideally it's be backported to gcc 9 and 10, so that it lands naturally
> in the Debian packages without having to bother doko.

Actually only gcc 10 would be needed.

Samuel



Re: [PATCH] hurd: libgcc unwinding support over signal trampolines

2020-06-08 Thread Samuel Thibault
Thomas Schwinge, le lun. 08 juin 2020 12:15:12 +0200, a ecrit:
> I'm not currently set up to test this, but I'll assume you have.

Sure :)

> Which GCC branches would you like this on?

Ideally it's be backported to gcc 9 and 10, so that it lands naturally
in the Debian packages without having to bother doko.

> Once we've got this in GCC, please then also cross-reference GCC's
> 'libgcc/config/i386/gnu-unwind.h' file in glibc's
> 'sysdeps/mach/hurd/i386/trampoline.c' file.

Ah, yes, I thought about it and forgot, will do.

Samuel



Re: [hurd,commited] htl: Enable more tests

2020-06-08 Thread Samuel Thibault
Andreas Schwab, le lun. 08 juin 2020 12:43:16 +0200, a ecrit:
> On Jun 07 2020, Samuel Thibault wrote:
> 
> > * htl/Makefile: Remove rules adding libpthread.so and libpthread.a to link
> > lines.
> > * nptl/Makefile: Move rules adding libpthread.so and libpthread.a to
> > link lines to...
> > * sysdeps/pthread/Makefile: ... here.
> 
> That breaks powerpc:
[...]
> make[2]: *** [../Rules:223: 
> /home/abuild/rpmbuild/BUILD/glibc-2.31.9000.532.g314a431d37/cc-base/nptl/test-get_hwcap]
>  Error 1

Oh...
So it's a test added by sysdeps/powerpc/Makefile, and it seems
sysdeps/powerpc gets included *after* sysdeps/pthread, thus the missing
rules for this test. I'll copy back the rules to htl/ and nptl/ for now.

Samuel



Re: [hurd,commited] htl: Enable more tests

2020-06-08 Thread Andreas Schwab
On Jun 07 2020, Samuel Thibault wrote:

> * htl/Makefile: Remove rules adding libpthread.so and libpthread.a to link
> lines.
> * nptl/Makefile: Move rules adding libpthread.so and libpthread.a to
> link lines to...
> * sysdeps/pthread/Makefile: ... here.

That breaks powerpc:

/usr/lib64/gcc/powerpc64-suse-linux/10/../../../../powerpc64-suse-linux/bin/ld: 
/home/abuild/rpmbuild/BUILD/glibc-2.31.9000.532.g314a431d37/cc-base/support/libsupport_nonshared.a(xpthread_create.oS):
 in function `xpthread_create':
/home/abuild/rpmbuild/BUILD/glibc-2.31.9000.532.g314a431d37/support/xpthread_create.c:26:
 undefined reference to `pthread_create'
/usr/lib64/gcc/powerpc64-suse-linux/10/../../../../powerpc64-suse-linux/bin/ld: 
/home/abuild/rpmbuild/BUILD/glibc-2.31.9000.532.g314a431d37/cc-base/support/libsupport_nonshared.a(xpthread_join.oS):
 in function `xpthread_join':
/home/abuild/rpmbuild/BUILD/glibc-2.31.9000.532.g314a431d37/support/xpthread_join.c:25:
 undefined reference to `pthread_join'
collect2: error: ld returned 1 exit status
make[2]: *** [../Rules:223: 
/home/abuild/rpmbuild/BUILD/glibc-2.31.9000.532.g314a431d37/cc-base/nptl/test-get_hwcap]
 Error 1

Andreas.

-- 
Andreas Schwab, sch...@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."



Re: [PATCH] hurd: libgcc unwinding support over signal trampolines

2020-06-08 Thread Thomas Schwinge
Hi Samuel!

On 2020-05-29T13:46:50+0200, Samuel Thibault  wrote:
> libgcc is currently missing the support for unwinding over signal
> trampolines on GNU/Hurd.

ACK.  Has been on my long TODO list for a long time.  ;-)

> The attached patch implements it.

Thanks!

I'm not intimately familiar with the unwinding implementation, but your
changes look quite what I'd have guessed they'd look like, and also
somewhat similar to 'libgcc/config/i386/linux-unwind.h'.  (I'll get
there, eventually, again..., but) I'm not currently set up to test this,
but I'll assume you have.

Which GCC branches would you like this on?

> --- /dev/null
> +++ b/src/libgcc/config/i386/gnu-unwind.h
> @@ -0,0 +1,107 @@

> + * i386 sigtramp frame we are looking for follows.
> + * (see glibc/sysdeps/mach/hurd/i386/trampoline.c assembly)
> + *
> + * rpc_wait_trampoline:
> + *   0:  b8 e7 ff ff ff  mov$-25,%eax   mach_msg_trap
> + *   5:  9a 00 00 00 00 07 00lcall  $7,$0
> + *  12:  89 01   movl   %eax, (%ecx)
> + *  14:  89 dc   movl   %ebx, %esp  switch to signal 
> stack
> + *
> + * trampoline:
> + *  16:  ff d2   call   *%edx   call the handler 
> function
> + * RA HERE
> + *  18:  83 c4 0caddl   $12, %esp   pop its args
> + *  21:  c3  retreturn to 
> sigreturn
> + *
> + * firewall:
> + *  22:  f4  hlt
> + */
> +
> +  if (!(   *(unsigned int   *)(context->ra ) == 0xc30cc483
> +&& *(unsigned char  *)(context->ra +  4) ==   0xf4
> +
> +&& *(unsigned int   *)(context->ra -  4) == 0xd2ffdc89
> +&& *(unsigned int   *)(context->ra -  8) == 0x01890007
> +&& *(unsigned int   *)(context->ra - 12) == 0x
> +&& *(unsigned int   *)(context->ra - 16) == 0x9aff
> +&& *(unsigned short *)(context->ra - 18) == 0xe7b8))
> +return _URC_END_OF_STACK;

Once we've got this in GCC, please then also cross-reference GCC's
'libgcc/config/i386/gnu-unwind.h' file in glibc's
'sysdeps/mach/hurd/i386/trampoline.c' file.


Grüße
 Thomas
-
Mentor Graphics (Deutschland) GmbH, Arnulfstraße 201, 80634 München / Germany
Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Alexander 
Walter