Re: Documentation Typo

[Paul Smith]

On Sun, 2023-01-01 at 18:39 -0800, Vafilor wrote:
> so just changing the second `of` to be `if`. 

I made this fix, thanks for reporting!

Documentation Typo

[Vafilor]

Hi there,

I think there is a tiny typo in the documentation at
https://www.gnu.org/software/make/manual/html_node/Special-Targets.html#Special-Targets
under the *.secondary* name it says:

Of course, of one of the source files *were* updated...

I believe it should be

Of course, *if* one of the source files *were* updated...

so just changing the second `of` to be `if`.

Thank you!

-- 
Andrey Melnikov

[bug #62936] Confusing description of chained rules in the manual

[Paul D. Smith]

Update of bug #62936 (project make):

  Status:None => Not A Bug  
 Open/Closed:Open => Closed 

___

Follow-up Comment #2:

I reread this paragraph and I still don't see anything particularly wrong or
confusing about it.  No further information was provided so I'm closing this
issue.  More comments can be added even when the issue is closed: if needed
and I can re-open it.


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

[bug #50372] gmk_floc missing offset member

[Paul D. Smith]

Follow-up Comment #1, bug #50372 (project make):

The offset field is not really needed by the load setup function.  It only has
a value inside a recipe: lineno is the line number of the start of the rule,
and offset is the number of lines into the recipe.  Since load operations
don't appear within recipes this offset value will be zero anyway.

I suppose that it's possible that a load directive could be invoked from
within an eval function in a recipe.


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

Re: Crash in hash_free_items()

[Paul Smith]

On Fri, 2022-12-30 at 11:34 +0100, Gisle Vanem wrote:
> I'm using the very latest GNU-make built on Win-10 by myself.
> Except I've disabled the call to 'SetUnhandledExceptionFilter()'.
> 
> In one particular Wine Makefile I get a crash in 'hash_free_items()':
>    gnumake!hash_free_items+0x22
>    gnumake!hash_free+0x30
>    gnumake!clear_directory_contents+0x34
>    gnumake!find_directory+0xed
>    gnumake!dir_file_exists_p+0xd
>    gnumake!selective_vpath_search+0x239
>    gnumake!vpath_search+0x9d
>    gnumake!pattern_search+0x1212
> ...
> 
> This is when creating an .res-file from a .rc-file.
> And I use this 'vpath %.rc obj' construct.

Can you try the following patch (after removing your change checking
the value of "ctr") and see if it solves the problem?

diff --git a/src/dir.c b/src/dir.c
index 1e6e7397..7a884d28 100644
--- a/src/dir.c
+++ b/src/dir.c
@@ -283,7 +283,8 @@ clear_directory_contents (struct directory_contents *dc)
   closedir (dc->dirstream);
   dc->dirstream = 0;
 }
-  hash_free (&dc->dirfiles, 1);
+  if (dc->dirfiles.ht_vec != NULL)
+hash_free (&dc->dirfiles, 1);

   return NULL;
 }