[Carbon-dev] How we break the build..? :-)
Nothing serious.. just for fun.. following are few ways how we did break the build in the past.. :-) Please add whatever you remember how you or your colleague broke the build... No names please 1. Changed a public API, built the components in my product and committed 2. Added a new method to an interface - updated it's implementation in my product and committed - forgot to send mail to carbon-dev on the interface change 3. Added new class - builds fine locally - committed all the other changes - forgot to commit the new file 4. Added new a component - added a new feature - committed both - updated the root pom of features - but, forgot to update the root pom of components 5. Added a new dependency to the pom of my component - did some code changes - did an svn stat from ../src - committed all code changes - missed the pom with the new dependency Let's build this list.. :) -- Thanks & Regards, Prabath http://blog.facilelogin.com http://RampartFAQ.com ___ Carbon-dev mailing list Carbon-dev@wso2.org http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
Re: [Carbon-dev] How we break the build..? :-)
1) most frequent case in patch-releases : when adding a new version of a component, we never add the relative path property. :) On Thu, Dec 8, 2011 at 9:12 AM, Prabath Siriwardena wrote: > Nothing serious.. just for fun.. following are few ways how we did break > the build in the past.. :-) Please add whatever you remember how you or > your colleague broke the build... No names please > > 1. Changed a public API, built the components in my product and committed > 2. Added a new method to an interface - updated it's implementation in my > product and committed - forgot to send mail to carbon-dev on the interface > change > 3. Added new class - builds fine locally - committed all the other changes > - forgot to commit the new file > 4. Added new a component - added a new feature - committed both - updated > the root pom of features - but, forgot to update the root pom of components > 5. Added a new dependency to the pom of my component - did some code > changes - did an svn stat from ../src - committed all code changes - missed > the pom with the new dependency > > Let's build this list.. :) > > -- > Thanks & Regards, > Prabath > > http://blog.facilelogin.com > http://RampartFAQ.com > > ___ > Carbon-dev mailing list > Carbon-dev@wso2.org > http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev > > -- Supun Malinga, Software Engineer, WSO2 Inc. http://wso2.com http://wso2.org email - sup...@wso2.com mobile - 071 56 91 321 ___ Carbon-dev mailing list Carbon-dev@wso2.org http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
Re: [Carbon-dev] How we break the build..? :-)
On Thu, Dec 8, 2011 at 9:12 AM, Prabath Siriwardena wrote: > Nothing serious.. just for fun.. following are few ways how we did break > the build in the past.. :-) Please add whatever you remember how you or > your colleague broke the build... No names please > > 1. Changed a public API, built the components in my product and committed > 2. Added a new method to an interface - updated it's implementation in my > product and committed - forgot to send mail to carbon-dev on the interface > change > 3. Added new class - builds fine locally - committed all the other changes > - forgot to commit the new file > 4. Added new a component - added a new feature - committed both - updated > the root pom of features - but, forgot to update the root pom of components > 5. Added a new dependency to the pom of my component - did some code > changes - did an svn stat from ../src - committed all code changes - missed > the pom with the new dependency > 6. I built only my part locally - not the product, not the whole thing. > Let's build this list.. :) > > -- > Thanks & Regards, > Prabath > > http://blog.facilelogin.com > http://RampartFAQ.com > > ___ > Carbon-dev mailing list > Carbon-dev@wso2.org > http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev > > Thanks, Samisa... Samisa Abeysinghe VP Engineering WSO2 Inc. http://wso2.com http://wso2.org ___ Carbon-dev mailing list Carbon-dev@wso2.org http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
Re: [Carbon-dev] How we break the build..? :-)
On Thu, Dec 8, 2011 at 9:23 AM, Supun Malinga wrote: my bad. wrong number! 7) most frequent case in patch-releases : when adding a new version of a component, we never add the relative path property. :) > 1) most frequent case in patch-releases : when adding a new version of a > component, we never add the relative path property. :) > > On Thu, Dec 8, 2011 at 9:12 AM, Prabath Siriwardena wrote: > >> Nothing serious.. just for fun.. following are few ways how we did break >> the build in the past.. :-) Please add whatever you remember how you or >> your colleague broke the build... No names please >> >> 1. Changed a public API, built the components in my product and committed >> 2. Added a new method to an interface - updated it's implementation in my >> product and committed - forgot to send mail to carbon-dev on the interface >> change >> 3. Added new class - builds fine locally - committed all the other >> changes - forgot to commit the new file >> 4. Added new a component - added a new feature - committed both - updated >> the root pom of features - but, forgot to update the root pom of components >> 5. Added a new dependency to the pom of my component - did some code >> changes - did an svn stat from ../src - committed all code changes - missed >> the pom with the new dependency >> >> Let's build this list.. :) >> >> -- >> Thanks & Regards, >> Prabath >> >> http://blog.facilelogin.com >> http://RampartFAQ.com >> >> ___ >> Carbon-dev mailing list >> Carbon-dev@wso2.org >> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev >> >> > > > -- > Supun Malinga, > > Software Engineer, > WSO2 Inc. > http://wso2.com > http://wso2.org > email - sup...@wso2.com > mobile - 071 56 91 321 > > -- Supun Malinga, Software Engineer, WSO2 Inc. http://wso2.com http://wso2.org email - sup...@wso2.com mobile - 071 56 91 321 ___ Carbon-dev mailing list Carbon-dev@wso2.org http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
Re: [Carbon-dev] How we break the build..? :-)
8. Built without tests and committed - my fix has broken a test case Thanks & regards, -Prabath On Thu, Dec 8, 2011 at 9:49 AM, Supun Malinga wrote: > > > On Thu, Dec 8, 2011 at 9:23 AM, Supun Malinga wrote: > my bad. wrong number! > > 7) most frequent case in patch-releases : when adding a new version of a > component, we never add the relative path property. :) > >> 1) most frequent case in patch-releases : when adding a new version of a >> component, we never add the relative path property. :) >> >> On Thu, Dec 8, 2011 at 9:12 AM, Prabath Siriwardena wrote: >> >>> Nothing serious.. just for fun.. following are few ways how we did break >>> the build in the past.. :-) Please add whatever you remember how you or >>> your colleague broke the build... No names please >>> >>> 1. Changed a public API, built the components in my product and >>> committed >>> 2. Added a new method to an interface - updated it's implementation in >>> my product and committed - forgot to send mail to carbon-dev on the >>> interface change >>> 3. Added new class - builds fine locally - committed all the other >>> changes - forgot to commit the new file >>> 4. Added new a component - added a new feature - committed both - >>> updated the root pom of features - but, forgot to update the root pom of >>> components >>> 5. Added a new dependency to the pom of my component - did some code >>> changes - did an svn stat from ../src - committed all code changes - missed >>> the pom with the new dependency >>> >>> Let's build this list.. :) >>> >>> -- >>> Thanks & Regards, >>> Prabath >>> >>> http://blog.facilelogin.com >>> http://RampartFAQ.com >>> >>> ___ >>> Carbon-dev mailing list >>> Carbon-dev@wso2.org >>> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev >>> >>> >> >> >> -- >> Supun Malinga, >> >> Software Engineer, >> WSO2 Inc. >> http://wso2.com >> http://wso2.org >> email - sup...@wso2.com >> mobile - 071 56 91 321 >> >> > > > -- > Supun Malinga, > > Software Engineer, > WSO2 Inc. > http://wso2.com > http://wso2.org > email - sup...@wso2.com > mobile - 071 56 91 321 > > > ___ > Carbon-dev mailing list > Carbon-dev@wso2.org > http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev > > -- Thanks & Regards, Prabath http://blog.facilelogin.com http://RampartFAQ.com ___ Carbon-dev mailing list Carbon-dev@wso2.org http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
Re: [Carbon-dev] How we break the build..? :-)
On Thu, Dec 8, 2011 at 9:53 AM, Prabath Siriwardena wrote: > 8. Built without tests and committed - my fix has broken a test case 9. Changes to orbit bundles can caues chaos, unless you build the whole thing and verify. These changes includes version changes, import/export changes, embedding of jar files. Sameera. > > Thanks & regards, > -Prabath > > > On Thu, Dec 8, 2011 at 9:49 AM, Supun Malinga wrote: > >> >> >> On Thu, Dec 8, 2011 at 9:23 AM, Supun Malinga wrote: >> my bad. wrong number! >> >> 7) most frequent case in patch-releases : when adding a new version of a >> component, we never add the relative path property. :) >> >>> 1) most frequent case in patch-releases : when adding a new version of a >>> component, we never add the relative path property. :) >>> >>> On Thu, Dec 8, 2011 at 9:12 AM, Prabath Siriwardena wrote: >>> Nothing serious.. just for fun.. following are few ways how we did break the build in the past.. :-) Please add whatever you remember how you or your colleague broke the build... No names please 1. Changed a public API, built the components in my product and committed 2. Added a new method to an interface - updated it's implementation in my product and committed - forgot to send mail to carbon-dev on the interface change 3. Added new class - builds fine locally - committed all the other changes - forgot to commit the new file 4. Added new a component - added a new feature - committed both - updated the root pom of features - but, forgot to update the root pom of components 5. Added a new dependency to the pom of my component - did some code changes - did an svn stat from ../src - committed all code changes - missed the pom with the new dependency Let's build this list.. :) -- Thanks & Regards, Prabath http://blog.facilelogin.com http://RampartFAQ.com ___ Carbon-dev mailing list Carbon-dev@wso2.org http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev >>> >>> >>> -- >>> Supun Malinga, >>> >>> Software Engineer, >>> WSO2 Inc. >>> http://wso2.com >>> http://wso2.org >>> email - sup...@wso2.com >>> mobile - 071 56 91 321 >>> >>> >> >> >> -- >> Supun Malinga, >> >> Software Engineer, >> WSO2 Inc. >> http://wso2.com >> http://wso2.org >> email - sup...@wso2.com >> mobile - 071 56 91 321 >> >> >> ___ >> Carbon-dev mailing list >> Carbon-dev@wso2.org >> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev >> >> > > > -- > Thanks & Regards, > Prabath > > http://blog.facilelogin.com > http://RampartFAQ.com > > ___ > Carbon-dev mailing list > Carbon-dev@wso2.org > http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev > > -- Sameera Jayasoma Technical Lead and Product Manager, WSO2 Carbon WSO2, Inc. (http://wso2.com) email: same...@wso2.com blog: http://tech.jayasoma.org Lean . Enterprise . Middleware ___ Carbon-dev mailing list Carbon-dev@wso2.org http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
Re: [Carbon-dev] How we break the build..? :-)
10. Applying a previously applied patch. If we try to apply a patch that was already applied or partially applied, it will revert the previous commit of the patch. (Just like applying the reverse of the original patch.) I have done that once, I recall. Have to take an svn up and check whether the patch is already applied before applying it and committing. Regards, Pradeeban. On Thu, Dec 8, 2011 at 2:19 PM, Sameera Jayasoma wrote: > > > On Thu, Dec 8, 2011 at 9:53 AM, Prabath Siriwardena wrote: > >> 8. Built without tests and committed - my fix has broken a test case > > > 9. Changes to orbit bundles can caues chaos, unless you build the whole > thing and verify. These changes includes version changes, import/export > changes, embedding of jar files. > > Sameera. > >> >> Thanks & regards, >> -Prabath >> >> >> On Thu, Dec 8, 2011 at 9:49 AM, Supun Malinga wrote: >> >>> >>> >>> On Thu, Dec 8, 2011 at 9:23 AM, Supun Malinga wrote: >>> my bad. wrong number! >>> >>> 7) most frequent case in patch-releases : when adding a new version of a >>> component, we never add the relative path property. :) >>> 1) most frequent case in patch-releases : when adding a new version of a component, we never add the relative path property. :) On Thu, Dec 8, 2011 at 9:12 AM, Prabath Siriwardena wrote: > Nothing serious.. just for fun.. following are few ways how we did > break the build in the past.. :-) Please add whatever you remember how you > or your colleague broke the build... No names please > > 1. Changed a public API, built the components in my product and > committed > 2. Added a new method to an interface - updated it's implementation in > my product and committed - forgot to send mail to carbon-dev on the > interface change > 3. Added new class - builds fine locally - committed all the other > changes - forgot to commit the new file > 4. Added new a component - added a new feature - committed both - > updated the root pom of features - but, forgot to update the root pom of > components > 5. Added a new dependency to the pom of my component - did some code > changes - did an svn stat from ../src - committed all code changes - > missed > the pom with the new dependency > > Let's build this list.. :) > > -- > Thanks & Regards, > Prabath > > http://blog.facilelogin.com > http://RampartFAQ.com > > ___ > Carbon-dev mailing list > Carbon-dev@wso2.org > http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev > > -- Supun Malinga, Software Engineer, WSO2 Inc. http://wso2.com http://wso2.org email - sup...@wso2.com mobile - 071 56 91 321 >>> >>> >>> -- >>> Supun Malinga, >>> >>> Software Engineer, >>> WSO2 Inc. >>> http://wso2.com >>> http://wso2.org >>> email - sup...@wso2.com >>> mobile - 071 56 91 321 >>> >>> >>> ___ >>> Carbon-dev mailing list >>> Carbon-dev@wso2.org >>> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev >>> >>> >> >> >> -- >> Thanks & Regards, >> Prabath >> >> http://blog.facilelogin.com >> http://RampartFAQ.com >> >> ___ >> Carbon-dev mailing list >> Carbon-dev@wso2.org >> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev >> >> > > > -- > Sameera Jayasoma > Technical Lead and Product Manager, WSO2 Carbon > > WSO2, Inc. (http://wso2.com) > email: same...@wso2.com > blog: http://tech.jayasoma.org > > Lean . Enterprise . Middleware > > ___ > Carbon-dev mailing list > Carbon-dev@wso2.org > http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev > > -- Kathiravelu Pradeeban. Software Engineer. WSO2 Inc. Blog: [Llovizna] http://kkpradeeban.blogspot.com/ ___ Carbon-dev mailing list Carbon-dev@wso2.org http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
Re: [Carbon-dev] How we break the build..? :-)
On Thu, Dec 8, 2011 at 2:28 PM, Kathiravelu Pradeeban wrote: > 10. Applying a previously applied patch. > If we try to apply a patch that was already applied or partially applied, > it will revert the previous commit of the patch. (Just like applying the > reverse of the original patch.) > 11. updating the version of a component. you update only in one product and forget the rest :) > I have done that once, I recall. > > Have to take an svn up and check whether the patch is already applied > before applying it and committing. > > Regards, > Pradeeban. > > > On Thu, Dec 8, 2011 at 2:19 PM, Sameera Jayasoma wrote: > >> >> >> On Thu, Dec 8, 2011 at 9:53 AM, Prabath Siriwardena wrote: >> >>> 8. Built without tests and committed - my fix has broken a test case >> >> >> 9. Changes to orbit bundles can caues chaos, unless you build the whole >> thing and verify. These changes includes version changes, import/export >> changes, embedding of jar files. >> >> Sameera. >> >>> >>> Thanks & regards, >>> -Prabath >>> >>> >>> On Thu, Dec 8, 2011 at 9:49 AM, Supun Malinga wrote: >>> On Thu, Dec 8, 2011 at 9:23 AM, Supun Malinga wrote: my bad. wrong number! 7) most frequent case in patch-releases : when adding a new version of a component, we never add the relative path property. :) > 1) most frequent case in patch-releases : when adding a new version of > a component, we never add the relative path property. :) > > On Thu, Dec 8, 2011 at 9:12 AM, Prabath Siriwardena > wrote: > >> Nothing serious.. just for fun.. following are few ways how we did >> break the build in the past.. :-) Please add whatever you remember how >> you >> or your colleague broke the build... No names please >> >> 1. Changed a public API, built the components in my product and >> committed >> 2. Added a new method to an interface - updated it's implementation >> in my product and committed - forgot to send mail to carbon-dev on the >> interface change >> 3. Added new class - builds fine locally - committed all the other >> changes - forgot to commit the new file >> 4. Added new a component - added a new feature - committed both - >> updated the root pom of features - but, forgot to update the root pom of >> components >> 5. Added a new dependency to the pom of my component - did some code >> changes - did an svn stat from ../src - committed all code changes - >> missed >> the pom with the new dependency >> >> Let's build this list.. :) >> >> -- >> Thanks & Regards, >> Prabath >> >> http://blog.facilelogin.com >> http://RampartFAQ.com >> >> ___ >> Carbon-dev mailing list >> Carbon-dev@wso2.org >> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev >> >> > > > -- > Supun Malinga, > > Software Engineer, > WSO2 Inc. > http://wso2.com > http://wso2.org > email - sup...@wso2.com > mobile - 071 56 91 321 > > -- Supun Malinga, Software Engineer, WSO2 Inc. http://wso2.com http://wso2.org email - sup...@wso2.com mobile - 071 56 91 321 ___ Carbon-dev mailing list Carbon-dev@wso2.org http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev >>> >>> >>> -- >>> Thanks & Regards, >>> Prabath >>> >>> http://blog.facilelogin.com >>> http://RampartFAQ.com >>> >>> ___ >>> Carbon-dev mailing list >>> Carbon-dev@wso2.org >>> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev >>> >>> >> >> >> -- >> Sameera Jayasoma >> Technical Lead and Product Manager, WSO2 Carbon >> >> WSO2, Inc. (http://wso2.com) >> email: same...@wso2.com >> blog: http://tech.jayasoma.org >> >> Lean . Enterprise . Middleware >> >> ___ >> Carbon-dev mailing list >> Carbon-dev@wso2.org >> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev >> >> > > > -- > Kathiravelu Pradeeban. > Software Engineer. > WSO2 Inc. > > Blog: [Llovizna] http://kkpradeeban.blogspot.com/ > > > ___ > Carbon-dev mailing list > Carbon-dev@wso2.org > http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev > > -- Supun Malinga, Software Engineer, WSO2 Inc. http://wso2.com http://wso2.org email - sup...@wso2.com mobile - 071 56 91 321 ___ Carbon-dev mailing list Carbon-dev@wso2.org http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
Re: [Carbon-dev] How we break the build..? :-)
12. Commented out some modules from the components root pom [these components not needed to my product] and committed it back accidentally.. Thanks & regards, -Prabath On Thu, Dec 8, 2011 at 2:37 PM, Supun Malinga wrote: > > > On Thu, Dec 8, 2011 at 2:28 PM, Kathiravelu Pradeeban > wrote: > >> 10. Applying a previously applied patch. >> If we try to apply a patch that was already applied or partially applied, >> it will revert the previous commit of the patch. (Just like applying the >> reverse of the original patch.) >> > > 11. updating the version of a component. you update only in one product > and forget the rest :) > > >> I have done that once, I recall. >> >> Have to take an svn up and check whether the patch is already applied >> before applying it and committing. >> >> Regards, >> Pradeeban. >> >> >> On Thu, Dec 8, 2011 at 2:19 PM, Sameera Jayasoma wrote: >> >>> >>> >>> On Thu, Dec 8, 2011 at 9:53 AM, Prabath Siriwardena wrote: >>> 8. Built without tests and committed - my fix has broken a test case >>> >>> >>> 9. Changes to orbit bundles can caues chaos, unless you build the whole >>> thing and verify. These changes includes version changes, import/export >>> changes, embedding of jar files. >>> >>> Sameera. >>> Thanks & regards, -Prabath On Thu, Dec 8, 2011 at 9:49 AM, Supun Malinga wrote: > > > On Thu, Dec 8, 2011 at 9:23 AM, Supun Malinga wrote: > my bad. wrong number! > > 7) most frequent case in patch-releases : when adding a new version of > a component, we never add the relative path property. :) > >> 1) most frequent case in patch-releases : when adding a new version >> of a component, we never add the relative path property. :) >> >> On Thu, Dec 8, 2011 at 9:12 AM, Prabath Siriwardena > > wrote: >> >>> Nothing serious.. just for fun.. following are few ways how we did >>> break the build in the past.. :-) Please add whatever you remember how >>> you >>> or your colleague broke the build... No names please >>> >>> 1. Changed a public API, built the components in my product and >>> committed >>> 2. Added a new method to an interface - updated it's implementation >>> in my product and committed - forgot to send mail to carbon-dev on the >>> interface change >>> 3. Added new class - builds fine locally - committed all the other >>> changes - forgot to commit the new file >>> 4. Added new a component - added a new feature - committed both - >>> updated the root pom of features - but, forgot to update the root pom of >>> components >>> 5. Added a new dependency to the pom of my component - did some code >>> changes - did an svn stat from ../src - committed all code changes - >>> missed >>> the pom with the new dependency >>> >>> Let's build this list.. :) >>> >>> -- >>> Thanks & Regards, >>> Prabath >>> >>> http://blog.facilelogin.com >>> http://RampartFAQ.com >>> >>> ___ >>> Carbon-dev mailing list >>> Carbon-dev@wso2.org >>> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev >>> >>> >> >> >> -- >> Supun Malinga, >> >> Software Engineer, >> WSO2 Inc. >> http://wso2.com >> http://wso2.org >> email - sup...@wso2.com >> mobile - 071 56 91 321 >> >> > > > -- > Supun Malinga, > > Software Engineer, > WSO2 Inc. > http://wso2.com > http://wso2.org > email - sup...@wso2.com > mobile - 071 56 91 321 > > > ___ > Carbon-dev mailing list > Carbon-dev@wso2.org > http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev > > -- Thanks & Regards, Prabath http://blog.facilelogin.com http://RampartFAQ.com ___ Carbon-dev mailing list Carbon-dev@wso2.org http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev >>> >>> >>> -- >>> Sameera Jayasoma >>> Technical Lead and Product Manager, WSO2 Carbon >>> >>> WSO2, Inc. (http://wso2.com) >>> email: same...@wso2.com >>> blog: http://tech.jayasoma.org >>> >>> Lean . Enterprise . Middleware >>> >>> ___ >>> Carbon-dev mailing list >>> Carbon-dev@wso2.org >>> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev >>> >>> >> >> >> -- >> Kathiravelu Pradeeban. >> Software Engineer. >> WSO2 Inc. >> >> Blog: [Llovizna] http://kkpradeeban.blogspot.com/ >> >> >> ___ >> Carbon-dev mailing list >> Carbon-dev@wso2.org >> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev >> >> > > > -- > Supun Malinga, > > Software Engineer, > WSO2 Inc. > http://wso2.com > http://wso2.org > email - sup...@wso2.com > mobile
Re: [Carbon-dev] How we break the build..? :-)
13. Add a new module to dependency, orbit and commit only orbit related changes. Thanks and Regards, Harshana On Thu, Dec 8, 2011 at 4:04 PM, Prabath Siriwardena wrote: > 12. Commented out some modules from the components root pom [these > components not needed to my product] and committed it back accidentally.. > > > Thanks & regards, > -Prabath > > > On Thu, Dec 8, 2011 at 2:37 PM, Supun Malinga wrote: > >> >> >> On Thu, Dec 8, 2011 at 2:28 PM, Kathiravelu Pradeeban > > wrote: >> >>> 10. Applying a previously applied patch. >>> If we try to apply a patch that was already applied or partially >>> applied, it will revert the previous commit of the patch. (Just like >>> applying the reverse of the original patch.) >>> >> >> 11. updating the version of a component. you update only in one product >> and forget the rest :) >> >> >>> I have done that once, I recall. >>> >>> Have to take an svn up and check whether the patch is already applied >>> before applying it and committing. >>> >>> Regards, >>> Pradeeban. >>> >>> >>> On Thu, Dec 8, 2011 at 2:19 PM, Sameera Jayasoma wrote: >>> On Thu, Dec 8, 2011 at 9:53 AM, Prabath Siriwardena wrote: > 8. Built without tests and committed - my fix has broken a test case 9. Changes to orbit bundles can caues chaos, unless you build the whole thing and verify. These changes includes version changes, import/export changes, embedding of jar files. Sameera. > > Thanks & regards, > -Prabath > > > On Thu, Dec 8, 2011 at 9:49 AM, Supun Malinga wrote: > >> >> >> On Thu, Dec 8, 2011 at 9:23 AM, Supun Malinga wrote: >> my bad. wrong number! >> >> 7) most frequent case in patch-releases : when adding a new version >> of a component, we never add the relative path property. :) >> >>> 1) most frequent case in patch-releases : when adding a new version >>> of a component, we never add the relative path property. :) >>> >>> On Thu, Dec 8, 2011 at 9:12 AM, Prabath Siriwardena < >>> prab...@wso2.com> wrote: >>> Nothing serious.. just for fun.. following are few ways how we did break the build in the past.. :-) Please add whatever you remember how you or your colleague broke the build... No names please 1. Changed a public API, built the components in my product and committed 2. Added a new method to an interface - updated it's implementation in my product and committed - forgot to send mail to carbon-dev on the interface change 3. Added new class - builds fine locally - committed all the other changes - forgot to commit the new file 4. Added new a component - added a new feature - committed both - updated the root pom of features - but, forgot to update the root pom of components 5. Added a new dependency to the pom of my component - did some code changes - did an svn stat from ../src - committed all code changes - missed the pom with the new dependency Let's build this list.. :) -- Thanks & Regards, Prabath http://blog.facilelogin.com http://RampartFAQ.com ___ Carbon-dev mailing list Carbon-dev@wso2.org http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev >>> >>> >>> -- >>> Supun Malinga, >>> >>> Software Engineer, >>> WSO2 Inc. >>> http://wso2.com >>> http://wso2.org >>> email - sup...@wso2.com >>> mobile - 071 56 91 321 >>> >>> >> >> >> -- >> Supun Malinga, >> >> Software Engineer, >> WSO2 Inc. >> http://wso2.com >> http://wso2.org >> email - sup...@wso2.com >> mobile - 071 56 91 321 >> >> >> ___ >> Carbon-dev mailing list >> Carbon-dev@wso2.org >> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev >> >> > > > -- > Thanks & Regards, > Prabath > > http://blog.facilelogin.com > http://RampartFAQ.com > > ___ > Carbon-dev mailing list > Carbon-dev@wso2.org > http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev > > -- Sameera Jayasoma Technical Lead and Product Manager, WSO2 Carbon WSO2, Inc. (http://wso2.com) email: same...@wso2.com blog: http://tech.jayasoma.org Lean . Enterprise . Middleware ___ Carbon-dev mailing list Carbon-dev@wso2.org http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev >>> >>> >>> -- >>> Kathiravelu Pradeeban. >>> Softwa
Re: [Carbon-dev] How we break the build..? :-)
14. work on a component that no one knows about and break other people's products! ;) .. Cheers, Anjana, On Thu, Dec 8, 2011 at 4:16 PM, Harshana Martin wrote: > 13. Add a new module to dependency, orbit and commit only orbit related > changes. > > Thanks and Regards, > Harshana > > > On Thu, Dec 8, 2011 at 4:04 PM, Prabath Siriwardena wrote: > >> 12. Commented out some modules from the components root pom [these >> components not needed to my product] and committed it back accidentally.. >> >> >> Thanks & regards, >> -Prabath >> >> >> On Thu, Dec 8, 2011 at 2:37 PM, Supun Malinga wrote: >> >>> >>> >>> On Thu, Dec 8, 2011 at 2:28 PM, Kathiravelu Pradeeban < >>> pradee...@wso2.com> wrote: >>> 10. Applying a previously applied patch. If we try to apply a patch that was already applied or partially applied, it will revert the previous commit of the patch. (Just like applying the reverse of the original patch.) >>> >>> 11. updating the version of a component. you update only in one product >>> and forget the rest :) >>> >>> I have done that once, I recall. Have to take an svn up and check whether the patch is already applied before applying it and committing. Regards, Pradeeban. On Thu, Dec 8, 2011 at 2:19 PM, Sameera Jayasoma wrote: > > > On Thu, Dec 8, 2011 at 9:53 AM, Prabath Siriwardena > wrote: > >> 8. Built without tests and committed - my fix has broken a test case > > > 9. Changes to orbit bundles can caues chaos, unless you build the > whole thing and verify. These changes includes version changes, > import/export changes, embedding of jar files. > > Sameera. > >> >> Thanks & regards, >> -Prabath >> >> >> On Thu, Dec 8, 2011 at 9:49 AM, Supun Malinga wrote: >> >>> >>> >>> On Thu, Dec 8, 2011 at 9:23 AM, Supun Malinga wrote: >>> my bad. wrong number! >>> >>> 7) most frequent case in patch-releases : when adding a new version >>> of a component, we never add the relative path property. :) >>> 1) most frequent case in patch-releases : when adding a new version of a component, we never add the relative path property. :) On Thu, Dec 8, 2011 at 9:12 AM, Prabath Siriwardena < prab...@wso2.com> wrote: > Nothing serious.. just for fun.. following are few ways how we did > break the build in the past.. :-) Please add whatever you remember > how you > or your colleague broke the build... No names please > > 1. Changed a public API, built the components in my product and > committed > 2. Added a new method to an interface - updated it's > implementation in my product and committed - forgot to send mail to > carbon-dev on the interface change > 3. Added new class - builds fine locally - committed all the other > changes - forgot to commit the new file > 4. Added new a component - added a new feature - committed both - > updated the root pom of features - but, forgot to update the root pom > of > components > 5. Added a new dependency to the pom of my component - did some > code changes - did an svn stat from ../src - committed all code > changes - > missed the pom with the new dependency > > Let's build this list.. :) > > -- > Thanks & Regards, > Prabath > > http://blog.facilelogin.com > http://RampartFAQ.com > > ___ > Carbon-dev mailing list > Carbon-dev@wso2.org > http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev > > -- Supun Malinga, Software Engineer, WSO2 Inc. http://wso2.com http://wso2.org email - sup...@wso2.com mobile - 071 56 91 321 >>> >>> >>> -- >>> Supun Malinga, >>> >>> Software Engineer, >>> WSO2 Inc. >>> http://wso2.com >>> http://wso2.org >>> email - sup...@wso2.com >>> mobile - 071 56 91 321 >>> >>> >>> ___ >>> Carbon-dev mailing list >>> Carbon-dev@wso2.org >>> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev >>> >>> >> >> >> -- >> Thanks & Regards, >> Prabath >> >> http://blog.facilelogin.com >> http://RampartFAQ.com >> >> ___ >> Carbon-dev mailing list >> Carbon-dev@wso2.org >> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev >> >> > > > -- > Sameera Jayasoma > Technical Lead and Product Manager, WSO2 Carbon > > WSO2, Inc.
Re: [Carbon-dev] How we break the build..? :-)
14. Commits not being atomic. :) On Thu, Dec 8, 2011 at 4:16 PM, Harshana Martin wrote: > 13. Add a new module to dependency, orbit and commit only orbit related > changes. > > Thanks and Regards, > Harshana > > > On Thu, Dec 8, 2011 at 4:04 PM, Prabath Siriwardena wrote: > >> 12. Commented out some modules from the components root pom [these >> components not needed to my product] and committed it back accidentally.. >> >> >> Thanks & regards, >> -Prabath >> >> >> On Thu, Dec 8, 2011 at 2:37 PM, Supun Malinga wrote: >> >>> >>> >>> On Thu, Dec 8, 2011 at 2:28 PM, Kathiravelu Pradeeban < >>> pradee...@wso2.com> wrote: >>> 10. Applying a previously applied patch. If we try to apply a patch that was already applied or partially applied, it will revert the previous commit of the patch. (Just like applying the reverse of the original patch.) >>> >>> 11. updating the version of a component. you update only in one product >>> and forget the rest :) >>> >>> I have done that once, I recall. Have to take an svn up and check whether the patch is already applied before applying it and committing. Regards, Pradeeban. On Thu, Dec 8, 2011 at 2:19 PM, Sameera Jayasoma wrote: > > > On Thu, Dec 8, 2011 at 9:53 AM, Prabath Siriwardena > wrote: > >> 8. Built without tests and committed - my fix has broken a test case > > > 9. Changes to orbit bundles can caues chaos, unless you build the > whole thing and verify. These changes includes version changes, > import/export changes, embedding of jar files. > > Sameera. > >> >> Thanks & regards, >> -Prabath >> >> >> On Thu, Dec 8, 2011 at 9:49 AM, Supun Malinga wrote: >> >>> >>> >>> On Thu, Dec 8, 2011 at 9:23 AM, Supun Malinga wrote: >>> my bad. wrong number! >>> >>> 7) most frequent case in patch-releases : when adding a new version >>> of a component, we never add the relative path property. :) >>> 1) most frequent case in patch-releases : when adding a new version of a component, we never add the relative path property. :) On Thu, Dec 8, 2011 at 9:12 AM, Prabath Siriwardena < prab...@wso2.com> wrote: > Nothing serious.. just for fun.. following are few ways how we did > break the build in the past.. :-) Please add whatever you remember > how you > or your colleague broke the build... No names please > > 1. Changed a public API, built the components in my product and > committed > 2. Added a new method to an interface - updated it's > implementation in my product and committed - forgot to send mail to > carbon-dev on the interface change > 3. Added new class - builds fine locally - committed all the other > changes - forgot to commit the new file > 4. Added new a component - added a new feature - committed both - > updated the root pom of features - but, forgot to update the root pom > of > components > 5. Added a new dependency to the pom of my component - did some > code changes - did an svn stat from ../src - committed all code > changes - > missed the pom with the new dependency > > Let's build this list.. :) > > -- > Thanks & Regards, > Prabath > > http://blog.facilelogin.com > http://RampartFAQ.com > > ___ > Carbon-dev mailing list > Carbon-dev@wso2.org > http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev > > -- Supun Malinga, Software Engineer, WSO2 Inc. http://wso2.com http://wso2.org email - sup...@wso2.com mobile - 071 56 91 321 >>> >>> >>> -- >>> Supun Malinga, >>> >>> Software Engineer, >>> WSO2 Inc. >>> http://wso2.com >>> http://wso2.org >>> email - sup...@wso2.com >>> mobile - 071 56 91 321 >>> >>> >>> ___ >>> Carbon-dev mailing list >>> Carbon-dev@wso2.org >>> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev >>> >>> >> >> >> -- >> Thanks & Regards, >> Prabath >> >> http://blog.facilelogin.com >> http://RampartFAQ.com >> >> ___ >> Carbon-dev mailing list >> Carbon-dev@wso2.org >> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev >> >> > > > -- > Sameera Jayasoma > Technical Lead and Product Manager, WSO2 Carbon > > WSO2, Inc. (http://wso2.com) > email: same...@wso2.com > blog: http://tech.j
Re: [Carbon-dev] How we break the build..? :-)
Just got the update of the number 14. Hence, changing the number to 15. 15) Commits not being atomic. ;) On Fri, Dec 9, 2011 at 1:45 PM, Anjana Fernando wrote: > 14. work on a component that no one knows about and break other people's > products! ;) .. > > Cheers, > Anjana, > > > On Thu, Dec 8, 2011 at 4:16 PM, Harshana Martin wrote: > >> 13. Add a new module to dependency, orbit and commit only orbit related >> changes. >> >> Thanks and Regards, >> Harshana >> >> >> On Thu, Dec 8, 2011 at 4:04 PM, Prabath Siriwardena wrote: >> >>> 12. Commented out some modules from the components root pom [these >>> components not needed to my product] and committed it back accidentally.. >>> >>> >>> Thanks & regards, >>> -Prabath >>> >>> >>> On Thu, Dec 8, 2011 at 2:37 PM, Supun Malinga wrote: >>> On Thu, Dec 8, 2011 at 2:28 PM, Kathiravelu Pradeeban < pradee...@wso2.com> wrote: > 10. Applying a previously applied patch. > If we try to apply a patch that was already applied or partially > applied, it will revert the previous commit of the patch. (Just like > applying the reverse of the original patch.) > 11. updating the version of a component. you update only in one product and forget the rest :) > I have done that once, I recall. > > Have to take an svn up and check whether the patch is already applied > before applying it and committing. > > Regards, > Pradeeban. > > > On Thu, Dec 8, 2011 at 2:19 PM, Sameera Jayasoma wrote: > >> >> >> On Thu, Dec 8, 2011 at 9:53 AM, Prabath Siriwardena > > wrote: >> >>> 8. Built without tests and committed - my fix has broken a test case >> >> >> 9. Changes to orbit bundles can caues chaos, unless you build the >> whole thing and verify. These changes includes version changes, >> import/export changes, embedding of jar files. >> >> Sameera. >> >>> >>> Thanks & regards, >>> -Prabath >>> >>> >>> On Thu, Dec 8, 2011 at 9:49 AM, Supun Malinga wrote: >>> On Thu, Dec 8, 2011 at 9:23 AM, Supun Malinga wrote: my bad. wrong number! 7) most frequent case in patch-releases : when adding a new version of a component, we never add the relative path property. :) > 1) most frequent case in patch-releases : when adding a new > version of a component, we never add the relative path property. :) > > On Thu, Dec 8, 2011 at 9:12 AM, Prabath Siriwardena < > prab...@wso2.com> wrote: > >> Nothing serious.. just for fun.. following are few ways how we >> did break the build in the past.. :-) Please add whatever you >> remember how >> you or your colleague broke the build... No names please >> >> 1. Changed a public API, built the components in my product and >> committed >> 2. Added a new method to an interface - updated it's >> implementation in my product and committed - forgot to send mail to >> carbon-dev on the interface change >> 3. Added new class - builds fine locally - committed all the >> other changes - forgot to commit the new file >> 4. Added new a component - added a new feature - committed both - >> updated the root pom of features - but, forgot to update the root >> pom of >> components >> 5. Added a new dependency to the pom of my component - did some >> code changes - did an svn stat from ../src - committed all code >> changes - >> missed the pom with the new dependency >> >> Let's build this list.. :) >> >> -- >> Thanks & Regards, >> Prabath >> >> http://blog.facilelogin.com >> http://RampartFAQ.com >> >> ___ >> Carbon-dev mailing list >> Carbon-dev@wso2.org >> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev >> >> > > > -- > Supun Malinga, > > Software Engineer, > WSO2 Inc. > http://wso2.com > http://wso2.org > email - sup...@wso2.com > mobile - 071 56 91 321 > > -- Supun Malinga, Software Engineer, WSO2 Inc. http://wso2.com http://wso2.org email - sup...@wso2.com mobile - 071 56 91 321 ___ Carbon-dev mailing list Carbon-dev@wso2.org http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev >>> >>> >>> -- >>> Thanks & Regards, >>> Prabath >>> >>> http://blog.facilelogin.com >>> http
Re: [Carbon-dev] How we break the build..? :-)
On Fri, Dec 9, 2011 at 1:51 PM, Prabath Abeysekera wrote: > Just got the update of the number 14. Hence, changing the number to 15. > > 15) Commits not being atomic. ;) > 16) not specifying the osgi properties properly and exact. This will give error in p2profile-gen goals.. :) > > > > On Fri, Dec 9, 2011 at 1:45 PM, Anjana Fernando wrote: > >> 14. work on a component that no one knows about and break other people's >> products! ;) .. >> >> Cheers, >> Anjana, >> >> >> On Thu, Dec 8, 2011 at 4:16 PM, Harshana Martin wrote: >> >>> 13. Add a new module to dependency, orbit and commit only orbit related >>> changes. >>> >>> Thanks and Regards, >>> Harshana >>> >>> >>> On Thu, Dec 8, 2011 at 4:04 PM, Prabath Siriwardena wrote: >>> 12. Commented out some modules from the components root pom [these components not needed to my product] and committed it back accidentally.. Thanks & regards, -Prabath On Thu, Dec 8, 2011 at 2:37 PM, Supun Malinga wrote: > > > On Thu, Dec 8, 2011 at 2:28 PM, Kathiravelu Pradeeban < > pradee...@wso2.com> wrote: > >> 10. Applying a previously applied patch. >> If we try to apply a patch that was already applied or partially >> applied, it will revert the previous commit of the patch. (Just like >> applying the reverse of the original patch.) >> > > 11. updating the version of a component. you update only in one > product and forget the rest :) > > >> I have done that once, I recall. >> >> Have to take an svn up and check whether the patch is already applied >> before applying it and committing. >> >> Regards, >> Pradeeban. >> >> >> On Thu, Dec 8, 2011 at 2:19 PM, Sameera Jayasoma wrote: >> >>> >>> >>> On Thu, Dec 8, 2011 at 9:53 AM, Prabath Siriwardena < >>> prab...@wso2.com> wrote: >>> 8. Built without tests and committed - my fix has broken a test case >>> >>> >>> 9. Changes to orbit bundles can caues chaos, unless you build the >>> whole thing and verify. These changes includes version changes, >>> import/export changes, embedding of jar files. >>> >>> Sameera. >>> Thanks & regards, -Prabath On Thu, Dec 8, 2011 at 9:49 AM, Supun Malinga wrote: > > > On Thu, Dec 8, 2011 at 9:23 AM, Supun Malinga wrote: > my bad. wrong number! > > 7) most frequent case in patch-releases : when adding a new > version of a component, we never add the relative path property. :) > >> 1) most frequent case in patch-releases : when adding a new >> version of a component, we never add the relative path property. :) >> >> On Thu, Dec 8, 2011 at 9:12 AM, Prabath Siriwardena < >> prab...@wso2.com> wrote: >> >>> Nothing serious.. just for fun.. following are few ways how we >>> did break the build in the past.. :-) Please add whatever you >>> remember how >>> you or your colleague broke the build... No names please >>> >>> 1. Changed a public API, built the components in my product and >>> committed >>> 2. Added a new method to an interface - updated it's >>> implementation in my product and committed - forgot to send mail to >>> carbon-dev on the interface change >>> 3. Added new class - builds fine locally - committed all the >>> other changes - forgot to commit the new file >>> 4. Added new a component - added a new feature - committed both >>> - updated the root pom of features - but, forgot to update the root >>> pom of >>> components >>> 5. Added a new dependency to the pom of my component - did some >>> code changes - did an svn stat from ../src - committed all code >>> changes - >>> missed the pom with the new dependency >>> >>> Let's build this list.. :) >>> >>> -- >>> Thanks & Regards, >>> Prabath >>> >>> http://blog.facilelogin.com >>> http://RampartFAQ.com >>> >>> ___ >>> Carbon-dev mailing list >>> Carbon-dev@wso2.org >>> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev >>> >>> >> >> >> -- >> Supun Malinga, >> >> Software Engineer, >> WSO2 Inc. >> http://wso2.com >> http://wso2.org >> email - sup...@wso2.com >> mobile - 071 56 91 321 >> >> > > > -- > Supun Malinga, > > Software Engineer, > WSO2 Inc. > http://wso2.com > http://wso2.org > email - sup...@wso2.com > mobile - 071 56 91 3
Re: [Carbon-dev] How we break the build..? :-)
On Fri, Dec 9, 2011 at 1:54 PM, Supun Malinga wrote: > > > On Fri, Dec 9, 2011 at 1:51 PM, Prabath Abeysekera wrote: > >> Just got the update of the number 14. Hence, changing the number to 15. >> >> 15) Commits not being atomic. ;) >> > > 16) not specifying the osgi properties properly and exact. This will give > error in p2profile-gen goals.. :) > 17) Not properly handling externals! one eg: you get some resource externally from another component and modify it in your component and commit. original component breaks. >> >> >> On Fri, Dec 9, 2011 at 1:45 PM, Anjana Fernando wrote: >> >>> 14. work on a component that no one knows about and break other people's >>> products! ;) .. >>> >>> Cheers, >>> Anjana, >>> >>> >>> On Thu, Dec 8, 2011 at 4:16 PM, Harshana Martin wrote: >>> 13. Add a new module to dependency, orbit and commit only orbit related changes. Thanks and Regards, Harshana On Thu, Dec 8, 2011 at 4:04 PM, Prabath Siriwardena wrote: > 12. Commented out some modules from the components root pom [these > components not needed to my product] and committed it back accidentally.. > > > Thanks & regards, > -Prabath > > > On Thu, Dec 8, 2011 at 2:37 PM, Supun Malinga wrote: > >> >> >> On Thu, Dec 8, 2011 at 2:28 PM, Kathiravelu Pradeeban < >> pradee...@wso2.com> wrote: >> >>> 10. Applying a previously applied patch. >>> If we try to apply a patch that was already applied or partially >>> applied, it will revert the previous commit of the patch. (Just like >>> applying the reverse of the original patch.) >>> >> >> 11. updating the version of a component. you update only in one >> product and forget the rest :) >> >> >>> I have done that once, I recall. >>> >>> Have to take an svn up and check whether the patch is already >>> applied before applying it and committing. >>> >>> Regards, >>> Pradeeban. >>> >>> >>> On Thu, Dec 8, 2011 at 2:19 PM, Sameera Jayasoma >>> wrote: >>> On Thu, Dec 8, 2011 at 9:53 AM, Prabath Siriwardena < prab...@wso2.com> wrote: > 8. Built without tests and committed - my fix has broken a test > case 9. Changes to orbit bundles can caues chaos, unless you build the whole thing and verify. These changes includes version changes, import/export changes, embedding of jar files. Sameera. > > Thanks & regards, > -Prabath > > > On Thu, Dec 8, 2011 at 9:49 AM, Supun Malinga wrote: > >> >> >> On Thu, Dec 8, 2011 at 9:23 AM, Supun Malinga wrote: >> my bad. wrong number! >> >> 7) most frequent case in patch-releases : when adding a new >> version of a component, we never add the relative path property. :) >> >>> 1) most frequent case in patch-releases : when adding a new >>> version of a component, we never add the relative path property. :) >>> >>> On Thu, Dec 8, 2011 at 9:12 AM, Prabath Siriwardena < >>> prab...@wso2.com> wrote: >>> Nothing serious.. just for fun.. following are few ways how we did break the build in the past.. :-) Please add whatever you remember how you or your colleague broke the build... No names please 1. Changed a public API, built the components in my product and committed 2. Added a new method to an interface - updated it's implementation in my product and committed - forgot to send mail to carbon-dev on the interface change 3. Added new class - builds fine locally - committed all the other changes - forgot to commit the new file 4. Added new a component - added a new feature - committed both - updated the root pom of features - but, forgot to update the root pom of components 5. Added a new dependency to the pom of my component - did some code changes - did an svn stat from ../src - committed all code changes - missed the pom with the new dependency Let's build this list.. :) -- Thanks & Regards, Prabath http://blog.facilelogin.com http://RampartFAQ.com ___ Carbon-dev mailing list Carbon-dev@wso2.org http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev >>> >>> >>> -- >>> Supun Malinga, >>> >>> Software Engin
Re: [Carbon-dev] How we break the build..? :-)
Hi all, Do we have this list on a wiki page or a document or something similar so that we can refer to it and ensure everyone is aware of what should not be done. Thanks, Senaka. On Sun, Dec 11, 2011 at 10:19 AM, Supun Malinga wrote: > > > On Fri, Dec 9, 2011 at 1:54 PM, Supun Malinga wrote: > >> >> >> On Fri, Dec 9, 2011 at 1:51 PM, Prabath Abeysekera wrote: >> >>> Just got the update of the number 14. Hence, changing the number to 15. >>> >>> 15) Commits not being atomic. ;) >>> >> >> 16) not specifying the osgi properties properly and exact. This will give >> error in p2profile-gen goals.. :) >> > > 17) Not properly handling externals! > one eg: you get some resource externally from another component and > modify it in your component and commit. original component breaks. > > >>> >>> >>> On Fri, Dec 9, 2011 at 1:45 PM, Anjana Fernando wrote: >>> 14. work on a component that no one knows about and break other people's products! ;) .. Cheers, Anjana, On Thu, Dec 8, 2011 at 4:16 PM, Harshana Martin wrote: > 13. Add a new module to dependency, orbit and commit only orbit > related changes. > > Thanks and Regards, > Harshana > > > On Thu, Dec 8, 2011 at 4:04 PM, Prabath Siriwardena > wrote: > >> 12. Commented out some modules from the components root pom [these >> components not needed to my product] and committed it back accidentally.. >> >> >> Thanks & regards, >> -Prabath >> >> >> On Thu, Dec 8, 2011 at 2:37 PM, Supun Malinga wrote: >> >>> >>> >>> On Thu, Dec 8, 2011 at 2:28 PM, Kathiravelu Pradeeban < >>> pradee...@wso2.com> wrote: >>> 10. Applying a previously applied patch. If we try to apply a patch that was already applied or partially applied, it will revert the previous commit of the patch. (Just like applying the reverse of the original patch.) >>> >>> 11. updating the version of a component. you update only in one >>> product and forget the rest :) >>> >>> I have done that once, I recall. Have to take an svn up and check whether the patch is already applied before applying it and committing. Regards, Pradeeban. On Thu, Dec 8, 2011 at 2:19 PM, Sameera Jayasoma wrote: > > > On Thu, Dec 8, 2011 at 9:53 AM, Prabath Siriwardena < > prab...@wso2.com> wrote: > >> 8. Built without tests and committed - my fix has broken a test >> case > > > 9. Changes to orbit bundles can caues chaos, unless you build the > whole thing and verify. These changes includes version changes, > import/export changes, embedding of jar files. > > Sameera. > >> >> Thanks & regards, >> -Prabath >> >> >> On Thu, Dec 8, 2011 at 9:49 AM, Supun Malinga wrote: >> >>> >>> >>> On Thu, Dec 8, 2011 at 9:23 AM, Supun Malinga >>> wrote: >>> my bad. wrong number! >>> >>> 7) most frequent case in patch-releases : when adding a new >>> version of a component, we never add the relative path property. :) >>> 1) most frequent case in patch-releases : when adding a new version of a component, we never add the relative path property. :) On Thu, Dec 8, 2011 at 9:12 AM, Prabath Siriwardena < prab...@wso2.com> wrote: > Nothing serious.. just for fun.. following are few ways how we > did break the build in the past.. :-) Please add whatever you > remember how > you or your colleague broke the build... No names please > > 1. Changed a public API, built the components in my product > and committed > 2. Added a new method to an interface - updated it's > implementation in my product and committed - forgot to send mail > to > carbon-dev on the interface change > 3. Added new class - builds fine locally - committed all the > other changes - forgot to commit the new file > 4. Added new a component - added a new feature - committed > both - updated the root pom of features - but, forgot to update > the root > pom of components > 5. Added a new dependency to the pom of my component - did > some code changes - did an svn stat from ../src - committed all > code > changes - missed the pom with the new dependency > > Let's build this list.. :) > > -- > Thanks & Regards, > Prabath > >>>
Re: [Carbon-dev] How we break the build..? :-)
+1 we should --Srinath On Tue, Dec 13, 2011 at 12:14 PM, Senaka Fernando wrote: > Hi all, > > Do we have this list on a wiki page or a document or something similar so > that we can refer to it and ensure everyone is aware of what should not be > done. > > Thanks, > Senaka. > > > On Sun, Dec 11, 2011 at 10:19 AM, Supun Malinga wrote: >> >> >> >> On Fri, Dec 9, 2011 at 1:54 PM, Supun Malinga wrote: >>> >>> >>> >>> On Fri, Dec 9, 2011 at 1:51 PM, Prabath Abeysekera >>> wrote: Just got the update of the number 14. Hence, changing the number to 15. 15) Commits not being atomic. ;) >>> >>> >>> 16) not specifying the osgi properties properly and exact. This will give >>> error in p2profile-gen goals.. :) >> >> >> 17) Not properly handling externals! >> one eg: you get some resource externally from another component and >> modify it in your component and commit. original component breaks. >> On Fri, Dec 9, 2011 at 1:45 PM, Anjana Fernando wrote: > > 14. work on a component that no one knows about and break other > people's products! ;) .. > > Cheers, > Anjana, > > > On Thu, Dec 8, 2011 at 4:16 PM, Harshana Martin > wrote: >> >> 13. Add a new module to dependency, orbit and commit only orbit >> related changes. >> >> Thanks and Regards, >> Harshana >> >> >> On Thu, Dec 8, 2011 at 4:04 PM, Prabath Siriwardena >> wrote: >>> >>> 12. Commented out some modules from the components root pom [these >>> components not needed to my product] and committed it >>> back accidentally.. >>> >>> >>> Thanks & regards, >>> -Prabath >>> >>> >>> On Thu, Dec 8, 2011 at 2:37 PM, Supun Malinga >>> wrote: On Thu, Dec 8, 2011 at 2:28 PM, Kathiravelu Pradeeban wrote: > > 10. Applying a previously applied patch. > If we try to apply a patch that was already applied or partially > applied, it will revert the previous commit of the patch. (Just like > applying the reverse of the original patch.) 11. updating the version of a component. you update only in one product and forget the rest :) > > I have done that once, I recall. > > Have to take an svn up and check whether the patch is already > applied before applying it and committing. > > Regards, > Pradeeban. > > > On Thu, Dec 8, 2011 at 2:19 PM, Sameera Jayasoma > wrote: >> >> >> >> On Thu, Dec 8, 2011 at 9:53 AM, Prabath Siriwardena >> wrote: >>> >>> 8. Built without tests and committed - my fix has broken a test >>> case >> >> >> 9. Changes to orbit bundles can caues chaos, unless you build the >> whole thing and verify. These changes includes version changes, >> import/export changes, embedding of jar files. >> >> Sameera. >>> >>> >>> Thanks & regards, >>> -Prabath >>> >>> >>> On Thu, Dec 8, 2011 at 9:49 AM, Supun Malinga >>> wrote: On Thu, Dec 8, 2011 at 9:23 AM, Supun Malinga wrote: my bad. wrong number! 7) most frequent case in patch-releases : when adding a new version of a component, we never add the relative path property. :) > > 1) most frequent case in patch-releases : when adding a new > version of a component, we never add the relative path property. > :) > > On Thu, Dec 8, 2011 at 9:12 AM, Prabath Siriwardena > wrote: >> >> Nothing serious.. just for fun.. following are few ways how we >> did break the build in the past.. :-) Please add whatever you >> remember how >> you or your colleague broke the build... No names please >> >> 1. Changed a public API, built the components in my product >> and committed >> 2. Added a new method to an interface - updated it's >> implementation in my product and committed - forgot to send mail >> to >> carbon-dev on the interface change >> 3. Added new class - builds fine locally - committed all the >> other changes - forgot to commit the new file >> 4. Added new a component - added a new feature - committed >> both - updated the root pom of features - but, forgot to update >> the root pom >> of components >> 5. Added a new dependency to the pom of my component - did >> some code changes - did an svn stat from ../src - c
Re: [Carbon-dev] How we break the build..? :-)
18. Commit without building... Thanks & regards, -Prabath On Sun, Dec 11, 2011 at 10:19 AM, Supun Malinga wrote: > > > On Fri, Dec 9, 2011 at 1:54 PM, Supun Malinga wrote: > >> >> >> On Fri, Dec 9, 2011 at 1:51 PM, Prabath Abeysekera wrote: >> >>> Just got the update of the number 14. Hence, changing the number to 15. >>> >>> 15) Commits not being atomic. ;) >>> >> >> 16) not specifying the osgi properties properly and exact. This will give >> error in p2profile-gen goals.. :) >> > > 17) Not properly handling externals! > one eg: you get some resource externally from another component and > modify it in your component and commit. original component breaks. > > >>> >>> >>> On Fri, Dec 9, 2011 at 1:45 PM, Anjana Fernando wrote: >>> 14. work on a component that no one knows about and break other people's products! ;) .. Cheers, Anjana, On Thu, Dec 8, 2011 at 4:16 PM, Harshana Martin wrote: > 13. Add a new module to dependency, orbit and commit only orbit > related changes. > > Thanks and Regards, > Harshana > > > On Thu, Dec 8, 2011 at 4:04 PM, Prabath Siriwardena > wrote: > >> 12. Commented out some modules from the components root pom [these >> components not needed to my product] and committed it back accidentally.. >> >> >> Thanks & regards, >> -Prabath >> >> >> On Thu, Dec 8, 2011 at 2:37 PM, Supun Malinga wrote: >> >>> >>> >>> On Thu, Dec 8, 2011 at 2:28 PM, Kathiravelu Pradeeban < >>> pradee...@wso2.com> wrote: >>> 10. Applying a previously applied patch. If we try to apply a patch that was already applied or partially applied, it will revert the previous commit of the patch. (Just like applying the reverse of the original patch.) >>> >>> 11. updating the version of a component. you update only in one >>> product and forget the rest :) >>> >>> I have done that once, I recall. Have to take an svn up and check whether the patch is already applied before applying it and committing. Regards, Pradeeban. On Thu, Dec 8, 2011 at 2:19 PM, Sameera Jayasoma wrote: > > > On Thu, Dec 8, 2011 at 9:53 AM, Prabath Siriwardena < > prab...@wso2.com> wrote: > >> 8. Built without tests and committed - my fix has broken a test >> case > > > 9. Changes to orbit bundles can caues chaos, unless you build the > whole thing and verify. These changes includes version changes, > import/export changes, embedding of jar files. > > Sameera. > >> >> Thanks & regards, >> -Prabath >> >> >> On Thu, Dec 8, 2011 at 9:49 AM, Supun Malinga wrote: >> >>> >>> >>> On Thu, Dec 8, 2011 at 9:23 AM, Supun Malinga >>> wrote: >>> my bad. wrong number! >>> >>> 7) most frequent case in patch-releases : when adding a new >>> version of a component, we never add the relative path property. :) >>> 1) most frequent case in patch-releases : when adding a new version of a component, we never add the relative path property. :) On Thu, Dec 8, 2011 at 9:12 AM, Prabath Siriwardena < prab...@wso2.com> wrote: > Nothing serious.. just for fun.. following are few ways how we > did break the build in the past.. :-) Please add whatever you > remember how > you or your colleague broke the build... No names please > > 1. Changed a public API, built the components in my product > and committed > 2. Added a new method to an interface - updated it's > implementation in my product and committed - forgot to send mail > to > carbon-dev on the interface change > 3. Added new class - builds fine locally - committed all the > other changes - forgot to commit the new file > 4. Added new a component - added a new feature - committed > both - updated the root pom of features - but, forgot to update > the root > pom of components > 5. Added a new dependency to the pom of my component - did > some code changes - did an svn stat from ../src - committed all > code > changes - missed the pom with the new dependency > > Let's build this list.. :) > > -- > Thanks & Regards, > Prabath > > http://blog.facilelogin.com > http://RampartFAQ.com > > ___
