[PATCH] D50543: [libcxx] Mark charconv tests as failing for previous libcxx versions.
vsapsai added a comment. Thanks for the review. Repository: rL LLVM https://reviews.llvm.org/D50543 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D50543: [libcxx] Mark charconv tests as failing for previous libcxx versions.
This revision was automatically updated to reflect the committed changes. Closed by commit rL339451: [libcxx] Mark charconv tests as failing for previous libcxx versions. (authored by vsapsai, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D50543?vs=160041&id=160132#toc Repository: rL LLVM https://reviews.llvm.org/D50543 Files: libcxx/trunk/test/std/utilities/charconv/charconv.from.chars/integral.pass.cpp libcxx/trunk/test/std/utilities/charconv/charconv.to.chars/integral.pass.cpp Index: libcxx/trunk/test/std/utilities/charconv/charconv.from.chars/integral.pass.cpp === --- libcxx/trunk/test/std/utilities/charconv/charconv.from.chars/integral.pass.cpp +++ libcxx/trunk/test/std/utilities/charconv/charconv.from.chars/integral.pass.cpp @@ -8,6 +8,15 @@ //===--===// // UNSUPPORTED: c++98, c++03, c++11 + +// XFAIL: with_system_cxx_lib=macosx10.13 +// XFAIL: with_system_cxx_lib=macosx10.12 +// XFAIL: with_system_cxx_lib=macosx10.11 +// XFAIL: with_system_cxx_lib=macosx10.10 +// XFAIL: with_system_cxx_lib=macosx10.9 +// XFAIL: with_system_cxx_lib=macosx10.8 +// XFAIL: with_system_cxx_lib=macosx10.7 + // // from_chars_result from_chars(const char* first, const char* last, Index: libcxx/trunk/test/std/utilities/charconv/charconv.to.chars/integral.pass.cpp === --- libcxx/trunk/test/std/utilities/charconv/charconv.to.chars/integral.pass.cpp +++ libcxx/trunk/test/std/utilities/charconv/charconv.to.chars/integral.pass.cpp @@ -8,6 +8,15 @@ //===--===// // UNSUPPORTED: c++98, c++03, c++11 + +// XFAIL: with_system_cxx_lib=macosx10.13 +// XFAIL: with_system_cxx_lib=macosx10.12 +// XFAIL: with_system_cxx_lib=macosx10.11 +// XFAIL: with_system_cxx_lib=macosx10.10 +// XFAIL: with_system_cxx_lib=macosx10.9 +// XFAIL: with_system_cxx_lib=macosx10.8 +// XFAIL: with_system_cxx_lib=macosx10.7 + // // to_chars_result to_chars(char* first, char* last, Integral value, Index: libcxx/trunk/test/std/utilities/charconv/charconv.from.chars/integral.pass.cpp === --- libcxx/trunk/test/std/utilities/charconv/charconv.from.chars/integral.pass.cpp +++ libcxx/trunk/test/std/utilities/charconv/charconv.from.chars/integral.pass.cpp @@ -8,6 +8,15 @@ //===--===// // UNSUPPORTED: c++98, c++03, c++11 + +// XFAIL: with_system_cxx_lib=macosx10.13 +// XFAIL: with_system_cxx_lib=macosx10.12 +// XFAIL: with_system_cxx_lib=macosx10.11 +// XFAIL: with_system_cxx_lib=macosx10.10 +// XFAIL: with_system_cxx_lib=macosx10.9 +// XFAIL: with_system_cxx_lib=macosx10.8 +// XFAIL: with_system_cxx_lib=macosx10.7 + // // from_chars_result from_chars(const char* first, const char* last, Index: libcxx/trunk/test/std/utilities/charconv/charconv.to.chars/integral.pass.cpp === --- libcxx/trunk/test/std/utilities/charconv/charconv.to.chars/integral.pass.cpp +++ libcxx/trunk/test/std/utilities/charconv/charconv.to.chars/integral.pass.cpp @@ -8,6 +8,15 @@ //===--===// // UNSUPPORTED: c++98, c++03, c++11 + +// XFAIL: with_system_cxx_lib=macosx10.13 +// XFAIL: with_system_cxx_lib=macosx10.12 +// XFAIL: with_system_cxx_lib=macosx10.11 +// XFAIL: with_system_cxx_lib=macosx10.10 +// XFAIL: with_system_cxx_lib=macosx10.9 +// XFAIL: with_system_cxx_lib=macosx10.8 +// XFAIL: with_system_cxx_lib=macosx10.7 + // // to_chars_result to_chars(char* first, char* last, Integral value, ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D50543: [libcxx] Mark charconv tests as failing for previous libcxx versions.
ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. Ship it! https://reviews.llvm.org/D50543 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D50543: [libcxx] Mark charconv tests as failing for previous libcxx versions.
lichray added a comment. LGTM. @ldionne 's job to confirm. https://reviews.llvm.org/D50543 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D50543: [libcxx] Mark charconv tests as failing for previous libcxx versions.
vsapsai created this revision. vsapsai added reviewers: mclow.lists, ldionne. Herald added a reviewer: EricWF. Herald added subscribers: dexonsmith, christof. was added in r338479. Previous libcxx versions don't have this functionality and corresponding tests should be failing. https://reviews.llvm.org/D50543 Files: libcxx/test/std/utilities/charconv/charconv.from.chars/integral.pass.cpp libcxx/test/std/utilities/charconv/charconv.to.chars/integral.pass.cpp Index: libcxx/test/std/utilities/charconv/charconv.to.chars/integral.pass.cpp === --- libcxx/test/std/utilities/charconv/charconv.to.chars/integral.pass.cpp +++ libcxx/test/std/utilities/charconv/charconv.to.chars/integral.pass.cpp @@ -8,6 +8,15 @@ //===--===// // UNSUPPORTED: c++98, c++03, c++11 + +// XFAIL: with_system_cxx_lib=macosx10.13 +// XFAIL: with_system_cxx_lib=macosx10.12 +// XFAIL: with_system_cxx_lib=macosx10.11 +// XFAIL: with_system_cxx_lib=macosx10.10 +// XFAIL: with_system_cxx_lib=macosx10.9 +// XFAIL: with_system_cxx_lib=macosx10.8 +// XFAIL: with_system_cxx_lib=macosx10.7 + // // to_chars_result to_chars(char* first, char* last, Integral value, Index: libcxx/test/std/utilities/charconv/charconv.from.chars/integral.pass.cpp === --- libcxx/test/std/utilities/charconv/charconv.from.chars/integral.pass.cpp +++ libcxx/test/std/utilities/charconv/charconv.from.chars/integral.pass.cpp @@ -8,6 +8,15 @@ //===--===// // UNSUPPORTED: c++98, c++03, c++11 + +// XFAIL: with_system_cxx_lib=macosx10.13 +// XFAIL: with_system_cxx_lib=macosx10.12 +// XFAIL: with_system_cxx_lib=macosx10.11 +// XFAIL: with_system_cxx_lib=macosx10.10 +// XFAIL: with_system_cxx_lib=macosx10.9 +// XFAIL: with_system_cxx_lib=macosx10.8 +// XFAIL: with_system_cxx_lib=macosx10.7 + // // from_chars_result from_chars(const char* first, const char* last, Index: libcxx/test/std/utilities/charconv/charconv.to.chars/integral.pass.cpp === --- libcxx/test/std/utilities/charconv/charconv.to.chars/integral.pass.cpp +++ libcxx/test/std/utilities/charconv/charconv.to.chars/integral.pass.cpp @@ -8,6 +8,15 @@ //===--===// // UNSUPPORTED: c++98, c++03, c++11 + +// XFAIL: with_system_cxx_lib=macosx10.13 +// XFAIL: with_system_cxx_lib=macosx10.12 +// XFAIL: with_system_cxx_lib=macosx10.11 +// XFAIL: with_system_cxx_lib=macosx10.10 +// XFAIL: with_system_cxx_lib=macosx10.9 +// XFAIL: with_system_cxx_lib=macosx10.8 +// XFAIL: with_system_cxx_lib=macosx10.7 + // // to_chars_result to_chars(char* first, char* last, Integral value, Index: libcxx/test/std/utilities/charconv/charconv.from.chars/integral.pass.cpp === --- libcxx/test/std/utilities/charconv/charconv.from.chars/integral.pass.cpp +++ libcxx/test/std/utilities/charconv/charconv.from.chars/integral.pass.cpp @@ -8,6 +8,15 @@ //===--===// // UNSUPPORTED: c++98, c++03, c++11 + +// XFAIL: with_system_cxx_lib=macosx10.13 +// XFAIL: with_system_cxx_lib=macosx10.12 +// XFAIL: with_system_cxx_lib=macosx10.11 +// XFAIL: with_system_cxx_lib=macosx10.10 +// XFAIL: with_system_cxx_lib=macosx10.9 +// XFAIL: with_system_cxx_lib=macosx10.8 +// XFAIL: with_system_cxx_lib=macosx10.7 + // // from_chars_result from_chars(const char* first, const char* last, ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits