[clang] Update Clang.cpp (PR #77882)
https://github.com/hw-1 created https://github.com/llvm/llvm-project/pull/77882 fix error: .gch' was ignored because it is not a clang PCH file https://github.com/llvm/llvm-project/issues/76923 >From d3735b032f8d482b8f362e827f412a26d9121c1d Mon Sep 17 00:00:00 2001 From: hw-1 <8053554+h...@users.noreply.github.com> Date: Fri, 12 Jan 2024 15:19:49 +0800 Subject: [PATCH] Update Clang.cpp fix error: .gch' was ignored because it is not a clang PCH file https://github.com/llvm/llvm-project/issues/76923 --- clang/lib/Driver/ToolChains/Clang.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/clang/lib/Driver/ToolChains/Clang.cpp b/clang/lib/Driver/ToolChains/Clang.cpp index 1ee7ae602f3ce5..2c35b9b84ac959 100644 --- a/clang/lib/Driver/ToolChains/Clang.cpp +++ b/clang/lib/Driver/ToolChains/Clang.cpp @@ -951,7 +951,7 @@ static void handleAMDGPUCodeObjectVersionOptions(const Driver &D, static bool hasClangPchSignature(const Driver &D, StringRef Path) { if (llvm::ErrorOr> MemBuf = D.getVFS().getBufferForFile(Path)) -return (*MemBuf)->getBuffer().starts_with("CPCH"); +return (*MemBuf)->getBuffer().contains("CPCH"); return false; } ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] Update Clang.cpp (PR #77882)
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using `@` followed by their GitHub username. If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers. If you have further questions, they may be answered by the [LLVM GitHub User Guide](https://llvm.org/docs/GitHub.html). You can also ask questions in a comment on this PR, on the [LLVM Discord](https://discord.com/invite/xS7Z362) or on the [forums](https://discourse.llvm.org/). https://github.com/llvm/llvm-project/pull/77882 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] Update Clang.cpp (PR #77882)
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-driver Author: hw-1 (hw-1) Changes fix error: .gch' was ignored because it is not a clang PCH file https://github.com/llvm/llvm-project/issues/76923 --- Full diff: https://github.com/llvm/llvm-project/pull/77882.diff 1 Files Affected: - (modified) clang/lib/Driver/ToolChains/Clang.cpp (+1-1) ``diff diff --git a/clang/lib/Driver/ToolChains/Clang.cpp b/clang/lib/Driver/ToolChains/Clang.cpp index 1ee7ae602f3ce5..2c35b9b84ac959 100644 --- a/clang/lib/Driver/ToolChains/Clang.cpp +++ b/clang/lib/Driver/ToolChains/Clang.cpp @@ -951,7 +951,7 @@ static void handleAMDGPUCodeObjectVersionOptions(const Driver &D, static bool hasClangPchSignature(const Driver &D, StringRef Path) { if (llvm::ErrorOr> MemBuf = D.getVFS().getBufferForFile(Path)) -return (*MemBuf)->getBuffer().starts_with("CPCH"); +return (*MemBuf)->getBuffer().contains("CPCH"); return false; } `` https://github.com/llvm/llvm-project/pull/77882 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] Update Clang.cpp (PR #77882)
https://github.com/MaskRay closed https://github.com/llvm/llvm-project/pull/77882 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang] Update Clang.cpp (PR #77882)
MaskRay wrote: The code has been removed by #77711 https://github.com/llvm/llvm-project/pull/77882 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits