[clang] [clang]MveEmitter: Pass Args as a const reference (PR #89551)

2024-04-22 Thread Simon Pilgrim via cfe-commits 

https://github.com/RKSimon closed 
https://github.com/llvm/llvm-project/pull/89551
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang]MveEmitter: Pass Args as a const reference (PR #89551)

2024-04-22 Thread Simon Pilgrim via cfe-commits 

https://github.com/RKSimon approved this pull request.

LGTM

https://github.com/llvm/llvm-project/pull/89551
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang]MveEmitter: Pass Args as a const reference (PR #89551)

2024-04-22 Thread via cfe-commits 

llvmbot wrote:




@llvm/pr-subscribers-clang

Author: aniplcc (aniplcc)


Changes

Closes #89192.
Also updated with review patches.
In continuation of: `https://github.com/llvm/llvm-project/pull/89202` [Closed 
due to a bad rebase]



---
Full diff: https://github.com/llvm/llvm-project/pull/89551.diff


1 Files Affected:

- (modified) clang/utils/TableGen/MveEmitter.cpp (+6-5) 


``diff
diff --git a/clang/utils/TableGen/MveEmitter.cpp 
b/clang/utils/TableGen/MveEmitter.cpp
index 88e7b6e8546595..c455071ed9da7c 100644
--- a/clang/utils/TableGen/MveEmitter.cpp
+++ b/clang/utils/TableGen/MveEmitter.cpp
@@ -658,9 +658,9 @@ class IRBuilderResult : public Result {
   std::vector Args;
   std::set AddressArgs;
   std::map IntegerArgs;
-  IRBuilderResult(StringRef CallPrefix, std::vector Args,
-  std::set AddressArgs,
-  std::map IntegerArgs)
+  IRBuilderResult(StringRef CallPrefix, const std::vector &Args,
+  const std::set &AddressArgs,
+  const std::map &IntegerArgs)
   : CallPrefix(CallPrefix), Args(Args), AddressArgs(AddressArgs),
 IntegerArgs(IntegerArgs) {}
   void genCode(raw_ostream &OS,
@@ -727,8 +727,9 @@ class IRIntrinsicResult : public Result {
   std::string IntrinsicID;
   std::vector ParamTypes;
   std::vector Args;
-  IRIntrinsicResult(StringRef IntrinsicID, std::vector 
ParamTypes,
-std::vector Args)
+  IRIntrinsicResult(StringRef IntrinsicID,
+const std::vector &ParamTypes,
+const std::vector &Args)
   : IntrinsicID(std::string(IntrinsicID)), ParamTypes(ParamTypes),
 Args(Args) {}
   void genCode(raw_ostream &OS,

``




https://github.com/llvm/llvm-project/pull/89551
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang]MveEmitter: Pass Args as a const reference (PR #89551)

2024-04-22 Thread via cfe-commits 

https://github.com/aniplcc ready_for_review 
https://github.com/llvm/llvm-project/pull/89551
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang]MveEmitter: Pass Args as a const reference (PR #89551)

2024-04-21 Thread via cfe-commits 

https://github.com/aniplcc created 
https://github.com/llvm/llvm-project/pull/89551

Closes #89192.
Also updated with review patches.
In continuation of: `https://github.com/llvm/llvm-project/pull/89202` [Closed 
due to a bad rebase]



>From 21ef2c83063a16866edec3eaa1847db7b34592c4 Mon Sep 17 00:00:00 2001
From: aniplcc 
Date: Sun, 21 Apr 2024 23:01:20 +0530
Subject: [PATCH 1/2] [clang]MveEmitter: Pass Args as a const reference

---
 clang/utils/TableGen/MveEmitter.cpp | 10 +-
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/clang/utils/TableGen/MveEmitter.cpp 
b/clang/utils/TableGen/MveEmitter.cpp
index 88e7b6e8546595..5f6546a6498c3c 100644
--- a/clang/utils/TableGen/MveEmitter.cpp
+++ b/clang/utils/TableGen/MveEmitter.cpp
@@ -658,9 +658,9 @@ class IRBuilderResult : public Result {
   std::vector Args;
   std::set AddressArgs;
   std::map IntegerArgs;
-  IRBuilderResult(StringRef CallPrefix, std::vector Args,
-  std::set AddressArgs,
-  std::map IntegerArgs)
+  IRBuilderResult(StringRef CallPrefix, const std::vector &Args,
+  const std::set &AddressArgs,
+  const std::map &IntegerArgs)
   : CallPrefix(CallPrefix), Args(Args), AddressArgs(AddressArgs),
 IntegerArgs(IntegerArgs) {}
   void genCode(raw_ostream &OS,
@@ -727,8 +727,8 @@ class IRIntrinsicResult : public Result {
   std::string IntrinsicID;
   std::vector ParamTypes;
   std::vector Args;
-  IRIntrinsicResult(StringRef IntrinsicID, std::vector 
ParamTypes,
-std::vector Args)
+  IRIntrinsicResult(StringRef IntrinsicID, const std::vector 
&ParamTypes,
+const std::vector &Args)
   : IntrinsicID(std::string(IntrinsicID)), ParamTypes(ParamTypes),
 Args(Args) {}
   void genCode(raw_ostream &OS,

>From d0bfc710b9fa90d71f544451432577620b4cf610 Mon Sep 17 00:00:00 2001
From: aniplcc 
Date: Sun, 21 Apr 2024 23:13:50 +0530
Subject: [PATCH 2/2] format fixes

---
 clang/utils/TableGen/MveEmitter.cpp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/clang/utils/TableGen/MveEmitter.cpp 
b/clang/utils/TableGen/MveEmitter.cpp
index 5f6546a6498c3c..c455071ed9da7c 100644
--- a/clang/utils/TableGen/MveEmitter.cpp
+++ b/clang/utils/TableGen/MveEmitter.cpp
@@ -727,7 +727,8 @@ class IRIntrinsicResult : public Result {
   std::string IntrinsicID;
   std::vector ParamTypes;
   std::vector Args;
-  IRIntrinsicResult(StringRef IntrinsicID, const std::vector 
&ParamTypes,
+  IRIntrinsicResult(StringRef IntrinsicID,
+const std::vector &ParamTypes,
 const std::vector &Args)
   : IntrinsicID(std::string(IntrinsicID)), ParamTypes(ParamTypes),
 Args(Args) {}

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits