[chromium-dev] Re: compile error on Snow Leopard
Nico Weber wrote: > Is SL a supported platform for building? Certainly. > If so, should we have an SL buildbot? Yes, but Tom and I have other priorities right now. We should have 10.6 bots running next month. Mark --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: compile error on Snow Leopard
Done. Is SL a supported platform for building? If so, should we have an SL buildbot? On Sat, Oct 24, 2009 at 11:39 AM, Nico Weber wrote: > Sorry 'bout that. FIxing. > > On Sat, Oct 24, 2009 at 11:33 AM, Mark Mentovai wrote: >> thakis r29990 (http://codereview.chromium.org/336001) >> >> -[NSString stringWithCString:] is deprecated as of Mac OS X 10.4. The >> replacement is -[NSString stringWithCString:encoding:]. >> >> We also have base::SysUTF8ToNSString from base/sys_string_conversions.h. >> >> Mark >> >> Paweł Hajdan Jr. wrote: >>> I get this when compiling unit_tests on Mac OS X 10.6 Snow Leopard: >>> /Users/ph/chromium/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm:689:0 >>> /Users/ph/chromium/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm:689: >>> warning: 'stringWithCString:' is deprecated (declared at >>> /Developer/SDKs/MacOSX10.5.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSString.h:364) >>> And warnings are treated as errors so it breaks the build. Mac OS X build is >>> healthy on the buildbot, so it's either something on my machine, or the GCC >>> in Snow Leopard has more warnings. Is there some easy workaround? I don't >>> know what's the correct fix for this. >> > --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: compile error on Snow Leopard
Sorry 'bout that. FIxing. On Sat, Oct 24, 2009 at 11:33 AM, Mark Mentovai wrote: > thakis r29990 (http://codereview.chromium.org/336001) > > -[NSString stringWithCString:] is deprecated as of Mac OS X 10.4. The > replacement is -[NSString stringWithCString:encoding:]. > > We also have base::SysUTF8ToNSString from base/sys_string_conversions.h. > > Mark > > Paweł Hajdan Jr. wrote: >> I get this when compiling unit_tests on Mac OS X 10.6 Snow Leopard: >> /Users/ph/chromium/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm:689:0 >> /Users/ph/chromium/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm:689: >> warning: 'stringWithCString:' is deprecated (declared at >> /Developer/SDKs/MacOSX10.5.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSString.h:364) >> And warnings are treated as errors so it breaks the build. Mac OS X build is >> healthy on the buildbot, so it's either something on my machine, or the GCC >> in Snow Leopard has more warnings. Is there some easy workaround? I don't >> know what's the correct fix for this. > --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: compile error on Snow Leopard
thakis r29990 (http://codereview.chromium.org/336001) -[NSString stringWithCString:] is deprecated as of Mac OS X 10.4. The replacement is -[NSString stringWithCString:encoding:]. We also have base::SysUTF8ToNSString from base/sys_string_conversions.h. Mark Paweł Hajdan Jr. wrote: > I get this when compiling unit_tests on Mac OS X 10.6 Snow Leopard: > /Users/ph/chromium/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm:689:0 > /Users/ph/chromium/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm:689: > warning: 'stringWithCString:' is deprecated (declared at > /Developer/SDKs/MacOSX10.5.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSString.h:364) > And warnings are treated as errors so it breaks the build. Mac OS X build is > healthy on the buildbot, so it's either something on my machine, or the GCC > in Snow Leopard has more warnings. Is there some easy workaround? I don't > know what's the correct fix for this. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---