Re: [cp-patches] Patch: remove bogus ServerSocket security check
Hi Anthony, On Mon, 2005-12-26 at 19:05 -0800, Anthony Green wrote: This patch removes a bogus security check from ServerSocket.accept(), and replaces it with a request to implement a proper check. Once applied I will file a bug report for our records. 2005-12-26 Anthony Green [EMAIL PROTECTED] * java/net/ServerSocket.java (accept): Remove bogus security check. It is clear the current check is wrong since we check on the SocketImpl of the ServerSocket and not the Socket that accept would return. But wouldn't the correct security check just be to move this check just after implAccept(socket) and then do the exact same check on the just created socket? Gary, do we have Mauve tests for this case already? Cheers, Mark signature.asc Description: This is a digitally signed message part ___ Classpath-patches mailing list Classpath-patches@gnu.org http://lists.gnu.org/mailman/listinfo/classpath-patches
Re: [cp-patches] FYi: Implement (naive) Bidi.requiresBidi() workaround
Hi,
On Sat, 2005-12-24 at 11:10 +0100, Mark Wielaard wrote:
But you are right that we could/should probably add most things from the
weak and neutral category, which we know won't disrupt
left-to-rightness:
DIRECTIONALITY_EUROPEAN_NUMBER (EN)
DIRECTIONALITY_EUROPEAN_NUMBER_SEPARATOR (ES)
DIRECTIONALITY_EUROPEAN_NUMBER_TERMINATOR (ET)
DIRECTIONALITY_ARABIC_NUMBER (AN)
DIRECTIONALITY_COMMON_NUMBER_SEPARATOR (CS)
DIRECTIONALITY_SEGMENT_SEPARATOR (S)
DIRECTIONALITY_WHITESPACE (WS)
I am not sure we should test for the others. I have been conservative
with the above list (just so I don't have to read the whole bidi
algorithm description). The idea behind requiresBidi() is that it is a
quick way to determine whether to do full bidirectional analysis or not
(or actually if the whole paragraph text is written left-to-right). So
false positives aren't really a problem. It just means that you have to
follow the full algorithm to get the full answer.
This patch implements the above.
2005-12-31 Mark Wielaard [EMAIL PROTECTED]
* java/text/Bidi.java (requiresBidi): Also test against character
types L, EN, ES, ET, AN, CS, S and WS.
Committed,
Mark
Index: java/text/Bidi.java
===
RCS file: /cvsroot/classpath/classpath/java/text/Bidi.java,v
retrieving revision 1.1
diff -u -r1.1 Bidi.java
--- java/text/Bidi.java 23 Dec 2005 18:27:21 - 1.1
+++ java/text/Bidi.java 31 Dec 2005 10:44:10 -
@@ -44,24 +44,32 @@
* TODO/FIXME Only one method coderequiresBidi/code is implemented
* for now by using codeCharacter/code. The full algorithm is a
* href=http://www.unicode.org/unicode/reports/tr9/;Unicode Standard
- * Annex #9: The Bidirectional Algorithm/a. A ful implementation is
+ * Annex #9: The Bidirectional Algorithm/a. A full implementation is
* a href=http://fribidi.org/;GNU FriBidi/a.
*/
public class Bidi
{
/**
* Returns false if all characters in the text between start and end
- * are all left-to-right text. WARNING, this implementation is
- * slow, it calls codeCharacter.getDirectionality(char)/code on
- * all characters.
+ * are all left-to-right text. This implementation is just calls
+ * codeCharacter.getDirectionality(char)/code on all characters
+ * and makes sure all characters are either explicitly left-to-right
+ * or neutral in directionality (character types L, EN, ES, ET, AN,
+ * CS, S and WS).
*/
public static boolean requiresBidi(char[] text, int start, int end)
{
-final int LEFT_TO_RIGHT = Character.DIRECTIONALITY_LEFT_TO_RIGHT;
for (int i = start; i end; i++)
{
- char c = text[i];
- if (Character.getDirectionality(c) != LEFT_TO_RIGHT)
+ byte dir = Character.getDirectionality(text[i]);
+ if (dir != Character.DIRECTIONALITY_LEFT_TO_RIGHT
+ dir != Character.DIRECTIONALITY_EUROPEAN_NUMBER
+ dir != Character.DIRECTIONALITY_EUROPEAN_NUMBER_SEPARATOR
+ dir != Character.DIRECTIONALITY_EUROPEAN_NUMBER_TERMINATOR
+ dir != Character.DIRECTIONALITY_ARABIC_NUMBER
+ dir != Character.DIRECTIONALITY_COMMON_NUMBER_SEPARATOR
+ dir != Character.DIRECTIONALITY_SEGMENT_SEPARATOR
+ dir != Character.DIRECTIONALITY_WHITESPACE)
return true;
}
signature.asc
Description: This is a digitally signed message part
___
Classpath-patches mailing list
Classpath-patches@gnu.org
http://lists.gnu.org/mailman/listinfo/classpath-patches
[cp-patches] FYI: More comprehensive exception in gnu.CORBA
2005-12-31 Audrius Meskauskas [EMAIL PROTECTED]
* gnu/CORBA/Poa/gnuPOA.java (reference_to_servant): Throw WrongAdapter with
explaining message.
Index: gnu/CORBA/Poa/gnuPOA.java
===
RCS file: /cvsroot/classpath/classpath/gnu/CORBA/Poa/gnuPOA.java,v
retrieving revision 1.5
diff -u -r1.5 gnuPOA.java
--- gnu/CORBA/Poa/gnuPOA.java 11 Nov 2005 11:39:34 - 1.5
+++ gnu/CORBA/Poa/gnuPOA.java 31 Dec 2005 17:43:40 -
@@ -1052,12 +1052,12 @@
/**
* Returns the servant that is serving this object.
- *
- * @return if the RETAIN policy applies and the object is in the Active
- * Object Map, the method returns the servant, associated with this object.
+ *
+ * @return if the RETAIN policy applies and the object is in the Active
Object
+ * Map, the method returns the servant, associated with this object.
* Otherwise, if the USE_DEFAULT_SERVANT policy applies, the method returns
* the default servant (if one was set).
- *
+ *
* @throws ObjectNotActive if none of the conditions above are satisfied.
* @throws WrongAdapter if the object reference was not created with this
POA.
* @throws WrongPolicy. This method requires either RETAIN or
@@ -1065,14 +1065,26 @@
* apply to this POA.
*/
public Servant reference_to_servant(org.omg.CORBA.Object the_Object)
- throws ObjectNotActive, WrongPolicy,
- WrongAdapter
+throws ObjectNotActive, WrongPolicy, WrongAdapter
{
if (applies(ServantRetentionPolicyValue.RETAIN))
{
AOM.Obj ref = aom.findObject(the_Object);
if (ref == null)
- throw new WrongAdapter();
+ {
+String object;
+if (the_Object == null)
+ object = null passed;
+else if (the_Object instanceof gnuServantObject)
+ {
+gnuServantObject gs = (gnuServantObject) the_Object;
+object = Wrong owner POA + gs.poa.the_name();
+ }
+else
+ object = Unknown + the_Object.getClass().getName();
+
+throw new WrongAdapter(object + for ' + the_name() + ');
+ }
else if (ref.isDeactiveted() || ref.servant == null)
{
if (default_servant != null)
@@ -1092,32 +1104,30 @@
}
/**
- * Returns the id of the object, served by the given servant
- * (assuming that the servant serves only one object).
- * The id is found in one of the following ways.
- * ul
- * liIf the POA has both the RETAIN and the UNIQUE_ID policy and
- * the specified servant is active, the method return the Object Id associated
- * with that servant.
- * /lili
- * If the POA has both the RETAIN and the IMPLICIT_ACTIVATION policy and
- * either the POA has the MULTIPLE_ID policy or the specified servant is
- * inactive, the method activates the servant using a POA-generated Object Id
- * and the Interface Id associated with the servant, and returns that
- * Object Id.
- * /li
- * liIf the POA has the USE_DEFAULT_SERVANT policy, the servant specified
- * is the default servant, and the method is being invoked in the context of
- * executing a request on the default servant, the method returns the
- * ObjectId associated with the current invocation.
- * /li
- * /ul
- * @throws ServantNotActive in all cases, not listed in the list above.
- * @throws WrongPolicy The method requres USE_DEFAULT_SERVANT policy or
- * a combination of the RETAIN policy and either the UNIQUE_ID or
- * IMPLICIT_ACTIVATION policies and throws the WrongPolicy if these conditions
- * are not satisfied.
- */
+ * Returns the id of the object, served by the given servant (assuming that
+ * the servant serves only one object). The id is found in one of the
+ * following ways.
+ * ul
+ * liIf the POA has both the RETAIN and the UNIQUE_ID policy and the
+ * specified servant is active, the method return the Object Id associated
+ * with that servant. /li
+ * li If the POA has both the RETAIN and the IMPLICIT_ACTIVATION policy and
+ * either the POA has the MULTIPLE_ID policy or the specified servant is
+ * inactive, the method activates the servant using a POA-generated Object Id
+ * and the Interface Id associated with the servant, and returns that Object
+ * Id. /li
+ * liIf the POA has the USE_DEFAULT_SERVANT policy, the servant specified
+ * is the default servant, and the method is being invoked in the context of
+ * executing a request on the default servant, the method returns the
ObjectId
+ * associated with the current invocation. /li
+ * /ul
+ *
+ * @throws ServantNotActive in all cases, not listed in the list above.
+ * @throws WrongPolicy The method requres USE_DEFAULT_SERVANT policy or a
+ * combination of the RETAIN policy and either the UNIQUE_ID or
+ * IMPLICIT_ACTIVATION policies and
[cp-testresults] Japi diffs for classpath
Japi diff jdk14 vs classpath: Full results: http://www.kaffe.org/~stuart/japi/htmlout/h-jdk14-classpath.html Changes since last run: -Comparison run at Fri Dec 30 10:52:17 2005 GMT -jdk14 API scanned at 2005/12/30 05:15:38 EST -classpath API scanned at 2005/12/30 05:07:40 GMT +Comparison run at Sat Dec 31 10:53:39 2005 GMT +jdk14 API scanned at 2005/12/31 05:15:48 EST +classpath API scanned at 2005/12/31 05:16:34 GMT -javax.print.attribute.standard: 99.94% good, 0.05% missing +javax.print.attribute.standard: 100% good -Total: 97.74% good, 0.11% minor, 0% bad, 2.05% missing +Total: 97.74% good, 0.11% minor, 0% bad, 2.04% missing -Methods: 58 missing. +Methods: 57 missing. -javax.print.attribute.standard: -Missing -method javax.print.attribute.standard.MediaSize.findMedia(float, float, int): missing in classpath - Japi diff jdk15 vs classpath: Full results: http://www.kaffe.org/~stuart/japi/htmlout/h-jdk15-classpath.html Changes since last run: -Comparison run at Fri Dec 30 10:55:08 2005 GMT -jdk15 API scanned at 2005/12/30 05:09:06 EST -classpath API scanned at 2005/12/30 05:07:40 GMT +Comparison run at Sat Dec 31 10:56:34 2005 GMT +jdk15 API scanned at 2005/12/31 05:09:16 EST +classpath API scanned at 2005/12/31 05:16:34 GMT -javax.print.attribute.standard: 98.63% good, 1.1% bad, 0.26% missing +javax.print.attribute.standard: 98.69% good, 1.1% bad, 0.19% missing -Methods: 11 minor, 1001 bad, 467 missing. +Methods: 11 minor, 1001 bad, 466 missing. -method javax.print.attribute.standard.MediaSize.findMedia(float, float, int): missing in classpath ___ Classpath-testresults mailing list Classpath-testresults@gnu.org http://lists.gnu.org/mailman/listinfo/classpath-testresults
[cp-testresults] FAIL: regressions for libgcj on Sat Dec 31 18:21:55 UTC 2005
Baseline from: Sat Dec 31 14:35:41 UTC 2005 Regressions: FAIL: Thread_Sleep -O3 output - bytecode-native test Totals: PASS: 3377 XPASS: 0 FAIL: 1 XFAIL: 10 ___ Classpath-testresults mailing list Classpath-testresults@gnu.org http://lists.gnu.org/mailman/listinfo/classpath-testresults
[cp-testresults] FAIL: regressions for libgcj on Sun Jan 1 01:54:35 UTC 2006
Baseline from: Sat Dec 31 22:09:12 UTC 2005 Regressions: FAIL: Thread_Sleep output - source compiled test Totals: PASS: 3377 XPASS: 0 FAIL: 1 XFAIL: 10 ___ Classpath-testresults mailing list Classpath-testresults@gnu.org http://lists.gnu.org/mailman/listinfo/classpath-testresults
Re: XML parsing problems
Hi Chris, On Tue, 2005-12-27 at 20:03 +, Chris Burdess wrote: Please test the new XML parser on as many weird and wonderful XML sources as you can, and report any problems to me either by mail or Bugzilla - I will try to deal with them before release, or we can revert to aelfred2 again if there are other showstoppers. Nice work! You are running some test-suites from time to time on the xml parsers. If these are free then I would like to add them to builder.classpath.org so regressions (or better conformance results) are automatically tracked. How much space do they need and is it difficult to setup? Cheers, Mark -- Escape the Java Trap with GNU Classpath! http://www.gnu.org/philosophy/java-trap.html Join the community at http://planet.classpath.org/ signature.asc Description: This is a digitally signed message part ___ Classpath mailing list Classpath@gnu.org http://lists.gnu.org/mailman/listinfo/classpath
Re: XML parsing problems
Mark Wielaard wrote: You are running some test-suites from time to time on the xml parsers. If these are free then I would like to add them to builder.classpath.org so regressions (or better conformance results) are automatically tracked. How much space do they need and is it difficult to setup? The DOM conformance tests take up about 15MB, the SAX tests around 640MB (less if you want to test fewer parsers). It shouldn't be too difficult to set up as I have harness scripts already. There are also some XSLT/XPath conformance tests from OASIS, these take up about 126MB. -- Chris Burdess They that can give up essential liberty to obtain a little safety deserve neither liberty nor safety. - Benjamin Franklin pgpmphjshomJ6.pgp Description: PGP signature ___ Classpath mailing list Classpath@gnu.org http://lists.gnu.org/mailman/listinfo/classpath
[commit-cp] classpath ./ChangeLog java/text/Bidi.java
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Mark Wielaard [EMAIL PROTECTED] 05/12/31 10:45:47 Modified files: . : ChangeLog java/text : Bidi.java Log message: * java/text/Bidi.java (requiresBidi): Also test against character types L, EN, ES, ET, AN, CS, S and WS. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/classpath/ChangeLog.diff?tr1=1.5908tr2=1.5909r1=textr2=text http://cvs.savannah.gnu.org/viewcvs/classpath/classpath/java/text/Bidi.java.diff?tr1=1.1tr2=1.2r1=textr2=text
[commit-cp] classpath ./ChangeLog gnu/CORBA/Poa/gnuPOA.java
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Audrius Meskauskas [EMAIL PROTECTED] 05/12/31 17:59:07 Modified files: . : ChangeLog gnu/CORBA/Poa : gnuPOA.java Log message: 2005-12-31 Audrius Meskauskas [EMAIL PROTECTED] * gnu/CORBA/Poa/gnuPOA.java (reference_to_servant): Throw WrongAdapter with explaining message. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/classpath/ChangeLog.diff?tr1=1.5909tr2=1.5910r1=textr2=text http://cvs.savannah.gnu.org/viewcvs/classpath/classpath/gnu/CORBA/Poa/gnuPOA.java.diff?tr1=1.5tr2=1.6r1=textr2=text
