[GitHub] [camel-kamelets] oscerd commented on pull request #1162: chore: Introduce Kamelet input/output data types
oscerd commented on PR #1162: URL: https://github.com/apache/camel-kamelets/pull/1162#issuecomment-1334886048 Thanks. Nice addition! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-kamelets] oscerd commented on pull request #1162: chore: Introduce Kamelet input/output data types
oscerd commented on PR #1162: URL: https://github.com/apache/camel-kamelets/pull/1162#issuecomment-1333813611 So I would prefer to have them in the catalog from the 0.10.0 release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-kamelets] oscerd commented on pull request #1162: chore: Introduce Kamelet input/output data types
oscerd commented on PR #1162: URL: https://github.com/apache/camel-kamelets/pull/1162#issuecomment-1333730592 and have early feedback -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-kamelets] oscerd commented on pull request #1162: chore: Introduce Kamelet input/output data types
oscerd commented on PR #1162: URL: https://github.com/apache/camel-kamelets/pull/1162#issuecomment-1333730116 Moving them to the official catalog seems to be better maybe something like aws-s3-source-exp.kamelet.yaml instead of .exp.kamelet.yaml. So we could give them to the users. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-kamelets] oscerd commented on pull request #1162: chore: Introduce Kamelet input/output data types
oscerd commented on PR #1162: URL: https://github.com/apache/camel-kamelets/pull/1162#issuecomment-1333652792 Pushed on main, should work now if you rebase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-kamelets] oscerd commented on pull request #1162: chore: Introduce Kamelet input/output data types
oscerd commented on PR #1162: URL: https://github.com/apache/camel-kamelets/pull/1162#issuecomment-1333539213 @christophd if you rebase the validation should be fixed now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-kamelets] oscerd commented on pull request #1162: chore: Introduce Kamelet input/output data types
oscerd commented on PR #1162: URL: https://github.com/apache/camel-kamelets/pull/1162#issuecomment-1332000120 Yes, I think something like introducing some side kamelets with the new feature and test them would be best. Then we can introduce this slowly on the Kamelets, once we have everything in the correct place. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-kamelets] oscerd commented on pull request #1162: chore: Introduce Kamelet input/output data types
oscerd commented on PR #1162: URL: https://github.com/apache/camel-kamelets/pull/1162#issuecomment-1331978544 Since, at least, from my PoV, this is a really big change, I would maybe postpone this to after 3.20.0 release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-kamelets] oscerd commented on pull request #1162: chore: Introduce Kamelet input/output data types
oscerd commented on PR #1162: URL: https://github.com/apache/camel-kamelets/pull/1162#issuecomment-1331936432 There is one point in the PR I didn't notice before, creating a Jackson Data format for each message is really overkilling. My only concern is related to the fact the behavior will be or not the same, in all the runtimes. We are introducing a new parameter with a default value, so the kamelet lifecycle and execution path won't be the same, I suppose. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-kamelets] oscerd commented on pull request #1162: chore: Introduce Kamelet input/output data types
oscerd commented on PR #1162: URL: https://github.com/apache/camel-kamelets/pull/1162#issuecomment-1331807606 I'm still under the impression this PR is WIP. We are not sure this will work across all the runtimes, we have some missing bits for make it work on Quarkus and camel-k. Probably it would be better to postpone the merge to another kamelets release, when we have something more stable. Thoughts? @lburgazzoli @christophd @davsclaus -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-kamelets] oscerd commented on pull request #1162: chore: Introduce Kamelet input/output data types
oscerd commented on PR #1162: URL: https://github.com/apache/camel-kamelets/pull/1162#issuecomment-1330668703 I would like to release 0.10.0 this week. There are some leftover to work on @christophd I guess. I'll wait all green in terms of review to merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-kamelets] oscerd commented on pull request #1162: chore: Introduce Kamelet input/output data types
oscerd commented on PR #1162: URL: https://github.com/apache/camel-kamelets/pull/1162#issuecomment-1326677661 We could create a kamelet-api module. I'll try the PR on jbang too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-kamelets] oscerd commented on pull request #1162: chore: Introduce Kamelet input/output data types
oscerd commented on PR #1162: URL: https://github.com/apache/camel-kamelets/pull/1162#issuecomment-1326637509 No rush. When you think the first iteration is done, I'll review and merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-kamelets] oscerd commented on pull request #1162: chore: Introduce Kamelet input/output data types
oscerd commented on PR #1162: URL: https://github.com/apache/camel-kamelets/pull/1162#issuecomment-1326155459 Can you rebase @christophd ? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-kamelets] oscerd commented on pull request #1162: chore: Introduce Kamelet input/output data types
oscerd commented on PR #1162: URL: https://github.com/apache/camel-kamelets/pull/1162#issuecomment-1325121789 Camel-k-runtime seems to be ok while upgrading to the required bits for Camel 3.19.0 and Camel Quarkus 2.14.0. I would like to include this PR in 0.10.0 and release by the end of this week or beginning of the next. So we could have a first camel k release (1.11.0) upstream with this feature. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-kamelets] oscerd commented on pull request #1162: chore: Introduce Kamelet input/output data types
oscerd commented on PR #1162: URL: https://github.com/apache/camel-kamelets/pull/1162#issuecomment-1323853861 Let me know once is ready and I'll review and merge. We need also to identify the default type for each of Kamelets we're going to modify. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-kamelets] oscerd commented on pull request #1162: chore: Introduce Kamelet input/output data types
oscerd commented on PR #1162: URL: https://github.com/apache/camel-kamelets/pull/1162#issuecomment-1323812022 That's fine, no need for squash at least from my PoV -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
