Re: [I] Infinispan with dev services enabled can lead to jakarta.enterprise.inject.CreationException [camel-quarkus]

2024-04-05 Thread via GitHub


karesti commented on issue #5965:
URL: https://github.com/apache/camel-quarkus/issues/5965#issuecomment-2039277207

   @jamesnetherton yes, the dev services creates a default remote cache manager 
without any configuration and then when we use a cache in the code, the cache 
is also created by default.
   My question is: do you need to use dev services AND this bean not to be 
created but being provided by camel quarkus ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Infinispan with dev services enabled can lead to jakarta.enterprise.inject.CreationException [camel-quarkus]

2024-04-05 Thread via GitHub


jamesnetherton commented on issue #5965:
URL: https://github.com/apache/camel-quarkus/issues/5965#issuecomment-2039308842

   > My question is: do you need to use dev services AND this bean not to be 
created but being provided by camel quarkus ?
   
   The problem is that devservices is enabled by default. Which isn't really 
desirable for minimal code, k8s based deployments like camel-k.
   
   So users have to either explicitly disable devservices or disable the Camel 
`RemoteCacheManager` auto discovery.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Infinispan with dev services enabled can lead to jakarta.enterprise.inject.CreationException [camel-quarkus]

2024-04-05 Thread via GitHub


karesti commented on issue #5965:
URL: https://github.com/apache/camel-quarkus/issues/5965#issuecomment-2039443811

   I afraid that having dev services not enabled by default is the dev services 
default behaviour, I can't change that for Infinispan. But I can do that if I 
detect the use of Camel in the Infinispan extension


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Infinispan with dev services enabled can lead to jakarta.enterprise.inject.CreationException [camel-quarkus]

2024-04-05 Thread via GitHub


karesti commented on issue #5965:
URL: https://github.com/apache/camel-quarkus/issues/5965#issuecomment-2039448901

   @jamesnetherton in the Infinispan extension, I already enable and so stuff 
depending on extensions that might be present.
   I have an idea that might be done in the camel quarkus extension


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Infinispan with dev services enabled can lead to jakarta.enterprise.inject.CreationException [camel-quarkus]

2024-04-05 Thread via GitHub


karesti commented on issue #5965:
URL: https://github.com/apache/camel-quarkus/issues/5965#issuecomment-2039451270

   @jamesnetherton maybe you can provide in the camel infinispan quarkus 
extension something like this
   
https://github.com/quarkiverse/quarkus-langchain4j/blob/main/infinispan/deployment/src/main/java/io/quarkiverse/langchain4j/infinispan/DevServicesConfigBuilderCustomizer.java#L1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Infinispan with dev services enabled can lead to jakarta.enterprise.inject.CreationException [camel-quarkus]

2024-04-05 Thread via GitHub


jamesnetherton commented on issue #5965:
URL: https://github.com/apache/camel-quarkus/issues/5965#issuecomment-2039467338

   > @jamesnetherton maybe this can provide in the camel infinispan quarkus 
extension something like this
   
   Yes, I was thinking about something like that. I need to experiment a little.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Infinispan with dev services enabled can lead to jakarta.enterprise.inject.CreationException [camel-quarkus]

2024-04-05 Thread via GitHub


karesti commented on issue #5965:
URL: https://github.com/apache/camel-quarkus/issues/5965#issuecomment-2039473661

   something like 
   ```java
   public class InfinispanDevServicesConfigBuilderCustomizer implements 
SmallRyeConfigBuilderCustomizer {
   @Override
   public void configBuilder(final SmallRyeConfigBuilder builder) {
   // use a priority of 50 to make sure that this is overridable by any 
of the standard methods
   builder.withSources(
   new PropertiesConfigSource(
   
Map.of("quarkus.infinispan-client.devservices.enabled", false),
   "quarkus-camel-infinispan", 50));
   }
   }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Infinispan with dev services enabled can lead to jakarta.enterprise.inject.CreationException [camel-quarkus]

2024-04-05 Thread via GitHub


karesti commented on issue #5965:
URL: https://github.com/apache/camel-quarkus/issues/5965#issuecomment-2039524264

   In the Infinispan extesion, I do have this code as well:
   
   ```java
// dev mode client name for default
   if 
(infinispanClientsBuildTimeConfig.defaultInfinispanClient.devService.devservices.enabled)
 {
   clientNames.add(DEFAULT_INFINISPAN_CLIENT_NAME);
   }
   ```
   
   I could the infinispan camel feature, and not create one since there is 
already one.
   
   this way dev services will spin up a infinispan container after all, but 
without creating the bean that is not needed for this use case. We could 
configure the
   
   ```properties
   camel.component.infinispan.hosts = ${INFINISPAN_HOST:localhost}
   camel.component.infinispan.username = admin
   camel.component.infinispan.password = password
   camel.component.infinispan.secure = true
   ```
   
   In the dev services override using the dev services
   
   For what is having a cache created on startup, you can also provide on the 
dev services a cache on the config


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Infinispan with dev services enabled can lead to jakarta.enterprise.inject.CreationException [camel-quarkus]

2024-04-05 Thread via GitHub


karesti commented on issue #5965:
URL: https://github.com/apache/camel-quarkus/issues/5965#issuecomment-2039547259

   @jamesnetherton I'm going to implement the liked issue (to be backported) 
   
   then I would suggest making use of spinning a server with Quarkus and adding 
extra config with a SmallRyeConfigBuilderCustomizer for Dev Mode 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org