Re: [PR] Review permission check [camel-k]
lburgazzoli merged PR #5479: URL: https://github.com/apache/camel-k/pull/5479 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Review permission check [camel-k]
squakez commented on PR #5479: URL: https://github.com/apache/camel-k/pull/5479#issuecomment-2100613067 > mh, since the master trait has been moved to addons, validation is not relevant as addons are untyped (in the CRDs) Very true. We should open a discussion and understand if it is still relevant to keep the separation between addon and traits. In any case, it would be for a separate venue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Review permission check [camel-k]
lburgazzoli commented on PR #5479: URL: https://github.com/apache/camel-k/pull/5479#issuecomment-2100600513 > Sorry, I misinterpreted the change, I thought you were removing the `Configmap` option. Okey, I see that nothing is really changing, however, I wonder if we can take the opportunity and add an `// +kubebuilder:validation:Enum=Configmap;Lease` to enforce a check on the accepted values. mh, since the master trait has been moved to addons, validation is not relevant as addons are untyped (in the CRDs) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Review permission check [camel-k]
squakez commented on PR #5479: URL: https://github.com/apache/camel-k/pull/5479#issuecomment-2100554400 Sorry, I misinterpreted the change, I thought you were removing the `Configmap` option. Okey, I see that nothing is really changing, however, I wonder if we can take the opportunity and add an `// +kubebuilder:validation:Enum=Configmap;Lease` to enforce a check on the accepted values. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Review permission check [camel-k]
lburgazzoli commented on PR #5479: URL: https://github.com/apache/camel-k/pull/5479#issuecomment-2100406013 > You'll need to change also [#5479 (files)](https://github.com/apache/camel-k/pull/5479/files#diff-7e0ef56e991c8a8605de6dd8886fe8be2694b81248420587eb799384adcd5257L58) > > and `make generate` accordingly. Also wondering if this may affect any possible existing application which is making use of those old leases. What do I need to change ? The default was `Lease` already and you can still set it to `ConfigMap`, the only change is the check on the permission to use leases and events since access to those resources is granted by the RBACs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Review permission check [camel-k]
lburgazzoli opened a new pull request, #5479: URL: https://github.com/apache/camel-k/pull/5479 Fixes #5210 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
