[jira] [Commented] (CASSANDRA-10149) Make nodetool cfstats and cfhistograms consistent

2015-08-20 Thread Joel Knighton (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-10149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14705926#comment-14705926
 ] 

Joel Knighton commented on CASSANDRA-10149:
---

Quick note: in the description, the description of parameters is inverted. 
cfstats takes keyspace.table and cfhistograms takes keyspace table.

For what it's worth, I'd bet (or at least it makes sense to me) that cfstats 
uses keyspace.table because it is possible to just give a keyspace to cfstats. 
Using space means the current parser would have to distinguish between 
keyspace1 keyspace2 and keyspace1 table1 as arguments. In the event that 
keyspace2 and table1 have the same name, there's no way to distinguish intent.

It may make sense to add keyspace.table as an option format for cfhistograms.

 Make nodetool cfstats and cfhistograms consistent
 -

 Key: CASSANDRA-10149
 URL: https://issues.apache.org/jira/browse/CASSANDRA-10149
 Project: Cassandra
  Issue Type: Improvement
  Components: Tools
Reporter: Jeremy Hanna
  Labels: lhf

 Currently when using nodetool cfstats and cfhistograms (for a keyspace and 
 table) have different syntax.  cfstats uses keyspace table.  cfhistograms 
 uses keyspace.table.  We should unify it one way or the other (or both).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (CASSANDRA-10149) Make nodetool cfstats and cfhistograms consistent

2015-08-20 Thread Sebastian Estevez (JIRA)

[ 
https://issues.apache.org/jira/browse/CASSANDRA-10149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14705896#comment-14705896
 ] 

Sebastian Estevez commented on CASSANDRA-10149:
---

We should allow both  . and   for both to avoid confusion from the 
historical API

 Make nodetool cfstats and cfhistograms consistent
 -

 Key: CASSANDRA-10149
 URL: https://issues.apache.org/jira/browse/CASSANDRA-10149
 Project: Cassandra
  Issue Type: Improvement
  Components: Tools
Reporter: Jeremy Hanna
  Labels: lhf

 Currently when using nodetool cfstats and cfhistograms (for a keyspace and 
 table) have different syntax.  cfstats uses keyspace table.  cfhistograms 
 uses keyspace.table.  We should unify it one way or the other (or both).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)