[GitHub] blueorangutan commented on issue #2018: CLOUDSTACK-9848: Added exit status checking for the iptables commands
blueorangutan commented on issue #2018: CLOUDSTACK-9848: Added exit status checking for the iptables commands URL: https://github.com/apache/cloudstack/pull/2018#issuecomment-299101965 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] borisstoyanov commented on issue #2018: CLOUDSTACK-9848: Added exit status checking for the iptables commands
borisstoyanov commented on issue #2018: CLOUDSTACK-9848: Added exit status checking for the iptables commands URL: https://github.com/apache/cloudstack/pull/2018#issuecomment-299101888 @blueorangutan test centos7 vmware-55u3 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] borisstoyanov commented on issue #1996: CLOUDSTACK-9099: SecretKey is returned from the APIs
borisstoyanov commented on issue #1996: CLOUDSTACK-9099: SecretKey is returned from the APIs URL: https://github.com/apache/cloudstack/pull/1996#issuecomment-299101715 Hi @jayapalu, sorry for the delay, we're using port 8096 in the config file and no API keys are configured in the cfg file. Are you able to execute the tests successfully, if yes can you share your config. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sureshanaparti commented on issue #1875: CLOUDSTACK-8608: [VMware] System VMs failed to start due to permissions issue. Provide permissions to template folder when mounted on management serve
sureshanaparti commented on issue #1875: CLOUDSTACK-8608: [VMware] System VMs failed to start due to permissions issue. Provide permissions to template folder when mounted on management server. URL: https://github.com/apache/cloudstack/pull/1875#issuecomment-299101726 The above intermitten failures are not related to this PR changes. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sateesh-chodapuneedi commented on issue #1253: CLOUDSTACK-9184: [VMware] vmware.ports.per.dvportgroup global setting is not useful from vCenter 5.0 onwards
sateesh-chodapuneedi commented on issue #1253: CLOUDSTACK-9184: [VMware] vmware.ports.per.dvportgroup global setting is not useful from vCenter 5.0 onwards URL: https://github.com/apache/cloudstack/pull/1253#issuecomment-299100369 >Can we remove the config param "vmware.ports.per.dvportgroup" now or hold it sometime? @sureshanaparti Yes, we can remove this config param. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sateesh-chodapuneedi commented on issue #1878: CLOUDSTACK-9717: [VMware] RVRs have mismatching MAC addresses for extra public NICs.
sateesh-chodapuneedi commented on issue #1878: CLOUDSTACK-9717: [VMware] RVRs have mismatching MAC addresses for extra public NICs. URL: https://github.com/apache/cloudstack/pull/1878#issuecomment-299098640 @sureshanaparti LGTM code change, please incorporate changes suggested by @rafaelweingartner This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] abhinandanprateek commented on issue #2075: [4.9+] CLOUDSTACK-9900: Fix high CPU deviation issues seen in metrics view
abhinandanprateek commented on issue #2075: [4.9+] CLOUDSTACK-9900: Fix high CPU deviation issues seen in metrics view URL: https://github.com/apache/cloudstack/pull/2075#issuecomment-299088351 LGTM, on code review. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] leprechau commented on issue #1606: Allow CGN (RFC6598) to be used within a VPC
leprechau commented on issue #1606: Allow CGN (RFC6598) to be used within a VPC URL: https://github.com/apache/cloudstack/pull/1606#issuecomment-299039096 @rossor @nathanejohnson Can we get the code formatted correctly so the tests pass? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2074: CLOUDSTACK-9899 Url validation disabling
blueorangutan commented on issue #2074: CLOUDSTACK-9899 Url validation disabling URL: https://github.com/apache/cloudstack/pull/2074#issuecomment-298992375 Trillian test result (tid-1055) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 31904 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2074-t1055-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_router_nics.py Test completed. 49 look ok, 2 have error(s) Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_VPC_nics_after_destroy | `Failure` | 796.93 | test_vpc_router_nics.py test_04_rvpc_privategw_static_routes | `Failure` | 360.75 | test_privategw_acl.py test_01_vpc_site2site_vpn | Success | 165.36 | test_vpc_vpn.py test_01_vpc_remote_access_vpn | Success | 66.24 | test_vpc_vpn.py test_01_redundant_vpc_site2site_vpn | Success | 260.97 | test_vpc_vpn.py test_02_VPC_default_routes | Success | 289.56 | test_vpc_router_nics.py test_05_rvpc_multi_tiers | Success | 521.81 | test_vpc_redundant.py test_04_rvpc_network_garbage_collector_nics | Success | 1446.33 | test_vpc_redundant.py test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 570.22 | test_vpc_redundant.py test_02_redundant_VPC_default_routes | Success | 755.50 | test_vpc_redundant.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1297.28 | test_vpc_redundant.py test_09_delete_detached_volume | Success | 156.78 | test_volumes.py test_08_resize_volume | Success | 156.60 | test_volumes.py test_07_resize_fail | Success | 161.62 | test_volumes.py test_06_download_detached_volume | Success | 156.45 | test_volumes.py test_05_detach_volume | Success | 150.80 | test_volumes.py test_04_delete_attached_volume | Success | 151.27 | test_volumes.py test_03_download_attached_volume | Success | 156.41 | test_volumes.py test_02_attach_volume | Success | 89.29 | test_volumes.py test_01_create_volume | Success | 622.53 | test_volumes.py test_03_delete_vm_snapshots | Success | 275.22 | test_vm_snapshots.py test_02_revert_vm_snapshots | Success | 100.80 | test_vm_snapshots.py test_01_create_vm_snapshots | Success | 163.76 | test_vm_snapshots.py test_deploy_vm_multiple | Success | 267.81 | test_vm_life_cycle.py test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py test_advZoneVirtualRouter | Success | 0.03 | test_vm_life_cycle.py test_10_attachAndDetach_iso | Success | 26.71 | test_vm_life_cycle.py test_09_expunge_vm | Success | 125.25 | test_vm_life_cycle.py test_08_migrate_vm | Success | 30.93 | test_vm_life_cycle.py test_07_restore_vm | Success | 0.13 | test_vm_life_cycle.py test_06_destroy_vm | Success | 125.86 | test_vm_life_cycle.py test_03_reboot_vm | Success | 125.88 | test_vm_life_cycle.py test_02_start_vm | Success | 10.18 | test_vm_life_cycle.py test_01_stop_vm | Success | 35.31 | test_vm_life_cycle.py test_CreateTemplateWithDuplicateName | Success | 95.81 | test_templates.py test_08_list_system_templates | Success | 0.06 | test_templates.py test_07_list_public_templates | Success | 0.04 | test_templates.py test_05_template_permissions | Success | 0.06 | test_templates.py test_04_extract_template | Success | 5.17 | test_templates.py test_03_delete_template | Success | 5.12 | test_templates.py test_02_edit_template | Success | 90.14 | test_templates.py test_01_create_template | Success | 40.44 | test_templates.py test_10_destroy_cpvm | Success | 161.64 | test_ssvm.py test_09_destroy_ssvm | Success | 163.72 | test_ssvm.py test_08_reboot_cpvm | Success | 101.59 | test_ssvm.py test_07_reboot_ssvm | Success | 133.52 | test_ssvm.py test_06_stop_cpvm | Success | 131.79 | test_ssvm.py test_05_stop_ssvm | Success | 133.67 | test_ssvm.py test_04_cpvm_internals | Success | 1.22 | test_ssvm.py test_03_ssvm_internals | Success | 3.39 | test_ssvm.py test_02_list_cpvm_vm | Success | 0.15 | test_ssvm.py test_01_list_sec_storage_vm | Success | 0.17 | test_ssvm.py test_02_list_snapshots_with_removed_data_store | Success | 87.13 | test_snapshots.py test_01_snapshot_root_disk | Success | 16.43 | test_snapshots.py test_04_change_offering_small | Success | 239.61 | test_service_offerings.py test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py test_02_edit_service_offering | Success | 0.08 | test_service_offerings.py test_01_create_service_offering | Success | 0.11 | test_service_offerings.py test_02_sys_template_ready | Success | 0.17 | test_secondary_storage.py test_01_sys_vm_start | Success | 0.24 | test_secondary_storage.py test_09_reboot_router | Success | 35.30 | test_routers.py test_08_start_router | Success | 30.29 | test_routers.py
[GitHub] kiwiflyer commented on issue #2070: [4.9+] hyperv: Fix log4j to have @AGENTLOG@ replaced
kiwiflyer commented on issue #2070: [4.9+] hyperv: Fix log4j to have @AGENTLOG@ replaced URL: https://github.com/apache/cloudstack/pull/2070#issuecomment-298962214 @rhtyd Can we create a jira issue for this? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] kiwiflyer commented on issue #2008: [CLOUDSTACK-9840] Fix datetime format of snapshots events
kiwiflyer commented on issue #2008: [CLOUDSTACK-9840] Fix datetime format of snapshots events URL: https://github.com/apache/cloudstack/pull/2008#issuecomment-298952645 Simple fix for log consistency. LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] kiwiflyer commented on issue #2008: [CLOUDSTACK-9840] Fix datetime format of snapshots events
kiwiflyer commented on issue #2008: [CLOUDSTACK-9840] Fix datetime format of snapshots events URL: https://github.com/apache/cloudstack/pull/2008#issuecomment-298952645 Simple fix for log consistency. LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rohit57 commented on issue #1908: CLOUDSTACK-9317: Fixed disable static nat on leaving ips on interface
rohit57 commented on issue #1908: CLOUDSTACK-9317: Fixed disable static nat on leaving ips on interface URL: https://github.com/apache/cloudstack/pull/1908#issuecomment-298896670 Disable static NAT working fine, IP's are leaving interface as soon as they are disabled.    Test results are as expected. LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jayapalu commented on issue #1996: CLOUDSTACK-9099: SecretKey is returned from the APIs
jayapalu commented on issue #1996: CLOUDSTACK-9099: SecretKey is returned from the APIs URL: https://github.com/apache/cloudstack/pull/1996#issuecomment-298893728 @borisstoyanov In marvin config with port 8080 and without keys, Is this valid configuration test ? Because with port 8080 and with out keys there is no way to get the keys first time unless it uses 8096 for the first time and then fall back to 8080 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jayapalu commented on issue #1996: CLOUDSTACK-9099: SecretKey is returned from the APIs
jayapalu commented on issue #1996: CLOUDSTACK-9099: SecretKey is returned from
the APIs
URL: https://github.com/apache/cloudstack/pull/1996#issuecomment-298597383
@borisstoyanov Can you upload the your "mgtSvr" from the .cfg. I am getting
the error when port is 8080 and apikey and secretkey is empty. I want to
confirm that you/trillian has the same configuration.
"mgtSvr": [
{
"mgtSvrIp": "10.233.88.88",
"passwd": "password",
"user": "root",
"port": 8080,
"useHttps": "False",
"certCAPath": "NA",
"certPath": "NA",
"apiKey": "",
"securityKey": ""
}
]
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] DaanHoogland commented on issue #2075: [4.9+] CLOUDSTACK-9900: Fix high CPU deviation issues seen in metrics view
DaanHoogland commented on issue #2075: [4.9+] CLOUDSTACK-9900: Fix high CPU deviation issues seen in metrics view URL: https://github.com/apache/cloudstack/pull/2075#issuecomment-29382 LGTM, I already approved but since we have this string in our policy... ;) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2075: [4.9+] CLOUDSTACK-9900: Fix high CPU deviation issues seen in metrics view
rhtyd commented on issue #2075: [4.9+] CLOUDSTACK-9900: Fix high CPU deviation issues seen in metrics view URL: https://github.com/apache/cloudstack/pull/2075#issuecomment-29353 Thanks @rashmidixit for reviewing This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] yvsubhash commented on issue #2047: CLOUDSTACK-8186: make setRemoved to null possible
yvsubhash commented on issue #2047: CLOUDSTACK-8186: make setRemoved to null possible URL: https://github.com/apache/cloudstack/pull/2047#issuecomment-298885131 @ustcweizhou LGTM for the code I have updated my PR to make use of this fix https://github.com/apache/cloudstack/pull/1716/files This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jayapalu commented on issue #2018: CLOUDSTACK-9848: Added exit status checking for the iptables commands
jayapalu commented on issue #2018: CLOUDSTACK-9848: Added exit status checking for the iptables commands URL: https://github.com/apache/cloudstack/pull/2018#issuecomment-298873490 few of the cleanup of test cases are failing and these are not related my changes. @borisstoyanov Can you trigger the tests again. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rashmidixit commented on issue #2075: [4.9+] CLOUDSTACK-9900: Fix high CPU deviation issues seen in metrics view
rashmidixit commented on issue #2075: [4.9+] CLOUDSTACK-9900: Fix high CPU deviation issues seen in metrics view URL: https://github.com/apache/cloudstack/pull/2075#issuecomment-298867373 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2075: [4.9+] CLOUDSTACK-9900: Fix high CPU deviation issues seen in metrics view
rhtyd commented on issue #2075: [4.9+] CLOUDSTACK-9900: Fix high CPU deviation issues seen in metrics view URL: https://github.com/apache/cloudstack/pull/2075#issuecomment-298866549 @DaanHoogland fixed thanks This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] karuturi commented on issue #927: CLOUDSTACK-9901 secure and hidden config values are returned as plaintext string
karuturi commented on issue #927: CLOUDSTACK-9901 secure and hidden config values are returned as plaintext string URL: https://github.com/apache/cloudstack/pull/927#issuecomment-298863250 update the PR with testcase fix This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2074: CLOUDSTACK-9899 Url validation disabling
blueorangutan commented on issue #2074: CLOUDSTACK-9899 Url validation disabling URL: https://github.com/apache/cloudstack/pull/2074#issuecomment-298862135 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #2074: CLOUDSTACK-9899 Url validation disabling
DaanHoogland commented on issue #2074: CLOUDSTACK-9899 Url validation disabling URL: https://github.com/apache/cloudstack/pull/2074#issuecomment-298862111 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on a change in pull request #2075: [4.9+] CLOUDSTACK-9900: Fix high CPU deviation issues seen in metrics view
DaanHoogland commented on a change in pull request #2075: [4.9+]
CLOUDSTACK-9900: Fix high CPU deviation issues seen in metrics view
URL: https://github.com/apache/cloudstack/pull/2075#discussion_r114501952
##
File path:
plugins/metrics/src/org/apache/cloudstack/response/ClusterMetricsResponse.java
##
@@ -128,10 +128,10 @@ public void setCpuAllocated(final Long cpuAllocated,
final Long cpuTotal) {
}
}
-public void setCpuMaxDeviation(final Double maxCpuDeviation, final Double
totalCpuUsed, final Long totalHosts) {
-if (maxCpuDeviation != null && totalCpuUsed != null && totalHosts !=
null && totalHosts != 0) {
-final Double averageCpuUsage = totalCpuUsed / totalHosts;
-this.cpuMaxDeviation = String.format("%.2f%%", (maxCpuDeviation -
averageCpuUsage) * 100.0 / averageCpuUsage);
+public void setCpuMaxDeviation(final Double maxCpuUsagePercentage, final
Double totalCpuUsedPercentage, final Long totalHosts) {
+if (maxCpuUsagePercentage != null && totalCpuUsedPercentage != null &&
totalHosts != null && totalHosts != 0) {
+final Double averageCpuUsagePercentage = totalCpuUsedPercentage /
totalHosts;
+this.cpuMaxDeviation = String.format("%.2f%%",
(maxCpuUsagePercentage - averageCpuUsagePercentage) * 1.0 /
averageCpuUsagePercentage);
Review comment:
is the '* 1.0' needed when it is devided next? I would rather see a cast if
it is, in this case
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] DaanHoogland commented on a change in pull request #2075: [4.9+] CLOUDSTACK-9900: Fix high CPU deviation issues seen in metrics view
DaanHoogland commented on a change in pull request #2075: [4.9+]
CLOUDSTACK-9900: Fix high CPU deviation issues seen in metrics view
URL: https://github.com/apache/cloudstack/pull/2075#discussion_r114502094
##
File path:
plugins/metrics/src/org/apache/cloudstack/response/ZoneMetricsResponse.java
##
@@ -123,10 +123,10 @@ public void setCpuAllocated(final Long cpuAllocated,
final Long cpuTotal) {
}
}
-public void setCpuMaxDeviation(final Double maxCpuDeviation, final Double
totalCpuUsed, final Long totalHosts) {
-if (maxCpuDeviation != null && totalCpuUsed != null && totalHosts !=
null && totalHosts != 0) {
-final Double averageCpuUsage = totalCpuUsed / totalHosts;
-this.cpuMaxDeviation = String.format("%.2f%%", (maxCpuDeviation -
averageCpuUsage) * 100.0 / averageCpuUsage);
+public void setCpuMaxDeviation(final Double maxCpuUsagePercentage, final
Double totalCpuUsedPercentage, final Long totalHosts) {
+if (maxCpuUsagePercentage != null && totalCpuUsedPercentage != null &&
totalHosts != null && totalHosts != 0) {
+final Double averageCpuUsagePercentage = totalCpuUsedPercentage /
totalHosts;
+this.cpuMaxDeviation = String.format("%.2f%%",
(maxCpuUsagePercentage - averageCpuUsagePercentage) * 1.0 /
averageCpuUsagePercentage);
Review comment:
but i think th '* 1.0' can be removed
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rhtyd commented on issue #2075: [4.9+] CLOUDSTACK-9900: Fix high CPU deviation issues seen in metrics view
rhtyd commented on issue #2075: [4.9+] CLOUDSTACK-9900: Fix high CPU deviation issues seen in metrics view URL: https://github.com/apache/cloudstack/pull/2075#issuecomment-298854263 Screenshots:   This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd opened a new pull request #2075: [4.9+] CLOUDSTACK-9900: Fix high CPU deviation issues seen in metrics view
rhtyd opened a new pull request #2075: [4.9+] CLOUDSTACK-9900: Fix high CPU deviation issues seen in metrics view URL: https://github.com/apache/cloudstack/pull/2075 HostStats returns cpu usage in percentage while memory usage in bytes. This fixes a regression in maximum CPU usage deviation that did not assume the values to be in percentage and multiple the final ratios with 100 which leads to 100x the actual deviation value. Pinging for review - @karuturi @DaanHoogland @abhinandanprateek @borisstoyanov @rashmidixit @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
