[cloudstack-primate] branch master updated: infra: reusable dedicated domain component (#113)

2020-01-22 Thread rohit
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git


The following commit(s) were added to refs/heads/master by this push:
 new bfc2d7e  infra: reusable dedicated domain component (#113)
bfc2d7e is described below

commit bfc2d7e8022f1967094ccf44c9ae7e4c4f455425
Author: Ritchie Vincent 
AuthorDate: Wed Jan 22 08:05:04 2020 +

infra: reusable dedicated domain component (#113)

Adds dedicated section for zone/pod/cluster/host to dedicate that resource 
to a domain (and account). Implements the list, dedicate and release APIs.

Signed-off-by: Rohit Yadav 
Co-authored-by: Rohit Yadav 
---
 src/components/view/DedicateData.vue   | 331 +
 src/components/view/DedicateDomain.vue | 145 +++
 src/components/view/DedicateModal.vue  | 286 
 src/components/view/DetailsTab.vue |  20 ++
 src/config/section/infra/clusters.js   |  26 ---
 src/config/section/infra/hosts.js  |  26 ---
 src/config/section/infra/pods.js   |  26 ---
 src/config/section/infra/zones.js  |  26 ---
 8 files changed, 782 insertions(+), 104 deletions(-)

diff --git a/src/components/view/DedicateData.vue 
b/src/components/view/DedicateData.vue
new file mode 100644
index 000..63954b1
--- /dev/null
+++ b/src/components/view/DedicateData.vue
@@ -0,0 +1,331 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+
+  
+
+  
+
+  
+{{ $t('dedicated') }}
+Yes
+  
+  
+{{ $t('domainid') }}
+{{ 
dedicatedDomainId }}
+  
+  
+{{ $t('account') }}
+{{ 
dedicatedAccountId }}
+  
+  
+{{ releaseButtonLabel }}
+  
+
+  
+  
+
+  {{ $t('dedicated') }}
+  No
+  
+{{ dedicatedButtonLabel }}
+  
+
+  
+
+
+  
+
+
+
+import { api } from '@/api'
+import DedicateModal from './DedicateModal'
+
+export default {
+  props: {
+resource: {
+  type: Object,
+  required: true
+}
+  },
+  components: {
+DedicateModal
+  },
+  inject: ['parentFetchData'],
+  data () {
+return {
+  modalActive: false,
+  dedicatedButtonLabel: 'Dedicate',
+  releaseButtonLabel: 'Release',
+  dedicatedModalLabel: 'Dedicate',
+  dedicatedDomainId: null,
+  dedicatedAccountId: null
+}
+  },
+  watch: {
+resource (newItem, oldItem) {
+  if (this.resource && this.resource.id && newItem && newItem.id !== 
oldItem.id) {
+this.fetchData()
+  }
+}
+  },
+  methods: {
+fetchData () {
+  if (this.$route.meta.name === 'zone') {
+this.fetchDedicatedZones()
+this.releaseButtonLabel = this.$t('label.release.dedicated.zone')
+this.dedicatedButtonLabel = this.$t('label.dedicate.zone')
+this.dedicatedModalLabel = this.$t('label.dedicate.zone')
+  }
+  if (this.$route.meta.name === 'pod') {
+this.fetchDedicatedPods()
+this.releaseButtonLabel = this.$t('label.release.dedicated.pod')
+this.dedicatedButtonLabel = this.$t('label.dedicate.pod')
+this.dedicatedModalLabel = this.$t('label.dedicate.pod')
+  }
+  if (this.$route.meta.name === 'cluster') {
+this.fetchDedicatedClusters()
+this.releaseButtonLabel = this.$t('label.release.dedicated.cluster')
+this.dedicatedButtonLabel = this.$t('label.dedicate.cluster')
+this.dedicatedModalLabel = this.$t('label.dedicate.cluster')
+  }
+  if (this.$route.meta.name === 'host') {
+this.fetchDedicatedHosts()
+this.releaseButtonLabel = this.$t('label.release.dedicated.host')
+this.dedicatedButtonLabel = this.$t('label.dedicate.host')
+this.dedicatedModalLabel = this.$t('label.dedicate.host')
+  }
+},
+fetchDedicatedZones () {
+  api('listDedicatedZones', {
+zoneid: this.resource.id
+  }).then(response => {
+if (response.listdedicatedzonesresponse.dedicatedzone &&
+   

[GitHub] [cloudstack] blueorangutan commented on issue #3748: [WIP DO NOT MERGE] Systemvm template api

2020-01-22 Thread GitBox
blueorangutan commented on issue #3748: [WIP DO NOT MERGE] Systemvm template api
URL: https://github.com/apache/cloudstack/pull/3748#issuecomment-577067449
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] borisstoyanov commented on issue #3748: [WIP DO NOT MERGE] Systemvm template api

2020-01-22 Thread GitBox
borisstoyanov commented on issue #3748: [WIP DO NOT MERGE] Systemvm template api
URL: https://github.com/apache/cloudstack/pull/3748#issuecomment-577067263
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[cloudstack-primate] branch master updated: infraa: add secondary storage form (#121)

2020-01-22 Thread rohit
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git


The following commit(s) were added to refs/heads/master by this push:
 new cb2be30  infraa: add secondary storage form (#121)
cb2be30 is described below

commit cb2be303e25085623e8b19b2dbfe22c8c70bff10
Author: Pearl Dsilva 
AuthorDate: Wed Jan 22 14:11:50 2020 +0530

infraa: add secondary storage form (#121)

This implements the add secondary storage form

Signed-off-by: Rohit Yadav 
Co-authored-by: Rohit Yadav 
---
 src/config/section/infra/secondaryStorages.js |   3 +-
 src/views/infra/AddSecondaryStorage.vue   | 314 ++
 2 files changed, 316 insertions(+), 1 deletion(-)

diff --git a/src/config/section/infra/secondaryStorages.js 
b/src/config/section/infra/secondaryStorages.js
index 0deea35..ffd8245 100644
--- a/src/config/section/infra/secondaryStorages.js
+++ b/src/config/section/infra/secondaryStorages.js
@@ -35,7 +35,8 @@ export default {
   icon: 'plus',
   label: 'label.add.secondary.storage',
   listView: true,
-  args: ['name', 'provider', 'zoneid', 'url', 'details']
+  popup: true,
+  component: () => import('@/views/infra/AddSecondaryStorage.vue')
 },
 {
   api: 'deleteImageStore',
diff --git a/src/views/infra/AddSecondaryStorage.vue 
b/src/views/infra/AddSecondaryStorage.vue
new file mode 100644
index 000..6a97dd6
--- /dev/null
+++ b/src/views/infra/AddSecondaryStorage.vue
@@ -0,0 +1,314 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+
+  
+
+  
+
+  
+
+
+  
+{{ prov }}
+  
+
+
+  
+
+  {{ zone.name }}
+
+  
+  
+
+  
+  
+
+  
+
+
+  
+
+  
+  
+
+  
+  
+
+  
+
+
+  
+
+  
+  
+
+  
+  
+
+  
+  
+
+  
+  
+
+  
+
+
+  {{ $t('Cancel') }}
+  {{ $t('OK') 
}}
+
+  
+
+  
+
+
+import { api } from '@/api'
+
+export default {
+  name: 'AddSecondryStorage',
+  props: {
+resource: {
+  type: Object,
+  required: true
+}
+  },
+  inject: ['parentFetchData'],
+  data () {
+return {
+  providers: ['NFS', 'SMB/CIFS', 'Swift'],
+  provider: '',
+  zones: [],
+  zoneSelected: '',
+  loading: false
+}
+  },
+  beforeCreate () {
+this.form = this.$form.createForm(this)
+  },
+  mounted () {
+this.fetchData()
+  },
+  methods: {
+fetchData () {
+  this.listZones()
+},
+closeModal () {
+  this.$parent.$parent.close()
+},
+listZones () {
+  api('listZones').then(json => {
+if (json && json.listzonesresponse && json.listzonesresponse.zone) {
+  this.zones = json.listzonesresponse.zone
+  if (this.zones.length > 0) {
+this.zoneSelected = this.zones[0].name
+  }
+}
+  })
+},
+nfsURL (server, path) {
+  var url
+  if (path.substring(0, 1) !== '/') {
+path = '/' + path
+  }
+  if (server.indexOf('://') === -1) {
+url = 'nfs://' + server + path
+  } else {
+url = server + path
+  }
+  return url
+},
+smbURL (server, path, smbUsername, smbPassword, smbDomain) {
+  var url = ''
+  if (path.substring(0, 1) !== '/') {
+path = '/' + path
+  }
+  if (server.indexOf('://') === -1) {
+url += 'cifs://'
+  }
+  url += (server + path)
+  return url
+},
+handleSubmit (e) {
+  e.preventDefault()
+  this.form.validateFields((err, values) => {
+if (err) {
+  return
+}
+
+var data = {
+  name: values.name
+}
+var url = ''
+var provider = values.provider
+if (provider === 'NFS')

[GitHub] [cloudstack] blueorangutan commented on issue #3748: [WIP DO NOT MERGE] Systemvm template api

2020-01-22 Thread GitBox
blueorangutan commented on issue #3748: [WIP DO NOT MERGE] Systemvm template api
URL: https://github.com/apache/cloudstack/pull/3748#issuecomment-577075712
 
 
   Packaging result: ✖centos6 ✔centos7 ✔debian. JID-647


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland closed pull request #3828: [WIP DO NOT MERGE] [KVM] Direct download agnostic of the storage provider

2020-01-22 Thread GitBox
DaanHoogland closed pull request #3828: [WIP DO NOT MERGE] [KVM] Direct 
download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] nvazquez opened a new pull request #3828: [WIP DO NOT MERGE] [KVM] Direct download agnostic of the storage provider

2020-01-22 Thread GitBox
nvazquez opened a new pull request #3828: [WIP DO NOT MERGE] [KVM] Direct 
download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828
 
 
   ## Description
   This FR proposes the extension of the direct download support to primary 
storage pools using the most commonly used protocols/storage types:
   - NFS – already supported
   - Local storage
   - SharedMountpoint
   
   Other storage providers support can be extended in future by interface 
implementation on the KVM storage provider depending on the storage adaptor.
   
   The KVM storage processor is extended to achieve the direct template 
downloads in a storage agnostic way, including the supported storage providers 
implementations and allowing future implementations for different storage 
providers:
   - A new check of the available free space on the downloading host local 
storage is added before attempting to download a template. As on registration, 
a CheckUrlCommand is sent to a random KVM host, this host performs a HEAD 
command to the template URL. In case the server provides the remote file size 
of the template, this size is passed as part of the DirectDownloadCommand and 
used to check against the available free space.
   - The template file is downloaded to a scratch space in the local storage 
system within the host. This location can be explicitly set by the 
administrator via agent.properties file on the property: 
`direct.download.temporary.download.location`, and in case it is not set the 
default location `var/lib/libvirt/images/direct-download` is used.
   - After the template file is downloaded to the scratch space location, it is 
extracted (or copied) to the primary storage pool selected by the CloudStack 
planner.
   - The implementation of the extract/copy method is extended to invoke the 
different StorageAdaptors implementations for different storage providers. 
These implementations include local storage, shared mount point and NFS in the 
scope of this PR.
   - After the template is extracted/copied to the destination storage pool, 
the downloaded file is removed from the scratch space location in the host.
   
   ## Types of changes
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   Ubuntu based management server
   Test zone with local storage for user VMs enabled
   2 x CentOS7 based KVM hosts
   1 NFS storage pool
   1 Shared mount point across the 2 hosts


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3828: [WIP DO NOT MERGE] [KVM] Direct download agnostic of the storage provider

2020-01-22 Thread GitBox
DaanHoogland commented on a change in pull request #3828: [WIP DO NOT MERGE] 
[KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#discussion_r369455351
 
 

 ##
 File path: 
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java
 ##
 @@ -1693,38 +1696,77 @@ private DirectTemplateDownloader 
getDirectTemplateDownloaderFromCommand(DirectDo
 @Override
 public Answer handleDownloadTemplateToPrimaryStorage(DirectDownloadCommand 
cmd) {
 final PrimaryDataStoreTO pool = cmd.getDestPool();
-if (!pool.getPoolType().equals(StoragePoolType.NetworkFilesystem)) {
-return new DirectDownloadAnswer(false, "Unsupported pool type " + 
pool.getPoolType().toString(), true);
-}
-KVMStoragePool destPool = 
storagePoolMgr.getStoragePool(pool.getPoolType(), pool.getUuid());
 DirectTemplateDownloader downloader;
+KVMPhysicalDisk template;
 
 try {
-downloader = getDirectTemplateDownloaderFromCommand(cmd, destPool);
-} catch (IllegalArgumentException e) {
-return new DirectDownloadAnswer(false, "Unable to create direct 
downloader: " + e.getMessage(), true);
-}
+s_logger.info("Verifying temporary location for downloading the 
template exists on the host");
+String temporaryDownloadPath = 
resource.getDirectDownloadTemporaryDownloadPath();
+if (!isLocationAccessible(temporaryDownloadPath)) {
+String msg = "The temporary location path for downloading 
templates does not exist: " +
+temporaryDownloadPath + " on this host";
+s_logger.error(msg);
+return new DirectDownloadAnswer(false, msg, true);
+}
 
-try {
+s_logger.info("Checking for free space on the host for downloading 
the template");
+if 
(!isEnoughSpaceForDownloadTemplateOnTemporaryLocation(cmd.getTemplateSize())) {
+String msg = "Not enough space on the defined temporary 
location to download the template " + cmd.getTemplateId();
+s_logger.error(msg);
+return new DirectDownloadAnswer(false, msg, true);
+}
+
+KVMStoragePool destPool = 
storagePoolMgr.getStoragePool(pool.getPoolType(), pool.getUuid());
+downloader = getDirectTemplateDownloaderFromCommand(cmd, destPool, 
temporaryDownloadPath);
 s_logger.info("Trying to download template");
 
 Review comment:
   maybe change this one to debug as well, or move and add the resulting path 
to the message


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3828: [WIP DO NOT MERGE] [KVM] Direct download agnostic of the storage provider

2020-01-22 Thread GitBox
DaanHoogland commented on a change in pull request #3828: [WIP DO NOT MERGE] 
[KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#discussion_r369454279
 
 

 ##
 File path: 
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java
 ##
 @@ -1693,38 +1696,77 @@ private DirectTemplateDownloader 
getDirectTemplateDownloaderFromCommand(DirectDo
 @Override
 public Answer handleDownloadTemplateToPrimaryStorage(DirectDownloadCommand 
cmd) {
 final PrimaryDataStoreTO pool = cmd.getDestPool();
-if (!pool.getPoolType().equals(StoragePoolType.NetworkFilesystem)) {
-return new DirectDownloadAnswer(false, "Unsupported pool type " + 
pool.getPoolType().toString(), true);
-}
-KVMStoragePool destPool = 
storagePoolMgr.getStoragePool(pool.getPoolType(), pool.getUuid());
 DirectTemplateDownloader downloader;
+KVMPhysicalDisk template;
 
 try {
-downloader = getDirectTemplateDownloaderFromCommand(cmd, destPool);
-} catch (IllegalArgumentException e) {
-return new DirectDownloadAnswer(false, "Unable to create direct 
downloader: " + e.getMessage(), true);
-}
+s_logger.info("Verifying temporary location for downloading the 
template exists on the host");
 
 Review comment:
   seems like a debug message to me. Why does the operator want to see this?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3828: [WIP DO NOT MERGE] [KVM] Direct download agnostic of the storage provider

2020-01-22 Thread GitBox
DaanHoogland commented on a change in pull request #3828: [WIP DO NOT MERGE] 
[KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#discussion_r369455650
 
 

 ##
 File path: 
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java
 ##
 @@ -1693,38 +1696,77 @@ private DirectTemplateDownloader 
getDirectTemplateDownloaderFromCommand(DirectDo
 @Override
 public Answer handleDownloadTemplateToPrimaryStorage(DirectDownloadCommand 
cmd) {
 final PrimaryDataStoreTO pool = cmd.getDestPool();
-if (!pool.getPoolType().equals(StoragePoolType.NetworkFilesystem)) {
-return new DirectDownloadAnswer(false, "Unsupported pool type " + 
pool.getPoolType().toString(), true);
-}
-KVMStoragePool destPool = 
storagePoolMgr.getStoragePool(pool.getPoolType(), pool.getUuid());
 DirectTemplateDownloader downloader;
+KVMPhysicalDisk template;
 
 try {
-downloader = getDirectTemplateDownloaderFromCommand(cmd, destPool);
-} catch (IllegalArgumentException e) {
-return new DirectDownloadAnswer(false, "Unable to create direct 
downloader: " + e.getMessage(), true);
-}
+s_logger.info("Verifying temporary location for downloading the 
template exists on the host");
+String temporaryDownloadPath = 
resource.getDirectDownloadTemporaryDownloadPath();
+if (!isLocationAccessible(temporaryDownloadPath)) {
+String msg = "The temporary location path for downloading 
templates does not exist: " +
+temporaryDownloadPath + " on this host";
+s_logger.error(msg);
+return new DirectDownloadAnswer(false, msg, true);
+}
 
-try {
+s_logger.info("Checking for free space on the host for downloading 
the template");
+if 
(!isEnoughSpaceForDownloadTemplateOnTemporaryLocation(cmd.getTemplateSize())) {
+String msg = "Not enough space on the defined temporary 
location to download the template " + cmd.getTemplateId();
+s_logger.error(msg);
+return new DirectDownloadAnswer(false, msg, true);
+}
+
+KVMStoragePool destPool = 
storagePoolMgr.getStoragePool(pool.getPoolType(), pool.getUuid());
+downloader = getDirectTemplateDownloaderFromCommand(cmd, destPool, 
temporaryDownloadPath);
 s_logger.info("Trying to download template");
-if (!downloader.downloadTemplate()) {
+Pair result = downloader.downloadTemplate();
+if (!result.first()) {
 s_logger.warn("Couldn't download template");
 return new DirectDownloadAnswer(false, "Unable to download 
template", true);
 }
+String tempFilePath = result.second();
 if (!downloader.validateChecksum()) {
 s_logger.warn("Couldn't validate template checksum");
 return new DirectDownloadAnswer(false, "Checksum validation 
failed", false);
 }
-if (!downloader.extractAndInstallDownloadedTemplate()) {
-s_logger.warn("Couldn't extract and install template");
-return new DirectDownloadAnswer(false, "Extraction and 
installation failed", false);
-}
+template = 
storagePoolMgr.createPhysicalDiskFromDirectDownloadTemplate(tempFilePath, 
destPool, 100);
 } catch (CloudRuntimeException e) {
 s_logger.warn("Error downloading template " + cmd.getTemplateId() 
+ " due to: " + e.getMessage());
 return new DirectDownloadAnswer(false, "Unable to download 
template: " + e.getMessage(), true);
+} catch (IllegalArgumentException e) {
+return new DirectDownloadAnswer(false, "Unable to create direct 
downloader: " + e.getMessage(), true);
 }
 
-DirectTemplateInformation info = downloader.getTemplateInformation();
-return new DirectDownloadAnswer(true, info.getSize(), 
info.getInstallPath());
+return new DirectDownloadAnswer(true, template.getSize(), 
template.getName());
+}
+
+/**
+ * True if location exists
+ */
+private boolean isLocationAccessible(String temporaryDownloadPath) {
+File dir = new File(temporaryDownloadPath);
+return dir.exists();
+}
+
+/**
+ * Perform a free space check on the host for downloading the direct 
download templates
+ * @param templateSize template size obtained from remote server when 
registering the template (in bytes)
+ */
+protected boolean isEnoughSpaceForDownloadTemplateOnTemporaryLocation(Long 
templateSize) {
+if (templateSize == null || templateSize == 0L) {
+s_logger.info("The server did not provide the template size, 
assuming there is enough space to download it");
 
 Review

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3828: [WIP DO NOT MERGE] [KVM] Direct download agnostic of the storage provider

2020-01-22 Thread GitBox
DaanHoogland commented on a change in pull request #3828: [WIP DO NOT MERGE] 
[KVM] Direct download agnostic of the storage provider
URL: https://github.com/apache/cloudstack/pull/3828#discussion_r369454964
 
 

 ##
 File path: 
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java
 ##
 @@ -1693,38 +1696,77 @@ private DirectTemplateDownloader 
getDirectTemplateDownloaderFromCommand(DirectDo
 @Override
 public Answer handleDownloadTemplateToPrimaryStorage(DirectDownloadCommand 
cmd) {
 final PrimaryDataStoreTO pool = cmd.getDestPool();
-if (!pool.getPoolType().equals(StoragePoolType.NetworkFilesystem)) {
-return new DirectDownloadAnswer(false, "Unsupported pool type " + 
pool.getPoolType().toString(), true);
-}
-KVMStoragePool destPool = 
storagePoolMgr.getStoragePool(pool.getPoolType(), pool.getUuid());
 DirectTemplateDownloader downloader;
+KVMPhysicalDisk template;
 
 try {
-downloader = getDirectTemplateDownloaderFromCommand(cmd, destPool);
-} catch (IllegalArgumentException e) {
-return new DirectDownloadAnswer(false, "Unable to create direct 
downloader: " + e.getMessage(), true);
-}
+s_logger.info("Verifying temporary location for downloading the 
template exists on the host");
+String temporaryDownloadPath = 
resource.getDirectDownloadTemporaryDownloadPath();
+if (!isLocationAccessible(temporaryDownloadPath)) {
+String msg = "The temporary location path for downloading 
templates does not exist: " +
+temporaryDownloadPath + " on this host";
+s_logger.error(msg);
+return new DirectDownloadAnswer(false, msg, true);
+}
 
-try {
+s_logger.info("Checking for free space on the host for downloading 
the template");
 
 Review comment:
   in this case i would say that if the operator wants info it would be the 
actual size found and not an announcement that it is going to be calculated. 
also seems debug to me.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] svenvogel commented on issue #3824: clarify the usage of vlanipranges

2020-01-22 Thread GitBox
svenvogel commented on issue #3824: clarify the usage of vlanipranges
URL: https://github.com/apache/cloudstack/issues/3824#issuecomment-577108851
 
 
   @weizhouapache yes i think so. for my understanding it should not use the 
systemvm ips in the other domain public ip assignment. i detected if DOMAINX is 
out of addresses it uses the ROOT ips which are only for systemvm. i think this 
should not happen.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] nvazquez commented on issue #3828: [KVM] Direct download agnostic of the storage provider

2020-01-22 Thread GitBox
nvazquez commented on issue #3828: [KVM] Direct download agnostic of the 
storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-577113629
 
 
   Thanks @DaanHoogland, comments are sorted out using your suggestions
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3828: [KVM] Direct download agnostic of the storage provider

2020-01-22 Thread GitBox
blueorangutan commented on issue #3828: [KVM] Direct download agnostic of the 
storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-577113698
 
 
   @nvazquez a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[cloudstack-primate] branch master updated (cb2be30 -> 6de301e)

2020-01-22 Thread rohit
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git.


from cb2be30  infraa: add secondary storage form (#121)
 add 6de301e  infra: host config tab

No new revisions were added by this update.

Summary of changes:
 docs/api/apis.remaining   |   5 --
 src/config/section/compute.js |   3 +-
 src/config/section/infra/hosts.js |  16 +++-
 src/locales/en.json   |   2 +-
 src/views/AutogenView.vue |   3 +
 src/views/infra/HostInfoTab.vue   | 152 ++
 6 files changed, 171 insertions(+), 10 deletions(-)
 create mode 100644 src/views/infra/HostInfoTab.vue



[GitHub] [cloudstack] blueorangutan commented on issue #3828: [KVM] Direct download agnostic of the storage provider

2020-01-22 Thread GitBox
blueorangutan commented on issue #3828: [KVM] Direct download agnostic of the 
storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-577121366
 
 
   Packaging result: ✖centos6 ✔centos7 ✔debian. JID-648


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] nvazquez commented on issue #3828: [KVM] Direct download agnostic of the storage provider

2020-01-22 Thread GitBox
nvazquez commented on issue #3828: [KVM] Direct download agnostic of the 
storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-577122692
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3828: [KVM] Direct download agnostic of the storage provider

2020-01-22 Thread GitBox
blueorangutan commented on issue #3828: [KVM] Direct download agnostic of the 
storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-577122776
 
 
   @nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes Service

2020-01-22 Thread GitBox
blueorangutan commented on issue #3680: [WIP: DO NOT MERGE] CloudStack 
Kubernetes Service
URL: https://github.com/apache/cloudstack/pull/3680#issuecomment-577128976
 
 
   Packaging result: ✖centos6 ✔centos7 ✔debian. JID-649


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[cloudstack-primate] branch master updated: infra: physical network, nsp and traffictypes support

2020-01-22 Thread rohit
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git


The following commit(s) were added to refs/heads/master by this push:
 new e0eaf8d  infra: physical network, nsp and traffictypes support
e0eaf8d is described below

commit e0eaf8d3e05b2de9fbac549a9e1fac31b0e3e4fd
Author: Rohit Yadav 
AuthorDate: Wed Jan 22 18:06:24 2020 +0530

infra: physical network, nsp and traffictypes support

Signed-off-by: Rohit Yadav 
---
 docs/api/apis.remaining|  6 --
 src/components/view/ListView.vue   |  3 +
 src/config/section/infra.js|  4 ++
 src/config/section/infra/nsp.js| 58 +++
 src/config/section/infra/phynetworks.js| 29 +++-
 .../infra/{phynetworks.js => traffictypes.js}  | 29 ++--
 .../infra/traffic/DedicatedVLANTab.vue}| 52 +++---
 .../infra/traffic/IpRangesTab.vue} | 52 +++---
 src/views/infra/traffic/NspTab.vue | 84 ++
 9 files changed, 287 insertions(+), 30 deletions(-)

diff --git a/docs/api/apis.remaining b/docs/api/apis.remaining
index ebcb174..9ba6b38 100644
--- a/docs/api/apis.remaining
+++ b/docs/api/apis.remaining
@@ -44,15 +44,12 @@ listInternalLoadBalancerVMs
 listLBHealthCheckPolicies
 listLoadBalancers
 listNetworkACLs
-listNetworkServiceProviders
 listPortableIpRanges
-listRegisteredServicePackages
 listStaticRoutes
 listStorageNetworkIpRange
 listStorageProviders
 listStorageTags
 listSupportedNetworkServices
-listTrafficTypes
 listVirtualRouterElements
 listVlanIpRanges
 listVmwareDcs
@@ -64,6 +61,3 @@ startInternalLoadBalancerVM
 stopInternalLoadBalancerVM
 updateNetworkACLItem
 updateNetworkACLList
-updateNetworkServiceProvider
-updatePhysicalNetwork
-updateTrafficType
diff --git a/src/components/view/ListView.vue b/src/components/view/ListView.vue
index c4f7d22..018d588 100644
--- a/src/components/view/ListView.vue
+++ b/src/components/view/ListView.vue
@@ -85,6 +85,9 @@
 
   {{ text 
}}
 
+
+  {{ text }}
+
 
   {{ text 
}}
 
diff --git a/src/config/section/infra.js b/src/config/section/infra.js
index e89e67a..eb000d0 100644
--- a/src/config/section/infra.js
+++ b/src/config/section/infra.js
@@ -17,6 +17,8 @@
 
 import zones from '@/config/section/infra/zones'
 import phynetworks from '@/config/section/infra/phynetworks'
+import traffictypes from '@/config/section/infra/traffictypes'
+import nsp from '@/config/section/infra/nsp'
 import pods from '@/config/section/infra/pods'
 import clusters from '@/config/section/infra/clusters'
 import hosts from '@/config/section/infra/hosts'
@@ -40,6 +42,8 @@ export default {
 },
 zones,
 phynetworks,
+traffictypes,
+nsp,
 pods,
 clusters,
 hosts,
diff --git a/src/config/section/infra/nsp.js b/src/config/section/infra/nsp.js
new file mode 100644
index 000..7cc2860
--- /dev/null
+++ b/src/config/section/infra/nsp.js
@@ -0,0 +1,58 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+export default {
+  name: 'nsp',
+  title: 'Network Service Providers',
+  icon: 'compass',
+  hidden: true,
+  permission: ['listNetworkServiceProviders'],
+  columns: ['name', 'state', 'physicalnetworkid'],
+  details: ['name', 'state', 'servicelist', 'canenableindividualservice', 
'physicalnetworkid'],
+  tabs: [{
+name: 'details',
+component: () => import('@/components/view/DetailsTab.vue')
+  }],
+  actions: [
+{
+  api: 'updateNetworkServiceProvider',
+  icon: 'stop',
+  label: 'Disable Provider',
+  dataView: true,
+  args: ['state'],
+  show: (record) => { return record.state === 'Enabled' },
+  mapping: {
+state: {
+  value: (record) => { return 'Disabled' }
+}
+  }
+},
+{
+  api: 'updateNetworkServiceProvider',
+  icon: 'right-circle',
+  label: 'Enable Provider',
+  dataView: true,
+  args: ['state'],
+  show: (record) => { return record.state === 'Disabled' },
+  mapping: {
+state: {
+  

[GitHub] [cloudstack] blueorangutan commented on issue #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes Service

2020-01-22 Thread GitBox
blueorangutan commented on issue #3680: [WIP: DO NOT MERGE] CloudStack 
Kubernetes Service
URL: https://github.com/apache/cloudstack/pull/3680#issuecomment-577164217
 
 
   Packaging result: ✖centos6 ✔centos7 ✔debian. JID-650


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] weizhouapache commented on issue #3694: Ldap fixes

2020-01-22 Thread GitBox
weizhouapache commented on issue #3694: Ldap fixes
URL: https://github.com/apache/cloudstack/pull/3694#issuecomment-577169915
 
 
   @DaanHoogland @borisstoyanov @nvazquez 
   I got an exception when I build the project using "mvn -P developer,systemvm 
clean install"
   
   ```
   [INFO] Results:
   [INFO]
   [ERROR] Errors:
   [ERROR]   LdapUnboundidZapdotConnectionTest.testContext:85 » Communication 
localhost:432...
   [ERROR]   LdapUnboundidZapdotConnectionTest.testDirContext:74 » 
Communication localhost:...
   [INFO]
   [ERROR] Tests run: 48, Failures: 0, Errors: 2, Skipped: 0
   ```
   
   surefire-reports
   ```
   
---
   Test set: org.apache.cloudstack.ldap.LdapUnboundidZapdotConnectionTest
   
---
   Tests run: 4, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 0.818 s <<< 
FAILURE! - in org.apache.cloudstack.ldap.LdapUnboundidZapdotConnectionTest
   testDirContext(org.apache.cloudstack.ldap.LdapUnboundidZapdotConnectionTest) 
 Time elapsed: 0.031 s  <<< ERROR!
   javax.naming.CommunicationException: localhost:42689
   at 
org.apache.cloudstack.ldap.LdapUnboundidZapdotConnectionTest.testDirContext(LdapUnboundidZapdotConnectionTest.java:74)
   Caused by: java.net.ConnectException: Connection refused (Connection refused)
   at 
org.apache.cloudstack.ldap.LdapUnboundidZapdotConnectionTest.testDirContext(LdapUnboundidZapdotConnectionTest.java:74)
   
   testContext(org.apache.cloudstack.ldap.LdapUnboundidZapdotConnectionTest)  
Time elapsed: 0.007 s  <<< ERROR!
   javax.naming.CommunicationException: localhost:43205
   at 
org.apache.cloudstack.ldap.LdapUnboundidZapdotConnectionTest.testContext(LdapUnboundidZapdotConnectionTest.java:85)
   Caused by: java.net.ConnectException: Connection refused (Connection refused)
   at 
org.apache.cloudstack.ldap.LdapUnboundidZapdotConnectionTest.testContext(LdapUnboundidZapdotConnectionTest.java:85)
   
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] weizhouapache commented on issue #3824: clarify the usage of vlanipranges

2020-01-22 Thread GitBox
weizhouapache commented on issue #3824: clarify the usage of vlanipranges
URL: https://github.com/apache/cloudstack/issues/3824#issuecomment-577174636
 
 
   @svenvogel agrees. so what you said should be a bug


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] weizhouapache edited a comment on issue #3824: clarify the usage of vlanipranges

2020-01-22 Thread GitBox
weizhouapache edited a comment on issue #3824: clarify the usage of vlanipranges
URL: https://github.com/apache/cloudstack/issues/3824#issuecomment-577174636
 
 
   @svenvogel agrees.
   is system.vm.public.ip.reservation.mode.strictness set to false in your 
global setting ?
   change it to true and have a try ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland commented on issue #3694: Ldap fixes

2020-01-22 Thread GitBox
DaanHoogland commented on issue #3694: Ldap fixes
URL: https://github.com/apache/cloudstack/pull/3694#issuecomment-577187450
 
 
   Auch, @weizhouapache let me get into that. I built it using mvn -P developer 
clean install, I don't think that should matter. Can you give me your platform?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland edited a comment on issue #3694: Ldap fixes

2020-01-22 Thread GitBox
DaanHoogland edited a comment on issue #3694: Ldap fixes
URL: https://github.com/apache/cloudstack/pull/3694#issuecomment-577187450
 
 
   Auch, @weizhouapache let me get into that. I built it using mvn -D developer 
clean install, I don't think that should matter. Can you give me your platform?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] weizhouapache commented on issue #3694: Ldap fixes

2020-01-22 Thread GitBox
weizhouapache commented on issue #3694: Ldap fixes
URL: https://github.com/apache/cloudstack/pull/3694#issuecomment-577190695
 
 
   > Auch, @weizhouapache let me get into that. I built it using mvn -P 
developer clean install, I don't think that should matter. Can you give me your 
platform?
   
   @DaanHoogland I use ubuntu 16.04 with openjdk 1.8.0_121
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] borisstoyanov commented on issue #3748: [WIP DO NOT MERGE] Systemvm template api

2020-01-22 Thread GitBox
borisstoyanov commented on issue #3748: [WIP DO NOT MERGE] Systemvm template api
URL: https://github.com/apache/cloudstack/pull/3748#issuecomment-577201042
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3748: [WIP DO NOT MERGE] Systemvm template api

2020-01-22 Thread GitBox
blueorangutan commented on issue #3748: [WIP DO NOT MERGE] Systemvm template api
URL: https://github.com/apache/cloudstack/pull/3748#issuecomment-577201396
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3748: [WIP DO NOT MERGE] Systemvm template api

2020-01-22 Thread GitBox
blueorangutan commented on issue #3748: [WIP DO NOT MERGE] Systemvm template api
URL: https://github.com/apache/cloudstack/pull/3748#issuecomment-577210210
 
 
   Packaging result: ✖centos6 ✔centos7 ✔debian. JID-651


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland commented on issue #3694: Ldap fixes

2020-01-22 Thread GitBox
DaanHoogland commented on issue #3694: Ldap fixes
URL: https://github.com/apache/cloudstack/pull/3694#issuecomment-577222421
 
 
   @weizhouapache i just ran `mvn -P developer -Ddeveloper clean install` and 
it ran fine. It is on macos however. Let spin up a ubuntu to try and reproduce.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DennisKonrad commented on issue #3759: server: fix resource count error when upgrade a vm

2020-01-22 Thread GitBox
DennisKonrad commented on issue #3759: server: fix resource count error when 
upgrade a vm
URL: https://github.com/apache/cloudstack/pull/3759#issuecomment-577230937
 
 
   @ustcweizhou I tried to recreate the bug with current master in a 
testenvironment. Are the any Domains, Projects or something else involved?
   
   Just creating another user with an vm and increasing the VM ressources with 
admin did not show the bug.
   I checked the resourcecount via api with
   `update resourcecount domainid=x account=testuser`
   and it showed the right counts.
   
   If I can recreate the bug I can review your PR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] nvazquez commented on issue #3694: Ldap fixes

2020-01-22 Thread GitBox
nvazquez commented on issue #3694: Ldap fixes
URL: https://github.com/apache/cloudstack/pull/3694#issuecomment-577236414
 
 
   Hi @weizhouapache, I could build properly on Ubuntu 19.10, using openjdk 
version "1.8.0_232"


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland commented on issue #3694: Ldap fixes

2020-01-22 Thread GitBox
DaanHoogland commented on issue #3694: Ldap fixes
URL: https://github.com/apache/cloudstack/pull/3694#issuecomment-577244103
 
 
   Might it be a matter of MAVEN_OPTS @weizhouapache @nvazquez ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland commented on issue #3807: Enhancement: Allow creating network with duplicate name

2020-01-22 Thread GitBox
DaanHoogland commented on issue #3807: Enhancement: Allow creating network with 
duplicate name
URL: https://github.com/apache/cloudstack/pull/3807#issuecomment-577295600
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland removed a comment on issue #3807: Enhancement: Allow creating network with duplicate name

2020-01-22 Thread GitBox
DaanHoogland removed a comment on issue #3807: Enhancement: Allow creating 
network with duplicate name
URL: https://github.com/apache/cloudstack/pull/3807#issuecomment-574199200
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan removed a comment on issue #3807: Enhancement: Allow creating network with duplicate name

2020-01-22 Thread GitBox
blueorangutan removed a comment on issue #3807: Enhancement: Allow creating 
network with duplicate name
URL: https://github.com/apache/cloudstack/pull/3807#issuecomment-574213063
 
 
   Packaging result: ✖centos6 ✔centos7 ✔debian. JID-597


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3807: Enhancement: Allow creating network with duplicate name

2020-01-22 Thread GitBox
blueorangutan commented on issue #3807: Enhancement: Allow creating network 
with duplicate name
URL: https://github.com/apache/cloudstack/pull/3807#issuecomment-577295958
 
 
   @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan removed a comment on issue #3807: Enhancement: Allow creating network with duplicate name

2020-01-22 Thread GitBox
blueorangutan removed a comment on issue #3807: Enhancement: Allow creating 
network with duplicate name
URL: https://github.com/apache/cloudstack/pull/3807#issuecomment-574199427
 
 
   @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland commented on issue #3807: Enhancement: Allow creating network with duplicate name

2020-01-22 Thread GitBox
DaanHoogland commented on issue #3807: Enhancement: Allow creating network with 
duplicate name
URL: https://github.com/apache/cloudstack/pull/3807#issuecomment-577297215
 
 
   @ravening "pudding needs eating" so i am starting a full regression suite. 
(if it comes back good i'm fine with it.)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland commented on issue #3726: vrouter: reload haproxy when cfg file is updated

2020-01-22 Thread GitBox
DaanHoogland commented on issue #3726: vrouter: reload haproxy when cfg file is 
updated
URL: https://github.com/apache/cloudstack/pull/3726#issuecomment-577298309
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3727: server: Capacity check should take vms in Migrating state into calculation

2020-01-22 Thread GitBox
blueorangutan commented on issue #3727: server: Capacity check should take vms 
in Migrating state into calculation
URL: https://github.com/apache/cloudstack/pull/3727#issuecomment-577298999
 
 
   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan removed a comment on issue #3825: fixed inconsistency of IP on VR when VR is destroyed and recreated (shared network)

2020-01-22 Thread GitBox
blueorangutan removed a comment on issue #3825: fixed inconsistency of IP on VR 
when VR is destroyed and recreated (shared network)
URL: https://github.com/apache/cloudstack/pull/3825#issuecomment-576738007
 
 
   @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland commented on issue #3727: server: Capacity check should take vms in Migrating state into calculation

2020-01-22 Thread GitBox
DaanHoogland commented on issue #3727: server: Capacity check should take vms 
in Migrating state into calculation
URL: https://github.com/apache/cloudstack/pull/3727#issuecomment-577298813
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland commented on issue #3825: fixed inconsistency of IP on VR when VR is destroyed and recreated (shared network)

2020-01-22 Thread GitBox
DaanHoogland commented on issue #3825: fixed inconsistency of IP on VR when VR 
is destroyed and recreated (shared network)
URL: https://github.com/apache/cloudstack/pull/3825#issuecomment-577299165
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan removed a comment on issue #3825: fixed inconsistency of IP on VR when VR is destroyed and recreated (shared network)

2020-01-22 Thread GitBox
blueorangutan removed a comment on issue #3825: fixed inconsistency of IP on VR 
when VR is destroyed and recreated (shared network)
URL: https://github.com/apache/cloudstack/pull/3825#issuecomment-576784870
 
 
   Packaging result: ✖centos6 ✖centos7 ✖debian. JID-643


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3825: fixed inconsistency of IP on VR when VR is destroyed and recreated (shared network)

2020-01-22 Thread GitBox
blueorangutan commented on issue #3825: fixed inconsistency of IP on VR when VR 
is destroyed and recreated (shared network)
URL: https://github.com/apache/cloudstack/pull/3825#issuecomment-577299409
 
 
   @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland removed a comment on issue #3825: fixed inconsistency of IP on VR when VR is destroyed and recreated (shared network)

2020-01-22 Thread GitBox
DaanHoogland removed a comment on issue #3825: fixed inconsistency of IP on VR 
when VR is destroyed and recreated (shared network)
URL: https://github.com/apache/cloudstack/pull/3825#issuecomment-576737846
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland commented on issue #3759: server: fix resource count error when upgrade a vm

2020-01-22 Thread GitBox
DaanHoogland commented on issue #3759: server: fix resource count error when 
upgrade a vm
URL: https://github.com/apache/cloudstack/pull/3759#issuecomment-577300718
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3759: server: fix resource count error when upgrade a vm

2020-01-22 Thread GitBox
blueorangutan commented on issue #3759: server: fix resource count error when 
upgrade a vm
URL: https://github.com/apache/cloudstack/pull/3759#issuecomment-577300999
 
 
   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland commented on issue #3758: server: Fix NPE while update displayvm on vm with dynamic service offering

2020-01-22 Thread GitBox
DaanHoogland commented on issue #3758: server: Fix NPE while update displayvm 
on vm with dynamic service offering
URL: https://github.com/apache/cloudstack/pull/3758#issuecomment-577301379
 
 
   regression results spurious, @borisstoyanov @andrijapanicsb 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland commented on issue #3761: [FIX] [BACKPORT] [4.13] Rethrow takeVMSnapshot() exception

2020-01-22 Thread GitBox
DaanHoogland commented on issue #3761: [FIX] [BACKPORT] [4.13] Rethrow 
takeVMSnapshot() exception
URL: https://github.com/apache/cloudstack/pull/3761#issuecomment-577303034
 
 
   @onitake where do you see those errors?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland commented on issue #3761: [FIX] [BACKPORT] [4.13] Rethrow takeVMSnapshot() exception

2020-01-22 Thread GitBox
DaanHoogland commented on issue #3761: [FIX] [BACKPORT] [4.13] Rethrow 
takeVMSnapshot() exception
URL: https://github.com/apache/cloudstack/pull/3761#issuecomment-577303556
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3761: [FIX] [BACKPORT] [4.13] Rethrow takeVMSnapshot() exception

2020-01-22 Thread GitBox
blueorangutan commented on issue #3761: [FIX] [BACKPORT] [4.13] Rethrow 
takeVMSnapshot() exception
URL: https://github.com/apache/cloudstack/pull/3761#issuecomment-577303904
 
 
   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland commented on issue #3780: Enhancement: Allow creating atmost 1 physical network with null tag

2020-01-22 Thread GitBox
DaanHoogland commented on issue #3780: Enhancement: Allow creating atmost 1 
physical network with null tag
URL: https://github.com/apache/cloudstack/pull/3780#issuecomment-577305105
 
 
   @svenvogel I did not review because of the functional argument going on. I 
have no issue, myself.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3807: Enhancement: Allow creating network with duplicate name

2020-01-22 Thread GitBox
blueorangutan commented on issue #3807: Enhancement: Allow creating network 
with duplicate name
URL: https://github.com/apache/cloudstack/pull/3807#issuecomment-577305627
 
 
   Packaging result: ✖centos6 ✔centos7 ✔debian. JID-652


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3825: fixed inconsistency of IP on VR when VR is destroyed and recreated (shared network)

2020-01-22 Thread GitBox
blueorangutan commented on issue #3825: fixed inconsistency of IP on VR when VR 
is destroyed and recreated (shared network)
URL: https://github.com/apache/cloudstack/pull/3825#issuecomment-577305624
 
 
   Packaging result: ✖centos6 ✖centos7 ✖debian. JID-653


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland commented on issue #3807: Enhancement: Allow creating network with duplicate name

2020-01-22 Thread GitBox
DaanHoogland commented on issue #3807: Enhancement: Allow creating network with 
duplicate name
URL: https://github.com/apache/cloudstack/pull/3807#issuecomment-577313261
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3807: Enhancement: Allow creating network with duplicate name

2020-01-22 Thread GitBox
blueorangutan commented on issue #3807: Enhancement: Allow creating network 
with duplicate name
URL: https://github.com/apache/cloudstack/pull/3807#issuecomment-577313648
 
 
   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland commented on issue #3825: fixed inconsistency of IP on VR when VR is destroyed and recreated (shared network)

2020-01-22 Thread GitBox
DaanHoogland commented on issue #3825: fixed inconsistency of IP on VR when VR 
is destroyed and recreated (shared network)
URL: https://github.com/apache/cloudstack/pull/3825#issuecomment-577315901
 
 
   @Pearl1594 there is a checkstyle error. Can you check?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] Pearl1594 commented on issue #3825: fixed inconsistency of IP on VR when VR is destroyed and recreated (shared network)

2020-01-22 Thread GitBox
Pearl1594 commented on issue #3825: fixed inconsistency of IP on VR when VR is 
destroyed and recreated (shared network)
URL: https://github.com/apache/cloudstack/pull/3825#issuecomment-577322299
 
 
   @DaanHoogland Handled it


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] onitake commented on issue #3761: [FIX] [BACKPORT] [4.13] Rethrow takeVMSnapshot() exception

2020-01-22 Thread GitBox
onitake commented on issue #3761: [FIX] [BACKPORT] [4.13] Rethrow 
takeVMSnapshot() exception
URL: https://github.com/apache/cloudstack/pull/3761#issuecomment-577323778
 
 
   @DaanHoogland They were in the Travis build logs linked here, which was 
still in "failed" state yesterday. Looks like they were from a different branch 
or older build?
   Or maybe it was simply an intermittent failure.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] richardlawley opened a new issue #3829: Unable to schedule async job - dangling vm_work_job rows

2020-01-22 Thread GitBox
richardlawley opened a new issue #3829: Unable to schedule async job - dangling 
vm_work_job rows
URL: https://github.com/apache/cloudstack/issues/3829
 
 
   
   
   # ISSUE TYPE
   
* Bug Report
   
   # COMPONENT NAME
   
   ~~~
   Management Server
   ~~~
   
   # CLOUDSTACK VERSION
   
   
   ~~~
   4.11.2, appears unfixed in master
   ~~~
   
   # CONFIGURATION
   
   N/A
   
   # OS / ENVIRONMENT
   
   N/A
   
   # SUMMARY
   
   AsyncJobManager contains code to expunge async job records after a 
configurable time (24h default).  Some async jobs have corresponding 
vm_work_job entries, which are created using the generated key of async_job.  
The expunge code only removes the async_job record, leaving dangling 
vm_work_job rows.
   
   Because the supported version of mysql recalculates autonumber sequences 
based on the last current row, this can cause async jobs to be created with IDs 
referencing existing rows in vm_work_job, which causes a primary key violation 
if this clashes, showing the following log message:
   
   ```
   Unable to schedule async job for command com.cloud.vm.VmWorkStart, 
unexpected exception. 
   javax.persistence.EntityExistsException: Entity already exists
   ```
   
   The set of circumstances to trigger this is a bit obscure, which is probably 
why this has been mentioned on the mailing list a few times but never with any 
fix or explanation.  I believe the only fix required is to ensure that when 
jobs are purged from async_jobs, they are also purged from vm_work_job.
   
   For anyone else encountering this bug (hopefully the error text will be 
enough!), the workaround is to remove all vm_work_job rows above the current 
max async_job, i.e. 
   
   ```
   DELETE FROM vm_work_job WHERE id > (SELECT MAX(id) FROM async_job)
   ```
   
   # STEPS TO REPRODUCE
   
   
   * On a clean management server, run some VM jobs to ensure that vm_work_job 
rows are present.
   * Wait for `job.expire.minutes` so that mgmt server can clean out the 
async_jobs table
   * Observe that vm_work_job rows are still present
   * Restart mysql server (perhaps mgmt server too, unsure)
   * Try to start/stop VMs until the async_job id clashes with a vm_work_job 
row.
   
   
   
   # EXPECTED RESULTS
   
   
   VM should start/stop correctly
   
   # ACTUAL RESULTS
   
   
   Error Starting/Stopping VM, with log message as below:
   
   ```
   2020-01-22 09:40:28,492 WARN  [o.a.c.f.j.i.AsyncJobManagerImpl] 
(API-Job-Executor-13:ctx-e8081448 job-4920 ctx-ad7b892d) (logid:08136108) 
Unable to schedule async job for command com.cloud.vm.VmWorkStop, unexpected 
exception.
   javax.persistence.EntityExistsException: Entity already exists:
   at 
com.cloud.utils.db.GenericDaoBase.persist(GenericDaoBase.java:1434)
   at 
org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$1.doInTransaction(AsyncJobManagerImpl.java:235)
   at 
org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$1.doInTransaction(AsyncJobManagerImpl.java:231)
   at 
com.cloud.utils.db.Transaction$2.doInTransaction(Transaction.java:50)
   at com.cloud.utils.db.Transaction.execute(Transaction.java:40)
   at com.cloud.utils.db.Transaction.execute(Transaction.java:47)
   at 
org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl.submitAsyncJob(AsyncJobManagerImpl.java:231)
   at 
com.cloud.vm.VirtualMachineManagerImpl.stopVmThroughJobQueue(VirtualMachineManagerImpl.java:4505)
   at 
com.cloud.vm.VirtualMachineManagerImpl.advanceStop(VirtualMachineManagerImpl.java:1600)
   at 
com.cloud.vm.VirtualMachineManagerImpl.destroy(VirtualMachineManagerImpl.java:1882)
   at 
org.apache.cloudstack.engine.cloud.entity.api.VMEntityManagerImpl.destroyVirtualMachine(VMEntityManagerImpl.java:271)
   at 
org.apache.cloudstack.engine.cloud.entity.api.VirtualMachineEntityImpl.destroy(VirtualMachineEntityImpl.java:233)
   at 
com.cloud.vm.UserVmManagerImpl.destroyVm(UserVmManagerImpl.java:4534)
   at 
com.cloud.vm.UserVmManagerImpl.destroyVm(UserVmManagerImpl.java:2758)
   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
   at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
   at java.lang.reflect.Method.invoke(Method.java:498)
   at 
org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:338)
   at 
org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:197)
   at 
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163)
   at 
org.apache.cloudstack.network.contrail.management.EventUtils$EventInterceptor.invoke(EventUtils.java:107)
   at 
org.

[GitHub] [cloudstack] syed commented on issue #3819: Clean up inactive iscsi sessions when VMs get moved due to crashes

2020-01-22 Thread GitBox
syed commented on issue #3819: Clean up inactive iscsi sessions when VMs get 
moved due to crashes
URL: https://github.com/apache/cloudstack/pull/3819#issuecomment-577357293
 
 
   LGTM :+1: 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3828: [KVM] Direct download agnostic of the storage provider

2020-01-22 Thread GitBox
blueorangutan commented on issue #3828: [KVM] Direct download agnostic of the 
storage provider
URL: https://github.com/apache/cloudstack/pull/3828#issuecomment-577401062
 
 
   Trillian test result (tid-805)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 37512 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3828-t805-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_direct_download.py
   Intermittent failure detected: /marvin/tests/smoke/test_templates.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 76 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_deploy_vm_from_direct_download_template_nfs_storage | `Error` | 3.34 
| test_direct_download.py
   ContextSuite context=TestDirectDownloadTemplates>:teardown | `Error` | 2.23 
| test_direct_download.py
   test_02_upload_direct_download_certificates | `Failure` | 0.04 | 
test_direct_download.py
   test_02_deploy_vm_from_direct_download_template | `Error` | 38.35 | 
test_templates.py
   test_03_deploy_vm_wrong_checksum | `Error` | 10.61 | test_templates.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3761: [FIX] [BACKPORT] [4.13] Rethrow takeVMSnapshot() exception

2020-01-22 Thread GitBox
blueorangutan commented on issue #3761: [FIX] [BACKPORT] [4.13] Rethrow 
takeVMSnapshot() exception
URL: https://github.com/apache/cloudstack/pull/3761#issuecomment-577477504
 
 
   Trillian test result (tid-809)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 29643 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3761-t809-kvm-centos7.zip
   Smoke tests completed. 77 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3759: server: fix resource count error when upgrade a vm

2020-01-22 Thread GitBox
blueorangutan commented on issue #3759: server: fix resource count error when 
upgrade a vm
URL: https://github.com/apache/cloudstack/pull/3759#issuecomment-577480895
 
 
   Trillian test result (tid-808)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 30995 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3759-t808-kvm-centos7.zip
   Smoke tests completed. 77 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] donnydavis commented on issue #3179: Redundant VRouter guest network on wrong interface

2020-01-22 Thread GitBox
donnydavis commented on issue #3179: Redundant VRouter guest network on wrong 
interface
URL: https://github.com/apache/cloudstack/issues/3179#issuecomment-577484455
 
 
   This is still an issue for me. Non redundant routers work fine, redundant 
routers do not. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3807: Enhancement: Allow creating network with duplicate name

2020-01-22 Thread GitBox
blueorangutan commented on issue #3807: Enhancement: Allow creating network 
with duplicate name
URL: https://github.com/apache/cloudstack/pull/3807#issuecomment-577489239
 
 
   Trillian test result (tid-810)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 31865 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3807-t810-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 78 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes Service

2020-01-22 Thread GitBox
blueorangutan commented on issue #3680: [WIP: DO NOT MERGE] CloudStack 
Kubernetes Service
URL: https://github.com/apache/cloudstack/pull/3680#issuecomment-577491678
 
 
   @shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] shwstppr commented on issue #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes Service

2020-01-22 Thread GitBox
shwstppr commented on issue #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes 
Service
URL: https://github.com/apache/cloudstack/pull/3680#issuecomment-577491587
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3727: server: Capacity check should take vms in Migrating state into calculation

2020-01-22 Thread GitBox
blueorangutan commented on issue #3727: server: Capacity check should take vms 
in Migrating state into calculation
URL: https://github.com/apache/cloudstack/pull/3727#issuecomment-577510691
 
 
   Trillian test result (tid-807)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 40427 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3727-t807-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 76 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_04_rvpc_network_garbage_collector_nics | `Failure` | 325.05 | 
test_vpc_redundant.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] prashant2594 closed issue #3817: cloudstack 4.13v unable to start management server

2020-01-22 Thread GitBox
prashant2594 closed issue #3817: cloudstack 4.13v unable to start management 
server
URL: https://github.com/apache/cloudstack/issues/3817
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] prashant2594 opened a new issue #3830: Cloudstack 4.13 HA Issue

2020-01-22 Thread GitBox
prashant2594 opened a new issue #3830: Cloudstack 4.13 HA Issue 
URL: https://github.com/apache/cloudstack/issues/3830
 
 
   
   @rhtyd 
   @wido 
   # ISSUE TYPE
   
* Other
   
   # COMPONENT NAME
   
   ~~~
   KVM, HA,  ceph version 14.2.6 nautilus
   ~~~
   
   # CLOUDSTACK VERSION
   
   
   ~~~
   Cloudstack 4.13
   ~~~
   
   # CONFIGURATION
   
   
   
   # OS / ENVIRONMENT
   
   Centos 7
   
   # SUMMARY
   
   
   - I've installed coludstack 4.13 on ceph OSD nodes, and also added ceph as 
primary storage in cloudstack as RBD pool. Till here it works smoothly. 
   
   - Problem starts in HA phase, when I test HA, it fails.
   
   - VM doesn't migrate to other available management server.
   
   
   # STEPS TO REPRODUCE
   
   
   
   ~~~
   https://user-images.githubusercontent.com/44703864/72960869-426d2900-3dd5-11ea-8418-c79adf396e95.png";>
   
   ~~~
   
   
   
   # EXPECTED RESULTS
   
   
   ~~~
   VM should migrate to available management server.
   ~~~
   
   # ACTUAL RESULTS
   
   
   
   ~~~
   It is stuck and doesn't move to other server.
   
   https://user-images.githubusercontent.com/44703864/72960913-76484e80-3dd5-11ea-9ea8-95bab4924e93.png";>
   
   ~~~
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[cloudstack-primate] branch master updated (e0eaf8d -> d84559c)

2020-01-22 Thread rohit
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git.


from e0eaf8d  infra: physical network, nsp and traffictypes support
 add d84559c  infra: zone resource capacity tab (#128)

No new revisions were added by this update.

Summary of changes:
 src/config/section/infra/zones.js |   5 +-
 src/locales/en.json   |  22 +
 src/views/infra/ZoneResources.vue | 166 ++
 3 files changed, 192 insertions(+), 1 deletion(-)
 create mode 100644 src/views/infra/ZoneResources.vue



[cloudstack-primate] branch master updated (d84559c -> 224967b)

2020-01-22 Thread rohit
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git.


from d84559c  infra: zone resource capacity tab (#128)
 add 224967b  infra: fix a-progress warnings

No new revisions were added by this update.

Summary of changes:
 src/views/infra/ZoneResources.vue | 2 --
 1 file changed, 2 deletions(-)



[GitHub] [cloudstack] borisstoyanov commented on issue #3748: [WIP DO NOT MERGE] Systemvm template api

2020-01-22 Thread GitBox
borisstoyanov commented on issue #3748: [WIP DO NOT MERGE] Systemvm template api
URL: https://github.com/apache/cloudstack/pull/3748#issuecomment-577558379
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3748: [WIP DO NOT MERGE] Systemvm template api

2020-01-22 Thread GitBox
blueorangutan commented on issue #3748: [WIP DO NOT MERGE] Systemvm template api
URL: https://github.com/apache/cloudstack/pull/3748#issuecomment-577558819
 
 
   @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services