[GitHub] macdonst commented on issue #312: CB-13854(ios): fix Camera opens in portrait orientation on iphones
macdonst commented on issue #312: CB-13854(ios): fix Camera opens in portrait orientation on iphones URL: https://github.com/apache/cordova-plugin-camera/pull/312#issuecomment-364817265 Closes CB-13854 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[cordova-plugin-camera] branch master updated: CB-13854(ios): fix Camera opens in portrait orientation on iphones
This is an automated email from the ASF dual-hosted git repository. macdonst pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-plugin-camera.git The following commit(s) were added to refs/heads/master by this push: new 7c90555 CB-13854(ios): fix Camera opens in portrait orientation on iphones 7c90555 is described below commit 7c90555bd4bfbbdfe23f357f130eb1bbb7e4fce6 Author: Julio César AuthorDate: Sun Feb 11 13:08:40 2018 +0100 CB-13854(ios): fix Camera opens in portrait orientation on iphones --- src/ios/CDVCamera.m | 1 + 1 file changed, 1 insertion(+) diff --git a/src/ios/CDVCamera.m b/src/ios/CDVCamera.m index 37b4ec8..c71de05 100644 --- a/src/ios/CDVCamera.m +++ b/src/ios/CDVCamera.m @@ -206,6 +206,7 @@ static NSString* toBase64(NSData* data) { [weakSelf displayPopover:pictureOptions.popoverOptions]; weakSelf.hasPendingOperation = NO; } else { +cameraPicker.modalPresentationStyle = UIModalPresentationCurrentContext; [weakSelf.viewController presentViewController:cameraPicker animated:YES completion:^{ weakSelf.hasPendingOperation = NO; }]; -- To stop receiving notification emails like this one, please contact macdo...@apache.org. - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] macdonst closed pull request #312: CB-13854(ios): fix Camera opens in portrait orientation on iphones
macdonst closed pull request #312: CB-13854(ios): fix Camera opens in portrait orientation on iphones URL: https://github.com/apache/cordova-plugin-camera/pull/312 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/src/ios/CDVCamera.m b/src/ios/CDVCamera.m index 37b4ec84..c71de054 100644 --- a/src/ios/CDVCamera.m +++ b/src/ios/CDVCamera.m @@ -206,6 +206,7 @@ - (void)takePicture:(CDVInvokedUrlCommand*)command [weakSelf displayPopover:pictureOptions.popoverOptions]; weakSelf.hasPendingOperation = NO; } else { +cameraPicker.modalPresentationStyle = UIModalPresentationCurrentContext; [weakSelf.viewController presentViewController:cameraPicker animated:YES completion:^{ weakSelf.hasPendingOperation = NO; }]; This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] macdonst commented on issue #165: CB-13852: (iOS) Fix bug prevent error on getPosition
macdonst commented on issue #165: CB-13852: (iOS) Fix bug prevent error on getPosition URL: https://github.com/apache/cordova-plugin-media/pull/165#issuecomment-364816971 @jcesarmobile we can do a "squash and merge" for this PR then only one commit will show up. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] fortunes-technology commented on issue #25: CB-13193: (ios) Fixed Lock iOS Landscape Orientation turn up-sidedown
fortunes-technology commented on issue #25: CB-13193: (ios) Fixed Lock iOS Landscape Orientation turn up-sidedown URL: https://github.com/apache/cordova-plugin-screen-orientation/pull/25#issuecomment-364814425 The Merge conflict fixed. This PR fixes, the landscape right and left issue. Also if you want to lock orientation to landscape (do not care when it is right or left) and it's already in landscape mode (whether it is right or left), we shouldn't be changing orientation. Right now, if we change orientation to landscape, it just change it to landscape left. So this is fixed with this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion
janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-364770895 None right now, just setting up to test/release tomorrow and wanted to make sure I know which combination is known good ;) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] jcesarmobile closed pull request #300: Fix a mistake or misprint in examples of usage descriptions.
jcesarmobile closed pull request #300: Fix a mistake or misprint in examples of usage descriptions. URL: https://github.com/apache/cordova-plugin-camera/pull/300 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/jsdoc2md/TEMPLATE.md b/jsdoc2md/TEMPLATE.md index d2e6b223..19471938 100644 --- a/jsdoc2md/TEMPLATE.md +++ b/jsdoc2md/TEMPLATE.md @@ -37,7 +37,7 @@ To add these entries into the `info.plist`, you can use the `edit-config` tag in ``` -need to photo library access to get pictures from there +need photo library access to get pictures from there ``` @@ -49,7 +49,7 @@ To add these entries into the `info.plist`, you can use the `edit-config` tag in ``` -need to photo library access to save pictures there +need photo library access to save pictures there ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] jcesarmobile commented on issue #300: Fix a mistake or misprint in examples of usage descriptions.
jcesarmobile commented on issue #300: Fix a mistake or misprint in examples of usage descriptions. URL: https://github.com/apache/cordova-plugin-camera/pull/300#issuecomment-364769549 As the requested changes have not been done, I've sent a new PR with the changes. Closing this in favour of https://github.com/apache/cordova-plugin-camera/pull/313 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] jcesarmobile opened a new pull request #313: Fix a mistake in the examples of usage descriptions
jcesarmobile opened a new pull request #313: Fix a mistake in the examples of usage descriptions URL: https://github.com/apache/cordova-plugin-camera/pull/313 ### Platforms affected ### What does this PR do? ### What testing has been done on this change? ### Checklist - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] jcesarmobile commented on issue #264: change CameraOptions of README.md in ios
jcesarmobile commented on issue #264: change CameraOptions of README.md in ios URL: https://github.com/apache/cordova-plugin-camera/pull/264#issuecomment-364769166 Thanks for the PR. Next time please, create an issue on JIRA even if the change is small. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[cordova-plugin-camera] branch master updated: modified init value (#264)
This is an automated email from the ASF dual-hosted git repository. jcesarmobile pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-plugin-camera.git The following commit(s) were added to refs/heads/master by this push: new e25aed9 modified init value (#264) e25aed9 is described below commit e25aed97c5122bbd4d72fb5986b2e413293c7b27 Author: Tsuruda AuthorDate: Mon Feb 12 02:22:34 2018 +0900 modified init value (#264) --- README.md | 2 +- www/Camera.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 27bf6f5..40ba072 100644 --- a/README.md +++ b/README.md @@ -272,7 +272,7 @@ Optional parameters to customize the camera settings. | quality | number | 50 | Quality of the saved image, expressed as a range of 0-100, where 100 is typically full resolution with no loss from file compression. (Note that information about the camera's resolution is unavailable.) | | destinationType | [DestinationType](#module_Camera.DestinationType) | FILE_URI | Choose the format of the return value. | | sourceType | [PictureSourceType](#module_Camera.PictureSourceType) | CAMERA | Set the source of the picture. | -| allowEdit | Boolean | true | Allow simple editing of image before selection. | +| allowEdit | Boolean | false | Allow simple editing of image before selection. | | encodingType | [EncodingType](#module_Camera.EncodingType) | JPEG | Choose the returned image file's encoding. | | targetWidth | number | | Width in pixels to scale image. Must be used with `targetHeight`. Aspect ratio remains constant. | | targetHeight | number | | Height in pixels to scale image. Must be used with `targetWidth`. Aspect ratio remains constant. | diff --git a/www/Camera.js b/www/Camera.js index c14e3f3..0eade0f 100644 --- a/www/Camera.js +++ b/www/Camera.js @@ -66,7 +66,7 @@ for (var key in Camera) { * @property {number} [quality=50] - Quality of the saved image, expressed as a range of 0-100, where 100 is typically full resolution with no loss from file compression. (Note that information about the camera's resolution is unavailable.) * @property {module:Camera.DestinationType} [destinationType=FILE_URI] - Choose the format of the return value. * @property {module:Camera.PictureSourceType} [sourceType=CAMERA] - Set the source of the picture. - * @property {Boolean} [allowEdit=true] - Allow simple editing of image before selection. + * @property {Boolean} [allowEdit=false] - Allow simple editing of image before selection. * @property {module:Camera.EncodingType} [encodingType=JPEG] - Choose the returned image file's encoding. * @property {number} [targetWidth] - Width in pixels to scale image. Must be used with `targetHeight`. Aspect ratio remains constant. * @property {number} [targetHeight] - Height in pixels to scale image. Must be used with `targetWidth`. Aspect ratio remains constant. -- To stop receiving notification emails like this one, please contact jcesarmob...@apache.org. - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] brodybits commented on issue #250: [CB-13861] Update TargetPlatformVersion
brodybits commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-364769143 > Ouch. We might want to look into that later ;) @janpio what are your results? Any different? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] jcesarmobile closed pull request #264: change CameraOptions of README.md in ios
jcesarmobile closed pull request #264: change CameraOptions of README.md in ios URL: https://github.com/apache/cordova-plugin-camera/pull/264 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/README.md b/README.md index 436eefd6..b944b766 100644 --- a/README.md +++ b/README.md @@ -255,7 +255,7 @@ Optional parameters to customize the camera settings. | quality | number | 50 | Quality of the saved image, expressed as a range of 0-100, where 100 is typically full resolution with no loss from file compression. (Note that information about the camera's resolution is unavailable.) | | destinationType | [DestinationType](#module_Camera.DestinationType) | FILE_URI | Choose the format of the return value. | | sourceType | [PictureSourceType](#module_Camera.PictureSourceType) | CAMERA | Set the source of the picture. | -| allowEdit | Boolean | true | Allow simple editing of image before selection. | +| allowEdit | Boolean | false | Allow simple editing of image before selection. | | encodingType | [EncodingType](#module_Camera.EncodingType) | JPEG | Choose the returned image file's encoding. | | targetWidth | number | | Width in pixels to scale image. Must be used with `targetHeight`. Aspect ratio remains constant. | | targetHeight | number | | Height in pixels to scale image. Must be used with `targetWidth`. Aspect ratio remains constant. | diff --git a/www/Camera.js b/www/Camera.js index d0067870..f468f627 100644 --- a/www/Camera.js +++ b/www/Camera.js @@ -66,7 +66,7 @@ for (var key in Camera) { * @property {number} [quality=50] - Quality of the saved image, expressed as a range of 0-100, where 100 is typically full resolution with no loss from file compression. (Note that information about the camera's resolution is unavailable.) * @property {module:Camera.DestinationType} [destinationType=FILE_URI] - Choose the format of the return value. * @property {module:Camera.PictureSourceType} [sourceType=CAMERA] - Set the source of the picture. - * @property {Boolean} [allowEdit=true] - Allow simple editing of image before selection. + * @property {Boolean} [allowEdit=false] - Allow simple editing of image before selection. * @property {module:Camera.EncodingType} [encodingType=JPEG] - Choose the returned image file's encoding. * @property {number} [targetWidth] - Width in pixels to scale image. Must be used with `targetHeight`. Aspect ratio remains constant. * @property {number} [targetHeight] - Height in pixels to scale image. Must be used with `targetWidth`. Aspect ratio remains constant. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion
janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-364768966 Ouch. We might want to look into that later ;) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] brodybits commented on issue #250: [CB-13861] Update TargetPlatformVersion
brodybits commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-364767817 If I would do `cordova platform add https://github.com/apache/cordova-windows` in a new project then do `cordova requirements windows` I get the following output: ```sh Requirements check results for windows: Windows OS: not installed Error: Cannot read property 'os' of undefined (node:5776) UnhandledPromiseRejectionWarning: CordovaError: Some of requirements check failed at C:\Users\brodybits\AppData\Local\nvs\node\9.5.0\x64\node_modules\cordova\src\cli.js:414:27 at _fulfilled (C:\Users\brodybits\AppData\Local\nvs\node\9.5.0\x64\node_modules\cordova\node_modules\cordova-lib\node_modules\q\q.js:787:54) at self.promiseDispatch.done (C:\Users\brodybits\AppData\Local\nvs\node\9.5.0\x64\node_modules\cordova\node_modules\cordova-lib\node_modules\q\q.js:816:30) at Promise.promise.promiseDispatch (C:\Users\brodybits\AppData\Local\nvs\node\9.5.0\x64\node_modules\cordova\node_modules\cordova-lib\node_modules\q\q.js:749:13) at C:\Users\brodybits\AppData\Local\nvs\node\9.5.0\x64\node_modules\cordova\node_modules\cordova-lib\node_modules\q\q.js:557:44 at flush (C:\Users\brodybits\AppData\Local\nvs\node\9.5.0\x64\node_modules\cordova\node_modules\cordova-lib\node_modules\q\q.js:108:17) at process._tickCallback (internal/process/next_tick.js:150:11) (node:5776) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1) (node:5776) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code. ``` Same result if I would do `cordova platform add https://github.com/apache/cordova-windows#CB-13861` then `cordova requirements windows`. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion
janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-364766938 What does `cordova requirements windows` return for you? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] jcesarmobile commented on issue #165: CB-13852: (iOS) Fix bug prevent error on getPosition
jcesarmobile commented on issue #165: CB-13852: (iOS) Fix bug prevent error on getPosition URL: https://github.com/apache/cordova-plugin-media/pull/165#issuecomment-364764819 No, I can still see 11 commits, only yours should appear This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[cordova-node-xcode] branch master updated (ba195a8 -> fadff44)
This is an automated email from the ASF dual-hosted git repository. shazron pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cordova-node-xcode.git. from ba195a8 CB-13380 Incremented package version to -dev add 747d7ba update invalid link of PEGjs on README new fadff44 Merge pull request #8 from ikhattab/patch-1 The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To stop receiving notification emails like this one, please contact shaz...@apache.org. - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[cordova-node-xcode] 01/01: Merge pull request #8 from ikhattab/patch-1
This is an automated email from the ASF dual-hosted git repository. shazron pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-node-xcode.git commit fadff4476da1979e3a40902a4a160d7024012d0d Merge: ba195a8 747d7ba Author: Shazron Abdullah AuthorDate: Mon Feb 12 00:12:08 2018 +0800 Merge pull request #8 from ikhattab/patch-1 update invalid link of PEGjs on README README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To stop receiving notification emails like this one, please contact shaz...@apache.org. - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] jcesarmobile opened a new pull request #312: CB-13854(ios): fix Camera opens in portrait orientation on iphones
jcesarmobile opened a new pull request #312: CB-13854(ios): fix Camera opens in portrait orientation on iphones URL: https://github.com/apache/cordova-plugin-camera/pull/312 ### Platforms affected iOS ### What does this PR do? Allow to properly present the camera in landscape ### What testing has been done on this change? Tested on iPhone and iPod touch ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org