apache-mynewt-bot commented on PR #1424:
URL: https://github.com/apache/mynewt-nimble/pull/1424#issuecomment-1366794889
## Style check summary
### Our coding style is
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
nimble/controller/src/ble_ll_ctrl.c
```diff
@@ -2097,53 +2096,53 @@
(connsm->max_tx_time <= BLE_LL_CONN_SUPP_TIME_MIN) &&
(connsm->max_rx_time <= BLE_LL_CONN_SUPP_TIME_MIN)) {
return;
-} else {
-if ((connsm->max_tx_octets < BLE_LL_CONN_SUPP_BYTES_MIN) &&
-(connsm->max_rx_octets < BLE_LL_CONN_SUPP_BYTES_MIN) &&
-(connsm->max_tx_time < BLE_LL_CONN_SUPP_TIME_MIN) &&
-(connsm->max_rx_time < BLE_LL_CONN_SUPP_TIME_MIN)) {
-return;
-}
-
-ble_ll_ctrl_proc_start(connsm, BLE_LL_CTRL_PROC_DATA_LEN_UPD, NULL);
-}
-
-static void
-ble_ll_ctrl_update_features(struct ble_ll_conn_sm *connsm, uint8_t *feat)
-{
-connsm->conn_features = feat[0];
-memcpy(connsm->remote_features, feat + 1, 7);
-
-/* If we received peer's features for the 1st time, we should try DLE */
-if (!connsm->csmflags.cfbit.rxd_features) {
+} else {
+if ((connsm->max_tx_octets < BLE_LL_CONN_SUPP_BYTES_MIN) &&
+(connsm->max_rx_octets < BLE_LL_CONN_SUPP_BYTES_MIN) &&
+(connsm->max_tx_time < BLE_LL_CONN_SUPP_TIME_MIN) &&
+(connsm->max_rx_time < BLE_LL_CONN_SUPP_TIME_MIN)) {
+return;
+}
+
+ble_ll_ctrl_proc_start(connsm, BLE_LL_CTRL_PROC_DATA_LEN_UPD,
NULL);
+}
+
+static void
+ble_ll_ctrl_update_features(struct ble_ll_conn_sm *connsm, uint8_t
*feat)
+{
+connsm->conn_features = feat[0];
+memcpy(connsm->remote_features, feat + 1, 7);
+
+/* If we received peer's features for the 1st time, we should
try DLE */
+if (!connsm->csmflags.cfbit.rxd_features) {
#if MYNEWT_VAL(BLE_LL_CFG_FEAT_LE_CODED_PHY)
-/*
- * If connection was established on uncoded PHY, by default we use
- * MaxTxTime and MaxRxTime applicable for that PHY since we are not
- * allowed to indicate longer supported time if peer does not
support
- * LE Coded PHY. However, once we know that peer does support it we
can
- * update those values to ones applicable for coded PHY.
- */
-if (ble_ll_conn_rem_feature_check(connsm,
BLE_LL_FEAT_LE_CODED_PHY)) {
-if (connsm->host_req_max_tx_time) {
-connsm->max_tx_time = max(connsm->max_tx_time,
+/*
+ * If connection was established on uncoded PHY, by default
we use
+ * MaxTxTime and MaxRxTime applicable for that PHY since we
are not
+ * allowed to indicate longer supported time if peer does
not support
+ * LE Coded PHY. However, once we know that peer does
support it we can
+ * update those values to ones applicable for coded PHY.
+ */
+if (ble_ll_conn_rem_feature_check(connsm,
BLE_LL_FEAT_LE_CODED_PHY)) {
+if (connsm->host_req_max_tx_time) {
+connsm->max_tx_time = max(connsm->max_tx_time,
connsm->host_req_max_tx_time);
-} else {
-connsm->max_tx_time =
g_ble_ll_conn_params.conn_init_max_tx_time_coded;
-}
-if (connsm->host_req_max_rx_time) {
-connsm->max_rx_time = max(connsm->max_rx_time,
+} else {
+connsm->max_tx_time =
g_ble_ll_conn_params.conn_init_max_tx_time_coded;
+}
+if (connsm->host_req_max_rx_time) {
+connsm->max_rx_time = max(connsm->max_rx_time,
connsm->host_req_max_rx_time);
-} else {
-connsm->max_rx_time = BLE_LL_CONN_SUPP_TIME_MAX_CODED;
-}
-}
-#endif
-
-connsm->csmflags.cfbit.pending_initiate_dle = 1;
-connsm->csmflags.cfbit.rxd_features = 1;
-}
-}
+} else {
+connsm->max_rx_time =
BLE_LL_CONN_SUPP_TIME_MAX_CODED;
+}
+}
+#endif
+
+connsm->csmflags.cfbit.pending_initiate_dle = 1;
+connsm->csmflags.cfbit.rxd_features = 1;
+}
+}
/**
* Called when we receive a feature request or a peripheral initiated
feature
@@ -2746,320 +2745,320 @@