[GitHub] [mynewt-core] kasjer merged pull request #2816: bsp/olimex-pic32: Add missing licenses

2022-04-20 Thread GitBox


kasjer merged PR #2816:
URL: https://github.com/apache/mynewt-core/pull/2816


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[mynewt-core] branch master updated: bsp/olimex-pic32: Add missing licenses

2022-04-20 Thread jerzy
This is an automated email from the ASF dual-hosted git repository.

jerzy pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-core.git


The following commit(s) were added to refs/heads/master by this push:
 new 358e29432 bsp/olimex-pic32: Add missing licenses
358e29432 is described below

commit 358e294325703c1ee04f23028584cd8cfe2946d8
Author: Jerzy Kasenberg 
AuthorDate: Tue Apr 19 21:24:57 2022 +0200

bsp/olimex-pic32: Add missing licenses
---
 hw/bsp/olimex-pic32-emz64/p32mz_app_mem.ld  | 18 ++
 hw/bsp/olimex-pic32-hmz144/p32mz_app_mem.ld | 18 ++
 2 files changed, 36 insertions(+)

diff --git a/hw/bsp/olimex-pic32-emz64/p32mz_app_mem.ld 
b/hw/bsp/olimex-pic32-emz64/p32mz_app_mem.ld
index 5a21eb6b6..46861cbe4 100644
--- a/hw/bsp/olimex-pic32-emz64/p32mz_app_mem.ld
+++ b/hw/bsp/olimex-pic32-emz64/p32mz_app_mem.ld
@@ -1,3 +1,21 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
 
 /*
  * Part of the MEMORY section that defines application memory size.
diff --git a/hw/bsp/olimex-pic32-hmz144/p32mz_app_mem.ld 
b/hw/bsp/olimex-pic32-hmz144/p32mz_app_mem.ld
index 5a21eb6b6..46861cbe4 100644
--- a/hw/bsp/olimex-pic32-hmz144/p32mz_app_mem.ld
+++ b/hw/bsp/olimex-pic32-hmz144/p32mz_app_mem.ld
@@ -1,3 +1,21 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
 
 /*
  * Part of the MEMORY section that defines application memory size.



[GitHub] [mynewt-core] sjanc commented on pull request #2810: hw/drivers/semihosting: Fix typo in semihost_rename

2022-04-20 Thread GitBox


sjanc commented on PR #2810:
URL: https://github.com/apache/mynewt-core/pull/2810#issuecomment-1103565809

   @caspermeijn it was reported here some time ago  
https://github.com/apache/mynewt-core/issues/2754   and looked like typo indeed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-core] sjanc merged pull request #2815: Update license and rat excludes

2022-04-20 Thread GitBox


sjanc merged PR #2815:
URL: https://github.com/apache/mynewt-core/pull/2815


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[mynewt-core] branch master updated: Update license and rat excludes

2022-04-20 Thread janc
This is an automated email from the ASF dual-hosted git repository.

janc pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-core.git


The following commit(s) were added to refs/heads/master by this push:
 new d1e4e9e9e Update license and rat excludes
d1e4e9e9e is described below

commit d1e4e9e9ecf0c3a3331e2c1c7c0db0c75f104488
Author: Szymon Janc 
AuthorDate: Tue Apr 19 17:54:23 2022 +0200

Update license and rat excludes
---
 .rat-excludes | 16 +++-
 LICENSE   | 21 -
 2 files changed, 35 insertions(+), 2 deletions(-)

diff --git a/.rat-excludes b/.rat-excludes
index 0a633f1c8..f2f7da104 100644
--- a/.rat-excludes
+++ b/.rat-excludes
@@ -134,6 +134,12 @@ nordic_pca10090_no_boot.ld
 nrf91xxaa.ld
 nrf91_ram_resident.ld
 boot-pinetime.ld
+boot-apollo3.ld
+apollo3.ld
+nordic_pca10059_no_boot.ld
+split-nordic_pca10059.ld
+split-ublox_bmd_345.ld
+ublox_bmd_345_no_boot.ld
 
 # STM32 HAL - BSD License
 stm32_driver_mod_i2c_v1.c
@@ -428,6 +434,8 @@ cache-err-exception.S
 cp0defs.h
 simple-tlb-refill-exception.S
 crt0.S
+p32mz_app.ld
+p32mz_boot.ld
 
 # Calliope SDK - BSD Licence
 split-calliope_mini.ld
@@ -447,12 +455,15 @@ pic32mz2048_wi-fire
 # hw/bsp/apollo2_evb/src/arch/cortex_m4/gcc_startup.s
 apollo2_evb
 
-# BSP for Apollo2 - BSD License
+# BSP for Ambiq Apollo2/Apollo3 - BSD License
 AmbiqSuite
 apollo2.h
 system_apollo2.h
 system_apollo2.c
 apollo_nvic.h
+system_apollo3.c
+apollo3.h
+system_apollo3.h
 
 # CMSIS Cortex-M4, STM32f3 - BSD License.
 STM32F3xx
@@ -472,6 +483,7 @@ docs
 nrfx
 nrfx_glue.h
 nrfx_config.h
+nrf51xxx
 nrf52xxx
 nrf91xx
 nrf52xxx-compat
@@ -550,3 +562,5 @@ startup_stm32l073xx.s
 
 # MK64F12 SDK - BSD License
 MK64F12
+
+
diff --git a/LICENSE b/LICENSE
index b16520a48..4691bc914 100644
--- a/LICENSE
+++ b/LICENSE
@@ -283,6 +283,8 @@ which are available under a BSD style license.  Relevant 
files are:
 * hw/mcu/nordic/nrf52xxx/src/system_nrf52.c
 * hw/mcu/nordic/nrf5340/include/nrfx_config.h
 * hw/mcu/nordic/nrf5340_net/include/nrfx_config.h
+* hw/mcu/nordic/nrf51xxx/src/arch/cortex_m0/gcc_startup_cm0.s
+* hw/mcu/nordic/nrf51xxx/src/arch/cortex_m0/gcc_startup_cm0_split.s
 
 This product bundles Gary S. Brown's CRC32 implementation, which is available
 under the following license:
@@ -564,6 +566,13 @@ which is available under the "modified Tcl/Tk" license.  
Bundled files are:
 * hw/bsp/vbluno52/split-vbluno52.ld
 * hw/bsp/vbluno52/vbluno52_no_boot.ld
 * hw/bsp/pinetime/boot-pinetime.ld
+* hw/bsp/apollo3_evb/apollo3.ld
+* hw/bsp/apollo3_evb/boot-apollo3.ld
+* hw/bsp/apollo3_evb/src/system_apollo3.c
+* hw/bsp/nordic_pca10059/nordic_pca10059_no_boot.ld
+* hw/bsp/nordic_pca10059/split-nordic_pca10059.ld
+* hw/bsp/ublox_bmd_345/split-ublox_bmd_345.ld
+* hw/bsp/ublox_bmd_345/ublox_bmd_345_no_boot.ld
 
 This product bundles part of NXP/FreeScale SDK, which is available
 under the "3-clause BSD" license. Bundled files are:
@@ -635,13 +644,21 @@ This products bundle Adafruit's tsl2561 driver, which is 
available under the
 
 This products bundles Amiq Micro Apollo 2, which is available under the
 "3-clause BSD" license. Bundled files are:
-* hw/mcu/ambiq/src/ext/AmbiqSuite
+* hw/mcu/ambiq/apollo2/src/ext/AmbiqSuite
 * hw/mcu/ambiq/apollo2/include/mcu/apollo2.h
 * hw/mcu/ambiq/apollo2/include/mcu/system_apollo2.h
 * hw/bsp/apollo2_evb/include/bsp/apollo_nvic.h
 * hw/bsp/apollo2_evb/src/system_apollo2.c
 * hw/bsp/apollo2_evb/src/arch/cortex_m4/gcc_startup.s
 
+This products bundles Amiq Micro Apollo 3, which is available under the
+"3-clause BSD" license. Bundled files are:
+* hw/mcu/ambiq/apollo3/src/ext/AmbiqSuite
+* hw/mcu/ambiq/apollo3/include/mcu/apollo3.h
+* hw/mcu/ambiq/apollo3/include/mcu/cmsis_nvic.h
+* hw/mcu/ambiq/apollo3/include/mcu/system_apollo3.h
+* hw/bsp/apollo3_evb/src/system_apollo3.c
+
 This product bundles processor headers for PIC32 by Microchip Technology
 Inc., which is available under the "3-clause BSD" license. Bundled files are:
 * hw/mcu/microchip/pic32mx470f512h/include/mcu/p32mx470f512h.h
@@ -655,6 +672,8 @@ Inc., which is available under the "3-clause BSD" license. 
Bundled files are:
 * kernel/os/src/arch/pic32/startup/simple-tlb-refill-exception.S
 * kernel/os/src/arch/pic32/stubs/pic32_init_cache.S
 * kernel/os/src/arch/pic32/stubs/pic32_init_tlb_ebi_sqi.S
+* hw/mcu/microchip/pic32mz/p32mz_app.ld
+* hw/mcu/microchip/pic32mz/p32mz_boot.ld
 
 This product bundles MIPS processor low-level macros by Imagination
 Technologies Limited, which is available under the "3-clause BSD" license.



[GitHub] [mynewt-nimble] sjanc merged pull request #1240: Update missing licenses and rat excludes

2022-04-20 Thread GitBox


sjanc merged PR #1240:
URL: https://github.com/apache/mynewt-nimble/pull/1240


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[mynewt-nimble] branch master updated: Update missing licenses and rat excludes

2022-04-20 Thread janc
This is an automated email from the ASF dual-hosted git repository.

janc pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-nimble.git


The following commit(s) were added to refs/heads/master by this push:
 new 2a713546 Update missing licenses and rat excludes
2a713546 is described below

commit 2a7135469ef6ef237dc20341ff978dbd5a4eb17b
Author: Szymon Janc 
AuthorDate: Tue Apr 19 17:07:15 2022 +0200

Update missing licenses and rat excludes
---
 .rat-excludes |  4 
 porting/targets/porting_default/syscfg.yml| 18 ++
 targets/nordic_pca10056-blehci-usb/pkg.yml| 18 ++
 targets/nordic_pca10056-blehci-usb/syscfg.yml | 18 ++
 targets/nordic_pca10056-blehci-usb/target.yml | 18 ++
 5 files changed, 76 insertions(+)

diff --git a/.rat-excludes b/.rat-excludes
index bed75ef7..a4bcb91b 100644
--- a/.rat-excludes
+++ b/.rat-excludes
@@ -16,6 +16,7 @@ pts-sm.txt
 94654-20170317-085441153.pts
 uncrustify.cfg
 .style_ignored_dirs
+.mailmap
 
 # tinycrypt - BSD License.
 tinycrypt
@@ -31,3 +32,6 @@ os_mbuf.c
 
 # Bluetooth Mesh badge sample - Apache 2.0 License
 mesh_badge
+
+#BabbleSim and EDDT - Apache 2.0 License
+babblesim
diff --git a/porting/targets/porting_default/syscfg.yml 
b/porting/targets/porting_default/syscfg.yml
index 7c6db1ae..cb6cda18 100644
--- a/porting/targets/porting_default/syscfg.yml
+++ b/porting/targets/porting_default/syscfg.yml
@@ -1,3 +1,21 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#  http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
 syscfg.vals:
 BLE_TRANSPORT_LL: socket
 BLE_SOCK_USE_TCP: 0
diff --git a/targets/nordic_pca10056-blehci-usb/pkg.yml 
b/targets/nordic_pca10056-blehci-usb/pkg.yml
index 772dd75e..2c8307d3 100644
--- a/targets/nordic_pca10056-blehci-usb/pkg.yml
+++ b/targets/nordic_pca10056-blehci-usb/pkg.yml
@@ -1,3 +1,21 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#  http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
 pkg.name: "targets/nordic_pca10056-blehci-usb"
 pkg.type: target
 pkg.description: 
diff --git a/targets/nordic_pca10056-blehci-usb/syscfg.yml 
b/targets/nordic_pca10056-blehci-usb/syscfg.yml
index f2579c14..0c5701a9 100644
--- a/targets/nordic_pca10056-blehci-usb/syscfg.yml
+++ b/targets/nordic_pca10056-blehci-usb/syscfg.yml
@@ -1,3 +1,21 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#  http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
 syscfg.vals:
 BLE_TRANSPORT_HS: usb
 USBD_BTH: 1
diff --git a/targets/nordic_pca10056-blehci-usb/target.yml 
b/targets/nordic_pca10056-blehci-usb/target.yml
index 39f4c8c4..ce455d45 100644
--- a/targets/nordic_pca10056-blehci-usb/target.yml
+++ b/targets/nordic_pca10056-blehci-usb/target.yml
@@ -1,3 +1,21 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or

[GitHub] [mynewt-newt] sjanc merged pull request #475: Update go.mod for Mac build

2022-04-20 Thread GitBox


sjanc merged PR #475:
URL: https://github.com/apache/mynewt-newt/pull/475


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[mynewt-newt] branch master updated: Update go.mod for Mac build

2022-04-20 Thread janc
This is an automated email from the ASF dual-hosted git repository.

janc pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-newt.git


The following commit(s) were added to refs/heads/master by this push:
 new 45f203d  Update go.mod for Mac build
45f203d is described below

commit 45f203d6e2a156dbff6b3c23a7165bdd4c32c279
Author: Szymon Janc 
AuthorDate: Tue Apr 19 18:16:19 2022 +0200

Update go.mod for Mac build

This seems to be required by build on mac, otherwise newt build with
build.sh results in 'dirty' binary.
---
 go.mod | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/go.mod b/go.mod
index 560aac1..07969da 100644
--- a/go.mod
+++ b/go.mod
@@ -8,7 +8,7 @@ require (
github.com/go-ole/go-ole v1.2.5 // indirect
github.com/kardianos/osext v0.0.0-20190222173326-2bc1f35cddc0
github.com/kballard/go-shellquote v0.0.0-20180428030007-95032a82bc51
-   github.com/otiai10/copy v1.6.0 // indirect
+   github.com/otiai10/copy v1.6.0
github.com/shirou/gopsutil v2.20.8+incompatible
github.com/sirupsen/logrus v1.4.2
github.com/spf13/cast v1.3.0



[GitHub] [mynewt-nimble] KKopyscinski opened a new pull request, #1241: host: l2cap: check connection parameters in ble_l2cap_sig_update_req_rx

2022-04-20 Thread GitBox


KKopyscinski opened a new pull request, #1241:
URL: https://github.com/apache/mynewt-nimble/pull/1241

   This should be done before asking application.
   
   This is affecting GAP/CONN/CPUP/BV-05-C


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-core] kasjer opened a new pull request, #2817: mcu/nrf5340: Add memory protection with MPU

2022-04-20 Thread GitBox


kasjer opened a new pull request, #2817:
URL: https://github.com/apache/mynewt-core/pull/2817

   This change allows enabling MPU with configuration
   that will protect against:
   - code execution from RAM
   - modification of bootloader and image in slot 0
   - bootloader code read (this can also help with NULL pointer access)
   - execution code from non-slot0 area
   
   Signed-off-by: Jerzy Kasenberg 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] bvdberg opened a new pull request, #1242: minor fixes

2022-04-20 Thread GitBox


bvdberg opened a new pull request, #1242:
URL: https://github.com/apache/mynewt-nimble/pull/1242

   - ble_ll needs to include hal_system.h for hal_debugger_connected()
   - ble_ll_sync needs stdlib.h for abs()
   - ble_ll_init() can be static/private


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[mynewt-mcumgr] annotated tag mcumgr_0_3_0_tag updated (215eb18 -> b3646dc)

2022-04-20 Thread janc
This is an automated email from the ASF dual-hosted git repository.

janc pushed a change to annotated tag mcumgr_0_3_0_tag
in repository https://gitbox.apache.org/repos/asf/mynewt-mcumgr.git


*** WARNING: tag mcumgr_0_3_0_tag was modified! ***

from 215eb18  (commit)
  to b3646dc  (tag)
 tagging 215eb188c20323a6b0489be2ddc08e0f3171c7d8 (commit)
 replaces mcumgr_0_2_0_tag
  by Szymon Janc
  on Wed Apr 20 17:19:01 2022 +0200

- Log -
Mcumgr 0.3.0
---


No new revisions were added by this update.

Summary of changes:



[GitHub] [mynewt-nimble] utzig commented on pull request #1241: host: l2cap: check connection parameters in ble_l2cap_sig_update_req_rx

2022-04-20 Thread GitBox


utzig commented on PR #1241:
URL: https://github.com/apache/mynewt-nimble/pull/1241#issuecomment-1104323849

   
   
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
    apps/bttester/src/gap.c
   
   
   ```diff
   @@ -48,8 +48,8 @@
#define REJECT_SUPERVISION_TIMEOUT 0x0C80

const uint8_t irk[16] = {
   -0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11,
   -0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11,
   +0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11,
   +0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11,
};

static uint8_t oob[16];
   @@ -685,1091 +702,1132 @@
 * If the resolution procedure fails, then the Host shall disconnect
 * with the error code "Authentication failure" [...]
 */
   -static void periph_privacy(struct ble_gap_conn_desc desc)
   +static void
   +periph_privacy(struct ble_gap_conn_desc desc)
{
#if !MYNEWT_VAL(BTTESTER_PRIVACY_MODE)
   -return;
   +return;
#endif
   -int count;
   -
   -SYS_LOG_DBG("");
   -
   -ble_store_util_count(BLE_STORE_OBJ_TYPE_PEER_SEC, &count);
   -if (count > 0 && BLE_ADDR_IS_RPA(&desc.peer_id_addr)) {
   -SYS_LOG_DBG("Authentication failure, disconnecting");
   -ble_gap_terminate(desc.conn_handle, BLE_ERR_AUTH_FAIL);
   -}
   -}
   -
   -static void device_connected_ev_send(struct os_event *ev)
   -{
   -struct ble_gap_conn_desc desc;
   -int rc;
   -
   -SYS_LOG_DBG("");
   -
   -rc = gap_conn_find_by_addr((ble_addr_t *)&connected_ev, &desc);
   -if (rc) {
   -tester_rsp(BTP_SERVICE_ID_GAP, GAP_EV_DEVICE_CONNECTED,
   -   CONTROLLER_INDEX, BTP_STATUS_FAILED);
   -return;
   -}
   -
   -tester_send(BTP_SERVICE_ID_GAP, GAP_EV_DEVICE_CONNECTED,
   -CONTROLLER_INDEX, (uint8_t *) &connected_ev,
   -sizeof(connected_ev));
   -
   -periph_privacy(desc);
   -}
   -
   -static void le_connected(uint16_t conn_handle, int status)
   -{
   -struct ble_gap_conn_desc desc;
   -ble_addr_t *addr;
   -int rc;
   -
   -SYS_LOG_DBG("");
   -
   -if (status != 0) {
   -return;
   -}
   -
   -rc = ble_gap_conn_find(conn_handle, &desc);
   -if (rc) {
   -return;
   -}
   -
   -peer_id_addr = desc.peer_id_addr;
   -peer_ota_addr = desc.peer_ota_addr;
   -
   -addr = &desc.peer_id_addr;
   -
   -memcpy(connected_ev.address, addr->val, sizeof(connected_ev.address));
   -connected_ev.address_type = addr->type;
   -connected_ev.conn_itvl = desc.conn_itvl;
   -connected_ev.conn_latency = desc.conn_latency;
   -connected_ev.supervision_timeout = desc.supervision_timeout;
   +int count;
   +
   +SYS_LOG_DBG("");
   +
   +ble_store_util_count(BLE_STORE_OBJ_TYPE_PEER_SEC, &count);
   +if (count > 0 && BLE_ADDR_IS_RPA(&desc.peer_id_addr)) {
   +SYS_LOG_DBG("Authentication failure, disconnecting");
   +ble_gap_terminate(desc.conn_handle, BLE_ERR_AUTH_FAIL);
   +}
   +}
   +
   +static void
   +device_connected_ev_send(struct os_event *ev)
   +{
   +struct ble_gap_conn_desc desc;
   +int rc;
   +
   +SYS_LOG_DBG("");
   +
   +rc = gap_conn_find_by_addr((ble_addr_t *)&connected_ev, &desc);
   +if (rc) {
   +tester_rsp(BTP_SERVICE_ID_GAP, GAP_EV_DEVICE_CONNECTED,
   +   CONTROLLER_INDEX, BTP_STATUS_FAILED);
   +return;
   +}
   +
   +tester_send(BTP_SERVICE_ID_GAP, GAP_EV_DEVICE_CONNECTED,
   +CONTROLLER_INDEX, (uint8_t *) &connected_ev,
   +sizeof(connected_ev));
   +
   +periph_privacy(desc);
   +}
   +
   +static void
   +le_connected(uint16_t conn_handle, int status)
   +{
   +struct ble_gap_conn_desc desc;
   +ble_addr_t *addr;
   +int rc;
   +
   +SYS_LOG_DBG("");
   +
   +if (status != 0) {
   +return;
   +}
   +
   +rc = ble_gap_conn_find(conn_handle, &desc);
   +if (rc) {
   +return;
   +}
   +
   +peer_id_addr = desc.peer_id_addr;
   +peer_ota_addr = desc.peer_ota_addr;
   +
   +addr = &desc.peer_id_addr;
   +
   +memcpy(connected_ev.address, addr->val, sizeof(connected_ev.address));
   +connected_ev.address_type = addr->type;
   +connected_ev.conn_itvl = desc.conn_itvl;
   +connected_ev.conn_latency = desc.conn_latency;
   +connected_ev.supervision_timeout = desc.supervision_timeout;

#if MYNEWT_VAL(BTTESTER_CONN_RETRY)
   -os_callout_reset(&connected_ev_co,
   - os_time_ms_to_ticks32(
   - CONNECTED_EV_DELAY_MS(desc.conn_itvl)));
   +os_callout_reset(&connected_ev_co,
   + os_time_ms_to_ticks32(
   + CONNECTED_EV_DELAY_MS(desc.conn_itvl)));
#else
   -tester_send(BTP_SERVI

[GitHub] [mynewt-nimble] utzig commented on pull request #1242: minor fixes

2022-04-20 Thread GitBox


utzig commented on PR #1242:
URL: https://github.com/apache/mynewt-nimble/pull/1242#issuecomment-1104342864

   
   
   
   ## Style check summary
   
    No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [mynewt-nimble] andrzej-kaczmarek merged pull request #1242: minor fixes

2022-04-20 Thread GitBox


andrzej-kaczmarek merged PR #1242:
URL: https://github.com/apache/mynewt-nimble/pull/1242


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[mynewt-nimble] branch master updated: minor fixes

2022-04-20 Thread andk
This is an automated email from the ASF dual-hosted git repository.

andk pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-nimble.git


The following commit(s) were added to refs/heads/master by this push:
 new 749f13bf minor fixes
749f13bf is described below

commit 749f13bf9cb85b08b41a562a6fc764d16b8bdec2
Author: Bas van den Berg 
AuthorDate: Wed Apr 20 13:58:23 2022 +0200

minor fixes

- ble_ll needs to include hal_system.h for hal_debugger_connected()
- ble_ll_sync needs stdlib.h for abs()
- ble_ll_init() can be static/private
---
 nimble/controller/include/controller/ble_ll.h | 3 ---
 nimble/controller/src/ble_ll.c| 3 ++-
 nimble/controller/src/ble_ll_sync.c   | 1 +
 3 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/nimble/controller/include/controller/ble_ll.h 
b/nimble/controller/include/controller/ble_ll.h
index 18468d43..58992e88 100644
--- a/nimble/controller/include/controller/ble_ll.h
+++ b/nimble/controller/include/controller/ble_ll.h
@@ -476,9 +476,6 @@ struct ble_ll_acad_channel_map_update_ind {
 } __attribute__((packed));
 
 /*--- External API ---*/
-/* Initialize the Link Layer */
-void ble_ll_init(void);
-
 /* Reset the Link Layer */
 int ble_ll_reset(void);
 
diff --git a/nimble/controller/src/ble_ll.c b/nimble/controller/src/ble_ll.c
index 23b105fa..b6681abf 100644
--- a/nimble/controller/src/ble_ll.c
+++ b/nimble/controller/src/ble_ll.c
@@ -47,6 +47,7 @@
 #include "ble_ll_conn_priv.h"
 #include "ble_ll_hci_priv.h"
 #include "ble_ll_priv.h"
+#include "hal/hal_system.h"
 
 #if MYNEWT_VAL(BLE_LL_DTM)
 #include "ble_ll_dtm_priv.h"
@@ -1788,7 +1789,7 @@ ble_ll_assert(const char *file, unsigned line)
  *
  * @return int
  */
-void
+static void
 ble_ll_init(void)
 {
 int rc;
diff --git a/nimble/controller/src/ble_ll_sync.c 
b/nimble/controller/src/ble_ll_sync.c
index 0395c72b..65f2fcae 100644
--- a/nimble/controller/src/ble_ll_sync.c
+++ b/nimble/controller/src/ble_ll_sync.c
@@ -20,6 +20,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include "syscfg/syscfg.h"
 



[GitHub] [mynewt-core] utzig commented on pull request #2817: mcu/nrf5340: Add memory protection with MPU

2022-04-20 Thread GitBox


utzig commented on PR #2817:
URL: https://github.com/apache/mynewt-core/pull/2817#issuecomment-1104473834

   
   
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
    hw/mcu/nordic/nrf5340/mpu/src/mpu.c
   
   
   ```diff
   @@ -46,7 +46,7 @@
ARM_MPU_SetMemAttr(0UL, ARM_MPU_ATTR(   /* Normal memory */
ARM_MPU_ATTR_MEMORY_(0UL, 1UL, 1UL, 1UL), /* Outer Write-Back 
transient with read and write allocate */
ARM_MPU_ATTR_MEMORY_(0UL, 0UL, 1UL, 1UL)  /* Inner Write-Through 
transient with read and write allocate */
   -));
   +   ));
/* RAM */
regions[0].RBAR = ARM_MPU_RBAR((uint32_t)&_ram_start, ARM_MPU_SH_OUTER, 
0UL, 1UL, 1UL);
regions[0].RLAR = ARM_MPU_RLAR(((uint32_t)&_ram_start + RAM_SIZE - 1), 
0UL);
   ```
   
   
   
    hw/mcu/nordic/nrf5340/src/system_nrf5340.c
   
   
   ```diff
   @@ -53,197 +53,189 @@
#define TRACE_TRACEDATA2_PIN TAD_PSEL_TRACEDATA2_PIN_Tracedata2
#define TRACE_TRACEDATA3_PIN TAD_PSEL_TRACEDATA3_PIN_Tracedata3

   -#if defined ( __CC_ARM )
   -uint32_t SystemCoreClock __attribute__((used)) = __SYSTEM_CLOCK_INITIAL;
   -#elif defined ( __ICCARM__ )
   -__root uint32_t SystemCoreClock = __SYSTEM_CLOCK_INITIAL;
   -#elif defined   ( __GNUC__ )
   -uint32_t SystemCoreClock __attribute__((used)) = __SYSTEM_CLOCK_INITIAL;
   +#if defined (__CC_ARM)
   +uint32_t SystemCoreClock __attribute__((used)) = __SYSTEM_CLOCK_INITIAL;
   +#elif defined (__ICCARM__)
   +__root uint32_t SystemCoreClock = __SYSTEM_CLOCK_INITIAL;
   +#elif defined   (__GNUC__)
   +uint32_t SystemCoreClock __attribute__((used)) = __SYSTEM_CLOCK_INITIAL;
#endif

/* stack limit provided by linker script */
extern uint32_t __StackLimit[];

   -void SystemCoreClockUpdate(void)
   +void
   +SystemCoreClockUpdate(void)
{
SystemCoreClock = __SYSTEM_CLOCK_MAX >> (NRF_CLOCK->HFCLKCTRL & 
(CLOCK_HFCLKCTRL_HCLK_Msk));
}

   -void SystemInit(void)
   +void
   +SystemInit(void)
{
#if !defined(NRF_TRUSTZONE_NONSECURE)
   -/* Perform Secure-mode initialization routines. */
   -
   -/* Set all ARM SAU regions to NonSecure if TrustZone extensions are 
enabled.
   -* Nordic SPU should handle Secure Attribution tasks */
   +/* Perform Secure-mode initialization routines. */
   +
   +/* Set all ARM SAU regions to NonSecure if TrustZone extensions are 
enabled.
   + * Nordic SPU should handle Secure Attribution tasks */
#if defined (__ARM_FEATURE_CMSE) && (__ARM_FEATURE_CMSE == 3U)
   -  SAU->CTRL |= (1 << SAU_CTRL_ALLNS_Pos);
   -#endif
   -
   -/* Workaround for Errata 97 "ERASEPROTECT, APPROTECT, or startup 
problems" found at the Errata document
   -   for your device located at 
https://infocenter.nordicsemi.com/index.jsp  */
   -if (nrf53_errata_97())
   -{
   -if (*((volatile uint32_t *)0x50004A20ul) == 0)
   -{
   -*((volatile uint32_t *)0x50004A20ul) = 0xDul;
   -*((volatile uint32_t *)0x5000491Cul) = 0x1ul;
   -*((volatile uint32_t *)0x5000491Cul) = 0x0ul;
   -}
   +SAU->CTRL |= (1 << SAU_CTRL_ALLNS_Pos);
   +#endif
   +
   +/* Workaround for Errata 97 "ERASEPROTECT, APPROTECT, or startup 
problems" found at the Errata document
   +   for your device located at 
https://infocenter.nordicsemi.com/index.jsp  */
   +if (nrf53_errata_97()) {
   +if (*((volatile uint32_t *)0x50004A20ul) == 0) {
   +*((volatile uint32_t *)0x50004A20ul) = 0xDul;
   +*((volatile uint32_t *)0x5000491Cul) = 0x1ul;
   +*((volatile uint32_t *)0x5000491Cul) = 0x0ul;
}
   -
   -/* Trimming of the device. Copy all the trimming values from FICR 
into the target addresses. Trim
   - until one ADDR is not initialized. */
   -uint32_t index = 0;
   -for (index = 0; index < 32ul && NRF_FICR_S->TRIMCNF[index].ADDR != 
(uint32_t *)0xul; index++){
   -#if defined ( __ICCARM__ )
   -/* IAR will complain about the order of volatile pointer 
accesses. */
   +}
   +
   +/* Trimming of the device. Copy all the trimming values from FICR into 
the target addresses. Trim
   +   until one ADDR is not initialized. */
   +uint32_t index = 0;
   +for (index = 0; index < 32ul && NRF_FICR_S->TRIMCNF[index].ADDR != 
(uint32_t *)0xul; index++) {
   +#if defined (__ICCARM__)
   +/* IAR will complain about the order of volatile pointer accesses. 
*/
#pragma diag_suppress=Pa082
#endif
   -*((volatile uint32_t *)NRF_FICR_S->TRIMCNF[index].ADDR) = 
NRF_FICR_S->TRIMCNF[index].DATA;
   -#if def