[jira] [Created] (TAP5-1736) Overridden base class methods causing a second submit
Overridden base class methods causing a second submit
-
Key: TAP5-1736
URL: https://issues.apache.org/jira/browse/TAP5-1736
Project: Tapestry 5
Issue Type: Bug
Components: tapestry-core
Affects Versions: 5.3
Reporter: Peter Stavrinides
As of Tapestry 5.3.0 overridden base class methods are causing a second submit,
behaviour not present in Tapestry 5.1:
public abstract class BaseClass {
public abstract Object onSuccessFromStep1();
}
public class SubClass extends BaseClass{
@Override
public Object onSuccessFromStep1() {
if (!foundErrors())
incrementStep();
return null;
}
}
onSuccessFromStep1() is invoked twice in this example... the simple workaround
is to return true, but this will not suffice when handling objects.
Comment from Howard:
I suspect Tapestry is not recognizing that
SubClass.onSuccessFromStep1() is an override of
BaseClass.onSuccessFromStep1() (perhaps the abstract flag is throwing
it).
So, Tapestry builds code for BaseClass, and implements
dispatchComponentEvent() to invoke onSuccessFromStep1().
It then builds code for SubClass, sees onSuccessFromStep1(), doesn't
think it's an override of the base class method (for whatever reason),
and implements dispatchComponentEvent() to (a) invoke
super.dispatchComponentEvent(), and (b) invoke onSuccessFromStep1().
Thus two invocations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1323) Change Quickstart Template to Match New Site Design
[ https://issues.apache.org/jira/browse/TAP5-1323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13139981#comment-13139981 ] Jochen Kemnade commented on TAP5-1323: -- Shouldn't the 5.3 quickstart layout also be changed? Change Quickstart Template to Match New Site Design --- Key: TAP5-1323 URL: https://issues.apache.org/jira/browse/TAP5-1323 Project: Tapestry 5 Issue Type: Improvement Components: quickstart Reporter: Mark Shead Assignee: Ulrich Stärk Priority: Minor Fix For: 5.3 Attachments: TAP5-1323.diff, images.zip Having the quickstart template match the look of the new site and the hotel booking application would be beneficial from a branding standpoint. Howard Lewis Ship to Tapestry Oct 21 (1 day ago) That's a great idea. On Thu, Oct 21, 2010 at 12:52 PM, Mark W. Shead mwsh...@gmail.com wrote: I like the look of the application. I wonder if it would help with Tapestry branding to use the same template and style for 5.2.2 archetype theme instead of the Concrete theme that is currently being used. Mark -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1338) Add informal parameters support to Form component
[ https://issues.apache.org/jira/browse/TAP5-1338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140011#comment-13140011 ] Emmanuel DEMEY commented on TAP5-1338: -- Hi This issue can be closed. resolved by Howard. Cf. https://issues.apache.org/jira/browse/TAP5-724 Add informal parameters support to Form component - Key: TAP5-1338 URL: https://issues.apache.org/jira/browse/TAP5-1338 Project: Tapestry 5 Issue Type: Improvement Components: tapestry-core Affects Versions: 5.2 Reporter: Anton N. Mezerny Priority: Minor Add @SupportsInformalParameters annotation to the Form component. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1704) Localizing the Today and None labels in the core datefield component
[ https://issues.apache.org/jira/browse/TAP5-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140018#comment-13140018 ] Emmanuel DEMEY commented on TAP5-1704: -- But these 2 strings are hardcoded in the external datepicker.js. I think we can not change this behavior easily. Localizing the Today and None labels in the core datefield component Key: TAP5-1704 URL: https://issues.apache.org/jira/browse/TAP5-1704 Project: Tapestry 5 Issue Type: Bug Components: tapestry-core Affects Versions: 5.3 Reporter: Patricia Arranz In de DateField Component the text of the buttons Today and None don´t get translated. they are hardcoded in the javascript code. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
svn commit: r1195399 - /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/package-info.java
Author: bobharner Date: Mon Oct 31 10:34:02 2011 New Revision: 1195399 URL: http://svn.apache.org/viewvc?rev=1195399view=rev Log: TAP5-1735 adding some of the missing package-level javadocs (and replacing some package.html with package-info.java) Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/package-info.java Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/package-info.java URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/package-info.java?rev=1195399r1=1195398r2=1195399view=diff == --- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/package-info.java (original) +++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/package-info.java Mon Oct 31 10:34:02 2011 @@ -15,4 +15,4 @@ /** * The set of core components available in all Tapestry applications */ -package org.apache.tapestry5.corelib.base; +package org.apache.tapestry5.corelib.components;
[jira] [Commented] (TAP5-1735) Most packages lack package-level javadocs
[ https://issues.apache.org/jira/browse/TAP5-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140074#comment-13140074 ] Hudson commented on TAP5-1735: -- Integrated in tapestry-trunk-freestyle #617 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/617/]) TAP5-1735 adding some of the missing package-level javadocs (and replacing some package.html with package-info.java) bobharner : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1195399 Files : * /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/package-info.java Most packages lack package-level javadocs - Key: TAP5-1735 URL: https://issues.apache.org/jira/browse/TAP5-1735 Project: Tapestry 5 Issue Type: Bug Components: documentation Affects Versions: 5.2.0 Reporter: Bob Harner Assignee: Bob Harner Priority: Minor As can be seen at http://tapestry.apache.org/current/apidocs/overview-summary.html, most Tapestry packages lack package-level javadocs (package-info.java or package.html). New users may see this page as their first introduction to Tapestry's javadoc documentation, and it seems very sparse. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (TAP5-1338) Add informal parameters support to Form component
[ https://issues.apache.org/jira/browse/TAP5-1338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Howard M. Lewis Ship closed TAP5-1338. -- Resolution: Duplicate Assignee: Howard M. Lewis Ship Add informal parameters support to Form component - Key: TAP5-1338 URL: https://issues.apache.org/jira/browse/TAP5-1338 Project: Tapestry 5 Issue Type: Improvement Components: tapestry-core Affects Versions: 5.2 Reporter: Anton N. Mezerny Assignee: Howard M. Lewis Ship Priority: Minor Add @SupportsInformalParameters annotation to the Form component. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[CONF] Apache Tapestry Release Notes
Release Notes Page edited by Howard M. Lewis Ship Changes (1) These release notes provide the details of the changes in each Tapestry version. || Tapestry 5.3 | [Consolidated Release Notes for 5.3|Release Notes 5.3] | _Current release candidate_ | || Tapestry 5.2 | [Consolidated Release Notes for 5.2|Release Notes 5.2] | *This is the current stable release* | || | nbsp; nbsp; [Release Notes 5.2.5] | Released 23 Mar 2011 | ... Full Content These release notes provide the details of the changes in each Tapestry version. Tapestry 5.3 Release Notes for 5.3 Current release candidate Tapestry 5.2 Consolidated Release Notes for 5.2 This is the current stable release Release Notes 5.2.5 Released 23 Mar 2011 Release Notes 5.2.4 Released 15 Nov 2010 Release Notes 5.2.3 Released 11 Nov 2010 Release Notes 5.2.2 Released 24 Oct 2010 Release Notes 5.2.1 Released 29 Sep 2010 Release Notes 5.2.0 Released 8 Aug 2010 Tapestry 5.1 Release Notes 5.1 Released 12Apr 2009 Tapestry 5.0 Release Notes 5.0 Released Dec 2008 Change Notification Preferences View Online | View Changes
[CONF] Apache Tapestry Tapestry 5.3 Release Candidate
Tapestry 5.3 Release Candidate
Blog post added by Howard M. Lewis Ship
We've released the first release candidate for Tapestry 5.3: Apache Tapestry 5.3-rc-1.
This represents the better part of a year of work, containing over 270 bug fixes and improvements, ranging from the trivial one-line bug fixes all the way up to a complete reimplementation of how Tapestry performs bytecode transformation of component classes. Tapestry 5.3 includes significant improvements to performance (especially in production mode), and reduces the memory footprint of the running application. See the release notes for full details about improvements, upgrades, and fixed bugs and issues.
To use the release candidate, update your build.gradle to include the Apache Maven Staging Repository:
repositories {
mavenCentral()
// For access to Apache Staging (Preview) packages
mavenRepo urls: "https://repository.apache.org/content/groups/staging"
}
Oh, are you still using Maven? My condolences; here you go:
repositories
repository
idapache-staging/id
urlhttps://repository.apache.org/content/groups/staging//url
/repository
/repositories
Change Notification Preferences
View Online
svn commit: r1195567 - /tapestry/tapestry5/tags/5.3-rc-1/
Author: hlship Date: Mon Oct 31 16:56:28 2011 New Revision: 1195567 URL: http://svn.apache.org/viewvc?rev=1195567view=rev Log: Create a tag for the 5.3-rc-1 preview Added: tapestry/tapestry5/tags/5.3-rc-1/ (props changed) - copied from r1195566, tapestry/tapestry5/trunk/ Propchange: tapestry/tapestry5/tags/5.3-rc-1/ -- --- svn:ignore (added) +++ svn:ignore Mon Oct 31 16:56:28 2011 @@ -0,0 +1,20 @@ +*.idea +*.iml +*.ipr +*.iws +.classpath +.externalToolBuilders +.gradle +.project +.settings +bin +bin-test +build +conf +db +hooks +locks +out +target +temp-testng-customsuite.xml +test-output Propchange: tapestry/tapestry5/tags/5.3-rc-1/ -- --- svn:mergeinfo (added) +++ svn:mergeinfo Mon Oct 31 16:56:28 2011 @@ -0,0 +1,4 @@ +/tapestry/tapestry5/branches/5.0:717929-719744,723395-728733 +/tapestry/tapestry5/branches/hlship-5.0-perf:726734-728728 +/tapestry/tapestry5/tags/releases/5.0.17:719745 +/tapestry/tapestry5/tags/releases/hlship-5.0-perf:726733
svn commit: r1195569 - /tapestry/tapestry5/branches/5.3/
Author: hlship Date: Mon Oct 31 17:03:00 2011 New Revision: 1195569 URL: http://svn.apache.org/viewvc?rev=1195569view=rev Log: Create a branch for the 5.3 release, to capture any final changes to release candidates Added: tapestry/tapestry5/branches/5.3/ (props changed) - copied from r1195568, tapestry/tapestry5/trunk/ Propchange: tapestry/tapestry5/branches/5.3/ -- --- svn:ignore (added) +++ svn:ignore Mon Oct 31 17:03:00 2011 @@ -0,0 +1,20 @@ +*.idea +*.iml +*.ipr +*.iws +.classpath +.externalToolBuilders +.gradle +.project +.settings +bin +bin-test +build +conf +db +hooks +locks +out +target +temp-testng-customsuite.xml +test-output Propchange: tapestry/tapestry5/branches/5.3/ -- --- svn:mergeinfo (added) +++ svn:mergeinfo Mon Oct 31 17:03:00 2011 @@ -0,0 +1,4 @@ +/tapestry/tapestry5/branches/5.0:717929-719744,723395-728733 +/tapestry/tapestry5/branches/hlship-5.0-perf:726734-728728 +/tapestry/tapestry5/tags/releases/5.0.17:719745 +/tapestry/tapestry5/tags/releases/hlship-5.0-perf:726733
svn commit: r1195617 - /tapestry/tapestry5/trunk/build.gradle
Author: hlship Date: Mon Oct 31 19:00:53 2011 New Revision: 1195617 URL: http://svn.apache.org/viewvc?rev=1195617view=rev Log: Advance version number to 5.3-rc-1 Modified: tapestry/tapestry5/trunk/build.gradle Modified: tapestry/tapestry5/trunk/build.gradle URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/build.gradle?rev=1195617r1=1195616r2=1195617view=diff == --- tapestry/tapestry5/trunk/build.gradle (original) +++ tapestry/tapestry5/trunk/build.gradle Mon Oct 31 19:00:53 2011 @@ -2,7 +2,7 @@ description = Apache Tapestry 5 Project // Remember that when generating a release, this should be incremented. Also don't forget to // tag the release in Subversion. -tapestryVersion = 5.3-beta-30 +tapestryVersion = 5.3-rc-1 jettyVersion = '7.0.0.v20091005' tomcatVersion = '6.0.30'
[jira] [Created] (TAP5-1737) Loading all pages using PageCatalog page fails with java.lang.ClassFormatError: Illegal field modifiers in class org/apache/tapestry5/corelib/pages/package-info: 0x12
Loading all pages using PageCatalog page fails with java.lang.ClassFormatError: Illegal field modifiers in class org/apache/tapestry5/corelib/pages/package-info: 0x12 -- Key: TAP5-1737 URL: https://issues.apache.org/jira/browse/TAP5-1737 Project: Tapestry 5 Issue Type: Bug Components: tapestry-core Affects Versions: 5.3 Reporter: Howard M. Lewis Ship Priority: Blocker This appeared very last minute, when a package-info.java was created for the org.apache.tapestry5.corelib.pages -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (TAP5-1737) Loading all pages using PageCatalog page fails with java.lang.ClassFormatError: Illegal field modifiers in class org/apache/tapestry5/corelib/pages/package-info: 0x12
[ https://issues.apache.org/jira/browse/TAP5-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Howard M. Lewis Ship reassigned TAP5-1737: -- Assignee: Howard M. Lewis Ship Loading all pages using PageCatalog page fails with java.lang.ClassFormatError: Illegal field modifiers in class org/apache/tapestry5/corelib/pages/package-info: 0x12 -- Key: TAP5-1737 URL: https://issues.apache.org/jira/browse/TAP5-1737 Project: Tapestry 5 Issue Type: Bug Components: tapestry-core Affects Versions: 5.3 Reporter: Howard M. Lewis Ship Assignee: Howard M. Lewis Ship Priority: Blocker This appeared very last minute, when a package-info.java was created for the org.apache.tapestry5.corelib.pages -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
svn commit: r1195662 - /tapestry/tapestry5/branches/5.3/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/ClassNameLocatorImpl.java
Author: hlship
Date: Mon Oct 31 20:48:21 2011
New Revision: 1195662
URL: http://svn.apache.org/viewvc?rev=1195662view=rev
Log:
TAP5-1737: Loading all pages using PageCatalog page fails with
java.lang.ClassFormatError: Illegal field modifiers in class
org/apache/tapestry5/corelib/pages/package-info: 0x12
Modified:
tapestry/tapestry5/branches/5.3/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/ClassNameLocatorImpl.java
Modified:
tapestry/tapestry5/branches/5.3/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/ClassNameLocatorImpl.java
URL:
http://svn.apache.org/viewvc/tapestry/tapestry5/branches/5.3/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/ClassNameLocatorImpl.java?rev=1195662r1=1195661r2=1195662view=diff
==
---
tapestry/tapestry5/branches/5.3/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/ClassNameLocatorImpl.java
(original)
+++
tapestry/tapestry5/branches/5.3/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/ClassNameLocatorImpl.java
Mon Oct 31 20:48:21 2011
@@ -278,7 +278,9 @@ public class ClassNameLocatorImpl implem
{
scanDir(packageName + . + fileName, file,
componentClassNames);
}
-else if (fileName.endsWith(CLASS_SUFFIX))
+// https://issues.apache.org/jira/browse/TAP5-1737
+// Use of package-info.java leaves these package-info.class
files around.
+else if (fileName.endsWith(CLASS_SUFFIX) !
fileName.equals(package-info))
{
String className = packageName + . +
fileName.substring(0,
fileName.length() - CLASS_SUFFIX.length());
svn commit: r1195663 - /tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/ClassNameLocatorImpl.java
Author: hlship
Date: Mon Oct 31 20:48:30 2011
New Revision: 1195663
URL: http://svn.apache.org/viewvc?rev=1195663view=rev
Log:
TAP5-1737: Loading all pages using PageCatalog page fails with
java.lang.ClassFormatError: Illegal field modifiers in class
org/apache/tapestry5/corelib/pages/package-info: 0x12
Modified:
tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/ClassNameLocatorImpl.java
Modified:
tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/ClassNameLocatorImpl.java
URL:
http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/ClassNameLocatorImpl.java?rev=1195663r1=1195662r2=1195663view=diff
==
---
tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/ClassNameLocatorImpl.java
(original)
+++
tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/ClassNameLocatorImpl.java
Mon Oct 31 20:48:30 2011
@@ -278,7 +278,9 @@ public class ClassNameLocatorImpl implem
{
scanDir(packageName + . + fileName, file,
componentClassNames);
}
-else if (fileName.endsWith(CLASS_SUFFIX))
+// https://issues.apache.org/jira/browse/TAP5-1737
+// Use of package-info.java leaves these package-info.class
files around.
+else if (fileName.endsWith(CLASS_SUFFIX) !
fileName.equals(package-info))
{
String className = packageName + . +
fileName.substring(0,
fileName.length() - CLASS_SUFFIX.length());
svn commit: r1195664 - /tapestry/tapestry5/trunk/build.gradle
Author: hlship Date: Mon Oct 31 20:48:33 2011 New Revision: 1195664 URL: http://svn.apache.org/viewvc?rev=1195664view=rev Log: Roll version number for trunk to 5.4-alpha-1 Modified: tapestry/tapestry5/trunk/build.gradle Modified: tapestry/tapestry5/trunk/build.gradle URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/build.gradle?rev=1195664r1=1195663r2=1195664view=diff == --- tapestry/tapestry5/trunk/build.gradle (original) +++ tapestry/tapestry5/trunk/build.gradle Mon Oct 31 20:48:33 2011 @@ -2,7 +2,7 @@ description = Apache Tapestry 5 Project // Remember that when generating a release, this should be incremented. Also don't forget to // tag the release in Subversion. -tapestryVersion = 5.3-rc-1 +tapestryVersion = 5.4-alpha-1 jettyVersion = '7.0.0.v20091005' tomcatVersion = '6.0.30'
svn commit: r1195666 - /tapestry/tapestry5/branches/5.3/build.gradle
Author: hlship Date: Mon Oct 31 20:49:27 2011 New Revision: 1195666 URL: http://svn.apache.org/viewvc?rev=1195666view=rev Log: Roll version number to 5.1-rc-2. Modified: tapestry/tapestry5/branches/5.3/build.gradle Modified: tapestry/tapestry5/branches/5.3/build.gradle URL: http://svn.apache.org/viewvc/tapestry/tapestry5/branches/5.3/build.gradle?rev=1195666r1=1195665r2=1195666view=diff == --- tapestry/tapestry5/branches/5.3/build.gradle (original) +++ tapestry/tapestry5/branches/5.3/build.gradle Mon Oct 31 20:49:27 2011 @@ -2,7 +2,7 @@ description = Apache Tapestry 5 Project // Remember that when generating a release, this should be incremented. Also don't forget to // tag the release in Subversion. -tapestryVersion = 5.3-beta-30 +tapestryVersion = 5.3-rc-2 jettyVersion = '7.0.0.v20091005' tomcatVersion = '6.0.30'
[CONF] Apache Tapestry Tapestry 5.3 Release Candidate
Tapestry 5.3 Release Candidate
Blog post edited by Howard M. Lewis Ship
Changes (1)
{excerpt}Weve released the first a new *release candidate* for Tapestry 5.3: Apache Tapestry *5.3-rc-12*.{excerpt}
This represents the better part of a year of work, containing over 270 bug fixes and improvements, ranging from the trivial one-line bug fixes all the way up to a complete reimplementation of how Tapestry performs bytecode transformation of component classes. Tapestry 5.3 includes significant improvements to performance (especially in production mode), and reduces the memory footprint of the running application. See the [release notes|TAPESTRY:Release Notes 5.3] for full details about improvements, upgrades, and fixed bugs and issues.
...
Full Content
We've released a new release candidate for Tapestry 5.3: Apache Tapestry 5.3-rc-2.
This represents the better part of a year of work, containing over 270 bug fixes and improvements, ranging from the trivial one-line bug fixes all the way up to a complete reimplementation of how Tapestry performs bytecode transformation of component classes. Tapestry 5.3 includes significant improvements to performance (especially in production mode), and reduces the memory footprint of the running application. See the release notes for full details about improvements, upgrades, and fixed bugs and issues.
To use the release candidate, update your build.gradle to include the Apache Maven Staging Repository:
repositories {
mavenCentral()
// For access to Apache Staging (Preview) packages
mavenRepo urls: "https://repository.apache.org/content/groups/staging"
}
Oh, are you still using Maven? My condolences; here you go:
repositories
repository
idapache-staging/id
urlhttps://repository.apache.org/content/groups/staging//url
/repository
/repositories
Change Notification Preferences
View Online
|
View Changes
svn commit: r1195682 - /tapestry/tapestry5/branches/5.3/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/ClassNameLocatorImpl.java
Author: hlship
Date: Mon Oct 31 21:31:32 2011
New Revision: 1195682
URL: http://svn.apache.org/viewvc?rev=1195682view=rev
Log:
TAP5-1737: Loading all pages using PageCatalog page fails with
java.lang.ClassFormatError: Illegal field modifiers in class
org/apache/tapestry5/corelib/pages/package-info: 0x12
Modified:
tapestry/tapestry5/branches/5.3/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/ClassNameLocatorImpl.java
Modified:
tapestry/tapestry5/branches/5.3/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/ClassNameLocatorImpl.java
URL:
http://svn.apache.org/viewvc/tapestry/tapestry5/branches/5.3/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/ClassNameLocatorImpl.java?rev=1195682r1=1195681r2=1195682view=diff
==
---
tapestry/tapestry5/branches/5.3/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/ClassNameLocatorImpl.java
(original)
+++
tapestry/tapestry5/branches/5.3/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/ClassNameLocatorImpl.java
Mon Oct 31 21:31:32 2011
@@ -280,7 +280,7 @@ public class ClassNameLocatorImpl implem
}
// https://issues.apache.org/jira/browse/TAP5-1737
// Use of package-info.java leaves these package-info.class
files around.
-else if (fileName.endsWith(CLASS_SUFFIX) !
fileName.equals(package-info))
+else if (fileName.endsWith(CLASS_SUFFIX) !
fileName.equals(package-info.class))
{
String className = packageName + . +
fileName.substring(0,
fileName.length() - CLASS_SUFFIX.length());
svn commit: r1195683 - /tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/ClassNameLocatorImpl.java
Author: hlship
Date: Mon Oct 31 21:31:39 2011
New Revision: 1195683
URL: http://svn.apache.org/viewvc?rev=1195683view=rev
Log:
TAP5-1737: Loading all pages using PageCatalog page fails with
java.lang.ClassFormatError: Illegal field modifiers in class
org/apache/tapestry5/corelib/pages/package-info: 0x12
Modified:
tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/ClassNameLocatorImpl.java
Modified:
tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/ClassNameLocatorImpl.java
URL:
http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/ClassNameLocatorImpl.java?rev=1195683r1=1195682r2=1195683view=diff
==
---
tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/ClassNameLocatorImpl.java
(original)
+++
tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/ClassNameLocatorImpl.java
Mon Oct 31 21:31:39 2011
@@ -280,7 +280,7 @@ public class ClassNameLocatorImpl implem
}
// https://issues.apache.org/jira/browse/TAP5-1737
// Use of package-info.java leaves these package-info.class
files around.
-else if (fileName.endsWith(CLASS_SUFFIX) !
fileName.equals(package-info))
+else if (fileName.endsWith(CLASS_SUFFIX) !
fileName.equals(package-info.class))
{
String className = packageName + . +
fileName.substring(0,
fileName.length() - CLASS_SUFFIX.length());
svn commit: r1195690 - /tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/ClassNameLocatorImpl.java
Author: hlship
Date: Mon Oct 31 21:48:11 2011
New Revision: 1195690
URL: http://svn.apache.org/viewvc?rev=1195690view=rev
Log:
TAP5-1737: Loading all pages using PageCatalog page fails with
java.lang.ClassFormatError: Illegal field modifiers in class
org/apache/tapestry5/corelib/pages/package-info: 0x12
Modified:
tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/ClassNameLocatorImpl.java
Modified:
tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/ClassNameLocatorImpl.java
URL:
http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/ClassNameLocatorImpl.java?rev=1195690r1=1195689r2=1195690view=diff
==
---
tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/ClassNameLocatorImpl.java
(original)
+++
tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/ClassNameLocatorImpl.java
Mon Oct 31 21:48:11 2011
@@ -74,8 +74,7 @@ public class ClassNameLocatorImpl implem
return findClassesWithinPath(packagePath);
-}
-catch (IOException ex)
+} catch (IOException ex)
{
throw new RuntimeException(ex);
}
@@ -108,8 +107,7 @@ public class ClassNameLocatorImpl implem
if (connection instanceof JarURLConnection)
{
jarFile = ((JarURLConnection) connection).getJarFile();
-}
-else
+} else
{
jarFile = getAlternativeJarFile(url);
}
@@ -117,8 +115,7 @@ public class ClassNameLocatorImpl implem
if (jarFile != null)
{
scanJarFile(packagePath, componentClassNames, jarFile);
-}
-else if (supportsDirStream(url))
+} else if (supportsDirStream(url))
{
StackQueued queue = CollectionFactory.newStack();
@@ -130,8 +127,7 @@ public class ClassNameLocatorImpl implem
scanDirStream(queued.packagePath, queued.packageURL,
componentClassNames, queue);
}
-}
-else
+} else
{
// Try scanning file system.
String packageName = packagePath.replace(/, .);
@@ -157,16 +153,13 @@ public class ClassNameLocatorImpl implem
{
is = packageURL.openStream();
return true;
-}
-catch (FileNotFoundException ex)
+} catch (FileNotFoundException ex)
{
return false;
-}
-catch (IOException e)
+} catch (IOException e)
{
return false;
-}
-finally
+} finally
{
InternalUtils.close(is);
}
@@ -180,8 +173,7 @@ public class ClassNameLocatorImpl implem
try
{
is = new BufferedInputStream(packageURL.openStream());
-}
-catch (FileNotFoundException ex)
+} catch (FileNotFoundException ex)
{
// This can happen for certain application servers (JBoss 4.0.5
for example), that
// export part of the exploded WAR for deployment, but leave part
(WEB-INF/classes)
@@ -205,13 +197,21 @@ public class ClassNameLocatorImpl implem
if (CLASS_NAME_PATTERN.matcher(line).matches())
{
-if (packageName == null) packageName =
packagePath.replace('/', '.');
+if (packageName == null)
+{
+packageName = packagePath.replace('/', '.');
+}
// packagePath ends with '/', packageName ends with '.'
-String fullClassName = packageName + line.substring(0,
line.length() - CLASS_SUFFIX.length());
+String fileName = line.substring(0, line.length() -
CLASS_SUFFIX.length());
-componentClassNames.add(fullClassName);
+if (!fileName.equals(package-info))
+{
+String fullClassName = packageName + fileName;
+
+componentClassNames.add(fullClassName);
+}
continue;
}
@@ -230,8 +230,7 @@ public class ClassNameLocatorImpl implem
lineReader.close();
lineReader = null;
-}
-finally
+} finally
{
InternalUtils.close(lineReader);
}
@@ -280,10 +279,10 @@ public class ClassNameLocatorImpl implem
}
// https://issues.apache.org/jira/browse/TAP5-1737
// Use of package-info.java leaves these package-info.class
files around.
-else if (fileName.endsWith(CLASS_SUFFIX) !
fileName.equals(package-info.class))
+
svn commit: r1195691 - /tapestry/tapestry5/branches/5.3/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/ClassNameLocatorImpl.java
Author: hlship
Date: Mon Oct 31 21:48:39 2011
New Revision: 1195691
URL: http://svn.apache.org/viewvc?rev=1195691view=rev
Log:
TAP5-1737: Loading all pages using PageCatalog page fails with
java.lang.ClassFormatError: Illegal field modifiers in class
org/apache/tapestry5/corelib/pages/package-info: 0x12
Modified:
tapestry/tapestry5/branches/5.3/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/ClassNameLocatorImpl.java
Modified:
tapestry/tapestry5/branches/5.3/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/ClassNameLocatorImpl.java
URL:
http://svn.apache.org/viewvc/tapestry/tapestry5/branches/5.3/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/ClassNameLocatorImpl.java?rev=1195691r1=1195690r2=1195691view=diff
==
---
tapestry/tapestry5/branches/5.3/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/ClassNameLocatorImpl.java
(original)
+++
tapestry/tapestry5/branches/5.3/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/ClassNameLocatorImpl.java
Mon Oct 31 21:48:39 2011
@@ -74,8 +74,7 @@ public class ClassNameLocatorImpl implem
return findClassesWithinPath(packagePath);
-}
-catch (IOException ex)
+} catch (IOException ex)
{
throw new RuntimeException(ex);
}
@@ -108,8 +107,7 @@ public class ClassNameLocatorImpl implem
if (connection instanceof JarURLConnection)
{
jarFile = ((JarURLConnection) connection).getJarFile();
-}
-else
+} else
{
jarFile = getAlternativeJarFile(url);
}
@@ -117,8 +115,7 @@ public class ClassNameLocatorImpl implem
if (jarFile != null)
{
scanJarFile(packagePath, componentClassNames, jarFile);
-}
-else if (supportsDirStream(url))
+} else if (supportsDirStream(url))
{
StackQueued queue = CollectionFactory.newStack();
@@ -130,8 +127,7 @@ public class ClassNameLocatorImpl implem
scanDirStream(queued.packagePath, queued.packageURL,
componentClassNames, queue);
}
-}
-else
+} else
{
// Try scanning file system.
String packageName = packagePath.replace(/, .);
@@ -157,16 +153,13 @@ public class ClassNameLocatorImpl implem
{
is = packageURL.openStream();
return true;
-}
-catch (FileNotFoundException ex)
+} catch (FileNotFoundException ex)
{
return false;
-}
-catch (IOException e)
+} catch (IOException e)
{
return false;
-}
-finally
+} finally
{
InternalUtils.close(is);
}
@@ -180,8 +173,7 @@ public class ClassNameLocatorImpl implem
try
{
is = new BufferedInputStream(packageURL.openStream());
-}
-catch (FileNotFoundException ex)
+} catch (FileNotFoundException ex)
{
// This can happen for certain application servers (JBoss 4.0.5
for example), that
// export part of the exploded WAR for deployment, but leave part
(WEB-INF/classes)
@@ -205,13 +197,21 @@ public class ClassNameLocatorImpl implem
if (CLASS_NAME_PATTERN.matcher(line).matches())
{
-if (packageName == null) packageName =
packagePath.replace('/', '.');
+if (packageName == null)
+{
+packageName = packagePath.replace('/', '.');
+}
// packagePath ends with '/', packageName ends with '.'
-String fullClassName = packageName + line.substring(0,
line.length() - CLASS_SUFFIX.length());
+String fileName = line.substring(0, line.length() -
CLASS_SUFFIX.length());
-componentClassNames.add(fullClassName);
+if (!fileName.equals(package-info))
+{
+String fullClassName = packageName + fileName;
+
+componentClassNames.add(fullClassName);
+}
continue;
}
@@ -230,8 +230,7 @@ public class ClassNameLocatorImpl implem
lineReader.close();
lineReader = null;
-}
-finally
+} finally
{
InternalUtils.close(lineReader);
}
@@ -280,10 +279,10 @@ public class ClassNameLocatorImpl implem
}
// https://issues.apache.org/jira/browse/TAP5-1737
// Use of package-info.java leaves these package-info.class
files around.
-else if (fileName.endsWith(CLASS_SUFFIX) !
svn commit: r1195700 - /tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/ClassNameLocatorImpl.java
Author: hlship
Date: Mon Oct 31 22:15:27 2011
New Revision: 1195700
URL: http://svn.apache.org/viewvc?rev=1195700view=rev
Log:
TAP5-1737: Loading all pages using PageCatalog page fails with
java.lang.ClassFormatError: Illegal field modifiers in class
org/apache/tapestry5/corelib/pages/package-info: 0x12
Modified:
tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/ClassNameLocatorImpl.java
Modified:
tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/ClassNameLocatorImpl.java
URL:
http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/ClassNameLocatorImpl.java?rev=1195700r1=1195699r2=1195700view=diff
==
---
tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/ClassNameLocatorImpl.java
(original)
+++
tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/ClassNameLocatorImpl.java
Mon Oct 31 22:15:27 2011
@@ -33,6 +33,7 @@ import java.util.regex.Pattern;
public class ClassNameLocatorImpl implements ClassNameLocator
{
private static final String CLASS_SUFFIX = .class;
+public static final String PACKAGE_INFO = package-info.class;
private final ClassLoader contextClassLoader =
Thread.currentThread().getContextClassLoader();
@@ -247,15 +248,22 @@ public class ClassNameLocatorImpl implem
if (!name.startsWith(packagePath)) continue;
-if (!name.endsWith(CLASS_SUFFIX)) continue;
-if (name.contains($)) continue;
+int lastSlashx = name.lastIndexOf('/');
-// Strip off .class and convert the slashes back to periods.
+String fileName = name.substring(lastSlashx + 1);
-String className = name.substring(0, name.length() -
CLASS_SUFFIX.length()).replace(/, .);
+if (isClassName(fileName))
+{
+
+// Strip off .class and convert the slashes back to periods.
+String className =
+name.substring(0, lastSlashx + 1).replace('/', '.') +
+fileName.substring(0, fileName.length() -
CLASS_SUFFIX.length());
-componentClassNames.add(className);
+
+componentClassNames.add(className);
+}
}
}
@@ -279,7 +287,7 @@ public class ClassNameLocatorImpl implem
}
// https://issues.apache.org/jira/browse/TAP5-1737
// Use of package-info.java leaves these package-info.class
files around.
-else if (fileName.endsWith(CLASS_SUFFIX)
!fileName.equals(package-info.class))
+else if (isClassName(fileName))
{
String className = packageName + . +
fileName.substring(0,
fileName.length() - CLASS_SUFFIX.length());
@@ -289,6 +297,11 @@ public class ClassNameLocatorImpl implem
}
}
+private boolean isClassName(String fileName)
+{
+return fileName.endsWith(CLASS_SUFFIX)
!fileName.equals(PACKAGE_INFO) !fileName.contains($);
+}
+
/**
* For URLs to JARs that do not use JarURLConnection - allowed by the
servlet spec - attempt to produce a JarFile
* object all the same. Known servlet engines that function like this
include Weblogic and OC4J. This is not a full
svn commit: r1195702 - /tapestry/tapestry5/branches/5.3/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/ClassNameLocatorImpl.java
Author: hlship
Date: Mon Oct 31 22:15:48 2011
New Revision: 1195702
URL: http://svn.apache.org/viewvc?rev=1195702view=rev
Log:
TAP5-1737: Loading all pages using PageCatalog page fails with
java.lang.ClassFormatError: Illegal field modifiers in class
org/apache/tapestry5/corelib/pages/package-info: 0x12
Modified:
tapestry/tapestry5/branches/5.3/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/ClassNameLocatorImpl.java
Modified:
tapestry/tapestry5/branches/5.3/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/ClassNameLocatorImpl.java
URL:
http://svn.apache.org/viewvc/tapestry/tapestry5/branches/5.3/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/ClassNameLocatorImpl.java?rev=1195702r1=1195701r2=1195702view=diff
==
---
tapestry/tapestry5/branches/5.3/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/ClassNameLocatorImpl.java
(original)
+++
tapestry/tapestry5/branches/5.3/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/ClassNameLocatorImpl.java
Mon Oct 31 22:15:48 2011
@@ -33,6 +33,7 @@ import java.util.regex.Pattern;
public class ClassNameLocatorImpl implements ClassNameLocator
{
private static final String CLASS_SUFFIX = .class;
+public static final String PACKAGE_INFO = package-info.class;
private final ClassLoader contextClassLoader =
Thread.currentThread().getContextClassLoader();
@@ -247,15 +248,22 @@ public class ClassNameLocatorImpl implem
if (!name.startsWith(packagePath)) continue;
-if (!name.endsWith(CLASS_SUFFIX)) continue;
-if (name.contains($)) continue;
+int lastSlashx = name.lastIndexOf('/');
-// Strip off .class and convert the slashes back to periods.
+String fileName = name.substring(lastSlashx + 1);
-String className = name.substring(0, name.length() -
CLASS_SUFFIX.length()).replace(/, .);
+if (isClassName(fileName))
+{
+
+// Strip off .class and convert the slashes back to periods.
+String className =
+name.substring(0, lastSlashx + 1).replace('/', '.') +
+fileName.substring(0, fileName.length() -
CLASS_SUFFIX.length());
-componentClassNames.add(className);
+
+componentClassNames.add(className);
+}
}
}
@@ -279,7 +287,7 @@ public class ClassNameLocatorImpl implem
}
// https://issues.apache.org/jira/browse/TAP5-1737
// Use of package-info.java leaves these package-info.class
files around.
-else if (fileName.endsWith(CLASS_SUFFIX)
!fileName.equals(package-info.class))
+else if (isClassName(fileName))
{
String className = packageName + . +
fileName.substring(0,
fileName.length() - CLASS_SUFFIX.length());
@@ -289,6 +297,11 @@ public class ClassNameLocatorImpl implem
}
}
+private boolean isClassName(String fileName)
+{
+return fileName.endsWith(CLASS_SUFFIX)
!fileName.equals(PACKAGE_INFO) !fileName.contains($);
+}
+
/**
* For URLs to JARs that do not use JarURLConnection - allowed by the
servlet spec - attempt to produce a JarFile
* object all the same. Known servlet engines that function like this
include Weblogic and OC4J. This is not a full
[jira] [Commented] (TAP5-1737) Loading all pages using PageCatalog page fails with java.lang.ClassFormatError: Illegal field modifiers in class org/apache/tapestry5/corelib/pages/package-info: 0x12
[ https://issues.apache.org/jira/browse/TAP5-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140710#comment-13140710 ] Hudson commented on TAP5-1737: -- Integrated in tapestry-trunk-freestyle #619 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/619/]) TAP5-1737: Loading all pages using PageCatalog page fails with java.lang.ClassFormatError: Illegal field modifiers in class org/apache/tapestry5/corelib/pages/package-info: 0x12 TAP5-1737: Loading all pages using PageCatalog page fails with java.lang.ClassFormatError: Illegal field modifiers in class org/apache/tapestry5/corelib/pages/package-info: 0x12 hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1195700 Files : * /tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/ClassNameLocatorImpl.java hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1195690 Files : * /tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/ClassNameLocatorImpl.java Loading all pages using PageCatalog page fails with java.lang.ClassFormatError: Illegal field modifiers in class org/apache/tapestry5/corelib/pages/package-info: 0x12 -- Key: TAP5-1737 URL: https://issues.apache.org/jira/browse/TAP5-1737 Project: Tapestry 5 Issue Type: Bug Components: tapestry-core Affects Versions: 5.3 Reporter: Howard M. Lewis Ship Assignee: Howard M. Lewis Ship Priority: Blocker Fix For: 5.3 This appeared very last minute, when a package-info.java was created for the org.apache.tapestry5.corelib.pages -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
