[jira] [Comment Edited] (TAP5-2564) Unwanted auto-boxing while annotation visiting
[ https://issues.apache.org/jira/browse/TAP5-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15525557#comment-15525557 ] Eugene Vologzhanin edited comment on TAP5-2564 at 9/27/16 9:11 AM: --- Bug affect Tapestry 5.3.8, but not Tapestry 5.4. Other words, Tapestry 5.3.8 have bug, and i write above a fix. Tapestry 5.4 have no AnnotationVisitor, consequently have noy bug. was (Author: jackv...@gmail.com): Bug affect Tapestry 5.3.8, but not Tapestry 5.4 > Unwanted auto-boxing while annotation visiting > --- > > Key: TAP5-2564 > URL: https://issues.apache.org/jira/browse/TAP5-2564 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-ioc >Affects Versions: 5.3.8 >Reporter: Eugene Vologzhanin > Fix For: 5.4 > > > class org.apache.tapestry5.ioc.internal.services.AnnotationMemberValueVisitor > Line #64: final Object result = method.invoke(value); > If method return boolean, result wil be *java.lang.Boolean* not *boolean*. > In this case in rutime will be Caused by: java.lang.ClassCastException: > java.lang.Boolean cannot be cast to java.lang.Enum. > I fix with: > {code} > MemberValue memberValue; > if (method.getReturnType().isPrimitive()) { > memberValue = Annotation.createMemberValue(this.constPool, > > this.classPool.get(method.getReturnType().getName())); > } else { > memberValue = Annotation.createMemberValue(this.constPool, > this.classPool.get(result.getClass().getName())); > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Reopened] (TAP5-2564) Unwanted auto-boxing while annotation visiting
[ https://issues.apache.org/jira/browse/TAP5-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eugene Vologzhanin reopened TAP5-2564: -- Bug affect Tapestry 5.3.8, but not Tapestry 5.4 > Unwanted auto-boxing while annotation visiting > --- > > Key: TAP5-2564 > URL: https://issues.apache.org/jira/browse/TAP5-2564 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-ioc >Affects Versions: 5.3.8 >Reporter: Eugene Vologzhanin > Fix For: 5.4 > > > class org.apache.tapestry5.ioc.internal.services.AnnotationMemberValueVisitor > Line #64: final Object result = method.invoke(value); > If method return boolean, result wil be *java.lang.Boolean* not *boolean*. > In this case in rutime will be Caused by: java.lang.ClassCastException: > java.lang.Boolean cannot be cast to java.lang.Enum. > I fix with: > {code} > MemberValue memberValue; > if (method.getReturnType().isPrimitive()) { > memberValue = Annotation.createMemberValue(this.constPool, > > this.classPool.get(method.getReturnType().getName())); > } else { > memberValue = Annotation.createMemberValue(this.constPool, > this.classPool.get(result.getClass().getName())); > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (TAP5-2564) Unwanted auto-boxing while annotation visiting
[ https://issues.apache.org/jira/browse/TAP5-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jochen Kemnade closed TAP5-2564. Resolution: Fixed Alright then, since the bug doesn't affect Tapestry itself, I'll close the issue. > Unwanted auto-boxing while annotation visiting > --- > > Key: TAP5-2564 > URL: https://issues.apache.org/jira/browse/TAP5-2564 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-ioc >Affects Versions: 5.3.8 >Reporter: Eugene Vologzhanin > Fix For: 5.4 > > > class org.apache.tapestry5.ioc.internal.services.AnnotationMemberValueVisitor > Line #64: final Object result = method.invoke(value); > If method return boolean, result wil be *java.lang.Boolean* not *boolean*. > In this case in rutime will be Caused by: java.lang.ClassCastException: > java.lang.Boolean cannot be cast to java.lang.Enum. > I fix with: > {code} > MemberValue memberValue; > if (method.getReturnType().isPrimitive()) { > memberValue = Annotation.createMemberValue(this.constPool, > > this.classPool.get(method.getReturnType().getName())); > } else { > memberValue = Annotation.createMemberValue(this.constPool, > this.classPool.get(result.getClass().getName())); > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TAP5-2564) Unwanted auto-boxing while annotation visiting
[ https://issues.apache.org/jira/browse/TAP5-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15525537#comment-15525537 ] Eugene Vologzhanin commented on TAP5-2564: -- I'm not using tapestry :) I just copy yours AnnotationMemberValueVisitor in my project, and found bug. > Unwanted auto-boxing while annotation visiting > --- > > Key: TAP5-2564 > URL: https://issues.apache.org/jira/browse/TAP5-2564 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-ioc >Affects Versions: 5.3.8 >Reporter: Eugene Vologzhanin > Fix For: 5.4 > > > class org.apache.tapestry5.ioc.internal.services.AnnotationMemberValueVisitor > Line #64: final Object result = method.invoke(value); > If method return boolean, result wil be *java.lang.Boolean* not *boolean*. > In this case in rutime will be Caused by: java.lang.ClassCastException: > java.lang.Boolean cannot be cast to java.lang.Enum. > I fix with: > {code} > MemberValue memberValue; > if (method.getReturnType().isPrimitive()) { > memberValue = Annotation.createMemberValue(this.constPool, > > this.classPool.get(method.getReturnType().getName())); > } else { > memberValue = Annotation.createMemberValue(this.constPool, > this.classPool.get(result.getClass().getName())); > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (TAP5-2564) Unwanted auto-boxing while annotation visiting
[ https://issues.apache.org/jira/browse/TAP5-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jochen Kemnade updated TAP5-2564: - Fix Version/s: 5.4 > Unwanted auto-boxing while annotation visiting > --- > > Key: TAP5-2564 > URL: https://issues.apache.org/jira/browse/TAP5-2564 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-ioc >Affects Versions: 5.3.8 >Reporter: Eugene Vologzhanin > Fix For: 5.4 > > > class org.apache.tapestry5.ioc.internal.services.AnnotationMemberValueVisitor > Line #64: final Object result = method.invoke(value); > If method return boolean, result wil be *java.lang.Boolean* not *boolean*. > In this case in rutime will be Caused by: java.lang.ClassCastException: > java.lang.Boolean cannot be cast to java.lang.Enum. > I fix with: > {code} > MemberValue memberValue; > if (method.getReturnType().isPrimitive()) { > memberValue = Annotation.createMemberValue(this.constPool, > > this.classPool.get(method.getReturnType().getName())); > } else { > memberValue = Annotation.createMemberValue(this.constPool, > this.classPool.get(result.getClass().getName())); > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TAP5-2564) Unwanted auto-boxing while annotation visiting
[ https://issues.apache.org/jira/browse/TAP5-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15525514#comment-15525514 ] Jochen Kemnade commented on TAP5-2564: -- Can you upgrade to 5.4.1 then or do you need a fix for 5.3.x? > Unwanted auto-boxing while annotation visiting > --- > > Key: TAP5-2564 > URL: https://issues.apache.org/jira/browse/TAP5-2564 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-ioc >Affects Versions: 5.3.8 >Reporter: Eugene Vologzhanin > > class org.apache.tapestry5.ioc.internal.services.AnnotationMemberValueVisitor > Line #64: final Object result = method.invoke(value); > If method return boolean, result wil be *java.lang.Boolean* not *boolean*. > In this case in rutime will be Caused by: java.lang.ClassCastException: > java.lang.Boolean cannot be cast to java.lang.Enum. > I fix with: > {code} > MemberValue memberValue; > if (method.getReturnType().isPrimitive()) { > memberValue = Annotation.createMemberValue(this.constPool, > > this.classPool.get(method.getReturnType().getName())); > } else { > memberValue = Annotation.createMemberValue(this.constPool, > this.classPool.get(result.getClass().getName())); > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
buildbot success in on tapestry-site-production
The Buildbot has detected a restored build on builder tapestry-site-production while building . Full details are available at: https://ci.apache.org/builders/tapestry-site-production/builds/10917 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: bb-cms-slave Build Reason: The Nightly scheduler named 'tapestry-site-production' triggered this build Build Source Stamp: [branch tapestry/tapestry-site] HEAD Blamelist: Build succeeded! Sincerely, -The Buildbot
[jira] [Commented] (TAP5-2564) Unwanted auto-boxing while annotation visiting
[ https://issues.apache.org/jira/browse/TAP5-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15525438#comment-15525438 ] Eugene Vologzhanin commented on TAP5-2564: -- tapestry-ioc-5.4-beta-6 have no this bug :) > Unwanted auto-boxing while annotation visiting > --- > > Key: TAP5-2564 > URL: https://issues.apache.org/jira/browse/TAP5-2564 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-ioc >Affects Versions: 5.3.8 >Reporter: Eugene Vologzhanin > > class org.apache.tapestry5.ioc.internal.services.AnnotationMemberValueVisitor > Line #64: final Object result = method.invoke(value); > If method return boolean, result wil be *java.lang.Boolean* not *boolean*. > In this case in rutime will be Caused by: java.lang.ClassCastException: > java.lang.Boolean cannot be cast to java.lang.Enum. > I fix with: > {code} > MemberValue memberValue; > if (method.getReturnType().isPrimitive()) { > memberValue = Annotation.createMemberValue(this.constPool, > > this.classPool.get(method.getReturnType().getName())); > } else { > memberValue = Annotation.createMemberValue(this.constPool, > this.classPool.get(result.getClass().getName())); > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TAP5-2564) Unwanted auto-boxing while annotation visiting
[ https://issues.apache.org/jira/browse/TAP5-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15525423#comment-15525423 ] Jochen Kemnade commented on TAP5-2564: -- Can you reproduce the issue with Tapestry 5.4.1? If so, please provide more details (e.g. some code snippets) to make it possible for us to reproduce it. > Unwanted auto-boxing while annotation visiting > --- > > Key: TAP5-2564 > URL: https://issues.apache.org/jira/browse/TAP5-2564 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-ioc >Affects Versions: 5.3.8 >Reporter: Eugene Vologzhanin > > class org.apache.tapestry5.ioc.internal.services.AnnotationMemberValueVisitor > Line #64: final Object result = method.invoke(value); > If method return boolean, result wil be *java.lang.Boolean* not *boolean*. > In this case in rutime will be Caused by: java.lang.ClassCastException: > java.lang.Boolean cannot be cast to java.lang.Enum. > I fix with: > {code} > MemberValue memberValue; > if (method.getReturnType().isPrimitive()) { > memberValue = Annotation.createMemberValue(this.constPool, > > this.classPool.get(method.getReturnType().getName())); > } else { > memberValue = Annotation.createMemberValue(this.constPool, > this.classPool.get(result.getClass().getName())); > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (TAP5-2564) Unwanted auto-boxing while annotation visiting
[ https://issues.apache.org/jira/browse/TAP5-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jochen Kemnade updated TAP5-2564: - Fix Version/s: (was: 5.5.0) > Unwanted auto-boxing while annotation visiting > --- > > Key: TAP5-2564 > URL: https://issues.apache.org/jira/browse/TAP5-2564 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-ioc >Affects Versions: 5.3.8 >Reporter: Eugene Vologzhanin > > class org.apache.tapestry5.ioc.internal.services.AnnotationMemberValueVisitor > Line #64: final Object result = method.invoke(value); > If method return boolean, result wil be *java.lang.Boolean* not *boolean*. > In this case in rutime will be Caused by: java.lang.ClassCastException: > java.lang.Boolean cannot be cast to java.lang.Enum. > I fix with: > {code} > MemberValue memberValue; > if (method.getReturnType().isPrimitive()) { > memberValue = Annotation.createMemberValue(this.constPool, > > this.classPool.get(method.getReturnType().getName())); > } else { > memberValue = Annotation.createMemberValue(this.constPool, > this.classPool.get(result.getClass().getName())); > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
buildbot failure in on tapestry-site-production
The Buildbot has detected a new failure on builder tapestry-site-production while building . Full details are available at: https://ci.apache.org/builders/tapestry-site-production/builds/10916 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: bb-cms-slave Build Reason: The Nightly scheduler named 'tapestry-site-production' triggered this build Build Source Stamp: [branch tapestry/tapestry-site] HEAD Blamelist: BUILD FAILED: failed compile Sincerely, -The Buildbot