[jira] [Commented] (TAP5-2453) Generic List not fully supported
[ https://issues.apache.org/jira/browse/TAP5-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16984653#comment-16984653 ] Simon poortman commented on TAP5-2453: -- {code:java} Begin war in eu union benelux come for 1 country nederland België luxenburg = 1 bundesland {code} > Generic List not fully supported > --- > > Key: TAP5-2453 > URL: https://issues.apache.org/jira/browse/TAP5-2453 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-ioc >Affects Versions: 5.4, 5.3.8 >Reporter: Jan Mynařík >Priority: Major > Labels: desired_for_5.5, generics, help-wanted > Attachments: TapestryGenericsTest.java > > > I've created an abstract generic CRUD implementation. When binding > implementations resulting proxies doesn't fully report parametrized type via > reflections. > See attached test. In 5.3.8 it fails in all asserts, in 5.4 only in the last > one. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (TAP5-2453) Generic List not fully supported
[ https://issues.apache.org/jira/browse/TAP5-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16744370#comment-16744370 ] Hudson commented on TAP5-2453: -- FAILURE: Integrated in Jenkins build tapestry-trunk-freestyle-java-9 #15 (See [https://builds.apache.org/job/tapestry-trunk-freestyle-java-9/15/]) Revert "TAP5-2453: move GenericsUtils (and tests) to plastic" (thiago: rev faf3b20c9c8f59e890bea4eff5ce8e42df083815) * (add) tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/internal/util/NonGenericBean.java * (delete) plastic/src/test/java/org/apache/tapestry5/ioc/internal/util/NonGenericBean.java * (delete) plastic/src/main/java/org/apache/tapestry5/ioc/internal/util/GenericsUtils.java * (delete) plastic/src/test/java/org/apache/tapestry5/ioc/internal/util/StringBean.java * (delete) plastic/src/test/java/org/apache/tapestry5/ioc/internal/util/BaseGenericBean.java * (delete) plastic/src/test/java/org/apache/tapestry5/ioc/internal/util/StringLongPair.java * (add) tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/internal/util/StringBean.java * (add) commons/src/main/java/org/apache/tapestry5/ioc/internal/util/GenericsUtils.java * (add) tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/internal/util/BaseGenericBean.java * (delete) plastic/src/test/groovy/ioc/specs/GenericUtilsSpec.groovy * (add) tapestry-ioc/src/test/groovy/ioc/specs/GenericUtilsSpec.groovy * (delete) plastic/src/test/java/org/apache/tapestry5/ioc/internal/util/Pair.java > Generic List not fully supported > --- > > Key: TAP5-2453 > URL: https://issues.apache.org/jira/browse/TAP5-2453 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-ioc >Affects Versions: 5.4, 5.3.8 >Reporter: Jan Mynařík >Priority: Major > Labels: desired_for_5.5, generics, help-wanted > Attachments: TapestryGenericsTest.java > > > I've created an abstract generic CRUD implementation. When binding > implementations resulting proxies doesn't fully report parametrized type via > reflections. > See attached test. In 5.3.8 it fails in all asserts, in 5.4 only in the last > one. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TAP5-2453) Generic List not fully supported
[ https://issues.apache.org/jira/browse/TAP5-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16744366#comment-16744366 ] Hudson commented on TAP5-2453: -- SUCCESS: Integrated in Jenkins build tapestry-trunk-freestyle #1726 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/1726/]) Revert "TAP5-2453: move GenericsUtils (and tests) to plastic" (thiago: rev faf3b20c9c8f59e890bea4eff5ce8e42df083815) * (add) tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/internal/util/NonGenericBean.java * (delete) plastic/src/test/java/org/apache/tapestry5/ioc/internal/util/Pair.java * (add) tapestry-ioc/src/test/groovy/ioc/specs/GenericUtilsSpec.groovy * (delete) plastic/src/main/java/org/apache/tapestry5/ioc/internal/util/GenericsUtils.java * (add) tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/internal/util/BaseGenericBean.java * (add) commons/src/main/java/org/apache/tapestry5/ioc/internal/util/GenericsUtils.java * (delete) plastic/src/test/java/org/apache/tapestry5/ioc/internal/util/StringLongPair.java * (delete) plastic/src/test/java/org/apache/tapestry5/ioc/internal/util/NonGenericBean.java * (delete) plastic/src/test/java/org/apache/tapestry5/ioc/internal/util/StringBean.java * (delete) plastic/src/test/java/org/apache/tapestry5/ioc/internal/util/BaseGenericBean.java * (delete) plastic/src/test/groovy/ioc/specs/GenericUtilsSpec.groovy * (add) tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/internal/util/StringBean.java > Generic List not fully supported > --- > > Key: TAP5-2453 > URL: https://issues.apache.org/jira/browse/TAP5-2453 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-ioc >Affects Versions: 5.4, 5.3.8 >Reporter: Jan Mynařík >Priority: Major > Labels: desired_for_5.5, generics, help-wanted > Attachments: TapestryGenericsTest.java > > > I've created an abstract generic CRUD implementation. When binding > implementations resulting proxies doesn't fully report parametrized type via > reflections. > See attached test. In 5.3.8 it fails in all asserts, in 5.4 only in the last > one. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TAP5-2453) Generic List not fully supported
[ https://issues.apache.org/jira/browse/TAP5-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16744308#comment-16744308 ] ASF subversion and git services commented on TAP5-2453: --- Commit faf3b20c9c8f59e890bea4eff5ce8e42df083815 in tapestry-5's branch refs/heads/master from Thiago H. de Paula Figueiredo [ https://git-wip-us.apache.org/repos/asf?p=tapestry-5.git;h=faf3b20 ] Revert "TAP5-2453: move GenericsUtils (and tests) to plastic" This reverts commit 5c617af6b3bfef81d79c573aec0acf29e1d0eb8c. > Generic List not fully supported > --- > > Key: TAP5-2453 > URL: https://issues.apache.org/jira/browse/TAP5-2453 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-ioc >Affects Versions: 5.4, 5.3.8 >Reporter: Jan Mynařík >Priority: Major > Labels: desired_for_5.5, generics, help-wanted > Attachments: TapestryGenericsTest.java > > > I've created an abstract generic CRUD implementation. When binding > implementations resulting proxies doesn't fully report parametrized type via > reflections. > See attached test. In 5.3.8 it fails in all asserts, in 5.4 only in the last > one. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TAP5-2453) Generic List not fully supported
[ https://issues.apache.org/jira/browse/TAP5-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16244098#comment-16244098 ] Hudson commented on TAP5-2453: -- ABORTED: Integrated in Jenkins build tapestry-trunk-freestyle #1682 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/1682/]) TAP5-2453: restore test classes (jochen.kemnade: rev 8530a27636f4fdc69ca7bb4877f6e31b87fe5292) * (add) tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/internal/util/Pair.java * (add) tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/internal/util/StringLongPair.java > Generic List not fully supported > --- > > Key: TAP5-2453 > URL: https://issues.apache.org/jira/browse/TAP5-2453 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-ioc >Affects Versions: 5.4, 5.3.8 >Reporter: Jan Mynařík > Labels: desired_for_5.5, generics > Attachments: TapestryGenericsTest.java > > > I've created an abstract generic CRUD implementation. When binding > implementations resulting proxies doesn't fully report parametrized type via > reflections. > See attached test. In 5.3.8 it fails in all asserts, in 5.4 only in the last > one. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TAP5-2453) Generic List not fully supported
[ https://issues.apache.org/jira/browse/TAP5-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16243974#comment-16243974 ] ASF subversion and git services commented on TAP5-2453: --- Commit 8530a27636f4fdc69ca7bb4877f6e31b87fe5292 in tapestry-5's branch refs/heads/master from [~jkemnade] [ https://git-wip-us.apache.org/repos/asf?p=tapestry-5.git;h=8530a27 ] TAP5-2453: restore test classes > Generic List not fully supported > --- > > Key: TAP5-2453 > URL: https://issues.apache.org/jira/browse/TAP5-2453 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-ioc >Affects Versions: 5.4, 5.3.8 >Reporter: Jan Mynařík > Labels: desired_for_5.5, generics > Attachments: TapestryGenericsTest.java > > > I've created an abstract generic CRUD implementation. When binding > implementations resulting proxies doesn't fully report parametrized type via > reflections. > See attached test. In 5.3.8 it fails in all asserts, in 5.4 only in the last > one. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TAP5-2453) Generic List not fully supported
[ https://issues.apache.org/jira/browse/TAP5-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16243968#comment-16243968 ] Hudson commented on TAP5-2453: -- FAILURE: Integrated in Jenkins build tapestry-trunk-freestyle #1681 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/1681/]) TAP5-2453: move GenericsUtils (and tests) to plastic (jochen.kemnade: rev 5c617af6b3bfef81d79c573aec0acf29e1d0eb8c) * (delete) tapestry-ioc/src/test/groovy/ioc/specs/GenericUtilsSpec.groovy * (delete) tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/internal/util/NonGenericBean.java * (add) plastic/src/test/java/org/apache/tapestry5/ioc/internal/util/NonGenericBean.java * (add) plastic/src/test/java/org/apache/tapestry5/ioc/internal/util/StringBean.java * (delete) tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/internal/util/StringLongPair.java * (delete) commons/src/main/java/org/apache/tapestry5/ioc/internal/util/GenericsUtils.java * (add) plastic/src/test/groovy/ioc/specs/GenericUtilsSpec.groovy * (add) plastic/src/test/java/org/apache/tapestry5/ioc/internal/util/Pair.java * (add) plastic/src/test/java/org/apache/tapestry5/ioc/internal/util/BaseGenericBean.java * (delete) tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/internal/util/Pair.java * (add) plastic/src/main/java/org/apache/tapestry5/ioc/internal/util/GenericsUtils.java * (delete) tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/internal/util/StringBean.java * (add) plastic/src/test/java/org/apache/tapestry5/ioc/internal/util/StringLongPair.java * (delete) tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/internal/util/BaseGenericBean.java > Generic List not fully supported > --- > > Key: TAP5-2453 > URL: https://issues.apache.org/jira/browse/TAP5-2453 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-ioc >Affects Versions: 5.4, 5.3.8 >Reporter: Jan Mynařík > Labels: desired_for_5.5, generics > Attachments: TapestryGenericsTest.java > > > I've created an abstract generic CRUD implementation. When binding > implementations resulting proxies doesn't fully report parametrized type via > reflections. > See attached test. In 5.3.8 it fails in all asserts, in 5.4 only in the last > one. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TAP5-2453) Generic List not fully supported
[ https://issues.apache.org/jira/browse/TAP5-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16243919#comment-16243919 ] ASF subversion and git services commented on TAP5-2453: --- Commit 5c617af6b3bfef81d79c573aec0acf29e1d0eb8c in tapestry-5's branch refs/heads/master from [~jkemnade] [ https://git-wip-us.apache.org/repos/asf?p=tapestry-5.git;h=5c617af ] TAP5-2453: move GenericsUtils (and tests) to plastic > Generic List not fully supported > --- > > Key: TAP5-2453 > URL: https://issues.apache.org/jira/browse/TAP5-2453 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-ioc >Affects Versions: 5.4, 5.3.8 >Reporter: Jan Mynařík > Labels: desired_for_5.5, generics > Attachments: TapestryGenericsTest.java > > > I've created an abstract generic CRUD implementation. When binding > implementations resulting proxies doesn't fully report parametrized type via > reflections. > See attached test. In 5.3.8 it fails in all asserts, in 5.4 only in the last > one. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TAP5-2453) Generic List not fully supported
[ https://issues.apache.org/jira/browse/TAP5-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211303#comment-16211303 ] Thiago H. de Paula Figueiredo commented on TAP5-2453: - Hello, [~jkemnade]! None yet. I haven't had a chance to take a look yet. I agree with moving GenericsUtil from commons to plastic as long as we keep the package and class names unchanged, just as how it was done when the commons and beanmodel projects were created, so we don't break backward compatibility. > Generic List not fully supported > --- > > Key: TAP5-2453 > URL: https://issues.apache.org/jira/browse/TAP5-2453 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-ioc >Affects Versions: 5.4, 5.3.8 >Reporter: Jan Mynařík > Labels: generics > Attachments: TapestryGenericsTest.java > > > I've created an abstract generic CRUD implementation. When binding > implementations resulting proxies doesn't fully report parametrized type via > reflections. > See attached test. In 5.3.8 it fails in all asserts, in 5.4 only in the last > one. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TAP5-2453) Generic List not fully supported
[ https://issues.apache.org/jira/browse/TAP5-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16209109#comment-16209109 ] Jochen Kemnade commented on TAP5-2453: -- [~thiagohp], any ideas? The problem is probably that {{org.apache.tapestry5.plastic.MethodDescription.MethodDescription(Method)}} does not extract the generics information. We'd probably have to move {{GenericsUtils}} to from {{commons}} to {{plastic}} and use its methods to retrieve the info. > Generic List not fully supported > --- > > Key: TAP5-2453 > URL: https://issues.apache.org/jira/browse/TAP5-2453 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-ioc >Affects Versions: 5.4, 5.3.8 >Reporter: Jan Mynařík > Labels: generics > Attachments: TapestryGenericsTest.java > > > I've created an abstract generic CRUD implementation. When binding > implementations resulting proxies doesn't fully report parametrized type via > reflections. > See attached test. In 5.3.8 it fails in all asserts, in 5.4 only in the last > one. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TAP5-2453) Generic List not fully supported
[ https://issues.apache.org/jira/browse/TAP5-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14640140#comment-14640140 ] Jochen Kemnade commented on TAP5-2453: -- If I remove the jacoco plugin, only the third assertion fails again. [~thiagohp], you've been working on generics-related stuff lately. Do you have any clues how Jacoco might break this? > Generic List not fully supported > --- > > Key: TAP5-2453 > URL: https://issues.apache.org/jira/browse/TAP5-2453 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-ioc >Affects Versions: 5.4, 5.3.8 >Reporter: Jan Mynařík > Labels: generics > Attachments: TapestryGenericsTest.java > > > I've created an abstract generic CRUD implementation. When binding > implementations resulting proxies doesn't fully report parametrized type via > reflections. > See attached test. In 5.3.8 it fails in all asserts, in 5.4 only in the last > one. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TAP5-2453) Generic List not fully supported
[ https://issues.apache.org/jira/browse/TAP5-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14640130#comment-14640130 ] Jochen Kemnade commented on TAP5-2453: -- I just ran the test against the current master, now the first assertion fails too. A quick {{git bisect}} shows that it fails since {{fbfbf6fc5c56e10b284b0d206ba2b93d7718561f}}, but I can't see how that commit should have changed the behavior. > Generic List not fully supported > --- > > Key: TAP5-2453 > URL: https://issues.apache.org/jira/browse/TAP5-2453 > Project: Tapestry 5 > Issue Type: Bug > Components: tapestry-ioc >Affects Versions: 5.4, 5.3.8 >Reporter: Jan Mynařík > Labels: generics > Attachments: TapestryGenericsTest.java > > > I've created an abstract generic CRUD implementation. When binding > implementations resulting proxies doesn't fully report parametrized type via > reflections. > See attached test. In 5.3.8 it fails in all asserts, in 5.4 only in the last > one. -- This message was sent by Atlassian JIRA (v6.3.4#6332)