Re: [PR] TINKERPOP-2862 Added withoutStrategies syntax to grammar [tinkerpop]
spmallette commented on code in PR #2483:
URL: https://github.com/apache/tinkerpop/pull/2483#discussion_r1487827851
##
docs/src/upgrade/release-4.x.x.asciidoc:
##
@@ -75,10 +75,43 @@ See:
link:https://issues.apache.org/jira/browse/TINKERPOP-3017[TINKERPOP-3017]
Starting from this version, `gremlin-javascript` will deserialize `Set` data
into a ECMAScript 2015 Set. Previously,
these were deserialized into arrays.
+ Gremlin Grammar Changes
+
+A number of changes have been introduce to the Gremlin grammar to help make it
be more consistent and easier to use.
+
+*`new` keyword is now optional*
+
+The `new` keyword is now optional in all cases where it was previously used.
Both of the following examples are now
+valid syntax with the second being the preferred form going forward:
+
+[source,groovy]
+
+g.V().withStrategies(new SubgraphStrategy(vertices: __.hasLabel('person')))
+
+g.V().withStrategies(SubgraphStrategy(vertices: __.hasLabel('person')))
+
+
+In a future version, it is likely that the `new` keyword will be removed
entirely from the grammar.
+
+*Supports withoutStrategies()*
+
+The `withoutStrategies()` configuration step is now supported syntax for the
grammar. While this option is not commonly
+used it is still a part of the Gremlin language and there are times where it
is helpful to have this fine grained
+control over how a traversal works.
+
+[source,groovy]
+
+g.V().withoutStrategies(CountStrategy)
Review Comment:
It doesn't need a String. The grammar should accept any `Identifier` there.
If it matches a registered strategy from a provider, it will work as valid
syntax.
https://github.com/apache/tinkerpop/pull/2483/files#diff-39ed59720093773649512a14aeba8c3da9e6d21ce016c7f0cdf7a1242e3a76a1R72
I suppose it will be up to each programming language to decide what to do
with that. For Java, you could have reference to the actual class file from the
provider and could use that. Since it matches on the simple name of the class a
dummy class could also be used. Alternatively, Java (and other languages) could
be changed to allow a `String` I suppose, but I wasn't ready to make that
choice. I mostly wanted to focus in on the grammar and getting that working
right for standard TinkerPop strategies. Created:
https://issues.apache.org/jira/browse/TINKERPOP-3055 to track.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
(tinkerpop) 01/01: TINKERPOP-3056 Fixed bug in mid-traversal mergeE for onMatch
This is an automated email from the ASF dual-hosted git repository.
spmallette pushed a commit to branch TINKERPOP-3056
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
commit 7c9964381344279bda2dd82086bc4422ab7f613b
Author: Stephen Mallette
AuthorDate: Tue Feb 13 09:24:40 2024 -0500
TINKERPOP-3056 Fixed bug in mid-traversal mergeE for onMatch
Since the current traverser was only being updated onMatch when it was used
as a start step doing mutations in a sideEffect() would update whatever the
current traverser was. This code may have been leftover from a time when the
merge steps operated more readily on the current traverser as an argument to
the step.
---
CHANGELOG.asciidoc | 1 +
.../process/traversal/step/map/MergeEdgeStep.java | 6 ++--
.../Gremlin.Net.IntegrationTest/Gherkin/Gremlin.cs | 2 ++
gremlin-go/driver/cucumber/gremlin.go | 2 ++
.../gremlin-javascript/test/cucumber/gremlin.js| 2 ++
gremlin-python/src/main/python/radish/gremlin.py | 2 ++
.../gremlin/test/features/map/MergeEdge.feature| 42 ++
7 files changed, 54 insertions(+), 3 deletions(-)
diff --git a/CHANGELOG.asciidoc b/CHANGELOG.asciidoc
index e886f0a7ae..38ded69065 100644
--- a/CHANGELOG.asciidoc
+++ b/CHANGELOG.asciidoc
@@ -32,6 +32,7 @@
image::https://raw.githubusercontent.com/apache/tinkerpop/master/docs/static/ima
* Fixed issue where server errors weren't being properly parsed when sending
bytecode over HTTP.
* Improved bulkset contains check for elements if all elements in bulkset are
of the same type
* Fixed bug in `EarlyLimitStrategy` which was too aggressive when promoting
`limit()` before `map()`.
+* Fixed bug in mid-traversal `mergeE()` where mutations in `sideEffect()` were
being applied to the current traverser rather than a `onMatch` edge.
[[release-3-6-6]]
=== TinkerPop 3.6.6 (November 20, 2023)
diff --git
a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/MergeEdgeStep.java
b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/MergeEdgeStep.java
index 748df266e0..761426efe3 100644
---
a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/MergeEdgeStep.java
+++
b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/MergeEdgeStep.java
@@ -273,9 +273,9 @@ public class MergeEdgeStep extends MergeStep {
edges = IteratorUtils.peek(edges, e -> {
-// if this was a start step the traverser is initialized with
placeholder edge, so override that with
-// the matched Edge so that the option() traversal can operate
on it properly
-if (isStart) traverser.set((S) e);
+// override current traverser with the matched Edge so that
the option() traversal can operate
+// on it properly
+traverser.set((S) e);
// assume good input from GraphTraversal - folks might drop in
a T here even though it is immutable
final Map onMatchMap = materializeMap(traverser,
onMatchTraversal);
diff --git a/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/Gremlin.cs
b/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/Gremlin.cs
index 5fc05ee05b..9dc4aa5745 100644
--- a/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/Gremlin.cs
+++ b/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/Gremlin.cs
@@ -689,6 +689,8 @@ namespace Gremlin.Net.IntegrationTest.Gherkin
{"g_mergeV_mergeE_combination_new_vertices", new
List, ITraversal>>
{(g,p) =>g.MergeV((IDictionary)
p["xx1"]).As("outV").MergeV((IDictionary)
p["xx2"]).As("inV").MergeE((IDictionary)
p["xx3"]).Option(Merge.OutV, (ITraversal)
__.Select("outV")).Option(Merge.InV, (ITraversal)
__.Select("inV")), (g,p) =>g.V(), (g,p) =>g.E(), (g,p)
=>g.V().Has("name","marko").Out [...]
{"g_mergeV_mergeE_combination_existing_vertices", new
List, ITraversal>>
{(g,p)
=>g.AddV("person").Property("name","marko").AddV("person").Property("name","vadas"),
(g,p) =>g.MergeV((IDictionary)
p["xx1"]).As("outV").MergeV((IDictionary)
p["xx2"]).As("inV").MergeE((IDictionary)
p["xx3"]).Option(Merge.OutV, (ITraversal)
__.Select("outV")).Option(Merge.InV, (ITraversal [...]
{"g_V_asXvX_mergeEXxx1X_optionXMerge_onMatch_xx2X_optionXMerge_outV_selectXvXX_optionXMerge_inV_selectXvXX",
new List, ITraversal>>
{(g,p) =>g.AddV("person").Property("name","marko").Property("age",29), (g,p)
=>g.V().As("v").MergeE((IDictionary)
p["xx1"]).Option(Merge.OnMatch, (IDictionary)
p["xx2"]).Option(Merge.OutV, (ITraversal)
__.Select("v")).Option(Merge.InV, (ITraversal) __. [...]
+
{"g_V_mergeEXlabel_knows_out_marko_in_vadasX_optionXonMatch_sideEffectXpropertyXweight_0XX_constantXemptyXX",
new List, ITraversal>>
{(g,p)
=>g.AddV("person").Property
(tinkerpop) branch TINKERPOP-3056 created (now 7c99643813)
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch TINKERPOP-3056 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git at 7c99643813 TINKERPOP-3056 Fixed bug in mid-traversal mergeE for onMatch This branch includes the following new commits: new 7c99643813 TINKERPOP-3056 Fixed bug in mid-traversal mergeE for onMatch The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[PR] TINKERPOP-3056 Fixed bug in mid-traversal mergeE for onMatch [tinkerpop]
spmallette opened a new pull request, #2487: URL: https://github.com/apache/tinkerpop/pull/2487 https://issues.apache.org/jira/browse/TINKERPOP-3056 Since the current traverser was only being updated onMatch when it was used as a start step doing mutations in a sideEffect() would update whatever the current traverser was. This code may have been leftover from a time when the merge steps operated more readily on the current traverser as an argument to the step. VOTE +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] TINKERPOP-3056 Fixed bug in mid-traversal mergeE for onMatch [tinkerpop]
codecov-commenter commented on PR #2487: URL: https://github.com/apache/tinkerpop/pull/2487#issuecomment-1941684720 ## [Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2487?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Comparison is base [(`c7f3d24`)](https://app.codecov.io/gh/apache/tinkerpop/commit/c7f3d2454a654cea57c2a99077d859b115fec4c3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 75.15% compared to head [(`7c99643`)](https://app.codecov.io/gh/apache/tinkerpop/pull/2487?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 75.16%. Additional details and impacted files ```diff @@Coverage Diff @@ ## 3.6-dev#2487 +/- ## == Coverage 75.15% 75.16% - Complexity 1235112352+1 == Files 1058 1058 Lines 6361063610 Branches6962 6962 == + Hits 4780647812+6 + Misses 1322413217-7 - Partials2580 2581+1 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/tinkerpop/pull/2487?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(tinkerpop) 03/03: Merge branch '3.7-dev'
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit c56e91738a647a56c8e7fee72d59319b931aa7f8 Merge: 55a7b7f256 e4ea40ffe9 Author: Stephen Mallette AuthorDate: Tue Feb 13 11:17:50 2024 -0500 Merge branch '3.7-dev' gremlin-python/src/main/python/examples/requirements.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
(tinkerpop) branch master updated (55a7b7f256 -> c56e91738a)
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from 55a7b7f256 Merge branch '3.7-dev' new 4e8a8f95fa Bumped patch/minors in examples for python CTR new e4ea40ffe9 Merge branch '3.6-dev' into 3.7-dev new c56e91738a Merge branch '3.7-dev' The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: gremlin-python/src/main/python/examples/requirements.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
(tinkerpop) 02/03: Merge branch '3.6-dev' into 3.7-dev
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit e4ea40ffe99b9b7a31a582f12d83fee90e65e687 Merge: d804e4a3b9 4e8a8f95fa Author: Stephen Mallette AuthorDate: Tue Feb 13 11:17:31 2024 -0500 Merge branch '3.6-dev' into 3.7-dev gremlin-python/src/main/python/examples/requirements.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
(tinkerpop) branch 3.7-dev updated (d804e4a3b9 -> e4ea40ffe9)
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch 3.7-dev in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from d804e4a3b9 Merge branch '3.6-dev' into 3.7-dev add 4e8a8f95fa Bumped patch/minors in examples for python CTR add e4ea40ffe9 Merge branch '3.6-dev' into 3.7-dev No new revisions were added by this update. Summary of changes: gremlin-python/src/main/python/examples/requirements.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
(tinkerpop) branch 3.6-dev updated (c7f3d2454a -> 4e8a8f95fa)
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch 3.6-dev in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from c7f3d2454a Drop use of unmodifiable map in arity predictor CTR add 4e8a8f95fa Bumped patch/minors in examples for python CTR No new revisions were added by this update. Summary of changes: gremlin-python/src/main/python/examples/requirements.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
(tinkerpop) 01/03: Bumped patch/minors in examples for python CTR
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit 4e8a8f95fa5237bca98de9b7b65a3a056ee44067 Author: Stephen Mallette AuthorDate: Tue Feb 13 11:16:28 2024 -0500 Bumped patch/minors in examples for python CTR --- gremlin-python/src/main/python/examples/requirements.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/gremlin-python/src/main/python/examples/requirements.txt b/gremlin-python/src/main/python/examples/requirements.txt index aac2e56d11..fb17e70620 100644 --- a/gremlin-python/src/main/python/examples/requirements.txt +++ b/gremlin-python/src/main/python/examples/requirements.txt @@ -19,11 +19,11 @@ aenum==3.1.15 aiohttp==3.8.0 aiosignal==1.3.1 async-timeout==4.0.3 -attrs==23.1.0 +attrs==23.2.0 charset-normalizer==3.3.2 -frozenlist==1.4.0 +frozenlist==1.4.1 idna==3.6 isodate==0.6.1 -multidict==6.0.4 +multidict==6.0.5 six==1.16.0 yarl==1.9.4
Re: [PR] Bump multidict from 6.0.4 to 6.0.5 in /gremlin-python/src/main/python [tinkerpop]
dependabot[bot] commented on PR #2477: URL: https://github.com/apache/tinkerpop/pull/2477#issuecomment-1941932813 Looks like multidict is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump multidict from 6.0.4 to 6.0.5 in /gremlin-python/src/main/python [tinkerpop]
dependabot[bot] closed pull request #2477: Bump multidict from 6.0.4 to 6.0.5 in /gremlin-python/src/main/python URL: https://github.com/apache/tinkerpop/pull/2477 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump attrs from 23.1.0 to 23.2.0 in /gremlin-python/src/main/python [tinkerpop]
dependabot[bot] commented on PR #2446: URL: https://github.com/apache/tinkerpop/pull/2446#issuecomment-1941932890 Looks like attrs is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump attrs from 23.1.0 to 23.2.0 in /gremlin-python/src/main/python [tinkerpop]
dependabot[bot] closed pull request #2446: Bump attrs from 23.1.0 to 23.2.0 in /gremlin-python/src/main/python URL: https://github.com/apache/tinkerpop/pull/2446 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(tinkerpop) branch dependabot/pip/gremlin-python/src/main/python/3.6-dev/multidict-6.0.5 deleted (was 5dcfc5e919)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/pip/gremlin-python/src/main/python/3.6-dev/multidict-6.0.5 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git was 5dcfc5e919 Bump multidict from 6.0.4 to 6.0.5 in /gremlin-python/src/main/python The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
Re: [PR] Bump frozenlist from 1.4.0 to 1.4.1 in /gremlin-python/src/main/python [tinkerpop]
dependabot[bot] commented on PR #2445: URL: https://github.com/apache/tinkerpop/pull/2445#issuecomment-1941933098 Looks like frozenlist is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump frozenlist from 1.4.0 to 1.4.1 in /gremlin-python/src/main/python [tinkerpop]
dependabot[bot] closed pull request #2445: Bump frozenlist from 1.4.0 to 1.4.1 in /gremlin-python/src/main/python URL: https://github.com/apache/tinkerpop/pull/2445 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(tinkerpop) branch dependabot/pip/gremlin-python/src/main/python/3.6-dev/attrs-23.2.0 deleted (was 7cf782f672)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/pip/gremlin-python/src/main/python/3.6-dev/attrs-23.2.0 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git was 7cf782f672 Bump attrs from 23.1.0 to 23.2.0 in /gremlin-python/src/main/python The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
(tinkerpop) branch dependabot/pip/gremlin-python/src/main/python/3.6-dev/frozenlist-1.4.1 deleted (was e9bda32059)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/pip/gremlin-python/src/main/python/3.6-dev/frozenlist-1.4.1 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git was e9bda32059 Bump frozenlist from 1.4.0 to 1.4.1 in /gremlin-python/src/main/python The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
Re: [PR] Remove gremlin-archetypes [tinkerpop]
spmallette commented on PR #2486: URL: https://github.com/apache/tinkerpop/pull/2486#issuecomment-1941937424 maybe better targetted at `master` as opposed to `3.7-dev` given semver? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(tinkerpop) branch dependabot/pip/gremlin-python/src/main/python/3.6-dev/aiohttp-3.9.3 updated (df31b30e24 -> 1229a79910)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/pip/gremlin-python/src/main/python/3.6-dev/aiohttp-3.9.3 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git discard df31b30e24 Bump aiohttp from 3.8.0 to 3.9.3 in /gremlin-python/src/main/python add a2b2550838 TINKERPOP-3045: EarlyLimitStrategy is too aggresive to promote Limit and thus causing incorrect results https://issues.apache.org/jira/browse/TINKERPOP-3045 add 0d119be3bb Follow-on to #2475 to fixup compile/test issues CTR add c7f3d2454a Drop use of unmodifiable map in arity predictor CTR add 4e8a8f95fa Bumped patch/minors in examples for python CTR add 1229a79910 Bump aiohttp from 3.8.0 to 3.9.3 in /gremlin-python/src/main/python This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (df31b30e24) \ N -- N -- N refs/heads/dependabot/pip/gremlin-python/src/main/python/3.6-dev/aiohttp-3.9.3 (1229a79910) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: CHANGELOG.asciidoc | 1 + .../strategy/optimization/EarlyLimitStrategy.java | 6 +- .../strategy/util/StepOutputArityPredictor.java| 357 + .../Gremlin.Net.IntegrationTest/Gherkin/Gremlin.cs | 1 + gremlin-go/driver/cucumber/gremlin.go | 1 + .../gremlin-javascript/test/cucumber/gremlin.js| 1 + .../src/main/python/examples/requirements.txt | 6 +- gremlin-python/src/main/python/radish/gremlin.py | 1 + .../gremlin/test/features/filter/Range.feature | 15 +- 9 files changed, 384 insertions(+), 5 deletions(-) create mode 100644 gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/util/StepOutputArityPredictor.java
Re: [PR] Bump ch.qos.reload4j:reload4j from 1.2.19 to 1.2.25 [tinkerpop]
spmallette commented on PR #2388: URL: https://github.com/apache/tinkerpop/pull/2388#issuecomment-194198 this is a dependency of hadoop - dependency declarations that resolve conflicts should be bumped as part of upgrades to the parent, unless there are explicit security issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump ch.qos.reload4j:reload4j from 1.2.19 to 1.2.25 [tinkerpop]
spmallette closed pull request #2388: Bump ch.qos.reload4j:reload4j from 1.2.19 to 1.2.25 URL: https://github.com/apache/tinkerpop/pull/2388 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump ch.qos.reload4j:reload4j from 1.2.19 to 1.2.25 [tinkerpop]
dependabot[bot] commented on PR #2388: URL: https://github.com/apache/tinkerpop/pull/2388#issuecomment-1941944553 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.woodstox:stax2-api from 4.2.1 to 4.2.2 [tinkerpop]
spmallette closed pull request #2392: Bump org.codehaus.woodstox:stax2-api from 4.2.1 to 4.2.2 URL: https://github.com/apache/tinkerpop/pull/2392 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(tinkerpop) branch dependabot/maven/3.6-dev/ch.qos.reload4j-reload4j-1.2.25 deleted (was 08f6dbfbf4)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/3.6-dev/ch.qos.reload4j-reload4j-1.2.25 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git was 08f6dbfbf4 Bump ch.qos.reload4j:reload4j from 1.2.19 to 1.2.25 The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
Re: [PR] Bump org.codehaus.woodstox:stax2-api from 4.2.1 to 4.2.2 [tinkerpop]
spmallette commented on PR #2392: URL: https://github.com/apache/tinkerpop/pull/2392#issuecomment-1941946413 this is a dependency of hadoop - dependency declarations that resolve conflicts should be bumped as part of upgrades to the parent, unless there are explicit security issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.woodstox:stax2-api from 4.2.1 to 4.2.2 [tinkerpop]
dependabot[bot] commented on PR #2392: URL: https://github.com/apache/tinkerpop/pull/2392#issuecomment-1941946494 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(tinkerpop) branch dependabot/maven/3.6-dev/org.codehaus.woodstox-stax2-api-4.2.2 deleted (was 4008525e5a)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/3.6-dev/org.codehaus.woodstox-stax2-api-4.2.2 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git was 4008525e5a Bump org.codehaus.woodstox:stax2-api from 4.2.1 to 4.2.2 The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
Re: [PR] Bump org.apache.curator:curator-recipes from 4.2.0 to 5.6.0 [tinkerpop]
spmallette closed pull request #2431: Bump org.apache.curator:curator-recipes from 4.2.0 to 5.6.0 URL: https://github.com/apache/tinkerpop/pull/2431 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.curator:curator-recipes from 4.2.0 to 5.6.0 [tinkerpop]
spmallette commented on PR #2431: URL: https://github.com/apache/tinkerpop/pull/2431#issuecomment-1941947838 this is a dependency of spark - dependency declarations that resolve conflicts should be bumped as part of upgrades to the parent, unless there are explicit security issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.curator:curator-recipes from 4.2.0 to 5.6.0 [tinkerpop]
dependabot[bot] commented on PR #2431: URL: https://github.com/apache/tinkerpop/pull/2431#issuecomment-1941947926 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(tinkerpop) branch dependabot/maven/3.6-dev/org.apache.curator-curator-recipes-5.6.0 deleted (was 0be0d7bcd9)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/3.6-dev/org.apache.curator-curator-recipes-5.6.0 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git was 0be0d7bcd9 Bump org.apache.curator:curator-recipes from 4.2.0 to 5.6.0 The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
Re: [PR] TINKERPOP-3056 Fixed bug in mid-traversal mergeE for onMatch [tinkerpop]
vkagamlyk commented on code in PR #2487:
URL: https://github.com/apache/tinkerpop/pull/2487#discussion_r1488216500
##
gremlin-test/src/main/resources/org/apache/tinkerpop/gremlin/test/features/map/MergeEdge.feature:
##
@@ -841,3 +841,45 @@ Feature: Step - mergeE()
"""
When iterated to list
Then the traversal will raise an error with message containing text of
"Property key can not be a hidden key: ~label"
+
+ Scenario:
g_V_mergeEXlabel_knows_out_marko_in_vadasX_optionXonMatch_sideEffectXpropertyXweight_0XX_constantXemptyXX
+Given the empty graph
+And the graph initializer of
+ """
+ g.addV("person").property("name", "marko").as("a").
+addV("person").property("name", "vadas").as("b").
+addE("knows").property("weight", 1).from("a").to("b")
+ """
+And using the parameter xx1 defined as "m[{\"t[label]\": \"knows\",
\"D[OUT]\":\"v[marko]\", \"D[IN]\":\"v[vadas]\"}]"
+And the traversal of
+ """
+ g.V().mergeE(xx1).
+ option(Merge.onMatch, __.sideEffect(__.property("weight",
0)).constant([:]))
+ """
+When iterated to list
+Then the result should have a count of 2
+And the graph should return 2 for count of "g.V()"
+And the graph should return 0 for count of
"g.E().hasLabel(\"knows\").has(\"weight\",1)"
+And the graph should return 1 for count of
"g.E().hasLabel(\"knows\").has(\"weight\",0)"
+And the graph should return 0 for count of
"g.V().hasLabel(\"knows\").has(\"weight\")"
+
+ Scenario:
g_mergeEXlabel_knows_out_marko_in_vadasX_optionXonMatch_sideEffectXpropertyXweight_0XX_constantXemptyXX
+Given the empty graph
+And the graph initializer of
+ """
+ g.addV("person").property("name", "marko").as("a").
+addV("person").property("name", "vadas").as("b").
+addE("knows").property("weight", 1).from("a").to("b")
+ """
+And using the parameter xx1 defined as "m[{\"t[label]\": \"knows\",
\"D[OUT]\":\"v[marko]\", \"D[IN]\":\"v[vadas]\"}]"
+And the traversal of
+ """
+ g.mergeE(xx1).
+ option(Merge.onMatch, __.sideEffect(__.property("weight",
0)).constant([:]))
+ """
+When iterated to list
+Then the result should have a count of 1
+And the graph should return 2 for count of "g.V()"
+And the graph should return 0 for count of
"g.E().hasLabel(\"knows\").has(\"weight\",1)"
+And the graph should return 1 for count of
"g.E().hasLabel(\"knows\").has(\"weight\",0)"
+And the graph should return 0 for count of
"g.V().hasLabel(\"knows\").has(\"weight\")"
Review Comment:
```suggestion
And the graph should return 0 for count of "g.V().has(\"weight\")"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] TINKERPOP-3056 Fixed bug in mid-traversal mergeE for onMatch [tinkerpop]
vkagamlyk commented on code in PR #2487:
URL: https://github.com/apache/tinkerpop/pull/2487#discussion_r1488215072
##
gremlin-test/src/main/resources/org/apache/tinkerpop/gremlin/test/features/map/MergeEdge.feature:
##
@@ -841,3 +841,45 @@ Feature: Step - mergeE()
"""
When iterated to list
Then the traversal will raise an error with message containing text of
"Property key can not be a hidden key: ~label"
+
+ Scenario:
g_V_mergeEXlabel_knows_out_marko_in_vadasX_optionXonMatch_sideEffectXpropertyXweight_0XX_constantXemptyXX
+Given the empty graph
+And the graph initializer of
+ """
+ g.addV("person").property("name", "marko").as("a").
+addV("person").property("name", "vadas").as("b").
+addE("knows").property("weight", 1).from("a").to("b")
+ """
+And using the parameter xx1 defined as "m[{\"t[label]\": \"knows\",
\"D[OUT]\":\"v[marko]\", \"D[IN]\":\"v[vadas]\"}]"
+And the traversal of
+ """
+ g.V().mergeE(xx1).
+ option(Merge.onMatch, __.sideEffect(__.property("weight",
0)).constant([:]))
+ """
+When iterated to list
+Then the result should have a count of 2
+And the graph should return 2 for count of "g.V()"
+And the graph should return 0 for count of
"g.E().hasLabel(\"knows\").has(\"weight\",1)"
+And the graph should return 1 for count of
"g.E().hasLabel(\"knows\").has(\"weight\",0)"
+And the graph should return 0 for count of
"g.V().hasLabel(\"knows\").has(\"weight\")"
Review Comment:
```suggestion
And the graph should return 0 for count of "g.V().has(\"weight\")"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] TINKERPOP-2862 Added withoutStrategies syntax to grammar [tinkerpop]
vkagamlyk commented on PR #2483: URL: https://github.com/apache/tinkerpop/pull/2483#issuecomment-1941971681 VOTE +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(tinkerpop) branch master updated (c56e91738a -> 2d9fabf3bc)
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from c56e91738a Merge branch '3.7-dev' add 9c9266b350 Bump org.codehaus.mojo:exec-maven-plugin from 1.2.1 to 3.1.1 new 2d9fabf3bc Merge branch 'pr-2353' The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: gremlin-dotnet/test/pom.xml | 2 +- gremlin-go/pom.xml | 2 +- gremlin-javascript/pom.xml | 2 +- gremlin-server/pom.xml | 2 +- pom.xml | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-)
(tinkerpop) 01/01: Merge branch 'pr-2353'
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit 2d9fabf3bcf3725d12a64893bab6803d812481a8 Merge: c56e91738a 9c9266b350 Author: Stephen Mallette AuthorDate: Tue Feb 13 11:28:08 2024 -0500 Merge branch 'pr-2353' gremlin-dotnet/test/pom.xml | 2 +- gremlin-go/pom.xml | 2 +- gremlin-javascript/pom.xml | 2 +- gremlin-server/pom.xml | 2 +- pom.xml | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-)
(tinkerpop) branch TINKERPOP-3056 updated (7c99643813 -> d7c2a7913b)
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch TINKERPOP-3056 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git discard 7c99643813 TINKERPOP-3056 Fixed bug in mid-traversal mergeE for onMatch add d7c2a7913b TINKERPOP-3056 Fixed bug in mid-traversal mergeE for onMatch This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (7c99643813) \ N -- N -- N refs/heads/TINKERPOP-3056 (d7c2a7913b) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/Gremlin.cs| 4 ++-- gremlin-go/driver/cucumber/gremlin.go | 4 ++-- .../src/main/javascript/gremlin-javascript/test/cucumber/gremlin.js | 4 ++-- gremlin-python/src/main/python/radish/gremlin.py | 4 ++-- .../org/apache/tinkerpop/gremlin/test/features/map/MergeEdge.feature | 4 ++-- 5 files changed, 10 insertions(+), 10 deletions(-)
Re: [PR] TINKERPOP-3056 Fixed bug in mid-traversal mergeE for onMatch [tinkerpop]
spmallette commented on code in PR #2487:
URL: https://github.com/apache/tinkerpop/pull/2487#discussion_r1488293645
##
gremlin-test/src/main/resources/org/apache/tinkerpop/gremlin/test/features/map/MergeEdge.feature:
##
@@ -841,3 +841,45 @@ Feature: Step - mergeE()
"""
When iterated to list
Then the traversal will raise an error with message containing text of
"Property key can not be a hidden key: ~label"
+
+ Scenario:
g_V_mergeEXlabel_knows_out_marko_in_vadasX_optionXonMatch_sideEffectXpropertyXweight_0XX_constantXemptyXX
+Given the empty graph
+And the graph initializer of
+ """
+ g.addV("person").property("name", "marko").as("a").
+addV("person").property("name", "vadas").as("b").
+addE("knows").property("weight", 1).from("a").to("b")
+ """
+And using the parameter xx1 defined as "m[{\"t[label]\": \"knows\",
\"D[OUT]\":\"v[marko]\", \"D[IN]\":\"v[vadas]\"}]"
+And the traversal of
+ """
+ g.V().mergeE(xx1).
+ option(Merge.onMatch, __.sideEffect(__.property("weight",
0)).constant([:]))
+ """
+When iterated to list
+Then the result should have a count of 2
+And the graph should return 2 for count of "g.V()"
+And the graph should return 0 for count of
"g.E().hasLabel(\"knows\").has(\"weight\",1)"
+And the graph should return 1 for count of
"g.E().hasLabel(\"knows\").has(\"weight\",0)"
+And the graph should return 0 for count of
"g.V().hasLabel(\"knows\").has(\"weight\")"
Review Comment:
bad cut/paste - fixed both - thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Bump org.codehaus.mojo:exec-maven-plugin from 1.2.1 to 3.1.1 [tinkerpop]
spmallette closed pull request #2353: Bump org.codehaus.mojo:exec-maven-plugin from 1.2.1 to 3.1.1 URL: https://github.com/apache/tinkerpop/pull/2353 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.mojo:exec-maven-plugin from 1.2.1 to 3.1.1 [tinkerpop]
spmallette commented on PR #2353: URL: https://github.com/apache/tinkerpop/pull/2353#issuecomment-1942056290 merged to `master` - 2d9fabf3bcf3725d12a64893bab6803d812481a8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.mojo:exec-maven-plugin from 1.2.1 to 3.1.1 [tinkerpop]
dependabot[bot] commented on PR #2353: URL: https://github.com/apache/tinkerpop/pull/2353#issuecomment-1942056353 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(tinkerpop) branch dependabot/maven/3.5-dev/org.codehaus.mojo-exec-maven-plugin-3.1.1 deleted (was 9c9266b350)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/3.5-dev/org.codehaus.mojo-exec-maven-plugin-3.1.1 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git was 9c9266b350 Bump org.codehaus.mojo:exec-maven-plugin from 1.2.1 to 3.1.1 The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
Re: [PR] TINKERPOP-3056 Fixed bug in mid-traversal mergeE for onMatch [tinkerpop]
vkagamlyk commented on PR #2487: URL: https://github.com/apache/tinkerpop/pull/2487#issuecomment-1942076338 VOTE +1 not exactly related to the current ticket, but is there same issue for `MergeV`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] TINKERPOP-3056 Fixed bug in mid-traversal mergeE for onMatch [tinkerpop]
xiazcy commented on PR #2487: URL: https://github.com/apache/tinkerpop/pull/2487#issuecomment-1942092498 VOTE +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] TINKERPOP-3056 Fixed bug in mid-traversal mergeE for onMatch [tinkerpop]
Cole-Greer commented on PR #2487: URL: https://github.com/apache/tinkerpop/pull/2487#issuecomment-1942116756 LGTM VOTE +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Remove gremlin-archetypes [tinkerpop]
Cole-Greer commented on PR #2486: URL: https://github.com/apache/tinkerpop/pull/2486#issuecomment-1942123299 There's one reference to the archetypes in the reference docs that I see. I think we can simply delete it as it is followed by a section on the new examples. https://github.com/apache/tinkerpop/blob/master/docs/src/reference/gremlin-variants.asciidoc#gremlin-archetypes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] TINKERPOP-2862 Added withoutStrategies syntax to grammar [tinkerpop]
Cole-Greer commented on PR #2483: URL: https://github.com/apache/tinkerpop/pull/2483#issuecomment-1942128603 LGTM VOTE +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(tinkerpop) 01/01: TINKERPOP-3031 Fixed bug in translation of g.tx() options
This is an automated email from the ASF dual-hosted git repository.
spmallette pushed a commit to branch TINKERPOP-3031
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
commit d4892ada5432e9e850883aef6a76b78a81200840
Author: Stephen Mallette
AuthorDate: Tue Feb 13 13:30:13 2024 -0500
TINKERPOP-3031 Fixed bug in translation of g.tx() options
---
CHANGELOG.asciidoc | 1 +
.../gremlin/process/traversal/GraphOp.java | 7 +--
.../traversal/dsl/graph/GraphTraversalSource.java | 1 +
.../traversal/translator/DotNetTranslator.java | 4
.../traversal/translator/GolangTranslator.java | 21 +
.../traversal/translator/GroovyTranslator.java | 5 -
.../traversal/translator/JavascriptTranslator.java | 4
.../traversal/translator/PythonTranslator.java | 6 +-
.../process/traversal/util/BytecodeHelper.java | 1 +
.../tinkerpop/gremlin/structure/Transaction.java| 14 ++
.../traversal/translator/DotNetTranslatorTest.java | 9 +
.../traversal/translator/GolangTranslatorTest.java | 9 +
.../traversal/translator/GroovyTranslatorTest.java | 9 +
.../translator/JavascriptTranslatorTest.java| 9 +
.../traversal/translator/PythonTranslatorTest.java | 9 +
15 files changed, 97 insertions(+), 12 deletions(-)
diff --git a/CHANGELOG.asciidoc b/CHANGELOG.asciidoc
index e886f0a7ae..40fa474891 100644
--- a/CHANGELOG.asciidoc
+++ b/CHANGELOG.asciidoc
@@ -24,6 +24,7 @@
image::https://raw.githubusercontent.com/apache/tinkerpop/master/docs/static/ima
=== TinkerPop 3.6.7 (NOT OFFICIALLY RELEASED YET)
* Fixed a bug in Gremlin.Net for .NET 8 that led to exceptions:
`InvalidOperationException: Enumeration has not started. Call MoveNext.`
+* Fixed bug in bytecode translation of `g.tx().commit()` and
`g.tx().rollback()` in all languages.
* Improved error message from `JavaTranslator` by including exception source.
* Added missing `short` serialization (`gx:Int16`) to GraphSONV2 and
GraphSONV3 in `gremlin-python`
* Added tests for error handling for GLV's if tx.commit() is called remotely
for graphs without transactions support.
diff --git
a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/GraphOp.java
b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/GraphOp.java
index 370009c193..ad47929414 100644
---
a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/GraphOp.java
+++
b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/GraphOp.java
@@ -18,6 +18,9 @@
*/
package org.apache.tinkerpop.gremlin.process.traversal;
+import
org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.GraphTraversalSource;
+import org.apache.tinkerpop.gremlin.structure.Transaction;
+
/**
* A {@code GraphOp} or "graph operation" is a static {@link Bytecode} form
that does not translate to a traversal
* but instead refers to a specific function to perform on a graph instance.
@@ -27,12 +30,12 @@ public enum GraphOp {
/**
* Commit a transaction.
*/
-TX_COMMIT(new Bytecode("tx", "commit")),
+TX_COMMIT(new Bytecode(GraphTraversalSource.Symbols.tx,
Transaction.Symbols.commit)),
/**
* Rollback a transaction.
*/
-TX_ROLLBACK(new Bytecode("tx", "rollback"));
+TX_ROLLBACK(new Bytecode(GraphTraversalSource.Symbols.tx,
Transaction.Symbols.rollback));
private final Bytecode bytecode;
diff --git
a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversalSource.java
b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversalSource.java
index c12bf41e46..a4bc9e33fa 100644
---
a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversalSource.java
+++
b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversalSource.java
@@ -77,6 +77,7 @@ public class GraphTraversalSource implements TraversalSource {
public static final String withBulk = "withBulk";
public static final String withPath = "withPath";
+public static final String tx = "tx";
}
diff --git
a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/translator/DotNetTranslator.java
b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/translator/DotNetTranslator.java
index 8e70b3000b..fbc2c1dc83 100644
---
a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/translator/DotNetTranslator.java
+++
b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/translator/DotNetTranslator.java
@@ -33,6 +33,7 @@ import
org.apache.tinkerpop.gremlin.process.traversal.Traversal;
import org.apache.tinkerpop.gremlin.process.traversal.TraversalSource;
import org.a
(tinkerpop) branch TINKERPOP-3031 created (now d4892ada54)
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch TINKERPOP-3031 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git at d4892ada54 TINKERPOP-3031 Fixed bug in translation of g.tx() options This branch includes the following new commits: new d4892ada54 TINKERPOP-3031 Fixed bug in translation of g.tx() options The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
Re: [PR] TINKERPOP-3031 Fixed bug in translation of g.tx() options [tinkerpop]
codecov-commenter commented on PR #2488: URL: https://github.com/apache/tinkerpop/pull/2488#issuecomment-1942184344 ## [Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2488?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Comparison is base [(`4e8a8f9`)](https://app.codecov.io/gh/apache/tinkerpop/commit/4e8a8f95fa5237bca98de9b7b65a3a056ee44067?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 75.14% compared to head [(`d4892ad`)](https://app.codecov.io/gh/apache/tinkerpop/pull/2488?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 75.14%. Additional details and impacted files ```diff @@Coverage Diff @@ ## 3.6-dev#2488 +/- ## == Coverage 75.14% 75.14% - Complexity 1234412345+1 == Files 1058 1058 Lines 6361063628 +18 Branches6962 6967+5 == + Hits 4779847815 +17 - Misses 1322613231+5 + Partials2586 2582-4 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/tinkerpop/pull/2488?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(tinkerpop) 03/03: Merge branch '3.7-dev'
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit 2d32517b3bca1b00d716b3205c2abdbcd6ed3352 Merge: 2d9fabf3bc 9b46b6777d Author: Stephen Mallette AuthorDate: Tue Feb 13 15:33:42 2024 -0500 Merge branch '3.7-dev' CHANGELOG.asciidoc | 1 + .../process/traversal/step/map/MergeEdgeStep.java | 6 ++-- .../Gremlin.Net.IntegrationTest/Gherkin/Gremlin.cs | 2 ++ gremlin-go/driver/cucumber/gremlin.go | 2 ++ .../gremlin-javascript/test/cucumber/gremlin.js| 2 ++ gremlin-python/src/main/python/radish/gremlin.py | 2 ++ .../gremlin/test/features/map/MergeEdge.feature| 42 ++ 7 files changed, 54 insertions(+), 3 deletions(-)
(tinkerpop) 02/03: Merge branch '3.6-dev' into 3.7-dev
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit 9b46b6777d2fa250e41daacf2fa4554605aff53a Merge: e4ea40ffe9 d9e34fb467 Author: Stephen Mallette AuthorDate: Tue Feb 13 15:17:32 2024 -0500 Merge branch '3.6-dev' into 3.7-dev CHANGELOG.asciidoc | 1 + .../process/traversal/step/map/MergeEdgeStep.java | 6 ++-- .../Gremlin.Net.IntegrationTest/Gherkin/Gremlin.cs | 2 ++ gremlin-go/driver/cucumber/gremlin.go | 2 ++ .../gremlin-javascript/test/cucumber/gremlin.js| 2 ++ gremlin-python/src/main/python/radish/gremlin.py | 2 ++ .../gremlin/test/features/map/MergeEdge.feature| 42 ++ 7 files changed, 54 insertions(+), 3 deletions(-)
(tinkerpop) 01/03: Merge branch 'TINKERPOP-3056' into 3.6-dev
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit d9e34fb4678c29ffa167066de45a9fa7329a319a Merge: 4e8a8f95fa d7c2a7913b Author: Stephen Mallette AuthorDate: Tue Feb 13 15:17:20 2024 -0500 Merge branch 'TINKERPOP-3056' into 3.6-dev CHANGELOG.asciidoc | 1 + .../process/traversal/step/map/MergeEdgeStep.java | 6 ++-- .../Gremlin.Net.IntegrationTest/Gherkin/Gremlin.cs | 2 ++ gremlin-go/driver/cucumber/gremlin.go | 2 ++ .../gremlin-javascript/test/cucumber/gremlin.js| 2 ++ gremlin-python/src/main/python/radish/gremlin.py | 2 ++ .../gremlin/test/features/map/MergeEdge.feature| 42 ++ 7 files changed, 54 insertions(+), 3 deletions(-)
(tinkerpop) branch master updated (2d9fabf3bc -> 2d32517b3b)
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from 2d9fabf3bc Merge branch 'pr-2353' add d7c2a7913b TINKERPOP-3056 Fixed bug in mid-traversal mergeE for onMatch new d9e34fb467 Merge branch 'TINKERPOP-3056' into 3.6-dev new 9b46b6777d Merge branch '3.6-dev' into 3.7-dev new 2d32517b3b Merge branch '3.7-dev' The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGELOG.asciidoc | 1 + .../process/traversal/step/map/MergeEdgeStep.java | 6 ++-- .../Gremlin.Net.IntegrationTest/Gherkin/Gremlin.cs | 2 ++ gremlin-go/driver/cucumber/gremlin.go | 2 ++ .../gremlin-javascript/test/cucumber/gremlin.js| 2 ++ gremlin-python/src/main/python/radish/gremlin.py | 2 ++ .../gremlin/test/features/map/MergeEdge.feature| 42 ++ 7 files changed, 54 insertions(+), 3 deletions(-)
(tinkerpop) branch 3.7-dev updated (e4ea40ffe9 -> 9b46b6777d)
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch 3.7-dev in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from e4ea40ffe9 Merge branch '3.6-dev' into 3.7-dev add d7c2a7913b TINKERPOP-3056 Fixed bug in mid-traversal mergeE for onMatch add d9e34fb467 Merge branch 'TINKERPOP-3056' into 3.6-dev add 9b46b6777d Merge branch '3.6-dev' into 3.7-dev No new revisions were added by this update. Summary of changes: CHANGELOG.asciidoc | 1 + .../process/traversal/step/map/MergeEdgeStep.java | 6 ++-- .../Gremlin.Net.IntegrationTest/Gherkin/Gremlin.cs | 2 ++ gremlin-go/driver/cucumber/gremlin.go | 2 ++ .../gremlin-javascript/test/cucumber/gremlin.js| 2 ++ gremlin-python/src/main/python/radish/gremlin.py | 2 ++ .../gremlin/test/features/map/MergeEdge.feature| 42 ++ 7 files changed, 54 insertions(+), 3 deletions(-)
Re: [PR] TINKERPOP-3056 Fixed bug in mid-traversal mergeE for onMatch [tinkerpop]
spmallette merged PR #2487: URL: https://github.com/apache/tinkerpop/pull/2487 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(tinkerpop) branch 3.6-dev updated (4e8a8f95fa -> d9e34fb467)
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch 3.6-dev in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from 4e8a8f95fa Bumped patch/minors in examples for python CTR add d7c2a7913b TINKERPOP-3056 Fixed bug in mid-traversal mergeE for onMatch add d9e34fb467 Merge branch 'TINKERPOP-3056' into 3.6-dev No new revisions were added by this update. Summary of changes: CHANGELOG.asciidoc | 1 + .../process/traversal/step/map/MergeEdgeStep.java | 6 ++-- .../Gremlin.Net.IntegrationTest/Gherkin/Gremlin.cs | 2 ++ gremlin-go/driver/cucumber/gremlin.go | 2 ++ .../gremlin-javascript/test/cucumber/gremlin.js| 2 ++ gremlin-python/src/main/python/radish/gremlin.py | 2 ++ .../gremlin/test/features/map/MergeEdge.feature| 42 ++ 7 files changed, 54 insertions(+), 3 deletions(-)
(tinkerpop) branch TINKERPOP-3056 deleted (was d7c2a7913b)
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch TINKERPOP-3056 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git was d7c2a7913b TINKERPOP-3056 Fixed bug in mid-traversal mergeE for onMatch The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
Re: [PR] EXAMPLE: Deserialization of integer based datatypes lose the type definition [tinkerpop]
xiazcy closed pull request #1848: EXAMPLE: Deserialization of integer based datatypes lose the type definition URL: https://github.com/apache/tinkerpop/pull/1848 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] EXAMPLE: Deserialization of integer based datatypes lose the type definition [tinkerpop]
xiazcy commented on PR #1848: URL: https://github.com/apache/tinkerpop/pull/1848#issuecomment-1942435541 Closing due to inactivity. Please feel free to follow-up in the JIRA ticket. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump codecov/codecov-action from 3 to 4 [tinkerpop]
xiazcy merged PR #2472: URL: https://github.com/apache/tinkerpop/pull/2472 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(tinkerpop) branch dependabot/github_actions/3.6-dev/codecov/codecov-action-4 deleted (was 5c99250d1d)
This is an automated email from the ASF dual-hosted git repository. xiazcy pushed a change to branch dependabot/github_actions/3.6-dev/codecov/codecov-action-4 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git was 5c99250d1d Bump codecov/codecov-action from 3 to 4 The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
(tinkerpop) branch 3.6-dev updated: Bump codecov/codecov-action from 3 to 4 (#2472)
This is an automated email from the ASF dual-hosted git repository. xiazcy pushed a commit to branch 3.6-dev in repository https://gitbox.apache.org/repos/asf/tinkerpop.git The following commit(s) were added to refs/heads/3.6-dev by this push: new d862355334 Bump codecov/codecov-action from 3 to 4 (#2472) d862355334 is described below commit d862355334eacc6725a96d1917ed08128c68f94f Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> AuthorDate: Tue Feb 13 14:51:54 2024 -0800 Bump codecov/codecov-action from 3 to 4 (#2472) Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3 to 4. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](https://github.com/codecov/codecov-action/compare/v3...v4) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --- .github/workflows/build-test.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build-test.yml b/.github/workflows/build-test.yml index d336ed9691..1141996cfc 100644 --- a/.github/workflows/build-test.yml +++ b/.github/workflows/build-test.yml @@ -29,7 +29,7 @@ jobs: - name: Build with Maven run: mvn clean install -pl -:gremlin-javascript,-:gremlin-dotnet-source,-:gremlin-dotnet-tests,-:gremlin-go,-:gremlin-python -Dci --batch-mode -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn -Dcoverage - name: Upload to Codecov -uses: codecov/codecov-action@v3 +uses: codecov/codecov-action@v4 with: directory: ./gremlin-tools/gremlin-coverage/target/site java-jdk8: @@ -331,7 +331,7 @@ jobs: mvn clean install -pl -:gremlin-python,-:gremlin-javascript,-:gremlin-dotnet,-:gremlin-dotnet-source,-:gremlin-dotnet-tests -q -DskipTests -Dci mvn verify -pl :gremlin-go - name: Upload to Codecov -uses: codecov/codecov-action@v3 +uses: codecov/codecov-action@v4 with: working-directory: ./gremlin-go - name: Go-Vet
(tinkerpop) branch 3.7-dev updated (9b46b6777d -> 01de8868c7)
This is an automated email from the ASF dual-hosted git repository. xiazcy pushed a change to branch 3.7-dev in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from 9b46b6777d Merge branch '3.6-dev' into 3.7-dev add d862355334 Bump codecov/codecov-action from 3 to 4 (#2472) new 01de8868c7 Merge branch '3.6-dev' into 3.7-dev The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .github/workflows/build-test.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
(tinkerpop) 01/01: Merge branch '3.6-dev' into 3.7-dev
This is an automated email from the ASF dual-hosted git repository. xiazcy pushed a commit to branch 3.7-dev in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit 01de8868c75fda50f5369d9706f0b3e9a4d604f0 Merge: 9b46b6777d d862355334 Author: Yang Xia <55853655+xia...@users.noreply.github.com> AuthorDate: Tue Feb 13 14:53:06 2024 -0800 Merge branch '3.6-dev' into 3.7-dev .github/workflows/build-test.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
(tinkerpop) 01/01: Merge branch '3.7-dev'
This is an automated email from the ASF dual-hosted git repository. xiazcy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit 9c1c9fa033817ed5ed9ac66dd7386ea007ad8e2c Merge: 2d32517b3b 01de8868c7 Author: Yang Xia <55853655+xia...@users.noreply.github.com> AuthorDate: Tue Feb 13 14:53:39 2024 -0800 Merge branch '3.7-dev' .github/workflows/build-test.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
(tinkerpop) branch master updated (2d32517b3b -> 9c1c9fa033)
This is an automated email from the ASF dual-hosted git repository. xiazcy pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from 2d32517b3b Merge branch '3.7-dev' add d862355334 Bump codecov/codecov-action from 3 to 4 (#2472) add 01de8868c7 Merge branch '3.6-dev' into 3.7-dev new 9c1c9fa033 Merge branch '3.7-dev' The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .github/workflows/build-test.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
