[jira] [Commented] (WICKET-5716) wicket-autocomplete prevents "change"-listener when leaving input via mouse click

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/WICKET-5716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14157733#comment-14157733
 ] 

ASF subversion and git services commented on WICKET-5716:
-

Commit c93d0186c60e52e2108fd5c0d2f4dfa893931830 in wicket's branch 
refs/heads/master from svenmeier
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=c93d018 ]

WICKET-5716 trigger change reliably after closing the popup


> wicket-autocomplete prevents "change"-listener when leaving input via mouse 
> click
> -
>
> Key: WICKET-5716
> URL: https://issues.apache.org/jira/browse/WICKET-5716
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket-extensions
>Affects Versions: 7.0.0-M3, 6.17.0
>Reporter: Sven Meier
>Assignee: Sven Meier
> Fix For: 6.18.0, 7.0.0-M4
>
>
> wicket-autocomplete's ignoreChange is true initially, this prevents "change" 
> events being fired when the user enters something and then clicks somewhere 
> else



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (WICKET-5716) wicket-autocomplete prevents "change"-listener when leaving input via mouse click

[Sven Meier (JIRA)]

 [ 
https://issues.apache.org/jira/browse/WICKET-5716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sven Meier resolved WICKET-5716.

   Resolution: Fixed
Fix Version/s: 7.0.0-M4
   6.18.0

"change" is now triggered reliably after closing of the popup

> wicket-autocomplete prevents "change"-listener when leaving input via mouse 
> click
> -
>
> Key: WICKET-5716
> URL: https://issues.apache.org/jira/browse/WICKET-5716
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket-extensions
>Affects Versions: 7.0.0-M3, 6.17.0
>Reporter: Sven Meier
>Assignee: Sven Meier
> Fix For: 6.18.0, 7.0.0-M4
>
>
> wicket-autocomplete's ignoreChange is true initially, this prevents "change" 
> events being fired when the user enters something and then clicks somewhere 
> else



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WICKET-5716) wicket-autocomplete prevents "change"-listener when leaving input via mouse click

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/WICKET-5716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14157732#comment-14157732
 ] 

ASF subversion and git services commented on WICKET-5716:
-

Commit 110a4f98a07c1cbaf3995792edc8f9fd62f23861 in wicket's branch 
refs/heads/wicket-6.x from svenmeier
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=110a4f9 ]

WICKET-5716 trigger change reliably after closing the popup


> wicket-autocomplete prevents "change"-listener when leaving input via mouse 
> click
> -
>
> Key: WICKET-5716
> URL: https://issues.apache.org/jira/browse/WICKET-5716
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket-extensions
>Affects Versions: 7.0.0-M3, 6.17.0
>Reporter: Sven Meier
>Assignee: Sven Meier
>
> wicket-autocomplete's ignoreChange is true initially, this prevents "change" 
> events being fired when the user enters something and then clicks somewhere 
> else



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

git commit: WICKET-5716 trigger change reliably after closing the popup

[svenmeier]

Repository: wicket
Updated Branches:
  refs/heads/wicket-6.x 7ee559486 -> 110a4f98a


WICKET-5716 trigger change reliably after closing the popup


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/110a4f98
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/110a4f98
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/110a4f98

Branch: refs/heads/wicket-6.x
Commit: 110a4f98a07c1cbaf3995792edc8f9fd62f23861
Parents: 7ee5594
Author: svenmeier 
Authored: Fri Oct 3 08:43:59 2014 +0200
Committer: svenmeier 
Committed: Fri Oct 3 08:43:59 2014 +0200

--
 .../html/autocomplete/wicket-autocomplete.js| 36 
 1 file changed, 21 insertions(+), 15 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/wicket/blob/110a4f98/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js
--
diff --git 
a/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js
 
b/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js
index ba66221..959bd2c 100644
--- 
a/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js
+++ 
b/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js
@@ -53,7 +53,7 @@

var ignoreKeyEnter = false; // ignore key ENTER 
because is already hid the autocomplete list
var ignoreOneFocusGain = false; // on FF, clicking an option in 
the pop-up would make field loose focus; focus() call only has effect in FF 
after popup is hidden, so the re-focusing must not show popup again in this case
-   var ignoreChange = true;// ignore change event 
because TAB or ENTER event already triggered a change
+   var triggerChangeOnHide = false;// should a 
change be triggered on hiding of the popup
 
var initialElement;
 
@@ -94,7 +94,6 @@
initialElement = obj;
 
Wicket.Event.add(obj, 'blur', function (jqEvent) {
-   jqEvent.stopPropagation();
window.setTimeout(hideAutoComplete, 500);
});
 
@@ -130,7 +129,7 @@
if (selected < elementCount-1) {
setSelected(selected+1);
}
-   if (visible===0) {
+   if (visible === 0) {
updateChoices();
} else {
render(true, false);
@@ -148,20 +147,18 @@
break;
case KEY_TAB:
case KEY_ENTER:
-   ignoreChange = false;
ignoreKeyEnter = false;

if (selected > -1) {
var value = 
getSelectedValue();
value = 
handleSelection(value);

-   hideAutoComplete();
-   
if (value) {
obj.value = 
value;
-   
jQuery(obj).triggerHandler('change');
-   ignoreChange = 
true;
+   
triggerChangeOnHide = true;
}
+
+   hideAutoComplete();

ignoreKeyEnter = true;
} else if 
(Wicket.AutoCompleteSettings.enterHidesWithNoSelection) {
@@ -177,9 +174,11 @@
});
 
Wicket.Event.add(obj, 'change', function (jqEvent) {

git commit: WICKET-5716 trigger change reliably after closing the popup

[svenmeier]

Repository: wicket
Updated Branches:
  refs/heads/master e004c08e5 -> c93d0186c


WICKET-5716 trigger change reliably after closing the popup


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/c93d0186
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/c93d0186
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/c93d0186

Branch: refs/heads/master
Commit: c93d0186c60e52e2108fd5c0d2f4dfa893931830
Parents: e004c08
Author: svenmeier 
Authored: Fri Oct 3 08:43:32 2014 +0200
Committer: svenmeier 
Committed: Fri Oct 3 08:43:32 2014 +0200

--
 .../html/autocomplete/wicket-autocomplete.js| 35 +++-
 1 file changed, 20 insertions(+), 15 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/wicket/blob/c93d0186/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js
--
diff --git 
a/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js
 
b/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js
index ca1a251..97a5e28 100644
--- 
a/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js
+++ 
b/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js
@@ -53,7 +53,7 @@

var ignoreKeyEnter = false; // ignore key ENTER 
because is already hid the autocomplete list
var ignoreOneFocusGain = false; // on FF, clicking an option in 
the pop-up would make field loose focus; focus() call only has effect in FF 
after popup is hidden, so the re-focusing must not show popup again in this case
-   var ignoreChange = true;// ignore change event 
because TAB or ENTER event already triggered a change
+   var triggerChangeOnHide = false;// should a 
change be triggered on hiding of the popup
 
var initialElement;
 
@@ -89,7 +89,6 @@
initialElement = obj;
 
Wicket.Event.add(obj, 'blur', function (jqEvent) {
-   jqEvent.stopPropagation();
window.setTimeout(hideAutoComplete, 500);
});
 
@@ -132,7 +131,7 @@
// select the first 
element
setSelected(0);
}
-   if (visible===0) {
+   if (visible === 0) {
updateChoices();
} else {
render(true, false);
@@ -150,21 +149,19 @@
break;
case KEY_TAB:
case KEY_ENTER:
-   ignoreChange = false;
ignoreKeyEnter = false;

if (selected > -1) {
var value = 
getSelectedValue();
value = 
handleSelection(value);

-   hideAutoComplete();
-   
if (value) {
obj.value = 
value;
-   
jQuery(obj).triggerHandler('change');
-   ignoreChange = 
true;
+   
triggerChangeOnHide = true;
}

+   hideAutoComplete();
+   
ignoreKeyEnter = true;
} else if 
(Wicket.AutoCompleteSettings.enterHidesWithNoSelection) {
hideAutoComplete();
@@ -179,9 

[jira] [Assigned] (WICKET-5716) wicket-autocomplete prevents "change"-listener when leaving input via mouse click

[Sven Meier (JIRA)]

 [ 
https://issues.apache.org/jira/browse/WICKET-5716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sven Meier reassigned WICKET-5716:
--

Assignee: Sven Meier

> wicket-autocomplete prevents "change"-listener when leaving input via mouse 
> click
> -
>
> Key: WICKET-5716
> URL: https://issues.apache.org/jira/browse/WICKET-5716
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket-extensions
>Affects Versions: 7.0.0-M3, 6.17.0
>Reporter: Sven Meier
>Assignee: Sven Meier
>
> wicket-autocomplete's ignoreChange is true initially, this prevents "change" 
> events being fired when the user enters something and then clicks somewhere 
> else



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WICKET-5717) Url.parse/toString should support fragment

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/WICKET-5717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14157270#comment-14157270
 ] 

ASF GitHub Bot commented on WICKET-5717:


GitHub user gsmet opened a pull request:

https://github.com/apache/wicket/pull/78

WICKET-5717 Support fragment in Url parse and toString

Note: this PR is for the wicket-6.x branch.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/openwide-java/wicket support-fragment-in-url

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/wicket/pull/78.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #78


commit f35ae430ee741ca7dd517ed09647d1a28a1f
Author: Guillaume Smet 
Date:   2014-09-30T23:42:27Z

WICKET-5717 Support fragment in Url parse and toString




> Url.parse/toString should support fragment
> --
>
> Key: WICKET-5717
> URL: https://issues.apache.org/jira/browse/WICKET-5717
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 6.17.0
>Reporter: Guillaume Smet
> Attachments: redirect-url-anchor.tar.gz
>
>
> Hi,
> Starting with Wicket 6.16, we have issues redirecting to an absolute
> URL containing a fragment: the # is escaped by Wicket.
> Changes in the commit
> https://fisheye6.atlassian.com/changelog/wicket-git?cs=e1f29e90ff3a35e117bb3ddc5ee2aefd900c13c8
> are causing the regression but as far as we can see, the commit is not
> the problem: the issue is that Url.parse then toString encodes the
> anchor.
> Before this commit, as we were using an absolute Url, we were in the
> case where the Url wasn't escaped.
> We think the right fix would be to make org.apache.wicket.request.Url
> anchor aware.
> Pull request to come.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (WICKET-5717) Url.parse/toString should support fragment

[Guillaume Smet (JIRA)]

 [ 
https://issues.apache.org/jira/browse/WICKET-5717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Smet updated WICKET-5717:
---
Attachment: redirect-url-anchor.tar.gz

Added a quick start showing the issue.

> Url.parse/toString should support fragment
> --
>
> Key: WICKET-5717
> URL: https://issues.apache.org/jira/browse/WICKET-5717
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 6.17.0
>Reporter: Guillaume Smet
> Attachments: redirect-url-anchor.tar.gz
>
>
> Hi,
> Starting with Wicket 6.16, we have issues redirecting to an absolute
> URL containing a fragment: the # is escaped by Wicket.
> Changes in the commit
> https://fisheye6.atlassian.com/changelog/wicket-git?cs=e1f29e90ff3a35e117bb3ddc5ee2aefd900c13c8
> are causing the regression but as far as we can see, the commit is not
> the problem: the issue is that Url.parse then toString encodes the
> anchor.
> Before this commit, as we were using an absolute Url, we were in the
> case where the Url wasn't escaped.
> We think the right fix would be to make org.apache.wicket.request.Url
> anchor aware.
> Pull request to come.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (WICKET-5717) Url.parse/toString should support fragment

[Guillaume Smet (JIRA)]

Guillaume Smet created WICKET-5717:
--

 Summary: Url.parse/toString should support fragment
 Key: WICKET-5717
 URL: https://issues.apache.org/jira/browse/WICKET-5717
 Project: Wicket
  Issue Type: Bug
  Components: wicket
Affects Versions: 6.17.0
Reporter: Guillaume Smet


Hi,

Starting with Wicket 6.16, we have issues redirecting to an absolute
URL containing a fragment: the # is escaped by Wicket.

Changes in the commit
https://fisheye6.atlassian.com/changelog/wicket-git?cs=e1f29e90ff3a35e117bb3ddc5ee2aefd900c13c8
are causing the regression but as far as we can see, the commit is not
the problem: the issue is that Url.parse then toString encodes the
anchor.

Before this commit, as we were using an absolute Url, we were in the
case where the Url wasn't escaped.

We think the right fix would be to make org.apache.wicket.request.Url
anchor aware.

Pull request to come.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

buildbot success in ASF Buildbot on wicket-master

[buildbot]

The Buildbot has detected a restored build on builder wicket-master while 
building wicket.
Full details are available at:
 http://ci.apache.org/builders/wicket-master/builds/235

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: hemera_ubuntu

Build Reason: scheduler
Build Source Stamp: [branch master] e004c08e528ed478710613f8d3094a23d431815e
Blamelist: Martin Tzvetanov Grigorov 

Build succeeded!

sincerely,
 -The Buildbot

git commit: Update the XML schema location

[mgrigorov]

Repository: wicket
Updated Branches:
  refs/heads/master e87e47add -> e004c08e5


Update the XML schema location


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/e004c08e
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/e004c08e
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/e004c08e

Branch: refs/heads/master
Commit: e004c08e528ed478710613f8d3094a23d431815e
Parents: e87e47a
Author: Martin Tzvetanov Grigorov 
Authored: Thu Oct 2 17:25:18 2014 +0200
Committer: Martin Tzvetanov Grigorov 
Committed: Thu Oct 2 17:25:18 2014 +0200

--
 .../test/java/org/apache/wicket/spring/applicationContext.xml  | 6 --
 1 file changed, 4 insertions(+), 2 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/wicket/blob/e004c08e/wicket-spring/src/test/java/org/apache/wicket/spring/applicationContext.xml
--
diff --git 
a/wicket-spring/src/test/java/org/apache/wicket/spring/applicationContext.xml 
b/wicket-spring/src/test/java/org/apache/wicket/spring/applicationContext.xml
index d1a961d..7d05c62 100644
--- 
a/wicket-spring/src/test/java/org/apache/wicket/spring/applicationContext.xml
+++ 
b/wicket-spring/src/test/java/org/apache/wicket/spring/applicationContext.xml
@@ -15,9 +15,11 @@
See the License for the specific language governing permissions and
limitations under the License.
 -->
-http://www.springframework.org/dtd/spring-beans.dtd";>
+http://www.springframework.org/schema/beans";
+   xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+   xsi:schemaLocation="
+http://www.springframework.org/schema/beans 
http://www.springframework.org/schema/beans/spring-beans.xsd";>
 
-

buildbot failure in ASF Buildbot on wicket-master

[buildbot]

The Buildbot has detected a new failure on builder wicket-master while building 
wicket.
Full details are available at:
 http://ci.apache.org/builders/wicket-master/builds/234

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: hemera_ubuntu

Build Reason: scheduler
Build Source Stamp: [branch master] e87e47addf933fb17557ae198abe3c4d2ebbd132
Blamelist: Martin Tzvetanov Grigorov 

BUILD FAILED: failed compile

sincerely,
 -The Buildbot

[jira] [Commented] (WICKET-5714) MockHttpServletRequest.buildRequest() should work for parameters with multiple values with multipart content type

[Dennis Waldherr (JIRA)]

[ 
https://issues.apache.org/jira/browse/WICKET-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14156609#comment-14156609
 ] 

Dennis Waldherr commented on WICKET-5714:
-

Thanks, that was quick :)

> MockHttpServletRequest.buildRequest() should work for parameters with 
> multiple values with multipart content type
> -
>
> Key: WICKET-5714
> URL: https://issues.apache.org/jira/browse/WICKET-5714
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 1.5.11
>Reporter: Dennis Waldherr
>Assignee: Martin Grigorov
> Fix For: 6.18.0, 1.5.13, 7.0.0-M4
>
>
> The following code in the method MockHttpServletRequest.buildRequest() 
> iterates over all values of a parameter. When writing the value to the 
> outputstream it doesn't use the iteration variable, but instead retrieves the 
> value with "post.getParameterValue(parameterName)" which always returns the 
> first element of the list.
> {code}
>   List values = 
> post.getParameterValues(parameterName);
>   for (StringValue value : values)
>   {
>   newAttachment(out);
>   out.write("; name=\"".getBytes());
>   out.write(parameterName.getBytes());
>   out.write("\"".getBytes());
>   out.write(crlf.getBytes());
>   out.write(crlf.getBytes());
>   
> out.write(post.getParameterValue(parameterName).toString().getBytes());
>   out.write(crlf.getBytes());
>   }
> {code}
> So for a given list of values "3", "2" and "1", it actually writes "3", "3" 
> and "3".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

git commit: Update the ciManagement data

[mgrigorov]

Repository: wicket
Updated Branches:
  refs/heads/master 16152d8f0 -> e87e47add


Update the ciManagement data


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/e87e47ad
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/e87e47ad
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/e87e47ad

Branch: refs/heads/master
Commit: e87e47addf933fb17557ae198abe3c4d2ebbd132
Parents: 16152d8
Author: Martin Tzvetanov Grigorov 
Authored: Thu Oct 2 16:09:10 2014 +0200
Committer: Martin Tzvetanov Grigorov 
Committed: Thu Oct 2 16:09:10 2014 +0200

--
 pom.xml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/wicket/blob/e87e47ad/pom.xml
--
diff --git a/pom.xml b/pom.xml
index 9c76321..a5f4a0d 100644
--- a/pom.xml
+++ b/pom.xml
@@ -45,8 +45,8 @@

2006

-   hudson
-   
https://hudson.apache.org/hudson/job/Apache%20Wicket%201.5.x/
+   BuildBot
+   http://ci.apache.org/builders/wicket-master

[jira] [Commented] (WICKET-5713) Move /wicket.properties to /META-INF/wicket/xyz.properties

[Martin Grigorov (JIRA)]

[ 
https://issues.apache.org/jira/browse/WICKET-5713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14156590#comment-14156590
 ] 

Martin Grigorov commented on WICKET-5713:
-

No. No new dependencies.
It is manual traversal of the content of .jar that has /META-INF/wicket/ folder 
entry inside.
There is no way to traverse only the files inside /META-INF/wicket/ so all 
entries in the jar are visited. Once the properties file is found we break the 
traversal.
I don't see noticeable delay in Maven build. And it is done only at application 
start time so it should not hurt.

> Move /wicket.properties to /META-INF/wicket/xyz.properties
> --
>
> Key: WICKET-5713
> URL: https://issues.apache.org/jira/browse/WICKET-5713
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket
>Affects Versions: 6.17.0
>Reporter: Martin Grigorov
>Assignee: Martin Grigorov
>Priority: Minor
>
> As found at http://markmail.org/message/gzychpjelr4eshly the current location 
> of wicket.properties (at the root of the classpath entry) is problematic when 
> an uberjar is used because usually the developer doesn't know how 
> org.apache.wicket.IInitializer works and doesn't add code to merge the 
> contents of all wicket.propeties files in the classpath into one.
> But even if the developer tried to merge them then it will fail again because 
> org.apache.wicket.Application#load(Properties) doesn't expect more than one 
> value per key, e.g. separated by comma.
> Garret Wilson suggested to move /wicket.properties files in /META-INF/wicket/ 
> and use more qualified names, e.g. org.apache.wicket.core.properties.
> The first problem is that there are no JRE and Servlet APIs to find such 
> files easily. We need to scan the classpath to be able to find them and load 
> them.
> Is this costly ?
> https://github.com/ronmamo/reflections is wildly used library that provides 
> this functionality (and much more) and it is using the same logic and seems 
> to be quite fast!
> So let's give it a try!
> We should still support /wicket.properties for backward compatibility. We can 
> log a WARN message when such is found and suggest to be moved in 
> /META-INF/wicket/ 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (WICKET-5716) wicket-autocomplete prevents "change"-listener when leaving input via mouse click

[Sven Meier (JIRA)]

Sven Meier created WICKET-5716:
--

 Summary: wicket-autocomplete prevents "change"-listener when 
leaving input via mouse click
 Key: WICKET-5716
 URL: https://issues.apache.org/jira/browse/WICKET-5716
 Project: Wicket
  Issue Type: Bug
  Components: wicket-extensions
Affects Versions: 6.17.0, 7.0.0-M3
Reporter: Sven Meier


wicket-autocomplete's ignoreChange is true initially, this prevents "change" 
events being fired when the user enters something and then clicks somewhere else



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WICKET-5713) Move /wicket.properties to /META-INF/wicket/xyz.properties

[Andrea Del Bene (JIRA)]

[ 
https://issues.apache.org/jira/browse/WICKET-5713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14156587#comment-14156587
 ] 

Andrea Del Bene commented on WICKET-5713:
-

so no additional dependency on reflections, right?

> Move /wicket.properties to /META-INF/wicket/xyz.properties
> --
>
> Key: WICKET-5713
> URL: https://issues.apache.org/jira/browse/WICKET-5713
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket
>Affects Versions: 6.17.0
>Reporter: Martin Grigorov
>Assignee: Martin Grigorov
>Priority: Minor
>
> As found at http://markmail.org/message/gzychpjelr4eshly the current location 
> of wicket.properties (at the root of the classpath entry) is problematic when 
> an uberjar is used because usually the developer doesn't know how 
> org.apache.wicket.IInitializer works and doesn't add code to merge the 
> contents of all wicket.propeties files in the classpath into one.
> But even if the developer tried to merge them then it will fail again because 
> org.apache.wicket.Application#load(Properties) doesn't expect more than one 
> value per key, e.g. separated by comma.
> Garret Wilson suggested to move /wicket.properties files in /META-INF/wicket/ 
> and use more qualified names, e.g. org.apache.wicket.core.properties.
> The first problem is that there are no JRE and Servlet APIs to find such 
> files easily. We need to scan the classpath to be able to find them and load 
> them.
> Is this costly ?
> https://github.com/ronmamo/reflections is wildly used library that provides 
> this functionality (and much more) and it is using the same logic and seems 
> to be quite fast!
> So let's give it a try!
> We should still support /wicket.properties for backward compatibility. We can 
> log a WARN message when such is found and suggest to be moved in 
> /META-INF/wicket/ 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

git commit: Remove unused m-clover-p. Move yuicompressor-m-p's configuration in the plugin (out of pluginManagement)

[mgrigorov]

Repository: wicket
Updated Branches:
  refs/heads/master d998c7fe6 -> 16152d8f0


Remove unused m-clover-p. Move yuicompressor-m-p's configuration in the plugin 
(out of pluginManagement)


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/16152d8f
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/16152d8f
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/16152d8f

Branch: refs/heads/master
Commit: 16152d8f0fa543f66779683f8355dcd30335beb4
Parents: d998c7f
Author: Martin Tzvetanov Grigorov 
Authored: Thu Oct 2 15:40:53 2014 +0200
Committer: Martin Tzvetanov Grigorov 
Committed: Thu Oct 2 15:40:53 2014 +0200

--
 wicket-core/pom.xml | 22 +-
 1 file changed, 5 insertions(+), 17 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/wicket/blob/16152d8f/wicket-core/pom.xml
--
diff --git a/wicket-core/pom.xml b/wicket-core/pom.xml
index 7d3d98c..bf6006d 100644
--- a/wicket-core/pom.xml
+++ b/wicket-core/pom.xml
@@ -72,24 +72,12 @@

net.alchim31.maven

yuicompressor-maven-plugin
-   
-   
-   org.apache.maven.plugins
-   maven-clover-plugin
+   
+   
+   **/jquery*.js
+   
+   


-   
-   
-   
-   net.alchim31.maven
-   
yuicompressor-maven-plugin
-   
-   
-   **/jquery*.js
-   
-   
-   
-   
-   

 

git commit: Upgrade Spring to 4.1.1 and m-javadoc-p to 2.10.1

[mgrigorov]

Repository: wicket
Updated Branches:
  refs/heads/master 41e71f9de -> d998c7fe6


Upgrade Spring to 4.1.1 and m-javadoc-p to 2.10.1


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/d998c7fe
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/d998c7fe
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/d998c7fe

Branch: refs/heads/master
Commit: d998c7fe6c4f88ac215b6adc1b30fac27576845c
Parents: 41e71f9
Author: Martin Tzvetanov Grigorov 
Authored: Thu Oct 2 15:36:12 2014 +0200
Committer: Martin Tzvetanov Grigorov 
Committed: Thu Oct 2 15:36:12 2014 +0200

--
 pom.xml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/wicket/blob/d998c7fe/pom.xml
--
diff --git a/pom.xml b/pom.xml
index e3f40f2..9c76321 100644
--- a/pom.xml
+++ b/pom.xml
@@ -118,9 +118,9 @@
0.7.1.201405082137
8.1.16.v20140903
9.0.7.v20131107
-   4.1.0.RELEASE
+   4.1.1.RELEASE
3.0.1
-   2.9.1
+   2.10.1
2.17
1.9.5
1.7.7

[jira] [Commented] (WICKET-5713) Move /wicket.properties to /META-INF/wicket/xyz.properties

[Martin Grigorov (JIRA)]

[ 
https://issues.apache.org/jira/browse/WICKET-5713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14156572#comment-14156572
 ] 

Martin Grigorov commented on WICKET-5713:
-

Are there not registered ones ?
org.apache.wicket.extensions.ajax.markup.html.form.upload.UploadProgressBar.ComponentInitializer
 is registered transitively, for example. Your way won't show it as registered 
one unless you open and read the content of 
org.apache.wicket.extensions.Initializer.
Anyway, you have your ways, and I have mine ...

By changing the file extension to '.initializer' we will make this Properties 
file's purpose solely for IInitializers (by looking at the file name).
At the moment there is no need to use it for something else but in the future 
there may appear one ...

> Move /wicket.properties to /META-INF/wicket/xyz.properties
> --
>
> Key: WICKET-5713
> URL: https://issues.apache.org/jira/browse/WICKET-5713
> Project: Wicket
>  Issue Type: Improvement
>  Components: wicket
>Affects Versions: 6.17.0
>Reporter: Martin Grigorov
>Assignee: Martin Grigorov
>Priority: Minor
>
> As found at http://markmail.org/message/gzychpjelr4eshly the current location 
> of wicket.properties (at the root of the classpath entry) is problematic when 
> an uberjar is used because usually the developer doesn't know how 
> org.apache.wicket.IInitializer works and doesn't add code to merge the 
> contents of all wicket.propeties files in the classpath into one.
> But even if the developer tried to merge them then it will fail again because 
> org.apache.wicket.Application#load(Properties) doesn't expect more than one 
> value per key, e.g. separated by comma.
> Garret Wilson suggested to move /wicket.properties files in /META-INF/wicket/ 
> and use more qualified names, e.g. org.apache.wicket.core.properties.
> The first problem is that there are no JRE and Servlet APIs to find such 
> files easily. We need to scan the classpath to be able to find them and load 
> them.
> Is this costly ?
> https://github.com/ronmamo/reflections is wildly used library that provides 
> this functionality (and much more) and it is using the same logic and seems 
> to be quite fast!
> So let's give it a try!
> We should still support /wicket.properties for backward compatibility. We can 
> log a WARN message when such is found and suggest to be moved in 
> /META-INF/wicket/ 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (WICKET-5714) MockHttpServletRequest.buildRequest() should work for parameters with multiple values with multipart content type

[Martin Grigorov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/WICKET-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martin Grigorov resolved WICKET-5714.
-
   Resolution: Fixed
Fix Version/s: 7.0.0-M4
   1.5.13
   6.18.0

Fixed!
Thank you!

> MockHttpServletRequest.buildRequest() should work for parameters with 
> multiple values with multipart content type
> -
>
> Key: WICKET-5714
> URL: https://issues.apache.org/jira/browse/WICKET-5714
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 1.5.11
>Reporter: Dennis Waldherr
>Assignee: Martin Grigorov
> Fix For: 6.18.0, 1.5.13, 7.0.0-M4
>
>
> The following code in the method MockHttpServletRequest.buildRequest() 
> iterates over all values of a parameter. When writing the value to the 
> outputstream it doesn't use the iteration variable, but instead retrieves the 
> value with "post.getParameterValue(parameterName)" which always returns the 
> first element of the list.
> {code}
>   List values = 
> post.getParameterValues(parameterName);
>   for (StringValue value : values)
>   {
>   newAttachment(out);
>   out.write("; name=\"".getBytes());
>   out.write(parameterName.getBytes());
>   out.write("\"".getBytes());
>   out.write(crlf.getBytes());
>   out.write(crlf.getBytes());
>   
> out.write(post.getParameterValue(parameterName).toString().getBytes());
>   out.write(crlf.getBytes());
>   }
> {code}
> So for a given list of values "3", "2" and "1", it actually writes "3", "3" 
> and "3".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

git commit: WICKET-5714 MockHttpServletRequest.buildRequest() should work for parameters with multiple values with multipart content type

[mgrigorov]

Repository: wicket
Updated Branches:
  refs/heads/master f6ee84e5f -> 41e71f9de


WICKET-5714 MockHttpServletRequest.buildRequest() should work for parameters 
with multiple values with multipart content type

(cherry picked from commit fb1f57f4d2be9534580b3a8e54ce98eb07adf77f)


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/41e71f9d
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/41e71f9d
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/41e71f9d

Branch: refs/heads/master
Commit: 41e71f9de5d84f24b80da12d2c5bd76216a5cf00
Parents: f6ee84e
Author: Martin Tzvetanov Grigorov 
Authored: Thu Oct 2 15:14:55 2014 +0200
Committer: Martin Tzvetanov Grigorov 
Committed: Thu Oct 2 15:15:20 2014 +0200

--
 .../apache/wicket/protocol/http/mock/MockHttpServletRequest.java   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/wicket/blob/41e71f9d/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/MockHttpServletRequest.java
--
diff --git 
a/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/MockHttpServletRequest.java
 
b/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/MockHttpServletRequest.java
index 5baddfa..5acc2a5 100755
--- 
a/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/MockHttpServletRequest.java
+++ 
b/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/MockHttpServletRequest.java
@@ -1672,7 +1672,7 @@ public class MockHttpServletRequest implements 
HttpServletRequest
out.write("\"".getBytes());
out.write(crlf.getBytes());
out.write(crlf.getBytes());
-   
out.write(post.getParameterValue(parameterName).toString().getBytes());
+   out.write(value.toString().getBytes());
out.write(crlf.getBytes());
}
}

[jira] [Commented] (WICKET-5714) MockHttpServletRequest.buildRequest() should work for parameters with multiple values with multipart content type

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/WICKET-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14156561#comment-14156561
 ] 

ASF subversion and git services commented on WICKET-5714:
-

Commit fb1f57f4d2be9534580b3a8e54ce98eb07adf77f in wicket's branch 
refs/heads/wicket-1.5.x from [~mgrigorov]
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=fb1f57f ]

WICKET-5714 MockHttpServletRequest.buildRequest() should work for parameters 
with multiple values with multipart content type


> MockHttpServletRequest.buildRequest() should work for parameters with 
> multiple values with multipart content type
> -
>
> Key: WICKET-5714
> URL: https://issues.apache.org/jira/browse/WICKET-5714
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 1.5.11
>Reporter: Dennis Waldherr
>Assignee: Martin Grigorov
>
> The following code in the method MockHttpServletRequest.buildRequest() 
> iterates over all values of a parameter. When writing the value to the 
> outputstream it doesn't use the iteration variable, but instead retrieves the 
> value with "post.getParameterValue(parameterName)" which always returns the 
> first element of the list.
> {code}
>   List values = 
> post.getParameterValues(parameterName);
>   for (StringValue value : values)
>   {
>   newAttachment(out);
>   out.write("; name=\"".getBytes());
>   out.write(parameterName.getBytes());
>   out.write("\"".getBytes());
>   out.write(crlf.getBytes());
>   out.write(crlf.getBytes());
>   
> out.write(post.getParameterValue(parameterName).toString().getBytes());
>   out.write(crlf.getBytes());
>   }
> {code}
> So for a given list of values "3", "2" and "1", it actually writes "3", "3" 
> and "3".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

git commit: WICKET-5714 MockHttpServletRequest.buildRequest() should work for parameters with multiple values with multipart content type

[mgrigorov]

Repository: wicket
Updated Branches:
  refs/heads/wicket-6.x ff1ad079c -> 7ee559486


WICKET-5714 MockHttpServletRequest.buildRequest() should work for parameters 
with multiple values with multipart content type

(cherry picked from commit fb1f57f4d2be9534580b3a8e54ce98eb07adf77f)


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/7ee55948
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/7ee55948
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/7ee55948

Branch: refs/heads/wicket-6.x
Commit: 7ee559486f53c62947171a150508893c9a5d16d1
Parents: ff1ad07
Author: Martin Tzvetanov Grigorov 
Authored: Thu Oct 2 15:14:55 2014 +0200
Committer: Martin Tzvetanov Grigorov 
Committed: Thu Oct 2 15:15:12 2014 +0200

--
 .../apache/wicket/protocol/http/mock/MockHttpServletRequest.java   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/wicket/blob/7ee55948/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/MockHttpServletRequest.java
--
diff --git 
a/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/MockHttpServletRequest.java
 
b/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/MockHttpServletRequest.java
index 7088d31..66287ff 100755
--- 
a/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/MockHttpServletRequest.java
+++ 
b/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/MockHttpServletRequest.java
@@ -1634,7 +1634,7 @@ public class MockHttpServletRequest implements 
HttpServletRequest
out.write("\"".getBytes());
out.write(crlf.getBytes());
out.write(crlf.getBytes());
-   
out.write(post.getParameterValue(parameterName).toString().getBytes());
+   out.write(value.toString().getBytes());
out.write(crlf.getBytes());
}
}

[jira] [Commented] (WICKET-5714) MockHttpServletRequest.buildRequest() should work for parameters with multiple values with multipart content type

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/WICKET-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14156563#comment-14156563
 ] 

ASF subversion and git services commented on WICKET-5714:
-

Commit 41e71f9de5d84f24b80da12d2c5bd76216a5cf00 in wicket's branch 
refs/heads/master from [~mgrigorov]
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=41e71f9 ]

WICKET-5714 MockHttpServletRequest.buildRequest() should work for parameters 
with multiple values with multipart content type

(cherry picked from commit fb1f57f4d2be9534580b3a8e54ce98eb07adf77f)


> MockHttpServletRequest.buildRequest() should work for parameters with 
> multiple values with multipart content type
> -
>
> Key: WICKET-5714
> URL: https://issues.apache.org/jira/browse/WICKET-5714
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 1.5.11
>Reporter: Dennis Waldherr
>Assignee: Martin Grigorov
>
> The following code in the method MockHttpServletRequest.buildRequest() 
> iterates over all values of a parameter. When writing the value to the 
> outputstream it doesn't use the iteration variable, but instead retrieves the 
> value with "post.getParameterValue(parameterName)" which always returns the 
> first element of the list.
> {code}
>   List values = 
> post.getParameterValues(parameterName);
>   for (StringValue value : values)
>   {
>   newAttachment(out);
>   out.write("; name=\"".getBytes());
>   out.write(parameterName.getBytes());
>   out.write("\"".getBytes());
>   out.write(crlf.getBytes());
>   out.write(crlf.getBytes());
>   
> out.write(post.getParameterValue(parameterName).toString().getBytes());
>   out.write(crlf.getBytes());
>   }
> {code}
> So for a given list of values "3", "2" and "1", it actually writes "3", "3" 
> and "3".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (WICKET-5714) MockHttpServletRequest.buildRequest() should work for parameters with multiple values with multipart content type

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/WICKET-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14156562#comment-14156562
 ] 

ASF subversion and git services commented on WICKET-5714:
-

Commit 7ee559486f53c62947171a150508893c9a5d16d1 in wicket's branch 
refs/heads/wicket-6.x from [~mgrigorov]
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=7ee5594 ]

WICKET-5714 MockHttpServletRequest.buildRequest() should work for parameters 
with multiple values with multipart content type

(cherry picked from commit fb1f57f4d2be9534580b3a8e54ce98eb07adf77f)


> MockHttpServletRequest.buildRequest() should work for parameters with 
> multiple values with multipart content type
> -
>
> Key: WICKET-5714
> URL: https://issues.apache.org/jira/browse/WICKET-5714
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 1.5.11
>Reporter: Dennis Waldherr
>Assignee: Martin Grigorov
>
> The following code in the method MockHttpServletRequest.buildRequest() 
> iterates over all values of a parameter. When writing the value to the 
> outputstream it doesn't use the iteration variable, but instead retrieves the 
> value with "post.getParameterValue(parameterName)" which always returns the 
> first element of the list.
> {code}
>   List values = 
> post.getParameterValues(parameterName);
>   for (StringValue value : values)
>   {
>   newAttachment(out);
>   out.write("; name=\"".getBytes());
>   out.write(parameterName.getBytes());
>   out.write("\"".getBytes());
>   out.write(crlf.getBytes());
>   out.write(crlf.getBytes());
>   
> out.write(post.getParameterValue(parameterName).toString().getBytes());
>   out.write(crlf.getBytes());
>   }
> {code}
> So for a given list of values "3", "2" and "1", it actually writes "3", "3" 
> and "3".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

git commit: WICKET-5714 MockHttpServletRequest.buildRequest() should work for parameters with multiple values with multipart content type

[mgrigorov]

Repository: wicket
Updated Branches:
  refs/heads/wicket-1.5.x 18787f8ba -> fb1f57f4d


WICKET-5714 MockHttpServletRequest.buildRequest() should work for parameters 
with multiple values with multipart content type


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/fb1f57f4
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/fb1f57f4
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/fb1f57f4

Branch: refs/heads/wicket-1.5.x
Commit: fb1f57f4d2be9534580b3a8e54ce98eb07adf77f
Parents: 18787f8
Author: Martin Tzvetanov Grigorov 
Authored: Thu Oct 2 15:14:55 2014 +0200
Committer: Martin Tzvetanov Grigorov 
Committed: Thu Oct 2 15:14:55 2014 +0200

--
 .../apache/wicket/protocol/http/mock/MockHttpServletRequest.java   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/wicket/blob/fb1f57f4/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/MockHttpServletRequest.java
--
diff --git 
a/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/MockHttpServletRequest.java
 
b/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/MockHttpServletRequest.java
index 79ee45d..62c038d 100755
--- 
a/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/MockHttpServletRequest.java
+++ 
b/wicket-core/src/main/java/org/apache/wicket/protocol/http/mock/MockHttpServletRequest.java
@@ -1581,7 +1581,7 @@ public class MockHttpServletRequest implements 
HttpServletRequest
out.write("\"".getBytes());
out.write(crlf.getBytes());
out.write(crlf.getBytes());
-   
out.write(post.getParameterValue(parameterName).toString().getBytes());
+   out.write(value.toString().getBytes());
out.write(crlf.getBytes());
}
}

[jira] [Assigned] (WICKET-5714) MockHttpServletRequest.buildRequest() should work for parameters with multiple values with multipart content type

[Martin Grigorov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/WICKET-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martin Grigorov reassigned WICKET-5714:
---

Assignee: Martin Grigorov

> MockHttpServletRequest.buildRequest() should work for parameters with 
> multiple values with multipart content type
> -
>
> Key: WICKET-5714
> URL: https://issues.apache.org/jira/browse/WICKET-5714
> Project: Wicket
>  Issue Type: Bug
>  Components: wicket
>Affects Versions: 1.5.11
>Reporter: Dennis Waldherr
>Assignee: Martin Grigorov
>
> The following code in the method MockHttpServletRequest.buildRequest() 
> iterates over all values of a parameter. When writing the value to the 
> outputstream it doesn't use the iteration variable, but instead retrieves the 
> value with "post.getParameterValue(parameterName)" which always returns the 
> first element of the list.
> {code}
>   List values = 
> post.getParameterValues(parameterName);
>   for (StringValue value : values)
>   {
>   newAttachment(out);
>   out.write("; name=\"".getBytes());
>   out.write(parameterName.getBytes());
>   out.write("\"".getBytes());
>   out.write(crlf.getBytes());
>   out.write(crlf.getBytes());
>   
> out.write(post.getParameterValue(parameterName).toString().getBytes());
>   out.write(crlf.getBytes());
>   }
> {code}
> So for a given list of values "3", "2" and "1", it actually writes "3", "3" 
> and "3".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (WICKET-5715) Allow setting 'async' attribute on reference

[Martin Grigorov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/WICKET-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martin Grigorov resolved WICKET-5715.
-
   Resolution: Fixed
Fix Version/s: 7.0.0-M4
   6.18.0

> Allow setting 'async' attribute on reference 

[jira] [Commented] (WICKET-5715) Allow setting 'async' attribute on reference

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/WICKET-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14156558#comment-14156558
 ] 

ASF subversion and git services commented on WICKET-5715:
-

Commit ff1ad079c450d024daa637faa4e3438f3b3e88c0 in wicket's branch 
refs/heads/wicket-6.x from [~mgrigorov]
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=ff1ad07 ]

WICKET-5715 Allow setting 'async' attribute on reference 

git commit: WICKET-5715 Allow setting 'async' attribute on reference

[mgrigorov]

Repository: wicket
Updated Branches:
  refs/heads/wicket-6.x a05aa4cae -> ff1ad079c


WICKET-5715 Allow setting 'async' attribute on reference  elements

(cherry picked from commit eeae249a95926027184b551239b46586a05848fc)


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/ff1ad079
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/ff1ad079
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/ff1ad079

Branch: refs/heads/wicket-6.x
Commit: ff1ad079c450d024daa637faa4e3438f3b3e88c0
Parents: a05aa4c
Author: Martin Tzvetanov Grigorov 
Authored: Thu Oct 2 14:46:34 2014 +0200
Committer: Martin Tzvetanov Grigorov 
Committed: Thu Oct 2 15:07:13 2014 +0200

--
 .../core/util/string/JavaScriptUtils.java   | 34 +++-
 .../AbstractJavaScriptReferenceHeaderItem.java  | 89 
 .../markup/head/JavaScriptHeaderItem.java   | 18 +++-
 .../head/JavaScriptReferenceHeaderItem.java | 27 +-
 .../head/JavaScriptUrlReferenceHeaderItem.java  | 28 +-
 .../core/util/string/JavaScriptUtilsTest.java   | 19 +
 6 files changed, 161 insertions(+), 54 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/wicket/blob/ff1ad079/wicket-core/src/main/java/org/apache/wicket/core/util/string/JavaScriptUtils.java
--
diff --git 
a/wicket-core/src/main/java/org/apache/wicket/core/util/string/JavaScriptUtils.java
 
b/wicket-core/src/main/java/org/apache/wicket/core/util/string/JavaScriptUtils.java
index 098efed..b95c531 100644
--- 
a/wicket-core/src/main/java/org/apache/wicket/core/util/string/JavaScriptUtils.java
+++ 
b/wicket-core/src/main/java/org/apache/wicket/core/util/string/JavaScriptUtils.java
@@ -109,7 +109,28 @@ public class JavaScriptUtils
public static void writeJavaScriptUrl(final Response response, final 
CharSequence url,
final String id)
{
-   writeJavaScriptUrl(response, url, id, false, null);
+   writeJavaScriptUrl(response, url, id, false, null, false);
+   }
+
+   /**
+* Write a reference to a javascript file to the response object
+*
+* @param response
+*The HTTP response
+* @param url
+*The javascript file URL
+* @param id
+*Unique identifier of element
+* @param defer
+*specifies that the execution of a script should be 
deferred (delayed) until after
+*the page has been loaded.
+* @param charset
+*a non null value specifies the charset attribute of the 
script tag
+*/
+   public static void writeJavaScriptUrl(final Response response, final 
CharSequence url,
+ final String id, boolean defer, 
String charset)
+   {
+   writeJavaScriptUrl(response, url, id, defer, charset, false);
}
 
/**
@@ -126,9 +147,11 @@ public class JavaScriptUtils
 *the page has been loaded.
 * @param charset
 *a non null value specifies the charset attribute of the 
script tag
+* @param async
+*specifies that the script can be loaded asynchronously by 
the browser
 */
public static void writeJavaScriptUrl(final Response response, final 
CharSequence url,
-   final String id, boolean defer, String charset)
+   final String id, boolean defer, String charset, boolean async)
{
response.write("