[jira] [Updated] (HADOOP-13723) AliyunOSSInputStream#read() should update read bytes stat correctly
[ https://issues.apache.org/jira/browse/HADOOP-13723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] SammiChen updated HADOOP-13723: --- Fix Version/s: 2.9.1 > AliyunOSSInputStream#read() should update read bytes stat correctly > --- > > Key: HADOOP-13723 > URL: https://issues.apache.org/jira/browse/HADOOP-13723 > Project: Hadoop Common > Issue Type: Bug > Components: tools >Reporter: Mingliang Liu >Assignee: Mingliang Liu > Fix For: 3.0.0-alpha2, 2.9.1 > > Attachments: HDFS-11007.000.patch > > > {code} > @Override > public synchronized int read() throws IOException { > .. > if (statistics != null && byteRead >= 0) { > statistics.incrementBytesRead(1); > } > return byteRead; > } > {code} > I believe it should be {{statistics.incrementBytesRead(byteRead);}}? -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-13723) AliyunOSSInputStream#read() should update read bytes stat correctly
[ https://issues.apache.org/jira/browse/HADOOP-13723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Wang updated HADOOP-13723: - Fix Version/s: 3.0.0-alpha2 > AliyunOSSInputStream#read() should update read bytes stat correctly > --- > > Key: HADOOP-13723 > URL: https://issues.apache.org/jira/browse/HADOOP-13723 > Project: Hadoop Common > Issue Type: Bug > Components: tools >Reporter: Mingliang Liu >Assignee: Mingliang Liu > Fix For: 3.0.0-alpha2 > > Attachments: HDFS-11007.000.patch > > > {code} > @Override > public synchronized int read() throws IOException { > .. > if (statistics != null && byteRead >= 0) { > statistics.incrementBytesRead(1); > } > return byteRead; > } > {code} > I believe it should be {{statistics.incrementBytesRead(byteRead);}}? -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-13723) AliyunOSSInputStream#read() should update read bytes stat correctly
[ https://issues.apache.org/jira/browse/HADOOP-13723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HADOOP-13723: --- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) I have committed this to {{trunk}} branch. Thanks [~drankye] for review. > AliyunOSSInputStream#read() should update read bytes stat correctly > --- > > Key: HADOOP-13723 > URL: https://issues.apache.org/jira/browse/HADOOP-13723 > Project: Hadoop Common > Issue Type: Bug > Components: tools >Reporter: Mingliang Liu >Assignee: Mingliang Liu > Attachments: HDFS-11007.000.patch > > > {code} > @Override > public synchronized int read() throws IOException { > .. > if (statistics != null && byteRead >= 0) { > statistics.incrementBytesRead(1); > } > return byteRead; > } > {code} > I believe it should be {{statistics.incrementBytesRead(byteRead);}}? -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org