[jira] [Commented] (CONNECTORS-215) Setting an environment variable of agent
[ https://issues.apache.org/jira/browse/CONNECTORS-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13055431#comment-13055431 ] Karl Wright commented on CONNECTORS-215: This will work fine, but may be overkill. The reason the -D switches are built using a special directory is because each connector might want to contribute some. But for -Xmx and -Xms, there can only be one such switch, so having these be built from a directory seems unnecessary. What do you think? > Setting an environment variable of agent > > > Key: CONNECTORS-215 > URL: https://issues.apache.org/jira/browse/CONNECTORS-215 > Project: ManifoldCF > Issue Type: Improvement > Components: Framework agents process >Reporter: Shinichiro Abe >Priority: Minor > Attachments: CONNECTORS-215-trial.patch > > > When using "./executecommand.sh org.apache.manifoldcf.agents.AgentRun", > we should have an environment variable or script parameter. > (e.g. JVM heapsize of agent) > We need to modify executecommand.bat too. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-215) Setting an environment variable of agent
[ https://issues.apache.org/jira/browse/CONNECTORS-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13055490#comment-13055490 ] Shinichiro Abe commented on CONNECTORS-215: --- OK, I agree that. It may need not to have a directory. Does the following become simple? OPTIONS=$(cat "$MCF_HOME"/processes/script/options) "Options" file includes default value "-Xms256m -Xmx256m".(Is it necessary?) > Setting an environment variable of agent > > > Key: CONNECTORS-215 > URL: https://issues.apache.org/jira/browse/CONNECTORS-215 > Project: ManifoldCF > Issue Type: Improvement > Components: Framework agents process >Reporter: Shinichiro Abe >Priority: Minor > Attachments: CONNECTORS-215-trial.patch > > > When using "./executecommand.sh org.apache.manifoldcf.agents.AgentRun", > we should have an environment variable or script parameter. > (e.g. JVM heapsize of agent) > We need to modify executecommand.bat too. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-215) Setting an environment variable of agent
[ https://issues.apache.org/jira/browse/CONNECTORS-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13055492#comment-13055492 ] Karl Wright commented on CONNECTORS-215: Having these options in a file is OK. If you look at how Tomcat works, they use an environment variable, and if the variable is not present they set it to whatever defaults are required. Either approach will do. But if you decide to use a file, then I would suggest giving it an extension (e.g. "options.env") so people understand what kind of file it is. > Setting an environment variable of agent > > > Key: CONNECTORS-215 > URL: https://issues.apache.org/jira/browse/CONNECTORS-215 > Project: ManifoldCF > Issue Type: Improvement > Components: Framework agents process >Reporter: Shinichiro Abe >Priority: Minor > Attachments: CONNECTORS-215-trial.patch > > > When using "./executecommand.sh org.apache.manifoldcf.agents.AgentRun", > we should have an environment variable or script parameter. > (e.g. JVM heapsize of agent) > We need to modify executecommand.bat too. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (CONNECTORS-216) Handling non-ingested documents in a repository connector needs to be made consistent and easy-to-understand
[ https://issues.apache.org/jira/browse/CONNECTORS-216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Wright reassigned CONNECTORS-216: -- Assignee: Karl Wright > Handling non-ingested documents in a repository connector needs to be made > consistent and easy-to-understand > > > Key: CONNECTORS-216 > URL: https://issues.apache.org/jira/browse/CONNECTORS-216 > Project: ManifoldCF > Issue Type: Improvement > Components: Framework crawler agent >Affects Versions: ManifoldCF 0.1, ManifoldCF 0.2, ManifoldCF 0.3 >Reporter: Karl Wright >Assignee: Karl Wright > > The way a connector writer is supposed to handle documents that should not be > indexed is not clear. The IProcessActivity interface provides a method, > deleteDocument(id), which removes the document from the index. But it does > not record the version string when it does this, making that method only > really useful for the case where the version string is empty. For cases > where the version string is non-empty, you are supposed to use > ingestDocument(id,version,null,null), which works fine to record the version > string and allow for change detection, but is very non-obvious to the user. > Suggestion is to add a new variant of deleteDocument(), which takes both an > id and version, and decides automatically whether to use ingestDocument() or > deleteDocument() based on the contents of the version string. Also, the old > deleteDocument(id) variant should be deprecated. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (CONNECTORS-216) Handling non-ingested documents in a repository connector needs to be made consistent and easy-to-understand
Handling non-ingested documents in a repository connector needs to be made consistent and easy-to-understand Key: CONNECTORS-216 URL: https://issues.apache.org/jira/browse/CONNECTORS-216 Project: ManifoldCF Issue Type: Improvement Components: Framework crawler agent Affects Versions: ManifoldCF 0.2, ManifoldCF 0.1, ManifoldCF 0.3 Reporter: Karl Wright The way a connector writer is supposed to handle documents that should not be indexed is not clear. The IProcessActivity interface provides a method, deleteDocument(id), which removes the document from the index. But it does not record the version string when it does this, making that method only really useful for the case where the version string is empty. For cases where the version string is non-empty, you are supposed to use ingestDocument(id,version,null,null), which works fine to record the version string and allow for change detection, but is very non-obvious to the user. Suggestion is to add a new variant of deleteDocument(), which takes both an id and version, and decides automatically whether to use ingestDocument() or deleteDocument() based on the contents of the version string. Also, the old deleteDocument(id) variant should be deprecated. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CONNECTORS-216) Handling non-ingested documents in a repository connector needs to be made consistent and easy-to-understand
[ https://issues.apache.org/jira/browse/CONNECTORS-216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Wright resolved CONNECTORS-216. Resolution: Fixed Fix Version/s: ManifoldCF 0.3 r1140147. > Handling non-ingested documents in a repository connector needs to be made > consistent and easy-to-understand > > > Key: CONNECTORS-216 > URL: https://issues.apache.org/jira/browse/CONNECTORS-216 > Project: ManifoldCF > Issue Type: Improvement > Components: Framework crawler agent >Affects Versions: ManifoldCF 0.1, ManifoldCF 0.2, ManifoldCF 0.3 >Reporter: Karl Wright >Assignee: Karl Wright > Fix For: ManifoldCF 0.3 > > > The way a connector writer is supposed to handle documents that should not be > indexed is not clear. The IProcessActivity interface provides a method, > deleteDocument(id), which removes the document from the index. But it does > not record the version string when it does this, making that method only > really useful for the case where the version string is empty. For cases > where the version string is non-empty, you are supposed to use > ingestDocument(id,version,null,null), which works fine to record the version > string and allow for change detection, but is very non-obvious to the user. > Suggestion is to add a new variant of deleteDocument(), which takes both an > id and version, and decides automatically whether to use ingestDocument() or > deleteDocument() based on the contents of the version string. Also, the old > deleteDocument(id) variant should be deprecated. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CONNECTORS-215) Setting an environment variable of agent
[ https://issues.apache.org/jira/browse/CONNECTORS-215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shinichiro Abe updated CONNECTORS-215: -- Attachment: CONNECTORS-215-sh.patch I've modified executecommand.sh. But I dont know how to write bat command, so it didnt work well.Please teach me bat command. > Setting an environment variable of agent > > > Key: CONNECTORS-215 > URL: https://issues.apache.org/jira/browse/CONNECTORS-215 > Project: ManifoldCF > Issue Type: Improvement > Components: Framework agents process >Reporter: Shinichiro Abe >Priority: Minor > Attachments: CONNECTORS-215-sh.patch, CONNECTORS-215-trial.patch > > > When using "./executecommand.sh org.apache.manifoldcf.agents.AgentRun", > we should have an environment variable or script parameter. > (e.g. JVM heapsize of agent) > We need to modify executecommand.bat too. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
