Re: RFR: 8276629: Use blessed modifier order in core-libs code
On Thu, 4 Nov 2021 11:09:42 GMT, Magnus Ihse Bursie wrote: > I ran bin/blessed-modifier-order.sh on source owned by core-libs. This > scripts verifies that modifiers are in the "blessed" order, and fixes it > otherwise. I have manually checked the changes made by the script to make > sure they are sound. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6250
Re: RFR: 8276629: Use blessed modifier order in core-libs code
On Thu, 4 Nov 2021 11:09:42 GMT, Magnus Ihse Bursie wrote: > I ran bin/blessed-modifier-order.sh on source owned by core-libs. This > scripts verifies that modifiers are in the "blessed" order, and fixes it > otherwise. I have manually checked the changes made by the script to make > sure they are sound. Marked as reviewed by mchung (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6250
Re: RFR: 8276629: Use blessed modifier order in core-libs code
On Thu, 4 Nov 2021 11:09:42 GMT, Magnus Ihse Bursie wrote: > I ran bin/blessed-modifier-order.sh on source owned by core-libs. This > scripts verifies that modifiers are in the "blessed" order, and fixes it > otherwise. I have manually checked the changes made by the script to make > sure they are sound. Marked as reviewed by dfuchs (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6250
Re: RFR: 8276629: Use blessed modifier order in core-libs code
On Thu, 4 Nov 2021 12:30:40 GMT, Aleksei Efimov wrote: >> I can see that this PR changes java.naming. Another bug to change >> java.naming, JDK-8276552, was filed yesterday. Please check with its >> reporter and coordinate this effort if necessary. > >> I can see that this PR changes java.naming. Another bug to change >> java.naming, JDK-8276552, was filed yesterday. Please check with its >> reporter and coordinate this effort if necessary. > > @magicus I'm ok with having `java.naming` changes integrated as part of this > PR. I'll close `JDK-8276552` as duplicate. > The changes looks fine to me. @AlekseiEfimov Thanks! I tried to search for open PRs with blessed ordering, but I did not search open bugs... - PR: https://git.openjdk.java.net/jdk/pull/6250
Re: RFR: 8276629: Use blessed modifier order in core-libs code
On Thu, 4 Nov 2021 11:31:50 GMT, Pavel Rappo wrote: > I can see that this PR changes java.naming. Another bug to change > java.naming, JDK-8276552, was filed yesterday. Please check with its reporter > and coordinate this effort if necessary. @magicus I'm ok with having `java.naming` changes integrated as part of this PR. I'll close `JDK-8276552` as duplicate. The changes looks fine to me. - PR: https://git.openjdk.java.net/jdk/pull/6250
Re: RFR: 8276629: Use blessed modifier order in core-libs code
On Thu, 4 Nov 2021 11:09:42 GMT, Magnus Ihse Bursie wrote: > I ran bin/blessed-modifier-order.sh on source owned by core-libs. This > scripts verifies that modifiers are in the "blessed" order, and fixes it > otherwise. I have manually checked the changes made by the script to make > sure they are sound. Marked as reviewed by aefimov (Committer). - PR: https://git.openjdk.java.net/jdk/pull/6250
Re: RFR: 8276629: Use blessed modifier order in core-libs code
On Thu, 4 Nov 2021 11:09:42 GMT, Magnus Ihse Bursie wrote: > I ran bin/blessed-modifier-order.sh on source owned by core-libs. This > scripts verifies that modifiers are in the "blessed" order, and fixes it > otherwise. I have manually checked the changes made by the script to make > sure they are sound. Looks fine to me. Thanks, David - Marked as reviewed by dholmes (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/6250
Re: RFR: 8276629: Use blessed modifier order in core-libs code
On Thu, 4 Nov 2021 11:09:42 GMT, Magnus Ihse Bursie wrote: > I ran bin/blessed-modifier-order.sh on source owned by core-libs. This > scripts verifies that modifiers are in the "blessed" order, and fixes it > otherwise. I have manually checked the changes made by the script to make > sure they are sound. I can see that this PR changes java.naming. Another bug to change java.naming, JDK-8276552, was filed yesterday. Please check with its reporter and coordinate this effort if necessary. - PR: https://git.openjdk.java.net/jdk/pull/6250
RFR: 8276629: Use blessed modifier order in core-libs code
I ran bin/blessed-modifier-order.sh on source owned by core-libs. This scripts verifies that modifiers are in the "blessed" order, and fixes it otherwise. I have manually checked the changes made by the script to make sure they are sound. - Commit messages: - 8276629: Use blessed modifier order in core-libs code Changes: https://git.openjdk.java.net/jdk/pull/6250/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=6250=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8276629 Stats: 44 lines in 28 files changed: 0 ins; 0 del; 44 mod Patch: https://git.openjdk.java.net/jdk/pull/6250.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6250/head:pull/6250 PR: https://git.openjdk.java.net/jdk/pull/6250
