Re: RFR [LDAP]: 8062947: Fix exception message to correctly represent LDAP connection failure
LGTM as well. Vyom On Thu, May 7, 2020 at 3:01 PM Chris Yin wrote: > +1 > > Thanks, > Chris > > > On 6 May 2020, at 6:35 PM, Daniel Fuchs wrote: > > > > Hi Aleksei, > > > > Looks good to me. > > > > best regards, > > > > -- daniel > > > > On 05/05/2020 18:23, Aleks Efimov wrote: > >> "LDAP response read timed out, timeout used:-1ms.": > >> https://bugs.openjdk.java.net/browse/JDK-8062947 > >> The following fix tries to tackle this issue: > >> http://cr.openjdk.java.net/~aefimov/8062947/00 > > > > -- Thanks, Vyom
Re: RFR [LDAP]: 8062947: Fix exception message to correctly represent LDAP connection failure
+1 Thanks, Chris > On 6 May 2020, at 6:35 PM, Daniel Fuchs wrote: > > Hi Aleksei, > > Looks good to me. > > best regards, > > -- daniel > > On 05/05/2020 18:23, Aleks Efimov wrote: >> "LDAP response read timed out, timeout used:-1ms.": >> https://bugs.openjdk.java.net/browse/JDK-8062947 >> The following fix tries to tackle this issue: >> http://cr.openjdk.java.net/~aefimov/8062947/00 >
Re: RFR [LDAP]: 8062947: Fix exception message to correctly represent LDAP connection failure
Hi Daniel, Thanks for the review ! Best, Aleksei On 06/05/2020 11:35, Daniel Fuchs wrote: Hi Aleksei, Looks good to me. best regards, -- daniel On 05/05/2020 18:23, Aleks Efimov wrote: "LDAP response read timed out, timeout used:-1ms.": https://bugs.openjdk.java.net/browse/JDK-8062947 The following fix tries to tackle this issue: http://cr.openjdk.java.net/~aefimov/8062947/00
Re: RFR [LDAP]: 8062947: Fix exception message to correctly represent LDAP connection failure
Hi Aleksei, Looks good to me. best regards, -- daniel On 05/05/2020 18:23, Aleks Efimov wrote: "LDAP response read timed out, timeout used:-1ms.": https://bugs.openjdk.java.net/browse/JDK-8062947 The following fix tries to tackle this issue: http://cr.openjdk.java.net/~aefimov/8062947/00
RFR [LDAP]: 8062947: Fix exception message to correctly represent LDAP connection failure
Hi, NamingException message is not precise about the cause of LDAP connection failure, i.e. in case of LDAP connection closure the NamingException with misleading message is thrown: "LDAP response read timed out, timeout used:-1ms.": https://bugs.openjdk.java.net/browse/JDK-8062947 The following fix tries to tackle this issue: http://cr.openjdk.java.net/~aefimov/8062947/00 Also, while we're here we can remove the commented debug code blocks in Connection class LDAP regression and javax.naming JCK tests are green - no failures With Best Regards, Aleksei