Re: [ITA][1.7] GraphicsMagick-1.3.5-2
my fault writing. :-(( the full setting of Yaakov was failing all test. This version pass almost all the test. Regards Marco --- Gio 2/4/09, Charles Wilson ha scritto: > Da: Charles Wilson > Oggetto: Re: [ITA][1.7] GraphicsMagick-1.3.5-2 > A: "CygWin-Apps" > Data: Giovedì 2 Aprile 2009, 03:39 > Marco Atzeri wrote: > > any comment ? > > Uhm, yeah: > > > all test failed so probably I screwed up something. > > I saw that in your earlier message, and figured you would > look into it. > If all the tests failed, then do the applications > themselves work at > all? IOW, is it a test suite configuration issue, or is the > build just > broken? If the latter, then...you need to fix it > before this is > uploaded. If merely the former, then...well, it > probably ought to be > fixed, too, but maybe that can wait until the next > release. > > -- > Chuck >
Re: [ITA][1.7] GraphicsMagick-1.3.5-2
Marco Atzeri wrote: > any comment ? Uhm, yeah: > all test failed so probably I screwed up something. I saw that in your earlier message, and figured you would look into it. If all the tests failed, then do the applications themselves work at all? IOW, is it a test suite configuration issue, or is the build just broken? If the latter, then...you need to fix it before this is uploaded. If merely the former, then...well, it probably ought to be fixed, too, but maybe that can wait until the next release. -- Chuck
Re: [ITA][1.7] GraphicsMagick-1.3.5-2
any comment ? --- Lun 23/3/09, Marco Atzeri ha scritto: > Da: Marco Atzeri > Oggetto: Re: [ITA][1.7] GraphicsMagick-1.3.5-2 > A: cygwin-apps@cygwin.com > Data: Lunedì 23 marzo 2009, 18:01 > > New version uploaded > > to download > wget -r -np http://matzeri.altervista.org/cygwin-1.7/GraphicsMagick/ > > > ./GraphicsMagick-1.3.5-3-src.tar.bz2 > ./GraphicsMagick-1.3.5-3.tar.bz2 > ./libGraphicsMagick-devel/libGraphicsMagick-devel-1.3.5-3.tar.bz2 > ./libGraphicsMagick-devel/setup.hint > ./libGraphicsMagick3/libGraphicsMagick3-1.3.5-3.tar.bz2 > ./libGraphicsMagick3/setup.hint > ./perl-Graphics-Magick/perl-Graphics-Magick-1.3.5-3.tar.bz2 > ./perl-Graphics-Magick/setup.hint > ./setup.hint > > >>> GraphicsMagick-1.3.5-3.tar.bz2 > usr/bin/gm.exe > usr/share/doc/ > usr/share/doc/Cygwin/ > usr/share/doc/Cygwin/GraphicsMagick.README > usr/share/doc/GraphicsMagick/ > usr/share/doc/GraphicsMagick/ChangeLog > usr/share/doc/GraphicsMagick/ChangeLog.2001 > usr/share/doc/GraphicsMagick/ChangeLog.2002 > usr/share/doc/GraphicsMagick/ChangeLog.2003 > usr/share/doc/GraphicsMagick/ChangeLog.2004 > usr/share/doc/GraphicsMagick/ChangeLog.2005 > usr/share/doc/GraphicsMagick/ChangeLog.2006 > usr/share/doc/GraphicsMagick/ChangeLog.2007 > usr/share/doc/GraphicsMagick/Copyright.txt > usr/share/doc/GraphicsMagick/NEWS.txt > usr/share/doc/GraphicsMagick/README.txt > usr/share/doc/GraphicsMagick/TODO.txt > usr/share/doc/GraphicsMagick/www/ > usr/share/doc/GraphicsMagick/www/animate.html > usr/share/doc/GraphicsMagick/www/api/ > usr/share/doc/GraphicsMagick/www/api/animate.html > usr/share/doc/GraphicsMagick/www/api/annotate.html > usr/share/doc/GraphicsMagick/www/api/api.html > usr/share/doc/GraphicsMagick/www/api/api.rst > usr/share/doc/GraphicsMagick/www/api/api_hyperlinks.rst > usr/share/doc/GraphicsMagick/www/api/attribute.html > usr/share/doc/GraphicsMagick/www/api/blob.html > usr/share/doc/GraphicsMagick/www/api/channel.html > usr/share/doc/GraphicsMagick/www/api/color.html > usr/share/doc/GraphicsMagick/www/api/compare.html > usr/share/doc/GraphicsMagick/www/api/composite.html > usr/share/doc/GraphicsMagick/www/api/constitute.html > usr/share/doc/GraphicsMagick/www/api/decorate.html > usr/share/doc/GraphicsMagick/www/api/deprecate.html > usr/share/doc/GraphicsMagick/www/api/display.html > usr/share/doc/GraphicsMagick/www/api/draw.html > usr/share/doc/GraphicsMagick/www/api/effect.html > usr/share/doc/GraphicsMagick/www/api/enhance.html > usr/share/doc/GraphicsMagick/www/api/error.html > usr/share/doc/GraphicsMagick/www/api/fx.html > usr/share/doc/GraphicsMagick/www/api/image.html > usr/share/doc/GraphicsMagick/www/api/list.html > usr/share/doc/GraphicsMagick/www/api/magick.html > usr/share/doc/GraphicsMagick/www/api/Makefile.am > usr/share/doc/GraphicsMagick/www/api/memory.html > usr/share/doc/GraphicsMagick/www/api/monitor.html > usr/share/doc/GraphicsMagick/www/api/montage.html > usr/share/doc/GraphicsMagick/www/api/operator.html > usr/share/doc/GraphicsMagick/www/api/paint.html > usr/share/doc/GraphicsMagick/www/api/pixel_cache.html > usr/share/doc/GraphicsMagick/www/api/pixel_iterator.html > usr/share/doc/GraphicsMagick/www/api/profile.html > usr/share/doc/GraphicsMagick/www/api/quantize.html > usr/share/doc/GraphicsMagick/www/api/registry.html > usr/share/doc/GraphicsMagick/www/api/render.html > usr/share/doc/GraphicsMagick/www/api/resize.html > usr/share/doc/GraphicsMagick/www/api/resource.html > usr/share/doc/GraphicsMagick/www/api/segment.html > usr/share/doc/GraphicsMagick/www/api/shear.html > usr/share/doc/GraphicsMagick/www/api/signature.html > usr/share/doc/GraphicsMagick/www/api/transform.html > usr/share/doc/GraphicsMagick/www/api/types.html > usr/share/doc/GraphicsMagick/www/api/types.rst > usr/share/doc/GraphicsMagick/www/api/widget.html > usr/share/doc/GraphicsMagick/www/authors.html > usr/share/doc/GraphicsMagick/www/authors.rst > usr/share/doc/GraphicsMagick/www/benchmarks-1.2.html > usr/share/doc/GraphicsMagick/www/benchmarks-1.2.rst > usr/share/doc/GraphicsMagick/www/benchmarks.html > usr/share/doc/GraphicsMagick/www/benchmarks.rst > usr/share/doc/GraphicsMagick/www/bugs.html > usr/share/doc/GraphicsMagick/www/bugs.rst > usr/share/doc/GraphicsMagick/www/Changelog.html > usr/share/doc/GraphicsMagick/www/color.html > usr/share/doc/GraphicsMagick/www/compare.html > usr/share/doc/GraphicsMagick/www/composite.html > usr/share/doc/GraphicsMagick/www/conjure.html > usr/share/doc/GraphicsMagick/www/contribute.html > usr/share/doc/GraphicsMagick/www/contribute.rst > usr/share/doc/GraphicsMagick/www/convert.html > usr/share/doc/GraphicsMagick/www/Copyright.html > usr/share/doc/GraphicsMagick/www/CVS.html > usr/share/doc/GraphicsMagick/www/CVS.rst > usr/share/doc/GraphicsMagick/www/display.html > usr/share/doc/GraphicsMagick/www/docutils-api.css > usr/share/doc/GraphicsMagick/www/docutils-articles.css > usr/share/doc/GraphicsMagick/www/download.html > usr/share/doc/GraphicsMagick/www/download.rst > usr/share/doc
[RFU 1.7] rdiff-backup 1.2.8-3 -- incremental backup/mirror
wget -x -nH --cut-dirs=2 \ http://mysite.verizon.net/res00a7j/cygwin-1.7/rdiff-backup/rdiff-backup-1.2.8-3-src.tar.bz2 \ http://mysite.verizon.net/res00a7j/cygwin-1.7/rdiff-backup/rdiff-backup-1.2.8-3.tar.bz2 \ http://mysite.verizon.net/res00a7j/cygwin-1.7/rdiff-backup/setup.hint -- David Rothenberger daver...@acm.org Machines take me by surprise with great frequency. -- Alan Turing
Re: Patch: Setup.exe - search for package
Dave Korn wrote:
> Dave Korn wrote:
>> Andrew Punch wrote:
>>> Hi,
>>>
>>> I have attached a patch for searching packages in the package selection
>>> screen. The patch is against version 2.573.2.3 - I couldn't get the
>>> CVS head to build due to a libtool version problem.
>> Thanks for contributing this. I'm currently up-porting it to CVS HEAD
>> and giving it some testing.
> I think the search box needs a label attached and a tool-tip, and IMO I
> think it might look nicer if it was left-aligned away from the view
> controls; what do you (and everyone else) think?
So, I've up-ported to HEAD, adjusted coding style to match its surroundings,
slightly restructured a couple of bits, and added a label and tool-tip and
left-aligned it. The result is attached for whoever else would like to test it.
One consequence of doing this is that it draws attention to the fact we need
to implement minimum window size dimensions for the chooser page; it's bad
enough that you can shrink it down far enough that controls slide off the
left-hand edge, but it looks even uglier when the right-aligned controls start
to slide over the left-aligned ones. If that sounds like the right thing to
do, I'll roll a patch.
> Secondly, every time you
> change the search-box contents in the category view, it collapses all
> expanded categories; I'd like to avoid that if we can, but haven't yet
> looked to see how.
I decided not to go any further into this one for now, because it's only the
same behaviour that all the other buttons display when using the category
view. Maybe we'll fix it later, maybe it will prove less tractable, but it's
another patch for another day.
Revised changelog follows. What do you think, everyone: OK for HEAD?
2009-03-27 Andrew Punch
* PickView.h: Add #include .
(PickView::SetPackageFilter): Add new function.
(PickView::packageFilterString): Add new string data member.
* PickView.cc (PickView::setViewMode): Use it to filter names.
(PickView::insert_category): Likewise.
(PickView::PickView): Initialise packageFilterString to blank.
* res.rc (IDD_CHOOSE): Add IDC_CHOOSE_SEARCH_EDIT and
IDC_CHOOSE_SEARCH_LABEL controls.
(IDS_SEARCH_TOOLTIP): Add new string resource.
* resource.h (IDS_SEARCH_TOOLTIP): New string resource ID.
(IDC_CHOOSE_SEARCH_EDIT): New edit control ID.
(IDC_CHOOSE_SEARCH_LABEL): Mew static text control ID.
* choose.cc (ChooserControlsInfo[]): Add IDC_CHOOSE_SEARCH_LABEL
and IDC_CHOOSE_SEARCH_EDIT controls to auto-resize list.
(ChooserPage::OnInit): Add tooltip to search edit box.
(ChooserPage::OnMessageCmd): Handle EN_CHANGE event from
IDC_CHOOSE_SEARCH_EDIT.
cheers,
DaveK
Index: choose.cc
===
RCS file: /cvs/cygwin-apps/setup/choose.cc,v
retrieving revision 2.145
diff -p -u -r2.145 choose.cc
--- choose.cc 5 Aug 2008 15:48:55 - 2.145
+++ choose.cc 1 Apr 2009 15:28:07 -
@@ -67,6 +67,8 @@ extern ThreeBarProgressPage Progress;
Sizing information.
*/
static ControlAdjuster::ControlInfo ChooserControlsInfo[] = {
+ {IDC_CHOOSE_SEARCH_LABEL,CP_LEFT,CP_TOP},
+ {IDC_CHOOSE_SEARCH_EDIT, CP_LEFT,CP_TOP},
{IDC_CHOOSE_KEEP,CP_RIGHT, CP_TOP},
{IDC_CHOOSE_PREV,CP_RIGHT, CP_TOP},
{IDC_CHOOSE_CURR,CP_RIGHT, CP_TOP},
@@ -172,6 +174,7 @@ ChooserPage::OnInit ()
AddTooltip (IDC_CHOOSE_EXP, IDS_TRUSTEXP_TOOLTIP);
AddTooltip (IDC_CHOOSE_VIEW, IDS_VIEWBUTTON_TOOLTIP);
AddTooltip (IDC_CHOOSE_HIDE, IDS_HIDEOBS_TOOLTIP);
+ AddTooltip (IDC_CHOOSE_SEARCH_EDIT, IDS_SEARCH_TOOLTIP);
}
void
@@ -255,7 +258,14 @@ ChooserPage::changeTrust(trusts aTrust)
bool
ChooserPage::OnMessageCmd (int id, HWND hwndctl, UINT code)
{
- if (code != BN_CLICKED)
+ if (code == EN_CHANGE && id == IDC_CHOOSE_SEARCH_EDIT)
+{
+ std::string value (egetString (GetHWND (), IDC_CHOOSE_SEARCH_EDIT));
+ chooser->SetPackageFilter (value);
+ chooser->refresh ();
+ return true;
+}
+ else if (code != BN_CLICKED && code != EN_CHANGE)
{
// Not a click notification, we don't care.
return false;
Index: resource.h
===
RCS file: /cvs/cygwin-apps/setup/resource.h,v
retrieving revision 2.36
diff -p -u -r2.36 resource.h
--- resource.h 22 Jun 2008 02:37:16 - 2.36
+++ resource.h 1 Apr 2009 15:28:07 -
@@ -33,6 +33,7 @@
#define IDS_HIDEOBS_TOOLTIP 130
#define IDS_SIG_INVALID 131
#define IDS_CRYPTO_ERROR 132
+#define IDS_SEARCH_TOOLTIP133
// Dialogs
@@ -161,3 +162,5 @@
#define IDC_STATUS_HEADER 582
#define IDC_STATUS583
#define IDC_STATIC_HEADER 584
+#define IDC_
Re: [PATCH] setup.exe: add autoload and version check for AttachConsole
Christopher Faylor wrote: > > Please don't submit this. I'll fix the problem but not this way. Okeydokey, cancelled, NP :) cheers, DaveK
Re: [PATCH] setup.exe: add autoload and version check for AttachConsole
On Wed, Apr 01, 2009 at 12:54:53PM +0100, Dave Korn wrote: > >Hi gang, > > AttachConsole (added recently for stdout/stderr handling) doesn't exist on >win2k, having been introduced in xp/2k3, so setup HEAD currently doesn't run >there. > > The attached patch fixes the load-time problem by adding an autoload. That >won't prevent the run-time crash if the function gets called, of course; so it >also adds a version check before the call. > > Unless anyone shouts, I'll commit it later today; I think this is basically >obvious. Tested by verifying under GDB that it avoids the SEGV and by seeing >that with the patch the setup.log and setup.log.full files are successfully >generated. > > * autoload.c (kernel32): Add autoload entry for AttachConsole. > * main.cc (set_cout): Check IsXpOrBetter before trying to use it. > * win32.h (IsXpOrBetter): New version check macro. Please don't submit this. I'll fix the problem but not this way. cgf
Re: Patch: Setup.exe - search for package
Dave Korn wrote:
> Andrew Punch wrote:
>> Hi,
>>
>> I have attached a patch for searching packages in the package selection
>> screen. The patch is against version 2.573.2.3 - I couldn't get the CVS
>> head to build due to a libtool version problem.
>
> Thanks for contributing this. I'm currently up-porting it to CVS HEAD and
> giving it some testing. None of the other maintainers seem to have any
> objections, so I'll commit it once I'm sure it works right. (Your ChangeLog
> entry isn't in the standard format but I'll fix that up for you.)
Ok, it looks pretty good. Functionality wise, I have a couple of thoughts:
I think the search box needs a label attached and a tool-tip, and IMO I think
it might look nicer if it was left-aligned away from the view controls; what
do you (and everyone else) think? Secondly, every time you change the
search-box contents in the category view, it collapses all expanded
categories; I'd like to avoid that if we can, but haven't yet looked to see how.
Also, a few stylistic issues to bear in mind for any potential future
occasion you're submitting a patch (don't worry about them now, I'll tidy it
up as part of porting it to HEAD):
- Standard system header includes should go at the top of lists of #includes,
not the end:
--- setup-2.573.2.3/PickView.h 2006-05-24 23:01:34.0 +1000
+++ setup-new/PickView.h2009-03-31 21:14:00.37500 +1100
@@ -19,6 +19,7 @@
#include "win32.h"
#include "window.h"
#include "RECTWrapper.h"
+#include
#define HMARGIN 10
#define ROW_MARGIN 5
@@ -82,6 +83,13 @@
- There should be a space between any function name and the following
open-bracket:
@@ -82,6 +83,13 @@
int header_height;
PickCategoryLine contents;
void scroll (HWND hwnd, int which, int *var, int code, int howmany);
+
+ void SetPackageFilter(const std::string &filterString)
+ {
+ packageFilterString = filterString;
+ }
+
+
- Watch out for accidental white-space and other superfluous or unintentional
changes; e.g.
diff -u --exclude '*config.*' --exclude '*Makefile' setup-2.573.2.3/res.rc
setup-new/res.rc
--- setup-2.573.2.3/res.rc 2008-06-19 09:26:20.0 +1000
+++ setup-new/res.rc2009-03-31 21:14:00.390625000 +1100
@@ -316,7 +316,8 @@
CAPTION "Cygwin Setup - Select Packages"
FONT 8, "MS Shell Dlg"
BEGIN
-CONTROL "&Keep",IDC_CHOOSE_KEEP,"Button",BS_AUTORADIOBUTTON |
+EDITTEXT IDC_CHOOSE_SEARCH_EDIT, 7, 30, 60, 12
+ CONTROL "&Keep",IDC_CHOOSE_KEEP,"Button",BS_AUTORADIOBUTTON |
here you replaced the spaces before CONTROL with a TAB, or here:
@@ -291,8 +300,9 @@
case IDC_CHOOSE_HIDE:
chooser->setObsolete (!IsButtonChecked (id));
break;
+
+
default:
- // Wasn't recognized or handled.
return false;
}
where you added some blank lines and deleted a comment; neither of these two
changes are related to or required for the purpose of your patch in any way.
@@ -283,20 +288,20 @@
}
else
{
- for (set ::const_iterator x
+ for (set ::const_iterator x
= pkg.categories.begin (); x != pkg.categories.end (); ++x)
-{
+ {
// Special case - yuck
if (casecompare(*x, "All") == 0)
- continue;
+ continue;
packagedb db;
PickCategoryLine & catline =
- *new PickCategoryLine (*this, *db.categories.find (*x), 1);
+ *new PickCategoryLine (*this, *db.categories.find (*x), 1);
PickLine & line = *new PickPackageLine(*this, pkg);
catline.insert (line);
contents.insert (catline);
-}
+ }
}
}
.. or here where you've just gone and added incorrect indentation without
making any changes at all. You should always match the existing indentation
style of any code you're working with; if it uses TABs, use TABs, if it uses
spaces, use spaces. And above all, watch out if your editor is set to
auto-convert between the two!
The other thing I wanted to mention is that your ChangeLog entry isn't in
the standard format. Minor: two spaces between the date and your name, and
your name and your email address. More significant: we don't put introductory
paragraphs in ChangeLogs, it's not what they're for. Minor again: each line
(apart from the header with date/name/email) should begin with a TAB; you
should only specify the filename once for each file modified, on the first
line; we use the present tense for verbs; and there are some standard ways of
denoting things like the addition of new functions. A sentence like "Add
definition of function SetPackageFilter to class PickView" contains a lot of
redundancy when you've already given the class and function names in brackets
immediately beforehand; anyone who understands C++ will already know that.
So I'd rewrite it like so (email protected just for illustration):
2009-03-27 Andrew Punch
* PickV
[PATCH] setup.exe: add autoload and version check for AttachConsole
Hi gang,
AttachConsole (added recently for stdout/stderr handling) doesn't exist on
win2k, having been introduced in xp/2k3, so setup HEAD currently doesn't run
there.
The attached patch fixes the load-time problem by adding an autoload. That
won't prevent the run-time crash if the function gets called, of course; so it
also adds a version check before the call.
Unless anyone shouts, I'll commit it later today; I think this is basically
obvious. Tested by verifying under GDB that it avoids the SEGV and by seeing
that with the patch the setup.log and setup.log.full files are successfully
generated.
* autoload.c (kernel32): Add autoload entry for AttachConsole.
* main.cc (set_cout): Check IsXpOrBetter before trying to use it.
* win32.h (IsXpOrBetter): New version check macro.
cheers,
DaveK
Index: autoload.c
===
RCS file: /cvs/cygwin-apps/setup/autoload.c,v
retrieving revision 2.7
diff -p -u -r2.7 autoload.c
--- autoload.c 8 Apr 2008 23:50:54 - 2.7
+++ autoload.c 1 Apr 2009 11:38:26 -
@@ -61,6 +61,8 @@ Auto (advapi32, OpenServiceA, 16);
Auto (advapi32, QueryServiceStatus, 8);
Auto (advapi32, StartServiceA, 16);
+DLL (kernel32);
+Auto (kernel32, AttachConsole, 4);
typedef struct {
DllInfo *dll;
Index: main.cc
===
RCS file: /cvs/cygwin-apps/setup/main.cc,v
retrieving revision 2.48
diff -p -u -r2.48 main.cc
--- main.cc 21 Mar 2009 21:00:25 - 2.48
+++ main.cc 1 Apr 2009 11:38:26 -
@@ -85,7 +85,7 @@ set_cout ()
{
HANDLE hstdout = GetStdHandle (STD_OUTPUT_HANDLE);
if (GetFileType (hstdout) == FILE_TYPE_UNKNOWN && GetLastError () != NO_ERROR
- && AttachConsole ((DWORD) -1))
+ && IsXpOrBetter () && AttachConsole ((DWORD) -1))
{
ofstream *conout = new ofstream ("conout$");
cout.rdbuf (conout->rdbuf ());
Index: win32.h
===
RCS file: /cvs/cygwin-apps/setup/win32.h,v
retrieving revision 2.17
diff -p -u -r2.17 win32.h
--- win32.h 20 Aug 2008 10:33:25 - 2.17
+++ win32.h 1 Apr 2009 11:38:27 -
@@ -162,5 +162,8 @@ VersionInfo& GetVer ();
#define IsWindowsNT() (GetVer ().isNT ())
#define OSMajorVersion() (GetVer ().major ())
#define OSMinorVersion() (GetVer ().minor ())
+#define IsXpOrBetter() ((OSMajorVersion () > 5) \
+ || (OSMajorVersion () == 5 && OSMinorVersion () >=
1))
+
#endif /* SETUP_WIN32_H */
Re: Patch: Setup.exe - search for package
Andrew Punch wrote: > Hi, > > I have attached a patch for searching packages in the package selection > screen. The patch is against version 2.573.2.3 - I couldn't get the CVS > head to build due to a libtool version problem. Thanks for contributing this. I'm currently up-porting it to CVS HEAD and giving it some testing. None of the other maintainers seem to have any objections, so I'll commit it once I'm sure it works right. (Your ChangeLog entry isn't in the standard format but I'll fix that up for you.) cheers, DaveK
