Re: [PATCH v1 - 1/5] DaVinci - restructuring code to support vpif capture driver
On Friday 14 August 2009 23:01:41 m-kariche...@ti.com wrote: > From: Muralidharan Karicheri > > This patch makes the following changes:- > 1) Modify vpif_subdev_info to add board_info, routing information > and vpif interface configuration. Remove addr since it is > part of board_info > > 2) Add code to setup channel mode and input decoder path for > vpif capture driver > > Also incorporated comments against version v0 of the patch series and > added a spinlock to protect writes to common registers A quick question: against which git tree are these arch changes applied? I've lost track of that :-) Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom ___ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
RE: [PATCH v1 - 1/5] DaVinci - restructuring code to support vpif capture driver
Hans, They are applied against davinci tree (also mentioned in the patch). General procedure what I follow is to create platform code against davinci tree and v4l patches against v4l-dvb linux-next tree. The architecture part of linux-next is not up to date. Davinci tree is at git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-davinci.git Murali Karicheri Software Design Engineer Texas Instruments Inc. Germantown, MD 20874 new phone: 301-407-9583 Old Phone : 301-515-3736 (will be deprecated) email: m-kariche...@ti.com >-Original Message- >From: Hans Verkuil [mailto:hverk...@xs4all.nl] >Sent: Saturday, August 15, 2009 8:10 AM >To: Karicheri, Muralidharan >Cc: linux-me...@vger.kernel.org; davinci-linux-open- >sou...@linux.davincidsp.com; khil...@deeprootsystems.com >Subject: Re: [PATCH v1 - 1/5] DaVinci - restructuring code to support vpif >capture driver > >On Friday 14 August 2009 23:01:41 m-kariche...@ti.com wrote: >> From: Muralidharan Karicheri >> >> This patch makes the following changes:- >> 1) Modify vpif_subdev_info to add board_info, routing information >> and vpif interface configuration. Remove addr since it is >> part of board_info >> >> 2) Add code to setup channel mode and input decoder path for >> vpif capture driver >> >> Also incorporated comments against version v0 of the patch series and >> added a spinlock to protect writes to common registers > >A quick question: against which git tree are these arch changes applied? >I've lost track of that :-) > >Regards, > > Hans > >-- >Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom ___ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
Re: [PATCH v1 - 1/5] DaVinci - restructuring code to support vpif capture driver
On Monday 17 August 2009 16:52:20 Karicheri, Muralidharan wrote: > Hans, > > They are applied against davinci tree (also mentioned in the patch). General > procedure what I follow is to create platform code against davinci tree and > v4l patches against v4l-dvb linux-next tree. The architecture part of > linux-next is not up to date. > > Davinci tree is at > > git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-davinci.git I must have missed the mention of this tree. I have a problem, though, as the current v4l-dvb repository doesn't compile against the linux-davinci git tree. And the only way I can get it to compile is to apply all five patches first. However, the whole tree should still compile after each patch is applied. And that goes wrong with your second patch where the Kconfig and Makefile are modified when the new sources aren't even added yet! What I would like to see is a patch series that starts with one patch that makes the current v4l-dvb tree compile again, then the arch patch is added, then a series of v4l-dvb patches in such an order that everything compiles after each step. Merging this is already complicated enough without breaking compilation in this way. Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom ___ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
RE: [PATCH v1 - 1/5] DaVinci - restructuring code to support vpif capture driver
Hans, Ok. I will rework the patch and send you the same. Murali Karicheri Software Design Engineer Texas Instruments Inc. Germantown, MD 20874 new phone: 301-407-9583 Old Phone : 301-515-3736 (will be deprecated) email: m-kariche...@ti.com >-Original Message- >From: Hans Verkuil [mailto:hverk...@xs4all.nl] >Sent: Monday, August 17, 2009 2:47 PM >To: Karicheri, Muralidharan >Cc: linux-me...@vger.kernel.org; davinci-linux-open- >sou...@linux.davincidsp.com; khil...@deeprootsystems.com >Subject: Re: [PATCH v1 - 1/5] DaVinci - restructuring code to support vpif >capture driver > >On Monday 17 August 2009 16:52:20 Karicheri, Muralidharan wrote: >> Hans, >> >> They are applied against davinci tree (also mentioned in the patch). >General procedure what I follow is to create platform code against davinci >tree and v4l patches against v4l-dvb linux-next tree. The architecture part >of linux-next is not up to date. >> >> Davinci tree is at >> >> git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-davinci.git > >I must have missed the mention of this tree. > >I have a problem, though, as the current v4l-dvb repository doesn't compile >against the linux-davinci git tree. And the only way I can get it to >compile >is to apply all five patches first. > >However, the whole tree should still compile after each patch is applied. >And >that goes wrong with your second patch where the Kconfig and Makefile are >modified when the new sources aren't even added yet! > >What I would like to see is a patch series that starts with one patch that >makes the current v4l-dvb tree compile again, then the arch patch is added, >then a series of v4l-dvb patches in such an order that everything compiles >after each step. > >Merging this is already complicated enough without breaking compilation in >this way. > >Regards, > > Hans > >-- >Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom ___ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
RE: [PATCH v1 - 1/5] DaVinci - restructuring code to support vpif capture driver
Hans, Would you like the architecture specific changes against v4l-dvb linux-next tree or linux-davinci ? I will rework both the vpfe and vpif patches as per your comment. Murali Karicheri Software Design Engineer Texas Instruments Inc. Germantown, MD 20874 new phone: 301-407-9583 Old Phone : 301-515-3736 (will be deprecated) email: m-kariche...@ti.com >-Original Message- >From: Hans Verkuil [mailto:hverk...@xs4all.nl] >Sent: Monday, August 17, 2009 2:47 PM >To: Karicheri, Muralidharan >Cc: linux-me...@vger.kernel.org; davinci-linux-open- >sou...@linux.davincidsp.com; khil...@deeprootsystems.com >Subject: Re: [PATCH v1 - 1/5] DaVinci - restructuring code to support vpif >capture driver > >On Monday 17 August 2009 16:52:20 Karicheri, Muralidharan wrote: >> Hans, >> >> They are applied against davinci tree (also mentioned in the patch). >General procedure what I follow is to create platform code against davinci >tree and v4l patches against v4l-dvb linux-next tree. The architecture part >of linux-next is not up to date. >> >> Davinci tree is at >> >> git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-davinci.git > >I must have missed the mention of this tree. > >I have a problem, though, as the current v4l-dvb repository doesn't compile >against the linux-davinci git tree. And the only way I can get it to >compile >is to apply all five patches first. > >However, the whole tree should still compile after each patch is applied. >And >that goes wrong with your second patch where the Kconfig and Makefile are >modified when the new sources aren't even added yet! > >What I would like to see is a patch series that starts with one patch that >makes the current v4l-dvb tree compile again, then the arch patch is added, >then a series of v4l-dvb patches in such an order that everything compiles >after each step. > >Merging this is already complicated enough without breaking compilation in >this way. > >Regards, > > Hans > >-- >Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom ___ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
Re: [PATCH v1 - 1/5] DaVinci - restructuring code to support vpif capture driver
On Monday 17 August 2009 22:10:04 Karicheri, Muralidharan wrote: > Hans, > > Would you like the architecture specific changes against v4l-dvb linux-next > tree or linux-davinci ? I will rework both the vpfe and vpif patches as per > your comment. v4l-dvb linux-next. The current v4l-dvb at least compiles against that one, so that is the most appropriate tree to do the patches against. Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom ___ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
RE: [PATCH v1 - 1/5] DaVinci - restructuring code to support vpif capture driver
Hans, I have re-send vpfe capture patch. I will re-send vpif patches tomorrow. Murali Karicheri Software Design Engineer Texas Instruments Inc. Germantown, MD 20874 new phone: 301-407-9583 Old Phone : 301-515-3736 (will be deprecated) email: m-kariche...@ti.com >-Original Message- >From: Hans Verkuil [mailto:hverk...@xs4all.nl] >Sent: Monday, August 17, 2009 4:27 PM >To: Karicheri, Muralidharan >Cc: linux-me...@vger.kernel.org; davinci-linux-open- >sou...@linux.davincidsp.com; khil...@deeprootsystems.com >Subject: Re: [PATCH v1 - 1/5] DaVinci - restructuring code to support vpif >capture driver > >On Monday 17 August 2009 22:10:04 Karicheri, Muralidharan wrote: >> Hans, >> >> Would you like the architecture specific changes against v4l-dvb linux- >next tree or linux-davinci ? I will rework both the vpfe and vpif patches >as per your comment. > >v4l-dvb linux-next. The current v4l-dvb at least compiles against that one, >so >that is the most appropriate tree to do the patches against. > >Regards, > > Hans > >-- >Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom ___ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
Re: [PATCH v1 - 1/5] DaVinci - restructuring code to support vpif capture driver
On Tuesday 18 August 2009 01:23:10 Karicheri, Muralidharan wrote: > Hans, > > I have re-send vpfe capture patch. I will re-send vpif patches tomorrow. These patches apply fine. I'll merge them in my v4l-dvb-dm646x tree tonight. Thanks! Hans > > Murali Karicheri > Software Design Engineer > Texas Instruments Inc. > Germantown, MD 20874 > new phone: 301-407-9583 > Old Phone : 301-515-3736 (will be deprecated) > email: m-kariche...@ti.com > > >-Original Message- > >From: Hans Verkuil [mailto:hverk...@xs4all.nl] > >Sent: Monday, August 17, 2009 4:27 PM > >To: Karicheri, Muralidharan > >Cc: linux-me...@vger.kernel.org; davinci-linux-open- > >sou...@linux.davincidsp.com; khil...@deeprootsystems.com > >Subject: Re: [PATCH v1 - 1/5] DaVinci - restructuring code to support vpif > >capture driver > > > >On Monday 17 August 2009 22:10:04 Karicheri, Muralidharan wrote: > >> Hans, > >> > >> Would you like the architecture specific changes against v4l-dvb linux- > >next tree or linux-davinci ? I will rework both the vpfe and vpif patches > >as per your comment. > > > >v4l-dvb linux-next. The current v4l-dvb at least compiles against that one, > >so > >that is the most appropriate tree to do the patches against. > > > >Regards, > > > > Hans > > > >-- > >Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom > > > > -- Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom ___ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
Re: [PATCH v1 - 1/5] DaVinci - restructuring code to support vpif capture driver
On Tuesday 18 August 2009 08:49:13 Hans Verkuil wrote: > On Tuesday 18 August 2009 01:23:10 Karicheri, Muralidharan wrote: > > Hans, > > > > I have re-send vpfe capture patch. I will re-send vpif patches tomorrow. > > These patches apply fine. I'll merge them in my v4l-dvb-dm646x tree tonight. Oops, wrong tree. It's v4l-dvb-vpif. Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom ___ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
RE: [PATCH v1 - 1/5] DaVinci - restructuring code to support vpif capture driver
Mauro, I need to send a set of patches for adding vpif capture driver. Currently the linux-next doesn't have the last patch from Chaithrika applied for vpif display. Is it possible to apply this asap so that I can create the vpif capture patch today? Murali Karicheri Software Design Engineer Texas Instruments Inc. Germantown, MD 20874 new phone: 301-407-9583 Old Phone : 301-515-3736 (will be deprecated) email: m-kariche...@ti.com >-Original Message- >From: Hans Verkuil [mailto:hverk...@xs4all.nl] >Sent: Tuesday, August 18, 2009 2:51 AM >To: Karicheri, Muralidharan >Cc: linux-me...@vger.kernel.org; davinci-linux-open- >sou...@linux.davincidsp.com; khil...@deeprootsystems.com >Subject: Re: [PATCH v1 - 1/5] DaVinci - restructuring code to support vpif >capture driver > >On Tuesday 18 August 2009 08:49:13 Hans Verkuil wrote: >> On Tuesday 18 August 2009 01:23:10 Karicheri, Muralidharan wrote: >> > Hans, >> > >> > I have re-send vpfe capture patch. I will re-send vpif patches tomorrow. >> >> These patches apply fine. I'll merge them in my v4l-dvb-dm646x tree >tonight. > >Oops, wrong tree. It's v4l-dvb-vpif. > >Regards, > > Hans > >-- >Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom ___ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
RE: [PATCH v1 - 1/5] DaVinci - restructuring code to support vpif capture driver
Mauro, Here are the patches from Chaithrika that I am referring to. http://www.mail-archive.com/linux-me...@vger.kernel.org/msg08254.html http://www.mail-archive.com/linux-me...@vger.kernel.org/msg07676.html Let me know once they are merged... Murali Karicheri Software Design Engineer Texas Instruments Inc. Germantown, MD 20874 new phone: 301-407-9583 Old Phone : 301-515-3736 (will be deprecated) email: m-kariche...@ti.com >-Original Message- >From: Mauro Carvalho Chehab [mailto:mche...@infradead.org] >Sent: Tuesday, August 18, 2009 1:28 PM >To: Karicheri, Muralidharan >Cc: Mauro Carvalho Chehab; linux-me...@vger.kernel.org; davinci-linux-open- >sou...@linux.davincidsp.com; khil...@deeprootsystems.com; Hans Verkuil >Subject: Re: [PATCH v1 - 1/5] DaVinci - restructuring code to support vpif >capture driver > >Em Tue, 18 Aug 2009 11:06:54 -0500 >"Karicheri, Muralidharan" escreveu: > >> Mauro, >> >> I need to send a set of patches for adding vpif capture driver. Currently >the linux-next doesn't have the last patch from Chaithrika applied for vpif >display. Is it possible to apply this asap so that I can create the vpif >capture patch today? > >Sure. Could you please point me what's the patchwork ID(s)[1] of the patch >you need >me to apply at our development tree and at linux-next? > [1] http://patchwork.kernel.org/project/linux-media/list/ > >Cheers, >Mauro ___ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
RE: [PATCH v1 - 1/5] DaVinci - restructuring code to support vpif capture driver
Mauro, Kevin has approved the architecture part of this patch. When can I expect these to be merged to linux-next? Thanks. Murali Karicheri Software Design Engineer Texas Instruments Inc. Germantown, MD 20874 email: m-kariche...@ti.com >-Original Message- >From: Karicheri, Muralidharan >Sent: Tuesday, August 18, 2009 5:51 PM >To: 'Mauro Carvalho Chehab' >Cc: Mauro Carvalho Chehab; linux-me...@vger.kernel.org; davinci-linux-open- >sou...@linux.davincidsp.com; khil...@deeprootsystems.com; Hans Verkuil >Subject: RE: [PATCH v1 - 1/5] DaVinci - restructuring code to support vpif >capture driver > >Mauro, > >Here are the patches from Chaithrika that I am referring to. >http://www.mail-archive.com/linux-me...@vger.kernel.org/msg08254.html >http://www.mail-archive.com/linux-me...@vger.kernel.org/msg07676.html > >Let me know once they are merged... > >Murali Karicheri >Software Design Engineer >Texas Instruments Inc. >Germantown, MD 20874 >new phone: 301-407-9583 >Old Phone : 301-515-3736 (will be deprecated) >email: m-kariche...@ti.com > >>-Original Message- >>From: Mauro Carvalho Chehab [mailto:mche...@infradead.org] >>Sent: Tuesday, August 18, 2009 1:28 PM >>To: Karicheri, Muralidharan >>Cc: Mauro Carvalho Chehab; linux-me...@vger.kernel.org; davinci-linux- >open- >>sou...@linux.davincidsp.com; khil...@deeprootsystems.com; Hans Verkuil >>Subject: Re: [PATCH v1 - 1/5] DaVinci - restructuring code to support vpif >>capture driver >> >>Em Tue, 18 Aug 2009 11:06:54 -0500 >>"Karicheri, Muralidharan" escreveu: >> >>> Mauro, >>> >>> I need to send a set of patches for adding vpif capture driver. >Currently >>the linux-next doesn't have the last patch from Chaithrika applied for >vpif >>display. Is it possible to apply this asap so that I can create the vpif >>capture patch today? >> >>Sure. Could you please point me what's the patchwork ID(s)[1] of the patch >>you need >>me to apply at our development tree and at linux-next? >> [1] http://patchwork.kernel.org/project/linux-media/list/ >> >>Cheers, >>Mauro ___ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
