Re: Bug#234513: debian-installer: segfault when starting kbd-chooser
On Sat, Mar 13, 2004 at 09:10:12AM +, Alastair McKinstry wrote: > Am Aoine, 2004-03-12 ag 23:46, scríobh Colin Watson: > > The segfault is here, on line 627 of kbd-chooser.c in version 0.42: > > > > return (preferred->present == TRUE) ? "low" : "medium"; > > > In addition to this, is it a bad sign that no preferred keyboard seems > > to be found? > > > Thanks for this. I've been having a hard time getting a powerpc setup to > test this on. > > Mac keyboards were not being included in powerpc machines! Ok, now can > we get this CVS version tested quickly for beta3? Current CVS doesn't build: cc -c -Wall -I. -DNDEBUG=1 -fomit-frame-pointer -Os -DUSB_KBD -DAT_KBD -DAMIGA_KBD +DMAC_KBD loadkeys.c cc: +DMAC_KBD: No such file or directory loadkeys.y: In function `addfunc': loadkeys.y:609: warning: comparison is always false due to limited range of data type loadkeys.y: At top level: :1593: warning: `yyunput' defined but not used make[1]: *** [loadkeys.o] Error 1 Patch: Index: Makefile === RCS file: /cvsroot/d-i/debian-installer/tools/kbd-chooser/Makefile,v retrieving revision 1.24 diff -p -u -r1.24 Makefile --- Makefile13 Mar 2004 09:01:59 - 1.24 +++ Makefile13 Mar 2004 10:28:23 - @@ -45,7 +45,7 @@ CFLAGS += -DSPARC_KBD -DUSB_KBD KEYBOARDS := sparc usb endif ifeq ($(ARCH),powerpc) -CFLAGS += -DUSB_KBD -DAT_KBD -DAMIGA_KBD +DMAC_KBD +CFLAGS += -DUSB_KBD -DAT_KBD -DAMIGA_KBD -DMAC_KBD KEYBOARDS := at usb amiga mac endif ifeq ($(ARCH),arm) After this, current CVS doesn't segfault, anyway, although as previously mentioned I can't test in the d-i environment right now. -- Colin Watson [EMAIL PROTECTED] -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Re: Bug#234513: debian-installer: segfault when starting kbd-chooser
Am Aoine, 2004-03-12 ag 23:46, scrÃobh Colin Watson: > On Tue, Feb 24, 2004 at 11:48:16AM +0100, Thomas Arendsen Hein wrote: > > Package: debian-installer > > Version: N/A; reported 2004-02-24 > > Severity: important > > > > Installation using sarge-powerpc-netinst.iso downloaded from > > http://gluck.debian.org/cdimage/testing/sid_d-i/powerpc/20040223/ > > can't start kbd-chooser. > > > > The segfault is here, on line 627 of kbd-chooser.c in version 0.42: > > return (preferred->present == TRUE) ? "low" : "medium"; > In addition to this, is it a bad sign that no preferred keyboard seems > to be found? Thanks for this. I've been having a hard time getting a powerpc setup to test this on. Mac keyboards were not being included in powerpc machines! Ok, now can we get this CVS version tested quickly for beta3? - Alastair > -- > Colin Watson [EMAIL PROTECTED] -- SlÃn agus Beannacht, Alastair Alastair McKinstry <[EMAIL PROTECTED]> GPG Key fingerprint (New) = CD45 260A 4546 C3C0 F595 F0F6 4132 BF90 2A38 5C57 He that would make his own liberty secure must guard even his enemy from oppression; for if he violates this duty he establishes a precedent that will reach to himself. - --Thomas Paine -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Bug#234513: debian-installer: segfault when starting kbd-chooser
On Tue, Feb 24, 2004 at 11:48:16AM +0100, Thomas Arendsen Hein wrote:
> Package: debian-installer
> Version: N/A; reported 2004-02-24
> Severity: important
>
> Installation using sarge-powerpc-netinst.iso downloaded from
> http://gluck.debian.org/cdimage/testing/sid_d-i/powerpc/20040223/
> can't start kbd-chooser.
>
> When starting kbd-chooser on the command line on tty2 and proceeding
> with multiple times, there is a segfault after 'GET
> console-tools/archs'
I'm not really in a position to check this in the d-i environment, but I
can reproduce it on powerpc by just hitting enter at kbd-chooser in a
normal Debian system (although the segfault is after 'SET
console-tools/archs', not 'GET console-tools/archs').
The segfault is here, on line 627 of kbd-chooser.c in version 0.42:
return (preferred->present == TRUE) ? "low" : "medium";
The code above this includes:
if (((preferred == NULL) || (preferred->present == UNKNOWN))
&& check_if_serial_console ()) {
... and:
mydebconf_default_set ("console-tools/archs",
preferred ? preferred->description : none);
... so it looks like there's simply a (preferred == NULL) check missing
from line 627? I don't know what the sense should be.
In addition to this, is it a bad sign that no preferred keyboard seems
to be found?
--
Colin Watson [EMAIL PROTECTED]
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Bug#234513: debian-installer: segfault when starting kbd-chooser
Package: debian-installer Version: N/A; reported 2004-02-24 Severity: important Installation using sarge-powerpc-netinst.iso downloaded from http://gluck.debian.org/cdimage/testing/sid_d-i/powerpc/20040223/ can't start kbd-chooser. When starting kbd-chooser on the command line on tty2 and proceeding with multiple times, there is a segfault after 'GET console-tools/archs' Thomas -- Email: [EMAIL PROTECTED] http://intevation.de/~thomas/ -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
