Re: Re: Bug#675845: adanaxisgpl: FTBFS:

2012-11-30 Thread Guillem Jover
Hi!

On Fri, 2012-11-30 at 03:26:49 +, Steven Chamberlain wrote:
> Control: found -1 1.2.5.dfsg.1-4.1
> Control: tags -1 + patch

> The problem is a '#define off_t long', which causes a problem later when
> GNU/kFreeBSD headers include  (again), and try to redefine
> off_t for some reason.
> 
> That only happens because HAVE_OFF_T isn't being set in config.h.  In
> fact it is hard-coded to 0 by default and set to 1 on certain supported
> platforms such as Mac OS X (in rubyconfigure.h).


> With the patch below, then running:
> 
> $ aclocal-1.10 && autoheader && autoconf
> 
> implements a proper detection for off_t and it builds now on
> kfreebsd-amd64.  Also it still builds okay and runs on GNU/Linux amd64.
> 
> --- a/configure.in  2007-10-25 21:38:55.0 +0100
> +++ b/configure.in  2012-11-30 02:01:34.039114307 +
> @@ -288,6 +288,8 @@
>  ])
>  ])
>  
> +AC_CHECK_TYPES([off_t], [], [], [[#include ]])
> +

I guess ideally the code would be using AC_TYPE_OFF_T, but as you
mention that the code depends on HAVE_OFF_T, then this might be the
smallest change to accomplish the same thing.

Thanks,
Guillem


-- 
To UNSUBSCRIBE, email to debian-bsd-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20121130083531.ga24...@gaara.hadrons.org



Re: Re: Bug#675845: adanaxisgpl: FTBFS:

2012-11-29 Thread Steven Chamberlain
Control: found -1 1.2.5.dfsg.1-4.1
Control: tags -1 + patch

Hi,

On 14:54, Felix Geyer wrote:
> Are you sure that you have built 1.2.5.dfsg.1-4.1 and not
> 1.2.5.dfsg.1-4 since the compiler command line should contain
> "-fpermissive"?

I could reproduce the same build failure in this version with
-fpermissive

The problem is a '#define off_t long', which causes a problem later when
GNU/kFreeBSD headers include  (again), and try to redefine
off_t for some reason.

That only happens because HAVE_OFF_T isn't being set in config.h.  In
fact it is hard-coded to 0 by default and set to 1 on certain supported
platforms such as Mac OS X (in rubyconfigure.h).

Linux headers presumably don't redefine off_t so it doesn't usually
matter.


With the patch below, then running:

$ aclocal-1.10 && autoheader && autoconf

implements a proper detection for off_t and it builds now on
kfreebsd-amd64.  Also it still builds okay and runs on GNU/Linux amd64.

--- a/configure.in  2007-10-25 21:38:55.0 +0100
+++ b/configure.in  2012-11-30 02:01:34.039114307 +
@@ -288,6 +288,8 @@
 ])
 ])
 
+AC_CHECK_TYPES([off_t], [], [], [[#include ]])
+
 LIBS="$LIBS $SDL_EXTRA_LIBS"
 
 AC_OUTPUT(Makefile src/Makefile data-adanaxis/Makefile)


Thank you!
Regards,
-- 
Steven Chamberlain
ste...@pyro.eu.org


-- 
To UNSUBSCRIBE, email to debian-bsd-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20121130032648.ga17...@squeeze.pyro.eu.org



Re: Re: Bug#675845: adanaxisgpl: FTBFS:

2012-07-25 Thread Felix Geyer

On 09.06.2012 18:33, Robert Millan wrote:
> 2012/6/3 Christoph Egger :
>> /usr/include/sys/kern/types.h:189:18: error: two or more data types in 
>> declaration specifiers
> This might be a bug in kfreebsd-kernel-headers, however I can't check
> because it hits a different error:
>
> g++ -DHAVE_CONFIG_H -I. -I..   -DMUSH_DATA_DIR=\"/usr/share/games\"
> -I/usr/include/SDL -D_GNU_SOURCE=1 -D_REENTRANT -I. -I./API -DNDEBUG
> -I./Platform/X11  -g -O2 -c -o GameStringSpec.o `test -f
> 'Game/GameStringSpec.cpp' || echo './'`Game/GameStringSpec.cpp
> In file included from ./Mushcore/MushcoreData.h:178:0,
>  from ./Mushcore/Mushcore.h:120,
>  from ./API/mushMushcore.h:58,
>  from Game/GameStringSpec.h:51,
>  from Game/GameStringSpec.cpp:50:
> ./Mushcore/MushcoreSingleton.h: In instantiation of ‘static void
> MushcoreSingleton::SingletonUncheckedNew() [with
> SingletonType = MushcoreFactory]’:
> ./Mushcore/MushcoreSingleton.h:76:9:   required from ‘static
> SingletonType& MushcoreSingleton::Sgl() [with
> SingletonType = MushcoreFactory]’
> Game/GameStringSpec.cpp:91:22:   required from here
> ./Mushcore/MushcoreSingleton.h:86:5: error: ‘SingletonPtrSet’ was not
> declared in this scope, and no declarations were found by
> argument-dependent lookup at the point of instantiation [-fpermissive]

Are you sure that you have built 1.2.5.dfsg.1-4.1 and not
1.2.5.dfsg.1-4 since the compiler command line should contain
"-fpermissive"?

Felix


-- 
To UNSUBSCRIBE, email to debian-bsd-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/500fec6b.7020...@debian.org