Bug#1023782: [Pkg-mozext-maintainers] Bug#1023782: Add dependency on pinentry-x11
Control: affects 1023782 + src:pinentry On Tue 2022-11-15 19:46:09 +0900, Olaf Meeuwissen wrote: > Maybe pinentry-gui should be added as a pure virtual package? And in > due course, pinentry-x11 removed? Anyway, that's not food for the > webext-browserpass package. yep, if someone has the space and motivation to do this work on the pinentry package, that'd be a welcome contribution. > Guess what! webext-browserpass doesn't even depend on pass! :-o > Oh, just noticed that pass (or gopass) is not actually required[1]. > Maybe that should become a Recommends: too, with a note in the package > description why it's not a Depends: ... > > [1]: https://github.com/browserpass/browserpass-extension#requirements urgh, i have to confess that reading the code in the browserpass-native repo gives me a bit of heartache because of how ill-suited the gpg API is for the work that it's doing here, but that's probably a different issue. --dkg signature.asc Description: PGP signature
Bug#1023782: [Pkg-mozext-maintainers] Bug#1023782: Add dependency on pinentry-x11
Hi,
Daniel Kahn Gillmor writes:
> over on Bug #1023782 ("Add dependency on pinentry-x11") about
> webext-browserpass,
> Meeuwissen Olaf wrote:
>
>> Please add a dependency on pinentry-x11. This is a pure virtual package that
>> makes the user pick one. I think that is to be preferred over adding a list
>> of
>> alternatives directly because the package managers tend to pick the first one
>> listed.
>
> Arguably, pinentry-x11 is a misnomer, because pinentry-gnome3 works in
> any GNOME graphical environment, including ones that are purely based on
> Wayland, with no X11 whatsoever.
Fully agree on the misnomer part. Point in case, I noticed this using
sway (with xwayland installed) and installed pinentry-gnome3.
> But we don't have a pinentry-gui virtual package at the moment, so
> pinentry-x11 is probably the right choice.
Maybe pinentry-gui should be added as a pure virtual package? And in
due course, pinentry-x11 removed? Anyway, that's not food for the
webext-browserpass package.
> It should definitely be at least a Recommends: given pass's reliance
> on GnuPG, and GnuPG's transitive reliance (through gpg-agent) on a
> graphical password prompter.
I was getting by fine for the most part with pinentry-tty until I tried
to integrate browserpass ;-)
> It's this tangled mess of dependencies that makes it necessary for the
> bits that are designed to run in a graphical environment (like
> browserpass) to explicitly declare their dependencies on graphical
> pinentry specifically.
Guess what! webext-browserpass doesn't even depend on pass! :-o
Oh, just noticed that pass (or gopass) is not actually required[1].
Maybe that should become a Recommends: too, with a note in the package
description why it's not a Depends: ...
[1]: https://github.com/browserpass/browserpass-extension#requirements
--
Olaf Meeuwissen
Bug#1023782: [Pkg-mozext-maintainers] Bug#1023782: Add dependency on pinentry-x11
over on Bug #1023782 ("Add dependency on pinentry-x11") about
webext-browserpass,
Meeuwissen Olaf wrote:
> Please add a dependency on pinentry-x11. This is a pure virtual package that
> makes the user pick one. I think that is to be preferred over adding a list
> of
> alternatives directly because the package managers tend to pick the first one
> listed.
Arguably, pinentry-x11 is a misnomer, because pinentry-gnome3 works in
any GNOME graphical environment, including ones that are purely based on
Wayland, with no X11 whatsoever.
But we don't have a pinentry-gui virtual package at the moment, so
pinentry-x11 is probably the right choice. It should definitely be at
least a Recommends: given pass's reliance on GnuPG, and GnuPG's
transitive reliance (through gpg-agent) on a graphical password
prompter. It's this tangled mess of dependencies that makes it
necessary for the bits that are designed to run in a graphical
environment (like browserpass) to explicitly declare their dependencies
on graphical pinentry specifically.
--dkg
signature.asc
Description: PGP signature
Bug#1023782: Add dependency on pinentry-x11
Package: webext-browserpass Version: 3.7.2-1+b6 Severity: important The upstream documentation[1] clearly mentions that this extension depends on a GUI-based pinentry (unless you know what you're doing). This is not reflected in the package dependencies. I realize most desktops will pull one in but I prefer to piece something myself. And without installing Recommends: to boot ;-) Please add a dependency on pinentry-x11. This is a pure virtual package that makes the user pick one. I think that is to be preferred over adding a list of alternatives directly because the package managers tend to pick the first one listed. Seeing that people who know what they are doing can get away without the GUI-based pinentry, I guess a Recommends: is sufficient (although a Depends: would be okay with me too). [1]: https://github.com/browserpass/browserpass-extension#error-unable-to-fetch-and-parse-login-fields Hope this helps,
