Bug#1062957: sysrepo: NMU diff for 64-bit time_t transition

2024-02-29 Thread Benjamin Drung
Source: sysrepo
Dear maintainer,

Please find attached a final version of this patch for the time_t
transition.  This patch is being uploaded to unstable.

Note that this adds a versioned build-dependency on dpkg-dev, to guard
against accidental backports with a wrong ABI.

Thanks!


-- System Information:
Debian Release: trixie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 6.5.0-21-generic (SMP w/16 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, 
TAINT_UNSIGNED_MODULE
Locale: LANG=C, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: unable to detect
diff -Nru sysrepo-2.0.53/debian/changelog sysrepo-2.0.53/debian/changelog
--- sysrepo-2.0.53/debian/changelog 2021-11-26 10:32:54.0 +
+++ sysrepo-2.0.53/debian/changelog 2024-02-29 17:57:10.0 +
@@ -1,3 +1,10 @@
+sysrepo (2.0.53-6.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Rename libraries for 64-bit time_t transition.  Closes: #1062957
+
+ -- Benjamin Drung   Thu, 29 Feb 2024 17:57:10 +
+
 sysrepo (2.0.53-6) unstable; urgency=medium
 
   * Don't move the /etc/sysrepo if it doesn't exist
diff -Nru sysrepo-2.0.53/debian/control sysrepo-2.0.53/debian/control
--- sysrepo-2.0.53/debian/control   2021-11-26 10:32:54.0 +
+++ sysrepo-2.0.53/debian/control   2024-02-29 17:57:10.0 +
@@ -3,7 +3,7 @@
 Maintainer: Ondřej Surý 
 Priority: optional
 Standards-Version: 4.5.1.0
-Build-Depends: cmake,
+Build-Depends: dpkg-dev (>= 1.22.5), cmake,
debhelper-compat (= 12),
doxygen,
graphviz,
@@ -12,7 +12,7 @@
 Homepage: https://github.com/sysrepo/sysrepo
 
 Package: sysrepo
-Depends: libsysrepo6 (= ${binary:Version}),
+Depends: libsysrepo6t64 (= ${binary:Version}),
  ${misc:Depends},
  ${shlibs:Depends}
 Section: admin
@@ -48,7 +48,7 @@
  This package contains the documentation.
 
 Package: sysrepo-plugind
-Depends: libsysrepo6 (= ${binary:Version}),
+Depends: libsysrepo6t64 (= ${binary:Version}),
  ${misc:Depends},
  ${shlibs:Depends}
 Section: admin
@@ -66,7 +66,10 @@
  .
  This package contains the daemon for grouping sysrepo plugins.
 
-Package: libsysrepo6
+Package: libsysrepo6t64
+Provides: ${t64:Provides}
+Replaces: libsysrepo6
+Breaks: libsysrepo6 (<< ${source:Version})
 Pre-Depends: ${misc:Pre-Depends}
 Depends: ${misc:Depends},
  ${shlibs:Depends}
@@ -86,7 +89,7 @@
  This package contains the shared C library.
 
 Package: libsysrepo-dev
-Depends: libsysrepo6 (= ${binary:Version}),
+Depends: libsysrepo6t64 (= ${binary:Version}),
  libyang2-dev,
  ${misc:Depends},
  ${shlibs:Depends}
diff -Nru sysrepo-2.0.53/debian/libsysrepo6.install 
sysrepo-2.0.53/debian/libsysrepo6.install
--- sysrepo-2.0.53/debian/libsysrepo6.install   2021-11-26 10:32:54.0 
+
+++ sysrepo-2.0.53/debian/libsysrepo6.install   1970-01-01 00:00:00.0 
+
@@ -1 +0,0 @@
-usr/lib/*/libsysrepo.so.*
diff -Nru sysrepo-2.0.53/debian/libsysrepo6.postrm 
sysrepo-2.0.53/debian/libsysrepo6.postrm
--- sysrepo-2.0.53/debian/libsysrepo6.postrm2021-11-26 10:32:54.0 
+
+++ sysrepo-2.0.53/debian/libsysrepo6.postrm1970-01-01 00:00:00.0 
+
@@ -1,40 +0,0 @@
-#!/bin/sh
-# postrm script for libsysrepo6
-#
-# see: dh_installdeb(1)
-
-set -e
-
-# summary of how this script can be called:
-#*  `remove'
-#*  `purge'
-#*  `upgrade' 
-#*  `failed-upgrade' 
-#*  `abort-install'
-#*  `abort-install' 
-#*  `abort-upgrade' 
-#*  `disappear' 
-#  
-# for details, see https://www.debian.org/doc/debian-policy/ or
-# the debian-policy package
-
-
-case "$1" in
-purge)
-   rm -rf /etc/sysrepo
-;;
-remove|upgrade|failed-upgrade|abort-install|abort-upgrade|disappear)
-;;
-
-*)
-echo "postrm called with unknown argument \`$1'" >&2
-exit 1
-;;
-esac
-
-# dh_installdeb will replace this with shell code automatically
-# generated by other debhelper scripts.
-
-#DEBHELPER#
-
-exit 0
diff -Nru sysrepo-2.0.53/debian/libsysrepo6.symbols 
sysrepo-2.0.53/debian/libsysrepo6.symbols
--- sysrepo-2.0.53/debian/libsysrepo6.symbols   2021-11-26 10:32:54.0 
+
+++ sysrepo-2.0.53/debian/libsysrepo6.symbols   1970-01-01 00:00:00.0 
+
@@ -1,144 +0,0 @@
-libsysrepo.so.6 libsysrepo6 #MINVER#
- sr_apply_changes@Base 1.4.70
- sr_cancel_update_module@Base 1.4.70
- sr_check_module_ds_access@Base 2.0.53
- sr_connect@Base 1.4.70
- sr_connection_count@Base 1.4.70
- sr_copy_config@Base 1.4.70
- sr_delete_item@Base 1.4.70
- sr_disable_module_feature@Base 1.4.70
- sr_discard_changes@Base 1.4.70
- sr_discard_oper_changes@Base 2.0.53
- sr_disconnect@Base 1.4.70
- sr_dup_changes_iter@Base 1.4.70
- sr_dup_val@Base 1.4.70
- 

Bug#1062957: sysrepo: NMU diff for 64-bit time_t transition

2024-02-03 Thread Steve Langasek
Source: sysrepo
Version: 2.0.53-6
Severity: serious
Tags: patch pending sid trixie
Justification: library ABI skew on upgrade
User: debian-...@lists.debian.org
Usertags: time-t

NOTICE: these changes must not be uploaded to unstable yet!

Dear maintainer,

As part of the 64-bit time_t transition required to support 32-bit
architectures in 2038 and beyond
(https://wiki.debian.org/ReleaseGoals/64bit-time), we have identified
sysrepo as a source package shipping runtime libraries whose ABI
either is affected by the change in size of time_t, or could not be
analyzed via abi-compliance-checker (and therefore to be on the safe
side we assume is affected).

To ensure that inconsistent combinations of libraries with their
reverse-dependencies are never installed together, it is necessary to
have a library transition, which is most easily done by renaming the
runtime library package.

Since turning on 64-bit time_t is being handled centrally through a change
to the default dpkg-buildflags (https://bugs.debian.org/1037136), it is
important that libraries affected by this ABI change all be uploaded close
together in time.  Therefore I have prepared a 0-day NMU for sysrepo
which will initially be uploaded to experimental if possible, then to
unstable after packages have cleared binary NEW.

Please find the patch for this NMU attached.

If you have any concerns about this patch, please reach out ASAP.  Although
this package will be uploaded to experimental immediately, there will be a
period of several days before we begin uploads to unstable; so if information
becomes available that your package should not be included in the transition,
there is time for us to amend the planned uploads.



-- System Information:
Debian Release: trixie/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 6.5.0-14-generic (SMP w/12 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=C, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
diff -Nru sysrepo-2.0.53/debian/changelog sysrepo-2.0.53/debian/changelog
--- sysrepo-2.0.53/debian/changelog 2021-11-26 10:32:54.0 +
+++ sysrepo-2.0.53/debian/changelog 2024-02-04 07:30:11.0 +
@@ -1,3 +1,10 @@
+sysrepo (2.0.53-6.1) experimental; urgency=medium
+
+  * Non-maintainer upload.
+  * Rename libraries for 64-bit time_t transition.
+
+ -- Steve Langasek   Sun, 04 Feb 2024 07:30:11 +
+
 sysrepo (2.0.53-6) unstable; urgency=medium
 
   * Don't move the /etc/sysrepo if it doesn't exist
diff -Nru sysrepo-2.0.53/debian/control sysrepo-2.0.53/debian/control
--- sysrepo-2.0.53/debian/control   2021-11-26 10:32:54.0 +
+++ sysrepo-2.0.53/debian/control   2024-02-04 07:30:11.0 +
@@ -12,7 +12,7 @@
 Homepage: https://github.com/sysrepo/sysrepo
 
 Package: sysrepo
-Depends: libsysrepo6 (= ${binary:Version}),
+Depends: libsysrepo6t64 (= ${binary:Version}),
  ${misc:Depends},
  ${shlibs:Depends}
 Section: admin
@@ -48,7 +48,7 @@
  This package contains the documentation.
 
 Package: sysrepo-plugind
-Depends: libsysrepo6 (= ${binary:Version}),
+Depends: libsysrepo6t64 (= ${binary:Version}),
  ${misc:Depends},
  ${shlibs:Depends}
 Section: admin
@@ -66,7 +66,10 @@
  .
  This package contains the daemon for grouping sysrepo plugins.
 
-Package: libsysrepo6
+Package: libsysrepo6t64
+Provides: ${t64:Provides}
+Replaces: libsysrepo6
+Breaks: libsysrepo6 (<< ${source:Version})
 Pre-Depends: ${misc:Pre-Depends}
 Depends: ${misc:Depends},
  ${shlibs:Depends}
@@ -86,7 +89,7 @@
  This package contains the shared C library.
 
 Package: libsysrepo-dev
-Depends: libsysrepo6 (= ${binary:Version}),
+Depends: libsysrepo6t64 (= ${binary:Version}),
  libyang2-dev,
  ${misc:Depends},
  ${shlibs:Depends}
diff -Nru sysrepo-2.0.53/debian/libsysrepo6.install 
sysrepo-2.0.53/debian/libsysrepo6.install
--- sysrepo-2.0.53/debian/libsysrepo6.install   2021-11-26 10:32:54.0 
+
+++ sysrepo-2.0.53/debian/libsysrepo6.install   1970-01-01 00:00:00.0 
+
@@ -1 +0,0 @@
-usr/lib/*/libsysrepo.so.*
diff -Nru sysrepo-2.0.53/debian/libsysrepo6.postrm 
sysrepo-2.0.53/debian/libsysrepo6.postrm
--- sysrepo-2.0.53/debian/libsysrepo6.postrm2021-11-26 10:32:54.0 
+
+++ sysrepo-2.0.53/debian/libsysrepo6.postrm1970-01-01 00:00:00.0 
+
@@ -1,40 +0,0 @@
-#!/bin/sh
-# postrm script for libsysrepo6
-#
-# see: dh_installdeb(1)
-
-set -e
-
-# summary of how this script can be called:
-#*  `remove'
-#*  `purge'
-#*  `upgrade' 
-#*  `failed-upgrade' 
-#*  `abort-install'
-#*  `abort-install' 
-#*  `abort-upgrade' 
-#*  `disappear' 
-#  
-# for details, see https://www.debian.org/doc/debian-policy/ or
-# the debian-policy package
-
-
-case