Bug#1063898: pipewire-bin: customization file in ALSA profile-sets wrongly packaged

2024-02-27 Thread Sander van Grieken
On donderdag 22 februari 2024 18:12:28 CET Dylan Aïssi wrote:
> Le jeu. 15 févr. 2024 à 16:03, Sander van Grieken
>  a écrit :
> >
> > Using dpkg-divert is fine. Maybe adding a single comment line mentioning 
> > dpkg-divert in 
> > /usr/share/alsa-card-profile/mixer/profile-sets/default.conf, just above 
> > the include of -custom.conf would be helpful.
> >
> 
> Patching files always has a maintenance cost that I would like to avoid and
> since dpkg-divert is something specific to Debian, I am not sure upstream is
> interested by adding such comment. But, we can install a 
> -custom.conf.README
> explaining how to use dpkg-divert on it. What do you think?

Sounds reasonable, this should sufficiently alert anyone customising the file.

thanks!

grtz,
Sander





Bug#1063898: pipewire-bin: customization file in ALSA profile-sets wrongly packaged

2024-02-22 Thread Dylan Aïssi
Le jeu. 15 févr. 2024 à 16:03, Sander van Grieken
 a écrit :
>
> Using dpkg-divert is fine. Maybe adding a single comment line mentioning 
> dpkg-divert in /usr/share/alsa-card-profile/mixer/profile-sets/default.conf, 
> just above the include of -custom.conf would be helpful.
>

Patching files always has a maintenance cost that I would like to avoid and
since dpkg-divert is something specific to Debian, I am not sure upstream is
interested by adding such comment. But, we can install a -custom.conf.README
explaining how to use dpkg-divert on it. What do you think?

Best,
Dylan



Bug#1063898: pipewire-bin: customization file in ALSA profile-sets wrongly packaged

2024-02-15 Thread Sander van Grieken
On donderdag 15 februari 2024 15:43:47 CET Dylan Aïssi wrote:
> Hi,
> 
> Le mer. 14 févr. 2024 à 13:45, Sander van Grieken
>  a écrit :
> >
> > The file /usr/share/alsa-card-profile/mixer/profile-sets/-custom.conf,
> > which is packaged as part of pipewire-bin and intended to be customized by 
> > the
> > user, is packaged in a way that it is overwritten by upgrades.
> >
> > The file -custom.conf should not be included, or included with a 
> > different
> > name, e.g. -custom.conf.example
> >
> 
> This file/feature was implemented with the idea of using dpkg-divert on it, 
> see
> https://gitlab.freedesktop.org/pipewire/pipewire/-/merge_requests/1686
> 
> Any reason of not using dpkg-divert?

Not really, just unusual, as I haven't really needed to use dpkg-divert before, 
probably because it's rare
to have config files outside the usual locations.

Using dpkg-divert is fine. Maybe adding a single comment line mentioning 
dpkg-divert in /usr/share/alsa-card-profile/mixer/profile-sets/default.conf, 
just above the include of -custom.conf would be helpful.

grtz,
Sander



Bug#1063898: pipewire-bin: customization file in ALSA profile-sets wrongly packaged

2024-02-15 Thread Dylan Aïssi
Hi,

Le mer. 14 févr. 2024 à 13:45, Sander van Grieken
 a écrit :
>
> The file /usr/share/alsa-card-profile/mixer/profile-sets/-custom.conf,
> which is packaged as part of pipewire-bin and intended to be customized by the
> user, is packaged in a way that it is overwritten by upgrades.
>
> The file -custom.conf should not be included, or included with a different
> name, e.g. -custom.conf.example
>

This file/feature was implemented with the idea of using dpkg-divert on it, see
https://gitlab.freedesktop.org/pipewire/pipewire/-/merge_requests/1686

Any reason of not using dpkg-divert?

Best regards,
Dylan



Bug#1063898: pipewire-bin: customization file in ALSA profile-sets wrongly packaged

2024-02-14 Thread Sander van Grieken
Package: pipewire-bin
Version: 1.0.3-1
Severity: normal
X-Debbugs-Cc: san...@outrightsolutions.nl

Dear Maintainer,

The file /usr/share/alsa-card-profile/mixer/profile-sets/-custom.conf,
which is packaged as part of pipewire-bin and intended to be customized by the
user, is packaged in a way that it is overwritten by upgrades.

The file -custom.conf should not be included, or included with a different
name, e.g. -custom.conf.example



-- System Information:
Debian Release: trixie/sid
  APT prefers testing
  APT policy: (750, 'testing'), (700, 'stable-security'), (700, 'stable'), 
(600, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.6.15-dirty (SMP w/12 CPU threads; PREEMPT)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages pipewire-bin depends on:
ii  libasound2   1.2.10-3
ii  libc62.37-15~deb13u1
ii  libdbus-1-3  1.14.10-4
ii  libncursesw6 6.4+20240113-1
ii  libpipewire-0.3-01.0.3-1
ii  libpipewire-0.3-modules  1.0.3-1
ii  libreadline8 8.2-3
ii  libsndfile1  1.2.2-1
ii  libtinfo66.4+20240113-1

Versions of packages pipewire-bin recommends:
ii  dbus-user-session  1.14.10-4
ii  rtkit  0.13-5
ii  wireplumber0.4.17-1+b1

pipewire-bin suggests no packages.

-- no debconf information